76039 2012-01-11 01:13:34 -0800 Rename HTMLInputElement::setDefaultName to setInitialName 2012-01-11 14:36:15 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P3 Minor --- 1 tkent tkent darin webkit.review.bot oldest_to_newest 533735 0 tkent 2012-01-11 01:13:34 -0800 https://bugs.webkit.org/show_bug.cgi?id=45719#c22 > In a mostly unrelated note, when looking at this I noticed a peculiarly-named public function, setDefaultName, that is called only by the HTMLIsIndexElement constructor. We should probably make that function protected. And further, it’s only safe to call that function if the object is not a checkbox, so we might want to assert that. And it’s only correct to call it on an object that doesn’t already have a name, so we might want to assert that m_name is null. And finally, this doesn’t actually work correctly if a name is added and then subsequently removed from the isindex element. That’s probably unimportant because of how rare it is to use the isindex element at all, but annoying that it’s incorrect. That’s the reason the function name is so bad: It doesn’t actually set a default name, just sets an initial name. 533743 1 tkent 2012-01-11 01:26:55 -0800 > this doesn’t actually work correctly if a name is added and then subsequently removed from the isindex element. I confirmed the current behavior of WebKit is compatible with IE9, Firefox, and Opera. As you wrote, setDefaultName() really sets just an initial name. 533746 2 121994 tkent 2012-01-11 01:46:17 -0800 Created attachment 121994 Patch 533991 3 121994 darin 2012-01-11 10:15:18 -0800 Comment on attachment 121994 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121994&action=review > Source/WebCore/html/HTMLInputElement.cpp:1305 > + ASSERT(hasTagName(isindexTag)); To me it seems like this assert goes a little overboard, but only a tiny bit, so I say, lets keep it. 534271 4 121994 webkit.review.bot 2012-01-11 14:36:10 -0800 Comment on attachment 121994 Patch Clearing flags on attachment: 121994 Committed r104747: <http://trac.webkit.org/changeset/104747> 534272 5 webkit.review.bot 2012-01-11 14:36:15 -0800 All reviewed patches have been landed. Closing bug. 121994 2012-01-11 01:46:17 -0800 2012-01-11 14:36:10 -0800 Patch bug-76039-20120111184615.patch text/plain 6169 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0NjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODkwZDEzZmQ5ZTVkMmRi MWE3ZjFiYzVhZGJjMTdkY2RmYWY3NDQ0Yy4uNTA3NTBmM2UzMTY5MGY0MzgwYmNkNzc3NjFiNzdk YzNhODMxN2MyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEyLTAxLTExICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW5hbWUgSFRNTElucHV0 RWxlbWVudDo6c2V0RGVmYXVsdE5hbWUgdG8gc2V0SW5pdGlhbE5hbWUuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjAzOQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbmFtZSBzZXREZWZhdWx0TmFtZSB0 byBzZXRJbml0aWFsTmFtZSwgbWFrZSBpdCBwcm90ZWN0ZWQsIGFuZCBhZGQgdHdvCisgICAgICAg IGFzc2VydGlvbnMuCisKKyAgICAgICAgVGhpcyBjaGFuZ2Ugc2hvdWxkIG5vdCBjaGFuZ2UgYW55 IGJlaGF2aW9yLgorCisgICAgICAgIFRlc3Q6IGZhc3QvZm9ybXMvaXNpbmRleC1uYW1lLmh0bWwK KworICAgICAgICAqIGh0bWwvSFRNTElucHV0RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpIVE1MSW5wdXRFbGVtZW50OjpzZXRJbml0aWFsTmFtZSk6CisgICAgICAgIC0gUmVuYW1lZCBm cm9tIHNldERlZmF1bHROYW1lLgorICAgICAgICAtIEFkZCBhc3NlcnRpb25zLgorICAgICAgICAq IGh0bWwvSFRNTElucHV0RWxlbWVudC5oOgorICAgICAgICBSZW5hbWUgc2V0RGVmYXVsdE5hbWUg dG8gc2V0SW5pdGlhbE5hbWUsIGFuZCBtb3ZlIGl0IHRvIHByb3RlY3RlZC4KKyAgICAgICAgKiBo dG1sL0hUTUxJc0luZGV4RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MSXNJbmRl eEVsZW1lbnQ6OkhUTUxJc0luZGV4RWxlbWVudCk6CisgICAgICAgIFVwZGF0ZSBhIHNldERlZmF1 bHROYW1lIGNhbGxzaXRlLgorICAgICAgICAoV2ViQ29yZTo6SFRNTElzSW5kZXhFbGVtZW50Ojpw YXJzZU1hcHBlZEF0dHJpYnV0ZSk6CisgICAgICAgIEEgc3R5bGUgZml4LgorCiAyMDEyLTAxLTA0 ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBBIHJhZGlvIGJ1 dHRvbiBub3QgaW4gYSBkb2N1bWVudCBzaG91bGQgbm90IGpvaW4gYSByYWRpbyBidXR0b24gZ3Jv dXAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCmluZGV4IDNiYjlhZjA5 Mzc1NGU2MmYyMzgxYWEzNGVkNTM4OWMxMTIyYWMyMDUuLjQ1ZTBiMmZjZTVhMzc5ZDE3NmJjMGNj ODhkNjI2YjUxOWJhMGFhMjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElu cHV0RWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50 LmNwcApAQCAtMTMwMCw4ICsxMzAwLDEwIEBAIHZvaWQgSFRNTElucHV0RWxlbWVudDo6c2V0RGVm YXVsdFZhbHVlKGNvbnN0IFN0cmluZyAmdmFsdWUpCiAgICAgc2V0QXR0cmlidXRlKHZhbHVlQXR0 ciwgdmFsdWUpOwogfQogCi12b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OnNldERlZmF1bHROYW1lKGNv bnN0IEF0b21pY1N0cmluZyYgbmFtZSkKK3ZvaWQgSFRNTElucHV0RWxlbWVudDo6c2V0SW5pdGlh bE5hbWUoY29uc3QgQXRvbWljU3RyaW5nJiBuYW1lKQogeworICAgIEFTU0VSVChoYXNUYWdOYW1l KGlzaW5kZXhUYWcpKTsKKyAgICBBU1NFUlQobV9uYW1lLmlzTnVsbCgpKTsKICAgICBtX25hbWUg PSBuYW1lOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVs ZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5oCmluZGV4IGQy MTI0NGQzOWQ3NTJhMzYzYjJjN2E1ZTY5MmE1ZTkxMjEyZGVlNDguLmZjNmYwNjgyOGY5ODdiYzhl MGQ3NTljNTI5YzkwYmIzZWM3MTk1NWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTElucHV0RWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxl bWVudC5oCkBAIC0xODgsOCArMTg4LDYgQEAgcHVibGljOgogICAgIFN0cmluZyBkZWZhdWx0VmFs dWUoKSBjb25zdDsKICAgICB2b2lkIHNldERlZmF1bHRWYWx1ZShjb25zdCBTdHJpbmcmKTsKIAot ICAgIHZvaWQgc2V0RGVmYXVsdE5hbWUoY29uc3QgQXRvbWljU3RyaW5nJik7Ci0KICAgICBWZWN0 b3I8U3RyaW5nPiBhY2NlcHRNSU1FVHlwZXMoKTsKICAgICBTdHJpbmcgYWNjZXB0KCkgY29uc3Q7 CiAgICAgU3RyaW5nIGFsdCgpIGNvbnN0OwpAQCAtMjQzLDYgKzI0MSw3IEBAIHB1YmxpYzoKIHBy b3RlY3RlZDoKICAgICBIVE1MSW5wdXRFbGVtZW50KGNvbnN0IFF1YWxpZmllZE5hbWUmLCBEb2N1 bWVudCosIEhUTUxGb3JtRWxlbWVudCosIGJvb2wgY3JlYXRlZEJ5UGFyc2VyKTsKICAgICB2b2lk IGNyZWF0ZVNoYWRvd1N1YnRyZWUoKTsKKyAgICB2b2lkIHNldEluaXRpYWxOYW1lKGNvbnN0IEF0 b21pY1N0cmluZyYpOwogICAgIHZpcnR1YWwgdm9pZCBkZWZhdWx0RXZlbnRIYW5kbGVyKEV2ZW50 Kik7CiAKIHByaXZhdGU6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJc0lu ZGV4RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJc0luZGV4RWxlbWVudC5j cHAKaW5kZXggZjdjZjVlY2QxYzFlNzUyYmUwYzBlZjQzZDQ5YjYzOTVkNTNhOWM4NS4uNjM4YzI5 NGJkZGJjYWZkNDYzNmUwMzEwZjkwYWQwOTJmZmE5YTJiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MSXNJbmRleEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTElzSW5kZXhFbGVtZW50LmNwcApAQCAtMzYsNyArMzYsNyBAQCBIVE1MSXNJbmRleEVs ZW1lbnQ6OkhUTUxJc0luZGV4RWxlbWVudChjb25zdCBRdWFsaWZpZWROYW1lJiB0YWdOYW1lLCBE b2N1bWVudCogZAogICAgIDogSFRNTElucHV0RWxlbWVudCh0YWdOYW1lLCBkb2N1bWVudCwgZm9y bSwgZmFsc2UpCiB7CiAgICAgQVNTRVJUKGhhc1RhZ05hbWUoaXNpbmRleFRhZykpOwotICAgIHNl dERlZmF1bHROYW1lKGlzaW5kZXhUYWcubG9jYWxOYW1lKCkpOworICAgIHNldEluaXRpYWxOYW1l KGlzaW5kZXhUYWcubG9jYWxOYW1lKCkpOwogfQogCiBQYXNzUmVmUHRyPEhUTUxJc0luZGV4RWxl bWVudD4gSFRNTElzSW5kZXhFbGVtZW50OjpjcmVhdGUoRG9jdW1lbnQqIGRvY3VtZW50LCBIVE1M Rm9ybUVsZW1lbnQqIGZvcm0pCkBAIC01OSwxMCArNTksMTEgQEAgdm9pZCBIVE1MSXNJbmRleEVs ZW1lbnQ6OnBhcnNlTWFwcGVkQXR0cmlidXRlKEF0dHJpYnV0ZSogYXR0cikKICAgICAgICAgc2V0 VmFsdWUoYXR0ci0+dmFsdWUoKSk7CiAgICAgZWxzZSBpZiAoYXR0ci0+bmFtZSgpID09IHBsYWNl aG9sZGVyQXR0cikKICAgICAgICAgdXBkYXRlUGxhY2Vob2xkZXJWaXNpYmlsaXR5KHRydWUpOwot ICAgIGVsc2UKKyAgICBlbHNlIHsKICAgICAgICAgLy8gZG9uJ3QgY2FsbCBIVE1MSW5wdXRFbGVt ZW50OjpwYXJzZU1hcHBlZEF0dHJpYnV0ZSBoZXJlLCBhcyBpdCB3b3VsZAogICAgICAgICAvLyBh Y2NlcHQgYXR0cmlidXRlcyB0aGlzIGVsZW1lbnQgZG9lcyBub3Qgc3VwcG9ydAogICAgICAgICBI VE1MRm9ybUNvbnRyb2xFbGVtZW50OjpwYXJzZU1hcHBlZEF0dHJpYnV0ZShhdHRyKTsKKyAgICB9 CiB9CiAKIH0gLy8gbmFtZXNwYWNlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggN2U2MGY3YTA3ZjAwZWNjNzQyNmY5NDVlYjY1 YzM1MDg2OGE2MzRlZS4uOGUzOWMxYWNjNjVmMTJkMWQyZGI4MWIwMGM0MjRkMGI1ODNkMzNkOCAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAxLTExICBLZW50IFRhbXVyYSAgPHRrZW50QGNo cm9taXVtLm9yZz4KKworICAgICAgICBSZW5hbWUgSFRNTElucHV0RWxlbWVudDo6c2V0RGVmYXVs dE5hbWUgdG8gc2V0SW5pdGlhbE5hbWUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03NjAzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogZmFzdC9mb3Jtcy9pc2luZGV4LW5hbWUtZXhwZWN0ZWQudHh0OiBB ZGRlZC4KKyAgICAgICAgKiBmYXN0L2Zvcm1zL2lzaW5kZXgtbmFtZS5odG1sOiBBZGRlZC4KKwog MjAxMi0wMS0wNCAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg QSByYWRpbyBidXR0b24gbm90IGluIGEgRG9jdW1lbnQgc2hvdWxkIG5vdCBqb2luIGEgcmFkaW8g YnV0dG9uIGdyb3VwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lzaW5kZXgt bmFtZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lzaW5kZXgtbmFtZS1l eHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOGNkOWVmZGI0MDFlNzIyZTZlZTBkNzNjNDFiZGQyNzI5 NmExMDQzMgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaXNpbmRl eC1uYW1lLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDExIEBACitJbml0aWFsIG5hbWU6CitQQVNT IGlzaW5kZXgubmFtZSBpcyAiaXNpbmRleCIKK0FkZGluZyBhIG5hbWUgYXR0cmlidXRlOgorUEFT UyBpc2luZGV4LnNldEF0dHJpYnV0ZSgibmFtZSIsICJmb28iKTsgaXNpbmRleC5uYW1lIGlzICJm b28iCitSZW1vdmluZyB0aGUgbmFtZSBhdHRyaWJ1dGU6CitQQVNTIGlzaW5kZXgucmVtb3ZlQXR0 cmlidXRlKCJuYW1lIik7IGlzaW5kZXgubmFtZSBpcyAiIgorUEFTUyBzdWNjZXNzZnVsbHlQYXJz ZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCitUaGlzIGlzIGEgc2VhcmNoYWJsZSBpbmRleC4g RW50ZXIgc2VhcmNoIGtleXdvcmRzOiAKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9m b3Jtcy9pc2luZGV4LW5hbWUuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaXNpbmRleC1u YW1lLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uY2JiYWEyYzk1ZTdjNjNlZDNjMGM1Njk5MWQwZTRlYThhNGRm ZTFlMQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaXNpbmRleC1u YW1lLmh0bWwKQEAgLTAsMCArMSwyMiBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFk PgorPHNjcmlwdCBzcmM9Ii4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48 L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPGlzaW5kZXggaWQ9aXNpbmRleDE+Cis8c2NyaXB0 PgordmFyIGlzaW5kZXggPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnaXNpbmRleDEnKTsKK2Rl YnVnKCdJbml0aWFsIG5hbWU6Jyk7CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoJ2lzaW5kZXgubmFt ZScsICdpc2luZGV4Jyk7CisKK2RlYnVnKCdBZGRpbmcgYSBuYW1lIGF0dHJpYnV0ZTonKTsKK3No b3VsZEJlRXF1YWxUb1N0cmluZygnaXNpbmRleC5zZXRBdHRyaWJ1dGUoIm5hbWUiLCAiZm9vIik7 IGlzaW5kZXgubmFtZScsICdmb28nKTsKKworZGVidWcoJ1JlbW92aW5nIHRoZSBuYW1lIGF0dHJp YnV0ZTonKTsKKy8vIFRoaXMgYmVoYXZpb3IgaXMgY29tcGF0aWJsZSB3aXRoIElFLCBGaXJlZm94 LCBhbmQgT3BlcmEuCitzaG91bGRCZUVxdWFsVG9TdHJpbmcoJ2lzaW5kZXgucmVtb3ZlQXR0cmli dXRlKCJuYW1lIik7IGlzaW5kZXgubmFtZScsICcnKTsKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9 Ii4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2Jv ZHk+Cis8L2h0bWw+Cg==