76010 2012-01-10 17:24:07 -0800 Remove redundant code from DOMWindowSQLDatabase.cpp 2012-01-10 18:05:12 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth webkit.review.bot oldest_to_newest 533510 0 haraken 2012-01-10 17:24:07 -0800 As abarth pointed out in the comment #2 in bug 76004, we should remove redundant code from DOMWindowSQLDatabase.cpp. 533514 1 121947 haraken 2012-01-10 17:27:36 -0800 Created attachment 121947 Patch 533544 2 121947 webkit.review.bot 2012-01-10 18:05:08 -0800 Comment on attachment 121947 Patch Clearing flags on attachment: 121947 Committed r104659: <http://trac.webkit.org/changeset/104659> 533545 3 webkit.review.bot 2012-01-10 18:05:12 -0800 All reviewed patches have been landed. Closing bug. 121947 2012-01-10 17:27:36 -0800 2012-01-10 18:05:08 -0800 Patch bug-76010-20120111102734.patch text/plain 2442 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0NjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTdiZjU2ODU0YjM1NzZl OTM4Yjg5OTYxOTNjOTgzNmZhOWNlNjU0MC4uMjM1YjAzMjA5YzFiYTg2NTk3YzYxMTIyM2FiYTJi Y2YxNDA5NjQ1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI4IEBACiAyMDEyLTAxLTEwICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZW1vdmUgcmVkdW5k YW50IGNvZGUgZnJvbSBET01XaW5kb3dTUUxEYXRhYmFzZS5jcHAKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2MDEwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCByZW1vdmVzIHJlZHVuZGFu dCBjb2RlIGZyb20gRE9NV2luZG93U1FMRGF0YWJhc2UuY3BwLgorCisgICAgICAgIC0gUmVtb3Zl IHdpbmRvdy0+ZnJhbWUoKSBjaGVjaywgc2luY2Ugd2luZG93LT5mcmFtZSgpIGlzIGFsd2F5cyB0 cnVlIHdoZW4KKyAgICAgICAgICB3aW5kb3ctPmlzQ3VycmVudGx5RGlzcGxheWVkSW5GcmFtZSgp IGlzIHRydWUuCisgICAgICAgIC0gd2luZG93LT5mcmFtZSgpLT5kb2N1bWVudCgpIGNhbiBqdXN0 IGJlIHdpbmRvdy0+ZG9jdW1lbnQoKQorCisgICAgICAgIFRlc3RzOiBzdG9yYWdlL29wZW4tZGF0 YWJhc2UtY3JlYXRpb24tY2FsbGJhY2staXNvbGF0ZWQtd29ybGQuaHRtbAorICAgICAgICAgICAg ICAgc3RvcmFnZS9vcGVuLWRhdGFiYXNlLWNyZWF0aW9uLWNhbGxiYWNrLmh0bWwKKyAgICAgICAg ICAgICAgIHN0b3JhZ2Uvb3Blbi1kYXRhYmFzZS1lbXB0eS12ZXJzaW9uLmh0bWwKKyAgICAgICAg ICAgICAgIHN0b3JhZ2Uvb3Blbi1kYXRhYmFzZS1vdmVyLXF1b3RhLmh0bWwKKyAgICAgICAgICAg ICAgIHN0b3JhZ2Uvb3Blbi1kYXRhYmFzZS1zZXQtZW1wdHktdmVyc2lvbi5odG1sCisgICAgICAg ICAgICAgICBzdG9yYWdlL29wZW4tZGF0YWJhc2Utd2hpbGUtdHJhbnNhY3Rpb24taW4tcHJvZ3Jl c3MuaHRtbAorCisgICAgICAgICogc3RvcmFnZS9ET01XaW5kb3dTUUxEYXRhYmFzZS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpET01XaW5kb3dTUUxEYXRhYmFzZTo6b3BlbkRhdGFiYXNlKToKKwor MjAxMi0wMS0xMCAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CisKICAgICAg ICAgVXNlIHRoZSBbU3VwcGxlbWVudGFsXSBJREwgaW4gU1FMRGF0YWJhc2UKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2MDA0CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvRE9NV2luZG93U1FMRGF0YWJhc2UuY3BwIGIvU291cmNl L1dlYkNvcmUvc3RvcmFnZS9ET01XaW5kb3dTUUxEYXRhYmFzZS5jcHAKaW5kZXggNWI5ZjBlZDBl YTg5NDkxZGNhN2E4NmFlNmVkNzFiYTk3NmIxNTU4Ni4uZTRiNjA5MDgwMGVkNzg0Y2RiNzM4ODhm NWFmMWEzNGJiMjFmODdhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9ET01X aW5kb3dTUUxEYXRhYmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9ET01XaW5k b3dTUUxEYXRhYmFzZS5jcHAKQEAgLTQ5LDggKzQ5LDggQEAgUGFzc1JlZlB0cjxEYXRhYmFzZT4g RE9NV2luZG93U1FMRGF0YWJhc2U6Om9wZW5EYXRhYmFzZShET01XaW5kb3cqIHdpbmRvdywgY29u c3QKICAgICAgICAgcmV0dXJuIDA7CiAKICAgICBSZWZQdHI8RGF0YWJhc2U+IGRhdGFiYXNlID0g MDsKLSAgICBpZiAod2luZG93LT5mcmFtZSgpICYmIEFic3RyYWN0RGF0YWJhc2U6OmlzQXZhaWxh YmxlKCkgJiYgd2luZG93LT5mcmFtZSgpLT5kb2N1bWVudCgpLT5zZWN1cml0eU9yaWdpbigpLT5j YW5BY2Nlc3NEYXRhYmFzZSgpKQotICAgICAgICBkYXRhYmFzZSA9IERhdGFiYXNlOjpvcGVuRGF0 YWJhc2Uod2luZG93LT5mcmFtZSgpLT5kb2N1bWVudCgpLCBuYW1lLCB2ZXJzaW9uLCBkaXNwbGF5 TmFtZSwgZXN0aW1hdGVkU2l6ZSwgY3JlYXRpb25DYWxsYmFjaywgZWMpOworICAgIGlmIChBYnN0 cmFjdERhdGFiYXNlOjppc0F2YWlsYWJsZSgpICYmIHdpbmRvdy0+ZG9jdW1lbnQoKS0+c2VjdXJp dHlPcmlnaW4oKS0+Y2FuQWNjZXNzRGF0YWJhc2UoKSkKKyAgICAgICAgZGF0YWJhc2UgPSBEYXRh YmFzZTo6b3BlbkRhdGFiYXNlKHdpbmRvdy0+ZG9jdW1lbnQoKSwgbmFtZSwgdmVyc2lvbiwgZGlz cGxheU5hbWUsIGVzdGltYXRlZFNpemUsIGNyZWF0aW9uQ2FsbGJhY2ssIGVjKTsKIAogICAgIGlm ICghZGF0YWJhc2UgJiYgIWVjKQogICAgICAgICBlYyA9IFNFQ1VSSVRZX0VSUjsK