75980 2012-01-10 11:47:20 -0800 Change -[WebHistoryItem copyWithZone:] to not use NSCopyObject() 2012-01-10 12:03:16 -0800 1 1 1 Unclassified WebKit History 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz oldest_to_newest 533254 0 mitz 2012-01-10 11:47:20 -0800 Change -[WebHistoryItem copyWithZone:] to not use NSCopyObject() 533256 1 121881 mitz 2012-01-10 11:48:31 -0800 Created attachment 121881 Patch 533262 2 121881 darin 2012-01-10 11:51:43 -0800 Comment on attachment 121881 Patch Maybe you should have used initWithWebCoreHistoryItem instead? 533270 3 121885 mitz 2012-01-10 11:56:24 -0800 Created attachment 121885 Patch 533274 4 121885 mrowe 2012-01-10 11:58:44 -0800 Comment on attachment 121885 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121885&action=review > Source/WebKit/mac/History/WebHistoryItem.mm:145 > + historyItemWrappers().set(core(_private), copy); I think you want core(copy->_private) here. 533275 5 121886 mitz 2012-01-10 11:59:00 -0800 Created attachment 121886 Patch 533278 6 mitz 2012-01-10 12:03:16 -0800 Committed <http://trac.webkit.org/r104613>. 121881 2012-01-10 11:48:31 -0800 2012-01-10 11:56:21 -0800 Patch bug-75980-20120110114830.patch text/plain 1357 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNDYwNykKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAxLTEw ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgQ2hhbmdlIC1bV2Vi SGlzdG9yeUl0ZW0gY29weVdpdGhab25lOl0gdG8gbm90IHVzZSBOU0NvcHlPYmplY3QoKQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU5ODAKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEhpc3RvcnkvV2Vi SGlzdG9yeUl0ZW0ubW06CisgICAgICAgICgtW1dlYkhpc3RvcnlJdGVtIGNvcHlXaXRoWm9uZTpd KTogUmVwbGFjZWQgTlNDb3B5T2JqZWN0KCkgd2l0aAorICAgICAgICAtYWxsb2MsIC1pbml0Lgor CiAyMDEyLTAxLTA2ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIE1pdGlnYXRlIHNjcm9sbGJhciBkaWZmZXJlbmNlcyB3aGVuIHJ1bm5pbmcgcGl4ZWwg dGVzdHMKSW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0hpc3RvcnkvV2ViSGlzdG9yeUl0ZW0ubW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9tYWMvSGlzdG9yeS9XZWJIaXN0b3J5SXRlbS5t bQkocmV2aXNpb24gMTA0NjAwKQorKysgU291cmNlL1dlYktpdC9tYWMvSGlzdG9yeS9XZWJIaXN0 b3J5SXRlbS5tbQkod29ya2luZyBjb3B5KQpAQCAtMTQxLDcgKzE0MSw3IEBAIC0gKHZvaWQpZmlu YWxpemUKIC0gKGlkKWNvcHlXaXRoWm9uZTooTlNab25lICopem9uZQogewogICAgIFdlYkNvcmVU aHJlYWRWaW9sYXRpb25DaGVja1JvdW5kT25lKCk7Ci0gICAgV2ViSGlzdG9yeUl0ZW0gKmNvcHkg PSAoV2ViSGlzdG9yeUl0ZW0gKilOU0NvcHlPYmplY3Qoc2VsZiwgMCwgem9uZSk7CisgICAgV2Vi SGlzdG9yeUl0ZW0gKmNvcHkgPSBbW1dlYkhpc3RvcnlJdGVtIGFsbG9jXSBpbml0XTsKICAgICBS ZWZQdHI8SGlzdG9yeUl0ZW0+IGl0ZW0gPSBjb3JlKF9wcml2YXRlKS0+Y29weSgpOwogICAgIGNv cHktPl9wcml2YXRlID0ga2l0UHJpdmF0ZShpdGVtLmdldCgpKTsKICAgICBoaXN0b3J5SXRlbVdy YXBwZXJzKCkuc2V0KGl0ZW0ucmVsZWFzZSgpLmxlYWtSZWYoKSwgY29weSk7Cg== 121885 2012-01-10 11:56:24 -0800 2012-01-10 11:58:57 -0800 Patch bug-75980-20120110115623.patch text/plain 1511 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNDYwNykKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAxLTEw ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgQ2hhbmdlIC1bV2Vi SGlzdG9yeUl0ZW0gY29weVdpdGhab25lOl0gdG8gbm90IHVzZSBOU0NvcHlPYmplY3QoKQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU5ODAKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEhpc3RvcnkvV2Vi SGlzdG9yeUl0ZW0ubW06CisgICAgICAgICgtW1dlYkhpc3RvcnlJdGVtIGNvcHlXaXRoWm9uZTpd KTogUmVwbGFjZWQgTlNDb3B5T2JqZWN0KCkgd2l0aAorICAgICAgICAtYWxsb2MsIC1pbml0V2l0 aFdlYkNvcmVIaXN0b3J5SXRlbTouCisKIDIwMTItMDEtMDYgIFNpbW9uIEZyYXNlciAgPHNpbW9u LmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgTWl0aWdhdGUgc2Nyb2xsYmFyIGRpZmZlcmVu Y2VzIHdoZW4gcnVubmluZyBwaXhlbCB0ZXN0cwpJbmRleDogU291cmNlL1dlYktpdC9tYWMvSGlz dG9yeS9XZWJIaXN0b3J5SXRlbS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9I aXN0b3J5L1dlYkhpc3RvcnlJdGVtLm1tCShyZXZpc2lvbiAxMDQ2MDApCisrKyBTb3VyY2UvV2Vi S2l0L21hYy9IaXN0b3J5L1dlYkhpc3RvcnlJdGVtLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xNDEs MTEgKzE0MSw5IEBAIC0gKHZvaWQpZmluYWxpemUKIC0gKGlkKWNvcHlXaXRoWm9uZTooTlNab25l ICopem9uZQogewogICAgIFdlYkNvcmVUaHJlYWRWaW9sYXRpb25DaGVja1JvdW5kT25lKCk7Ci0g ICAgV2ViSGlzdG9yeUl0ZW0gKmNvcHkgPSAoV2ViSGlzdG9yeUl0ZW0gKilOU0NvcHlPYmplY3Qo c2VsZiwgMCwgem9uZSk7Ci0gICAgUmVmUHRyPEhpc3RvcnlJdGVtPiBpdGVtID0gY29yZShfcHJp dmF0ZSktPmNvcHkoKTsKLSAgICBjb3B5LT5fcHJpdmF0ZSA9IGtpdFByaXZhdGUoaXRlbS5nZXQo KSk7Ci0gICAgaGlzdG9yeUl0ZW1XcmFwcGVycygpLnNldChpdGVtLnJlbGVhc2UoKS5sZWFrUmVm KCksIGNvcHkpOwotICAgIAorICAgIFdlYkhpc3RvcnlJdGVtICpjb3B5ID0gW1tXZWJIaXN0b3J5 SXRlbSBhbGxvY10gaW5pdFdpdGhXZWJDb3JlSGlzdG9yeUl0ZW06Y29yZShfcHJpdmF0ZSktPmNv cHkoKV07CisgICAgaGlzdG9yeUl0ZW1XcmFwcGVycygpLnNldChjb3JlKF9wcml2YXRlKSwgY29w eSk7CisKICAgICByZXR1cm4gY29weTsKIH0KIAo= 121886 2012-01-10 11:59:00 -0800 2012-01-10 11:59:29 -0800 Patch bug-75980-20120110115859.patch text/plain 1517 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNDYwNykKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAxLTEw ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgQ2hhbmdlIC1bV2Vi SGlzdG9yeUl0ZW0gY29weVdpdGhab25lOl0gdG8gbm90IHVzZSBOU0NvcHlPYmplY3QoKQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU5ODAKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEhpc3RvcnkvV2Vi SGlzdG9yeUl0ZW0ubW06CisgICAgICAgICgtW1dlYkhpc3RvcnlJdGVtIGNvcHlXaXRoWm9uZTpd KTogUmVwbGFjZWQgTlNDb3B5T2JqZWN0KCkgd2l0aAorICAgICAgICAtYWxsb2MsIC1pbml0V2l0 aFdlYkNvcmVIaXN0b3J5SXRlbTouCisKIDIwMTItMDEtMDYgIFNpbW9uIEZyYXNlciAgPHNpbW9u LmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgTWl0aWdhdGUgc2Nyb2xsYmFyIGRpZmZlcmVu Y2VzIHdoZW4gcnVubmluZyBwaXhlbCB0ZXN0cwpJbmRleDogU291cmNlL1dlYktpdC9tYWMvSGlz dG9yeS9XZWJIaXN0b3J5SXRlbS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9I aXN0b3J5L1dlYkhpc3RvcnlJdGVtLm1tCShyZXZpc2lvbiAxMDQ2MDApCisrKyBTb3VyY2UvV2Vi S2l0L21hYy9IaXN0b3J5L1dlYkhpc3RvcnlJdGVtLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xNDEs MTEgKzE0MSw5IEBAIC0gKHZvaWQpZmluYWxpemUKIC0gKGlkKWNvcHlXaXRoWm9uZTooTlNab25l ICopem9uZQogewogICAgIFdlYkNvcmVUaHJlYWRWaW9sYXRpb25DaGVja1JvdW5kT25lKCk7Ci0g ICAgV2ViSGlzdG9yeUl0ZW0gKmNvcHkgPSAoV2ViSGlzdG9yeUl0ZW0gKilOU0NvcHlPYmplY3Qo c2VsZiwgMCwgem9uZSk7Ci0gICAgUmVmUHRyPEhpc3RvcnlJdGVtPiBpdGVtID0gY29yZShfcHJp dmF0ZSktPmNvcHkoKTsKLSAgICBjb3B5LT5fcHJpdmF0ZSA9IGtpdFByaXZhdGUoaXRlbS5nZXQo KSk7Ci0gICAgaGlzdG9yeUl0ZW1XcmFwcGVycygpLnNldChpdGVtLnJlbGVhc2UoKS5sZWFrUmVm KCksIGNvcHkpOwotICAgIAorICAgIFdlYkhpc3RvcnlJdGVtICpjb3B5ID0gW1tXZWJIaXN0b3J5 SXRlbSBhbGxvY10gaW5pdFdpdGhXZWJDb3JlSGlzdG9yeUl0ZW06Y29yZShfcHJpdmF0ZSktPmNv cHkoKV07CisgICAgaGlzdG9yeUl0ZW1XcmFwcGVycygpLnNldChjb3JlKGNvcHktPl9wcml2YXRl KSwgY29weSk7CisKICAgICByZXR1cm4gY29weTsKIH0KIAo=