75977 2012-01-10 11:30:02 -0800 [GTK] Linking of big binaries should be serialized to avoid thrashing 2012-01-11 05:55:31 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 gustavo gustavo mrobinson pnormand xan.lopez oldest_to_newest 533235 0 gustavo 2012-01-10 11:30:02 -0800 WebKitPluginProcess, libwebkitgtk, and libwebkit2gtk are huge libraries when built in debug mode and can exhaust the available memory pretty easily when linked at the same time. We Their linking should be serialized. 533241 1 121878 gustavo 2012-01-10 11:35:17 -0800 Created attachment 121878 Proposed patch I'm doing a test build with --no-webkit2 to make sure it works, Philippe, but I couldn't see a reason for it not to =). More details on the trick to adding dependencies to automake targets: http://old.nabble.com/side-stepping-automake-limitations-with-custom-dependencies-td31907825.html 533339 2 gustavo 2012-01-10 13:24:52 -0800 OK, my --no-webkit2 build worked =) 533685 3 121878 mrobinson 2012-01-10 23:54:54 -0800 Comment on attachment 121878 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=121878&action=review This is awesome. > Source/WebKit2/GNUmakefile.am:1017 > +WEBKIT2GTKLIBFORDEP = libwebkit2gtk-@WEBKITGTK_API_MAJOR_VERSION@.@WEBKITGTK_API_MINOR_VERSION@.la We've been using names_like_this recently in automake files. Do you mind changing this to something like webkit2gtk_lib_for_dep > Source/WebKit2/GNUmakefile.am:1280 > +# Serialize linking of the plugin process with both webkit libraries Super nit: missing a period at the end of this line. > Source/WebKit2/GNUmakefile.am:1281 > +PLUGINPROCFORDEP = Programs/WebKitPluginProcess Ditto with the caps. 533832 4 gustavo 2012-01-11 05:54:47 -0800 Committed r104706: <http://trac.webkit.org/changeset/104706> 533833 5 121878 gustavo 2012-01-11 05:55:31 -0800 Comment on attachment 121878 Proposed patch Clearing review flag 121878 2012-01-10 11:35:17 -0800 2012-01-11 05:55:31 -0800 Proposed patch 0001-Patch.patch text/plain 2717 gustavo RnJvbSAwYTUyODY2OTFiNWZiOTdmZjZkOWY0NTkxOWU1ZDk2NzI2NTFmYjFhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+ CkRhdGU6IFR1ZSwgMTAgSmFuIDIwMTIgMTc6MzI6MjUgLTAyMDAKU3ViamVjdDogW1BBVENIXSBQ YXRjaAoKLS0tCiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgICAgICB8ICAgMTUgKysrKysrKysr KysrKysrCiBTb3VyY2UvV2ViS2l0Mi9HTlVtYWtlZmlsZS5hbSB8ICAgMTAgKysrKysrKysrKwog MiBmaWxlcyBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZwppbmRleCA2YjFiYzE0Li5iOWRhZGJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFu Z2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIw MTItMDEtMTAgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJv cmEuY29tPgorCisgICAgICAgIFtHVEtdIExpbmtpbmcgb2YgYmlnIGJpbmFyaWVzIHNob3VsZCBi ZSBzZXJpYWxpemVkIHRvIGF2b2lkIHRocmFzaGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU5NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBhcnRpZmljaWFsIGRlcGVuZGVuY2llcyBzbyB0 aGF0IGxpYndlYmtpdGd0ayBpcyBhbHdheXMKKyAgICAgICAgbGlua2VkIGZpcnN0LCBsaWJ3ZWJr aXQyZ3RrIHNlY29uZCwgYW5kIFdlYktpdFBsdWdpblByb2Nlc3MKKyAgICAgICAgbGFzdC4gQXV0 b21ha2UgdW5mb3J0dW5hdGVseSByZXBsYWNlcyB0aGUgd2hvbGUgcnVsZSB1c2VkIHRvIGJ1aWxk CisgICAgICAgIHRoZSBsaWJyYXJpZXMgaWYgdGhlIGFjdHVhbCBuYW1lIGlzIHVzZWQgdG8gYWRk IHRoZSBkZXBlbmRlbmN5LCBzbworICAgICAgICB3ZSB1c2UgaGVscGVyIHZhcmlhYmxlcyB0byB3 b3JrIGFyb3VuZCB0aGF0LgorCisgICAgICAgICogR05VbWFrZWZpbGUuYW06CisKIDIwMTItMDEt MDkgIEFuZHJhcyBCZWNzaSAgPGFuZHJhcy5iZWNzaUBub2tpYS5jb20+CiAKICAgICAgICAgW1F0 XVtXSzJdIFBpbmNoIHpvb20gc2hvdWxkIGFmZmVjdCB0aGUgcGFnZSBzaXplCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9HTlVtYWtlZmlsZS5hbSBiL1NvdXJjZS9XZWJLaXQyL0dOVW1ha2Vm aWxlLmFtCmluZGV4IGRjYjQ3YTEuLjYzMGFhOGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L0dOVW1ha2VmaWxlLmFtCisrKyBiL1NvdXJjZS9XZWJLaXQyL0dOVW1ha2VmaWxlLmFtCkBAIC0x MDExLDYgKzEwMTEsMTIgQEAgbGlid2Via2l0Mmd0a19AV0VCS0lUR1RLX0FQSV9NQUpPUl9WRVJT SU9OQF9AV0VCS0lUR1RLX0FQSV9NSU5PUl9WRVJTSU9OQF9sYV9DRkwKIGxpYl9MVExJQlJBUklF UyArPSBcCiAJbGlid2Via2l0Mmd0ay1AV0VCS0lUR1RLX0FQSV9NQUpPUl9WRVJTSU9OQC5AV0VC S0lUR1RLX0FQSV9NSU5PUl9WRVJTSU9OQC5sYQogCisjIEFydGlmaWNpYWwgZGVwZW5kZW5jeSB0 byBtYWtlIHN1cmUgbGlid2Via2l0Mmd0ayBhbmQgbGlid2Via2l0Z3RrIGFyZSBub3QgbGlua2Vk IGF0IHRoZSBzYW1lIHRpbWUKKyMgVGhlIHZhcmlhYmxlIGNyZWF0aW9uIGlzIHRvIGF2b2lkIGhh dmluZyBhdXRvbWFrZSBvdmVycmlkZSB0aGUgZW50aXJlIHJ1bGUgaW5zdGVhZCBvZiBhZGRpbmcg dGhlCisjIGRlcGVuZGVuY3kuCitXRUJLSVQyR1RLTElCRk9SREVQID0gbGlid2Via2l0Mmd0ay1A V0VCS0lUR1RLX0FQSV9NQUpPUl9WRVJTSU9OQC5AV0VCS0lUR1RLX0FQSV9NSU5PUl9WRVJTSU9O QC5sYQorJChXRUJLSVQyR1RLTElCRk9SREVQKTogbGlid2Via2l0Z3RrLUBXRUJLSVRHVEtfQVBJ X01BSk9SX1ZFUlNJT05ALkBXRUJLSVRHVEtfQVBJX01JTk9SX1ZFUlNJT05ALmxhCisKIGxpYndl YmtpdDJndGtfQFdFQktJVEdUS19BUElfTUFKT1JfVkVSU0lPTkBfQFdFQktJVEdUS19BUElfTUlO T1JfVkVSU0lPTkBfbGFkaXIgPSBcCiAJJChsaWJ3ZWJraXQyZ3RraW5jbHVkZWRpcikvV2ViS2l0 MgogCkBAIC0xMjcxLDYgKzEyNzcsMTAgQEAgbGliV2ViQ29yZUd0azJfbGFfQ1BQRkxBR1MgPSBc CiBsaWJleGVjX1BST0dSQU1TICs9IFwKIAlQcm9ncmFtcy9XZWJLaXRQbHVnaW5Qcm9jZXNzCiAK KyMgU2VyaWFsaXplIGxpbmtpbmcgb2YgdGhlIHBsdWdpbiBwcm9jZXNzIHdpdGggYm90aCB3ZWJr aXQgbGlicmFyaWVzCitQTFVHSU5QUk9DRk9SREVQID0gUHJvZ3JhbXMvV2ViS2l0UGx1Z2luUHJv Y2VzcworJChQTFVHSU5QUk9DRk9SREVQKTogbGlid2Via2l0Z3RrLUBXRUJLSVRHVEtfQVBJX01B Sk9SX1ZFUlNJT05ALkBXRUJLSVRHVEtfQVBJX01JTk9SX1ZFUlNJT05ALmxhIGxpYndlYmtpdDJn dGstQFdFQktJVEdUS19BUElfTUFKT1JfVkVSU0lPTkAuQFdFQktJVEdUS19BUElfTUlOT1JfVkVS U0lPTkAubGEKKwogUHJvZ3JhbXNfV2ViS2l0UGx1Z2luUHJvY2Vzc19DUFBGTEFHUyA9IFwKIAkt aW5jbHVkZSAkKHNyY2RpcikvU291cmNlL1dlYktpdDIvV2ViS2l0MlByZWZpeC5oIFwKIAktSSQo c3JjZGlyKS9Tb3VyY2UvV2ViS2l0MiBcCi0tIAoxLjcuOC4yCgo=