75962 2012-01-10 07:34:33 -0800 webkit-patch cannot rollout patches without changelog/bug number 2012-01-19 16:58:06 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kenneth eric abarth ahf aroben eric kkristof ojan ossy webkit.review.bot webkit-sed oldest_to_newest 533059 0 kenneth 2012-01-10 07:34:33 -0800 backtrace: webkit-patch rollout 104569 Committed unreviewed code from wrong branch Unable to parse bug number from diff. Traceback (most recent call last): File "/home/kenneth/swork/Qt5/webkit/Tools/Scripts/webkit-patch", line 69, in <module> main() File "/home/kenneth/swork/Qt5/webkit/Tools/Scripts/webkit-patch", line 64, in main WebKitPatch(os.path.abspath(__file__)).main() File "/scratchbox/users/kenneth/home/kenneth/swork/Qt5/webkit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main result = command.check_arguments_and_execute(options, args, self) File "/scratchbox/users/kenneth/home/kenneth/swork/Qt5/webkit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/scratchbox/users/kenneth/home/kenneth/swork/Qt5/webkit/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 46, in execute state = self._prepare_state(options, args, tool) File "/scratchbox/users/kenneth/home/kenneth/swork/Qt5/webkit/Tools/Scripts/webkitpy/tool/commands/download.py", line 348, in _prepare_state for party in commit_info.responsible_parties() AttributeError: 'NoneType' object has no attribute 'responsible_parties' 533060 1 kenneth 2012-01-10 07:35:04 -0800 Anyone knows who to cc here? 533070 2 ossy 2012-01-10 07:51:35 -0800 (In reply to comment #1) > Anyone knows who to cc here? Sure. :) 533173 3 eric 2012-01-10 10:27:38 -0800 Should be simple to fix and unittest. Thanks for the report. 538867 4 123160 eric 2012-01-19 11:45:47 -0800 Created attachment 123160 Patch 539162 5 123160 webkit.review.bot 2012-01-19 16:58:01 -0800 Comment on attachment 123160 Patch Clearing flags on attachment: 123160 Committed r105464: <http://trac.webkit.org/changeset/105464> 539163 6 webkit.review.bot 2012-01-19 16:58:06 -0800 All reviewed patches have been landed. Closing bug. 123160 2012-01-19 11:45:47 -0800 2012-01-19 16:58:01 -0800 Patch bug-75962-20120119114546.patch text/plain 3460 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NDI0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDdiNmIzNzgxZDc2NWMxY2M1YWEwZTRkNWQzZWZlNDE1 MjEyMzg4ZS4uNGUyN2Q3MTcxNTRhOTY5NGFiMjYxNzRlZmFlNTQzYjNjMjQwYjYzOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTAxLTE5ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAg ICB3ZWJraXQtcGF0Y2ggY2Fubm90IHJvbGxvdXQgcGF0Y2hlcyB3aXRob3V0IGNoYW5nZWxvZy9i dWcgbnVtYmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03NTk2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Rvd25sb2FkLnB5OgorICAgICAgICAo QWJzdHJhY3RSb2xsb3V0UHJlcENvbW1hbmQuX3ByZXBhcmVfc3RhdGUpOgorICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9kb3dubG9hZF91bml0dGVzdC5weToKKyAgICAg ICAgKEFic3RyYWN0Um9sbG91dFByZXBDb21tYW5kVGVzdC50ZXN0X3ByZXBhcmVfc3RhdGUpOgor CiAyMDEyLTAxLTE4ICBFbnJpY2EgQ2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CiAKICAgICAg ICAgZWRpdGluZ0F0dHJpYnV0ZWRTdHJpbmdGcm9tUmFuZ2UgaW4gV2ViSFRNTENvbnZlcnRlciBk b2VzIG5vdCBoYW5kbGUgTlNVbmRlcmxpbmVTdHlsZUF0dHJpYnV0ZU5hbWUuCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZG93bmxvYWQucHkgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZG93bmxvYWQucHkKaW5kZXggMmJhNDk4 NmUyY2IyZGRhNDFiZTg1NmM1ODNiMTM4ZmMwZTFiOTM1Yy4uODJhNTcwYTI1MzhjODgxMzM2ZTRm ODRiMjkyNzdkMWU1NjM4NDk5ZCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL2NvbW1hbmRzL2Rvd25sb2FkLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9v bC9jb21tYW5kcy9kb3dubG9hZC5weQpAQCAtMzQzLDE4ICszNDMsMjAgQEAgY2xhc3MgQWJzdHJh Y3RSb2xsb3V0UHJlcENvbW1hbmQoQWJzdHJhY3RTZXF1ZW5jZWRDb21tYW5kKToKIAogICAgICAg ICAjIFdlIHVzZSB0aGUgZWFybGllc3QgcmV2aXNpb24gZm9yIHRoZSBidWcgaW5mbwogICAgICAg ICBlYXJsaWVzdF9yZXZpc2lvbiA9IHJldmlzaW9uX2xpc3RbMF0KLSAgICAgICAgY29tbWl0X2lu Zm8gPSBzZWxmLl9jb21taXRfaW5mbyhlYXJsaWVzdF9yZXZpc2lvbikKLSAgICAgICAgY2NfbGlz dCA9IHNvcnRlZChbcGFydHkuYnVnemlsbGFfZW1haWwoKQotICAgICAgICAgICAgICAgICAgICAg ICAgICBmb3IgcGFydHkgaW4gY29tbWl0X2luZm8ucmVzcG9uc2libGVfcGFydGllcygpCi0gICAg ICAgICAgICAgICAgICAgICAgICAgIGlmIHBhcnR5LmJ1Z3ppbGxhX2VtYWlsKCldKQotICAgICAg ICByZXR1cm4geworICAgICAgICBzdGF0ZSA9IHsKICAgICAgICAgICAgICJyZXZpc2lvbiI6IGVh cmxpZXN0X3JldmlzaW9uLAogICAgICAgICAgICAgInJldmlzaW9uX2xpc3QiOiByZXZpc2lvbl9s aXN0LAotICAgICAgICAgICAgImJ1Z19pZCI6IGNvbW1pdF9pbmZvLmJ1Z19pZCgpLAotICAgICAg ICAgICAgIyBGSVhNRTogV2Ugc2hvdWxkIHVzZWQgdGhlIGxpc3QgYXMgdGhlIGNhbm9uaWNhbCBy ZXByZXNlbnRhdGlvbi4KLSAgICAgICAgICAgICJidWdfY2MiOiAiLCIuam9pbihjY19saXN0KSwK ICAgICAgICAgICAgICJyZWFzb24iOiBhcmdzWzFdLAogICAgICAgICB9CisgICAgICAgIGNvbW1p dF9pbmZvID0gc2VsZi5fY29tbWl0X2luZm8oZWFybGllc3RfcmV2aXNpb24pCisgICAgICAgIGlm IGNvbW1pdF9pbmZvOgorICAgICAgICAgICAgc3RhdGVbImJ1Z19pZCJdID0gY29tbWl0X2luZm8u YnVnX2lkKCkKKyAgICAgICAgICAgIGNjX2xpc3QgPSBzb3J0ZWQoW3BhcnR5LmJ1Z3ppbGxhX2Vt YWlsKCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBmb3IgcGFydHkgaW4gY29tbWl0X2lu Zm8ucmVzcG9uc2libGVfcGFydGllcygpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgaWYg cGFydHkuYnVnemlsbGFfZW1haWwoKV0pCisgICAgICAgICAgICAjIEZJWE1FOiBXZSBzaG91bGQg dXNlZCB0aGUgbGlzdCBhcyB0aGUgY2Fub25pY2FsIHJlcHJlc2VudGF0aW9uLgorICAgICAgICAg ICAgc3RhdGVbImJ1Z19jYyJdID0gIiwiLmpvaW4oY2NfbGlzdCkKKyAgICAgICAgcmV0dXJuIHN0 YXRlCiAKIAogY2xhc3MgUHJlcGFyZVJvbGxvdXQoQWJzdHJhY3RSb2xsb3V0UHJlcENvbW1hbmQp OgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Rvd25s b2FkX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Rv d25sb2FkX3VuaXR0ZXN0LnB5CmluZGV4IGQ1YTZmYWYwMjAyMGMwYTJjMTc0NDU4ZWVkMWJjMGIy MDE5MGIwMDEuLjQyMzllY2MzZGEzYTdlY2FmYjY5NzNkZTg5MDkxYjNjOGRjNzgyNmUgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9kb3dubG9hZF91bml0 dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZG93bmxv YWRfdW5pdHRlc3QucHkKQEAgLTY2LDYgKzY2LDExIEBAIGNsYXNzIEFic3RyYWN0Um9sbG91dFBy ZXBDb21tYW5kVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgIHNlbGYuYXNzZXJ0UmFp c2VzKFNjcmlwdEVycm9yLCBjb21tYW5kLl9wcmVwYXJlX3N0YXRlLCBvcHRpb25zPU5vbmUsIGFy Z3M9WyIxMjUgcjEyMiAgMTIzIiwgIlJlYXNvbiJdLCB0b29sPU5vbmUpCiAgICAgICAgIHNlbGYu YXNzZXJ0UmFpc2VzKFNjcmlwdEVycm9yLCBjb21tYW5kLl9wcmVwYXJlX3N0YXRlLCBvcHRpb25z PU5vbmUsIGFyZ3M9WyIxMjUgZm9vIDEyMyIsICJSZWFzb24iXSwgdG9vbD1Ob25lKQogCisgICAg ICAgIGNvbW1hbmQuX2NvbW1pdF9pbmZvID0gbGFtYmRhIHJldmlzaW9uOiBOb25lCisgICAgICAg IHN0YXRlID0gY29tbWFuZC5fcHJlcGFyZV9zdGF0ZShOb25lLCBbIjEyNCAxMjMgMTI1IiwgIlJl YXNvbiJdLCBOb25lKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKDEyMywgc3RhdGVbInJldmlz aW9uIl0pCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoWzEyMywgMTI0LCAxMjVdLCBzdGF0ZVsi cmV2aXNpb25fbGlzdCJdKQorCiAKIGNsYXNzIERvd25sb2FkQ29tbWFuZHNUZXN0KENvbW1hbmRz VGVzdCk6CiAgICAgZGVmIF9kZWZhdWx0X29wdGlvbnMoc2VsZik6Cg==