75960 CVE-2011-3927 2012-01-10 07:26:14 -0800 [skia] not all convex paths are convex, so recompute convexity for the problematic ones 2012-01-19 07:59:04 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 reed reed jschuh senorblanco webkit.review.bot oldest_to_newest 533051 0 reed 2012-01-10 07:26:14 -0800 [skia] not all convex paths are convex, so recompute convexity for the problematic ones 533053 1 121844 reed 2012-01-10 07:27:36 -0800 Created attachment 121844 Patch 533132 2 121844 senorblanco 2012-01-10 09:17:56 -0800 Comment on attachment 121844 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121844&action=review Looks good. r=me > Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:451 > + if (4 == numPoints) Nit: WebKit style doesn't use the reversed == operands. 533208 3 121872 reed 2012-01-10 11:08:13 -0800 Created attachment 121872 Patch 533210 4 reed 2012-01-10 11:08:45 -0800 new version fixes nit 533222 5 121872 senorblanco 2012-01-10 11:21:05 -0800 Comment on attachment 121872 Patch Thanks! r=me 533259 6 121872 webkit.review.bot 2012-01-10 11:50:57 -0800 Comment on attachment 121872 Patch Clearing flags on attachment: 121872 Committed r104609: <http://trac.webkit.org/changeset/104609> 533260 7 webkit.review.bot 2012-01-10 11:51:01 -0800 All reviewed patches have been landed. Closing bug. 121844 2012-01-10 07:27:36 -0800 2012-01-10 11:08:09 -0800 Patch bug-75960-20120110102736.patch text/plain 1857 reed SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNDU3MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAxLTEwICBNaWtlIFJl ZWQgIDxyZWVkQGdvb2dsZS5jb20+CisKKyAgICAgICAgW3NraWFdIG5vdCBhbGwgY29udmV4IHBh dGhzIGFyZSBjb252ZXgsIHNvIHJlY29tcHV0ZSBjb252ZXhpdHkgZm9yIHRoZSBwcm9ibGVtYXRp YyBvbmVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03 NTk2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cy4gU2VlIHJlbGF0ZWQgY2hyb21lIGlzc3VlCisgICAgICAgIGh0dHA6Ly9jb2Rl Lmdvb2dsZS5jb20vcC9jaHJvbWl1bS9pc3N1ZXMvZGV0YWlsP2lkPTEwODYwNQorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lhLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OnNldFBhdGhGcm9tQ29udmV4UG9pbnRzKToKKwogMjAxMi0wMS0wNiAgU3Rl cGhlbiBXaGl0ZSAgPHNlbm9yYmxhbmNvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbU2tpYV0g U3dpdGNoIEZFQ29sb3JNYXRyaXggdG8gdXNlIGEgc2tpYS1iYXNlZCBpbXBsZW1lbnRhdGlvbiB3 aGVuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBoaWNz Q29udGV4dFNraWEuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tpYS5jcHAJKHJldmlzaW9uIDEwNDU2NykKKysr IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tp YS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ0MCw3ICs0NDAsMTcgQEAgc3RhdGljIHZvaWQgc2V0 UGF0aEZyb21Db252ZXhQb2ludHMoU2tQYQogICAgICAgICBwYXRoLT5saW5lVG8oV2ViQ29yZUZs b2F0VG9Ta1NjYWxhcihwb2ludHNbaV0ueCgpKSwKICAgICAgICAgICAgICAgICAgICAgIFdlYkNv cmVGbG9hdFRvU2tTY2FsYXIocG9pbnRzW2ldLnkoKSkpOwogICAgIH0KLSAgICBwYXRoLT5zZXRJ c0NvbnZleCh0cnVlKTsKKworICAgIC8qICBUaGUgY29kZSB1c2VkIHRvIGp1c3QgYmxpbmRseSBj YWxsIHRoaXMKKyAgICAgICAgICAgIHBhdGgtPnNldElzQ29udmV4KHRydWUpOworICAgICAgICBC dXQgd2Via2l0IGNhbiBzb21ldGltZXMgc2VuZCB1cyBub24tY29udmV4IDQtcG9pbnQgdmFsdWVz LCBzbyB3ZSBtYXJrIHRoZSBwYXRoJ3MKKyAgICAgICAgY29udmV4aXR5IGFzIHVua25vd24sIHNv IGl0IHdpbGwgZ2V0IGNvbXB1dGVkIGJ5IHNraWEgYXQgZHJhdyB0aW1lLgorICAgICAgICBTZWUg Y3JidWcuY29tIDEwODYwNQorICAgICovCisgICAgU2tQYXRoOjpDb252ZXhpdHkgY29udmV4aXR5 ID0gU2tQYXRoOjprQ29udmV4X0NvbnZleGl0eTsKKyAgICBpZiAoNCA9PSBudW1Qb2ludHMpCisg ICAgICAgIGNvbnZleGl0eSA9IFNrUGF0aDo6a1Vua25vd25fQ29udmV4aXR5OworICAgIHBhdGgt PnNldENvbnZleGl0eShjb252ZXhpdHkpOwogfQogCiB2b2lkIEdyYXBoaWNzQ29udGV4dDo6ZHJh d0NvbnZleFBvbHlnb24oc2l6ZV90IG51bVBvaW50cywK 121872 2012-01-10 11:08:13 -0800 2012-01-10 11:50:57 -0800 Patch bug-75960-20120110140812.patch text/plain 1847 reed SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNDYwMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAxLTEwICBNaWtlIFJl ZWQgIDxyZWVkQGdvb2dsZS5jb20+CisKKyAgICAgICAgW3NraWFdIG5vdCBhbGwgY29udmV4IHBh dGhzIGFyZSBjb252ZXgsIHNvIHJlY29tcHV0ZSBjb252ZXhpdHkgZm9yIHRoZSBwcm9ibGVtYXRp YyBvbmVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03 NTk2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cy4KKyAgICAgICAgU2VlIHJlbGF0ZWQgY2hyb21lIGlzc3VlCisgICAgICAgIGh0 dHA6Ly9jb2RlLmdvb2dsZS5jb20vcC9jaHJvbWl1bS9pc3N1ZXMvZGV0YWlsP2lkPTEwODYwNQor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lhLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OnNldFBhdGhGcm9tQ29udmV4UG9pbnRzKToKKwogMjAxMi0w MS0xMCAgQWRyaWVubmUgV2Fsa2VyICA8ZW5uZUBnb29nbGUuY29tPgogCiAgICAgICAgIFtjaHJv bWl1bV0gRHJhdyBkZWJ1ZyB0aWxlIGJvcmRlcnMgb24gY29tcG9zaXRlZCBsYXllcnMKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tp YS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tp YS9HcmFwaGljc0NvbnRleHRTa2lhLmNwcAkocmV2aXNpb24gMTA0NTk4KQorKysgU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lhLmNwcAkod29y a2luZyBjb3B5KQpAQCAtNDQwLDcgKzQ0MCwxNyBAQCBzdGF0aWMgdm9pZCBzZXRQYXRoRnJvbUNv bnZleFBvaW50cyhTa1BhCiAgICAgICAgIHBhdGgtPmxpbmVUbyhXZWJDb3JlRmxvYXRUb1NrU2Nh bGFyKHBvaW50c1tpXS54KCkpLAogICAgICAgICAgICAgICAgICAgICAgV2ViQ29yZUZsb2F0VG9T a1NjYWxhcihwb2ludHNbaV0ueSgpKSk7CiAgICAgfQotICAgIHBhdGgtPnNldElzQ29udmV4KHRy dWUpOworCisgICAgLyogIFRoZSBjb2RlIHVzZWQgdG8ganVzdCBibGluZGx5IGNhbGwgdGhpcwor ICAgICAgICAgICAgcGF0aC0+c2V0SXNDb252ZXgodHJ1ZSk7CisgICAgICAgIEJ1dCB3ZWJraXQg Y2FuIHNvbWV0aW1lcyBzZW5kIHVzIG5vbi1jb252ZXggNC1wb2ludCB2YWx1ZXMsIHNvIHdlIG1h cmsgdGhlIHBhdGgncworICAgICAgICBjb252ZXhpdHkgYXMgdW5rbm93biwgc28gaXQgd2lsbCBn ZXQgY29tcHV0ZWQgYnkgc2tpYSBhdCBkcmF3IHRpbWUuCisgICAgICAgIFNlZSBjcmJ1Zy5jb20g MTA4NjA1CisgICAgKi8KKyAgICBTa1BhdGg6OkNvbnZleGl0eSBjb252ZXhpdHkgPSBTa1BhdGg6 OmtDb252ZXhfQ29udmV4aXR5OworICAgIGlmIChudW1Qb2ludHMgPT0gNCkKKyAgICAgICAgY29u dmV4aXR5ID0gU2tQYXRoOjprVW5rbm93bl9Db252ZXhpdHk7CisgICAgcGF0aC0+c2V0Q29udmV4 aXR5KGNvbnZleGl0eSk7CiB9CiAKIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpkcmF3Q29udmV4UG9s eWdvbihzaXplX3QgbnVtUG9pbnRzLAo=