75953 2012-01-10 05:04:53 -0800 Web Inspector: fix DebuggerPresentationModel::uiSourceCodes - do not iterate over same raw source code multiple times. 2012-01-10 05:49:21 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 532978 0 pfeldman 2012-01-10 05:04:53 -0800 Fix to follow. 532990 1 121833 pfeldman 2012-01-10 05:25:27 -0800 Created attachment 121833 Patch 532999 2 121833 yurys 2012-01-10 05:36:14 -0800 Comment on attachment 121833 Patch Would be good to have a test for this. 533004 3 pfeldman 2012-01-10 05:47:31 -0800 uiSources is already covered with the tests, I could add one, but it would be artificial, covering the only mocked scenario... 533006 4 pfeldman 2012-01-10 05:49:21 -0800 Committed r104563: <http://trac.webkit.org/changeset/104563> 121833 2012-01-10 05:25:27 -0800 2012-01-10 05:36:14 -0800 Patch bug-75953-20120110172525.patch text/plain 5558 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0NTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGZmZGNjYjAwNWYxNzk0 Mzk3YzkzODQwNjVjN2U3ZTExNjQzNzhmYy4uMzJhNmQ3ZGYyMDAwMDU3NTMzMDE4ZDBhMTMwNzg2 M2FmMDQyYzViMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEyLTAxLTEwICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AZ29vZ2xlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9y OiBmaXggRGVidWdnZXJQcmVzZW50YXRpb25Nb2RlbDo6dWlTb3VyY2VDb2RlcyAtIGRvIG5vdCBp dGVyYXRlCisgICAgICAgIG92ZXIgc2FtZSByYXcgc291cmNlIGNvZGUgbXVsdGlwbGUgdGltZXMu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTk1Mwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVj dG9yL2Zyb250LWVuZC9EZWJ1Z2dlclByZXNlbnRhdGlvbk1vZGVsLmpzOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLkRlYnVnZ2VyUHJlc2VudGF0aW9uTW9kZWwpOgorICAgICAgICAoV2ViSW5zcGVj dG9yLkRlYnVnZ2VyUHJlc2VudGF0aW9uTW9kZWwucHJvdG90eXBlLl9iaW5kU2NyaXB0VG9SYXdT b3VyY2VDb2RlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5EZWJ1Z2dlclByZXNlbnRhdGlvbk1v ZGVsLnByb3RvdHlwZS51aVNvdXJjZUNvZGVzKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5EZWJ1 Z2dlclByZXNlbnRhdGlvbk1vZGVsLnByb3RvdHlwZS5zZXRGb3JtYXRTb3VyY2UpOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLkRlYnVnZ2VyUHJlc2VudGF0aW9uTW9kZWwucHJvdG90eXBlLl9jb25z b2xlQ2xlYXJlZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRGVidWdnZXJQcmVzZW50YXRpb25N b2RlbC5wcm90b3R5cGUuX2RlYnVnZ2VyUmVzZXQpOgorCisyMDEyLTAxLTEwICBQYXZlbCBGZWxk bWFuICA8cGZlbGRtYW5AZ29vZ2xlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiB0eXBv OiBOZXR3b3JrQWdlbnQuY2FuQ2xlYXJCcm93c2VyQ2FjaGUgLT4gTmV0d29ya0FnZW50LmNhbkNs ZWFyQnJvd3NlckNvb2tpZXMuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD03NTk0OQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL0RlYnVnZ2VyUHJlc2VudGF0aW9uTW9kZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0RlYnVnZ2VyUHJlc2VudGF0aW9uTW9kZWwuanMKaW5kZXggNmNm ZTY4M2IzMzdjZGNlZDAwMmVlYTRmZDQ0ZTdlNmJiYjM3OWNmMi4uNzZkYTY1OGIzMjUxZjg5NDVj OTI3MDg3YjhkYzNmOTczMmQ0NTMwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9EZWJ1Z2dlclByZXNlbnRhdGlvbk1vZGVsLmpzCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGVidWdnZXJQcmVzZW50YXRpb25Nb2RlbC5qcwpA QCAtMzYsNiArMzYsNyBAQCBXZWJJbnNwZWN0b3IuRGVidWdnZXJQcmVzZW50YXRpb25Nb2RlbCA9 IGZ1bmN0aW9uKCkKIHsKICAgICAvLyBGSVhNRTogYXBwbHkgZm9ybWF0dGVyIGZyb20gb3V0c2lk ZSBhcyBhIGdlbmVyaWMgbWFwcGluZy4KICAgICB0aGlzLl9mb3JtYXR0ZXIgPSBuZXcgV2ViSW5z cGVjdG9yLlNjcmlwdEZvcm1hdHRlcigpOworICAgIHRoaXMuX3Jhd1NvdXJjZUNvZGVzID0gW107 CiAgICAgdGhpcy5fcmF3U291cmNlQ29kZUZvclNjcmlwdElkID0ge307CiAgICAgdGhpcy5fcmF3 U291cmNlQ29kZUZvclVSTCA9IHt9OwogICAgIHRoaXMuX3Jhd1NvdXJjZUNvZGVGb3JEb2N1bWVu dFVSTCA9IHt9OwpAQCAtMTQzLDcgKzE0NCw4IEBAIFdlYkluc3BlY3Rvci5EZWJ1Z2dlclByZXNl bnRhdGlvbk1vZGVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgaWYgKFdlYkluc3BlY3Rvci5zZXR0 aW5ncy5zb3VyY2VNYXBzRW5hYmxlZC5nZXQoKSAmJiBzY3JpcHQuc291cmNlTWFwVVJMKQogICAg ICAgICAgICAgY29tcGlsZXJTb3VyY2VNYXBwaW5nID0gbmV3IFdlYkluc3BlY3Rvci5DbG9zdXJl Q29tcGlsZXJTb3VyY2VNYXBwaW5nKHNjcmlwdC5zb3VyY2VNYXBVUkwsIHNjcmlwdC5zb3VyY2VV UkwpOwogCi0gICAgICAgIHJhd1NvdXJjZUNvZGUgPSBuZXcgV2ViSW5zcGVjdG9yLlJhd1NvdXJj ZUNvZGUoc2NyaXB0LnNjcmlwdElkLCBzY3JpcHQsIHJlc291cmNlLCB0aGlzLl9mb3JtYXR0ZXIs IHRoaXMuX2Zvcm1hdFNvdXJjZSwgY29tcGlsZXJTb3VyY2VNYXBwaW5nKTsKKyAgICAgICAgdmFy IHJhd1NvdXJjZUNvZGUgPSBuZXcgV2ViSW5zcGVjdG9yLlJhd1NvdXJjZUNvZGUoc2NyaXB0LnNj cmlwdElkLCBzY3JpcHQsIHJlc291cmNlLCB0aGlzLl9mb3JtYXR0ZXIsIHRoaXMuX2Zvcm1hdFNv dXJjZSwgY29tcGlsZXJTb3VyY2VNYXBwaW5nKTsKKyAgICAgICAgdGhpcy5fcmF3U291cmNlQ29k ZXMucHVzaChyYXdTb3VyY2VDb2RlKTsKICAgICAgICAgdGhpcy5fYmluZFNjcmlwdFRvUmF3U291 cmNlQ29kZShzY3JpcHQsIHJhd1NvdXJjZUNvZGUpOwogCiAgICAgICAgIGlmIChpc0lubGluZVNj cmlwdCkKQEAgLTE4MCwxMCArMTgyLDEwIEBAIFdlYkluc3BlY3Rvci5EZWJ1Z2dlclByZXNlbnRh dGlvbk1vZGVsLnByb3RvdHlwZSA9IHsKICAgICB1aVNvdXJjZUNvZGVzOiBmdW5jdGlvbigpCiAg ICAgewogICAgICAgICB2YXIgcmVzdWx0ID0gW107Ci0gICAgICAgIGZvciAodmFyIGlkIGluIHRo aXMuX3Jhd1NvdXJjZUNvZGVGb3JTY3JpcHRJZCkgewotICAgICAgICAgICAgdmFyIHVpU291cmNl Q29kZUxpc3QgPSB0aGlzLl9yYXdTb3VyY2VDb2RlRm9yU2NyaXB0SWRbaWRdLnNvdXJjZU1hcHBp bmcudWlTb3VyY2VDb2RlTGlzdCgpOwotICAgICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCB1 aVNvdXJjZUNvZGVMaXN0Lmxlbmd0aDsgKytpKQotICAgICAgICAgICAgICAgIHJlc3VsdC5wdXNo KHVpU291cmNlQ29kZUxpc3RbaV0pOworICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHRoaXMu X3Jhd1NvdXJjZUNvZGVzLmxlbmd0aDsgKytpKSB7CisgICAgICAgICAgICB2YXIgdWlTb3VyY2VD b2RlTGlzdCA9IHRoaXMuX3Jhd1NvdXJjZUNvZGVzW2ldLnNvdXJjZU1hcHBpbmcudWlTb3VyY2VD b2RlTGlzdCgpOworICAgICAgICAgICAgZm9yICh2YXIgaiA9IDA7IGogPCB1aVNvdXJjZUNvZGVM aXN0Lmxlbmd0aDsgKytqKQorICAgICAgICAgICAgICAgIHJlc3VsdC5wdXNoKHVpU291cmNlQ29k ZUxpc3Rbal0pOwogICAgICAgICB9CiAgICAgICAgIHJldHVybiByZXN1bHQ7CiAgICAgfSwKQEAg LTMzNSw4ICszMzcsOCBAQCBXZWJJbnNwZWN0b3IuRGVidWdnZXJQcmVzZW50YXRpb25Nb2RlbC5w cm90b3R5cGUgPSB7CiAKICAgICAgICAgdGhpcy5fZm9ybWF0U291cmNlID0gZm9ybWF0U291cmNl OwogICAgICAgICB0aGlzLl9icmVha3BvaW50TWFuYWdlci5yZXNldCgpOwotICAgICAgICBmb3Ig KHZhciBpZCBpbiB0aGlzLl9yYXdTb3VyY2VDb2RlRm9yU2NyaXB0SWQpCi0gICAgICAgICAgICB0 aGlzLl9yYXdTb3VyY2VDb2RlRm9yU2NyaXB0SWRbaWRdLnNldEZvcm1hdHRlZCh0aGlzLl9mb3Jt YXRTb3VyY2UpOworICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHRoaXMuX3Jhd1NvdXJjZUNv ZGVzLmxlbmd0aDsgKytpKQorICAgICAgICAgICAgdGhpcy5fcmF3U291cmNlQ29kZXNbaV0uc2V0 Rm9ybWF0dGVkKHRoaXMuX2Zvcm1hdFNvdXJjZSk7CiAgICAgfSwKIAogICAgIC8qKgpAQCAtMzc2 LDggKzM3OCw4IEBAIFdlYkluc3BlY3Rvci5EZWJ1Z2dlclByZXNlbnRhdGlvbk1vZGVsLnByb3Rv dHlwZSA9IHsKIAogICAgIF9jb25zb2xlQ2xlYXJlZDogZnVuY3Rpb24oKQogICAgIHsKLSAgICAg ICAgZm9yICh2YXIgaWQgaW4gdGhpcy5fcmF3U291cmNlQ29kZUZvclNjcmlwdElkKQotICAgICAg ICAgICAgdGhpcy5fcmF3U291cmNlQ29kZUZvclNjcmlwdElkW2lkXS5tZXNzYWdlcyA9IFtdOwor ICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHRoaXMuX3Jhd1NvdXJjZUNvZGVzLmxlbmd0aDsg KytpKQorICAgICAgICAgICAgdGhpcy5fcmF3U291cmNlQ29kZXNbaV0ubWVzc2FnZXMgPSBbXTsK ICAgICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV2ViSW5zcGVjdG9yLkRlYnVn Z2VyUHJlc2VudGF0aW9uTW9kZWwuRXZlbnRzLkNvbnNvbGVNZXNzYWdlc0NsZWFyZWQpOwogICAg IH0sCiAKQEAgLTY1NSwxNSArNjU3LDE2IEBAIFdlYkluc3BlY3Rvci5EZWJ1Z2dlclByZXNlbnRh dGlvbk1vZGVsLnByb3RvdHlwZSA9IHsKIAogICAgIF9kZWJ1Z2dlclJlc2V0OiBmdW5jdGlvbigp CiAgICAgewotICAgICAgICBmb3IgKHZhciBpZCBpbiB0aGlzLl9yYXdTb3VyY2VDb2RlRm9yU2Ny aXB0SWQpIHsKLSAgICAgICAgICAgIHZhciByYXdTb3VyY2VDb2RlID0gdGhpcy5fcmF3U291cmNl Q29kZUZvclNjcmlwdElkW2lkXTsKKyAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCB0aGlzLl9y YXdTb3VyY2VDb2Rlcy5sZW5ndGg7ICsraSkgeworICAgICAgICAgICAgdmFyIHJhd1NvdXJjZUNv ZGUgPSB0aGlzLl9yYXdTb3VyY2VDb2Rlc1tpXTsKICAgICAgICAgICAgIGlmIChyYXdTb3VyY2VD b2RlLnNvdXJjZU1hcHBpbmcpIHsKICAgICAgICAgICAgICAgICB2YXIgdWlTb3VyY2VDb2RlTGlz dCA9IHJhd1NvdXJjZUNvZGUuc291cmNlTWFwcGluZy51aVNvdXJjZUNvZGVMaXN0KCk7Ci0gICAg ICAgICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCB1aVNvdXJjZUNvZGVMaXN0Lmxlbmd0aDsg KytpKQotICAgICAgICAgICAgICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhX ZWJJbnNwZWN0b3IuRGVidWdnZXJQcmVzZW50YXRpb25Nb2RlbC5FdmVudHMuVUlTb3VyY2VDb2Rl UmVtb3ZlZCwgdWlTb3VyY2VDb2RlTGlzdFtpXSk7CisgICAgICAgICAgICAgICAgZm9yICh2YXIg aiA9IDA7IGogPCB1aVNvdXJjZUNvZGVMaXN0Lmxlbmd0aDsgKytqKQorICAgICAgICAgICAgICAg ICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhXZWJJbnNwZWN0b3IuRGVidWdnZXJQ cmVzZW50YXRpb25Nb2RlbC5FdmVudHMuVUlTb3VyY2VDb2RlUmVtb3ZlZCwgdWlTb3VyY2VDb2Rl TGlzdFtqXSk7CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICByYXdTb3VyY2VDb2RlLnJlbW92 ZUFsbExpc3RlbmVycygpOwogICAgICAgICB9CisgICAgICAgIHRoaXMuX3Jhd1NvdXJjZUNvZGVz ID0gW107CiAgICAgICAgIHRoaXMuX3Jhd1NvdXJjZUNvZGVGb3JTY3JpcHRJZCA9IHt9OwogICAg ICAgICB0aGlzLl9yYXdTb3VyY2VDb2RlRm9yVVJMID0ge307CiAgICAgICAgIHRoaXMuX3Jhd1Nv dXJjZUNvZGVGb3JEb2N1bWVudFVSTCA9IHt9Owo=