75921 2012-01-09 18:14:37 -0800 [Mac] Accelerate canvas layers with the same logic as accelerating the canvas itself 2012-01-10 12:31:03 -0800 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mdelaney7 mdelaney7 mdelaney7 simon.fraser oldest_to_newest 532745 0 mdelaney7 2012-01-09 18:14:37 -0800 Unblocking our desired lazy allocation of canvas backing stores via http://trac.webkit.org/changeset/96624/trunk introduced the issue of timing problems when asking if a canvas is accelerated or not. For example, when deciding whether or not to set accelerates drawing on a layer we ask if the canvas is accelerated. If the canvas isn't fully created, we might not know if it's accelerated or not, so we default to returning false. So, we can avoid this issue if we just instead accelerate the layer based off the same logic the canvas would use, namely HTMLCanvasElement::shouldAccelerate(). 532750 1 121778 mdelaney7 2012-01-09 18:22:57 -0800 Created attachment 121778 Patch 532752 2 121779 mdelaney7 2012-01-09 18:27:48 -0800 Created attachment 121779 Patch 533295 3 mdelaney7 2012-01-10 12:31:03 -0800 Committed r104616: <http://trac.webkit.org/changeset/104616> 121778 2012-01-09 18:22:57 -0800 2012-01-09 18:27:45 -0800 Patch bug-75921-20120109182256.patch text/plain 2494 mdelaney7 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNDUzMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAxLTA5ICBNYXR0aGV3 IERlbGFuZXkgIDxtZGVsYW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgW01hY10gQWNjZWxlcmF0 ZSBjYW52YXMgbGF5ZXJzIHdpdGggdGhlIHNhbWUgbG9naWMgYXMgYWNjZWxlcmF0aW5nIHRoZSBj YW52YXMgaXRzZWxmCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03NTkyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cy4gRG9lcyBub3QgYWZmZWN0IGRldGVjdGFibGUgYmVoYXZpb3IuCisK KyAgICAgICAgKiBodG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6Q2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjppc0FjY2VsZXJhdGVkKToK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlJlbmRlckxheWVyQ29tcG9zaXRvcjo6dXBkYXRlQmFja2luZyk6CisKIDIwMTIt MDEtMDkgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICAtW0RPTVJh bmdlIHJlbmRlcmVkSW1hZ2VGb3JjaW5nQmxhY2tUZXh0Ol0gZmFpbHMgd2l0aCBub24tdXNlci1z ZWxlY3RhYmxlIHRleHQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1Jl bmRlcmluZ0NvbnRleHQyRC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9j YW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAkocmV2aXNpb24gMTAzOTQzKQorKysg U291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTQ5LDcgKzE0OSwxMCBAQCBDYW52YXNSZW5kZXJpbmdDb250ZXh0 MkQ6On5DYW52YXNSZW5kZXJpCiBib29sIENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6aXNBY2Nl bGVyYXRlZCgpIGNvbnN0CiB7CiAjaWYgVVNFKElPU1VSRkFDRV9DQU5WQVNfQkFDS0lOR19TVE9S RSkgfHwgRU5BQkxFKEFDQ0VMRVJBVEVEXzJEX0NBTlZBUykKLSAgICByZXR1cm4gY2FudmFzKCkt Pmhhc0NyZWF0ZWRJbWFnZUJ1ZmZlcigpICYmIGRyYXdpbmdDb250ZXh0KCkgJiYgZHJhd2luZ0Nv bnRleHQoKS0+aXNBY2NlbGVyYXRlZENvbnRleHQoKTsKKyAgICBib29sIHZhbCA9IGNhbnZhcygp LT5oYXNDcmVhdGVkSW1hZ2VCdWZmZXIoKTsKKyAgICB2YWwgPSB2YWwgJiYgZHJhd2luZ0NvbnRl eHQoKTsKKyAgICB2YWwgPSB2YWwgJiYgZHJhd2luZ0NvbnRleHQoKS0+aXNBY2NlbGVyYXRlZENv bnRleHQoKTsKKyAgICByZXR1cm4gdmFsOwogI2Vsc2UKICAgICByZXR1cm4gZmFsc2U7CiAjZW5k aWYKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3Iu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNv bXBvc2l0b3IuY3BwCShyZXZpc2lvbiAxMDM5NDMpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzcyLDcgKzM3 Miw3IEBAIGJvb2wgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjp1cGRhdGVCYWNraW4KICAgICAgICAg ICAgICAgICBsYXllci0+YmFja2luZygpLT5ncmFwaGljc0xheWVyKCktPnNldEFjY2VsZXJhdGVz RHJhd2luZyh0cnVlKTsKICAgICAgICAgICAgIGVsc2UgaWYgKGxheWVyLT5yZW5kZXJlcigpLT5p c0NhbnZhcygpKSB7CiAgICAgICAgICAgICAgICAgSFRNTENhbnZhc0VsZW1lbnQqIGNhbnZhcyA9 IHN0YXRpY19jYXN0PEhUTUxDYW52YXNFbGVtZW50Kj4obGF5ZXItPnJlbmRlcmVyKCktPm5vZGUo KSk7Ci0gICAgICAgICAgICAgICAgaWYgKGNhbnZhcy0+cmVuZGVyaW5nQ29udGV4dCgpICYmIGNh bnZhcy0+cmVuZGVyaW5nQ29udGV4dCgpLT5pc0FjY2VsZXJhdGVkKCkpCisgICAgICAgICAgICAg ICAgaWYgKGNhbnZhcy0+c2hvdWxkQWNjZWxlcmF0ZShjYW52YXMtPnNpemUoKSkpCiAgICAgICAg ICAgICAgICAgICAgIGxheWVyLT5iYWNraW5nKCktPmdyYXBoaWNzTGF5ZXIoKS0+c2V0QWNjZWxl cmF0ZXNEcmF3aW5nKHRydWUpOwogICAgICAgICAgICAgfQogI2VuZGlmCg== 121779 2012-01-09 18:27:48 -0800 2012-01-09 21:39:44 -0800 Patch bug-75921-20120109182747.patch text/plain 1703 mdelaney7 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNDUzMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAxLTA5ICBNYXR0aGV3 IERlbGFuZXkgIDxtZGVsYW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgW01hY10gQWNjZWxlcmF0 ZSBjYW52YXMgbGF5ZXJzIHdpdGggdGhlIHNhbWUgbG9naWMgYXMgYWNjZWxlcmF0aW5nIHRoZSBj YW52YXMgaXRzZWxmCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03NTkyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cy4gRG9lcyBub3QgYWZmZWN0IGRldGVjdGFibGUgYmVoYXZpb3IuCisK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcDogVXNlIGNhbnZh cydzIHNob3VsZEFjY2VsZXJhdGUgdG8gYXZvaWQgYXNraW5nCisgICAgICAgIHVuaW5pdGlhbGl6 ZWQgY2FudmFzJ3MgaWYgdGhleSdyZSBhY2NlbGVyYXRlZCBvciBub3QuCisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJMYXllckNvbXBvc2l0b3I6OnVwZGF0ZUJhY2tpbmcpOgorCiAyMDEyLTAxLTA5 ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgLVtET01SYW5nZSBy ZW5kZXJlZEltYWdlRm9yY2luZ0JsYWNrVGV4dDpdIGZhaWxzIHdpdGggbm9uLXVzZXItc2VsZWN0 YWJsZSB0ZXh0CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21w b3NpdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXJDb21wb3NpdG9yLmNwcAkocmV2aXNpb24gMTAzOTQzKQorKysgU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM3 Miw3ICszNzIsNyBAQCBib29sIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6dXBkYXRlQmFja2luCiAg ICAgICAgICAgICAgICAgbGF5ZXItPmJhY2tpbmcoKS0+Z3JhcGhpY3NMYXllcigpLT5zZXRBY2Nl bGVyYXRlc0RyYXdpbmcodHJ1ZSk7CiAgICAgICAgICAgICBlbHNlIGlmIChsYXllci0+cmVuZGVy ZXIoKS0+aXNDYW52YXMoKSkgewogICAgICAgICAgICAgICAgIEhUTUxDYW52YXNFbGVtZW50KiBj YW52YXMgPSBzdGF0aWNfY2FzdDxIVE1MQ2FudmFzRWxlbWVudCo+KGxheWVyLT5yZW5kZXJlcigp LT5ub2RlKCkpOwotICAgICAgICAgICAgICAgIGlmIChjYW52YXMtPnJlbmRlcmluZ0NvbnRleHQo KSAmJiBjYW52YXMtPnJlbmRlcmluZ0NvbnRleHQoKS0+aXNBY2NlbGVyYXRlZCgpKQorICAgICAg ICAgICAgICAgIGlmIChjYW52YXMtPnNob3VsZEFjY2VsZXJhdGUoY2FudmFzLT5zaXplKCkpKQog ICAgICAgICAgICAgICAgICAgICBsYXllci0+YmFja2luZygpLT5ncmFwaGljc0xheWVyKCktPnNl dEFjY2VsZXJhdGVzRHJhd2luZyh0cnVlKTsKICAgICAgICAgICAgIH0KICNlbmRpZgo=