75912 2012-01-09 16:45:06 -0800 [chromium] Correctly recreate DrawingBuffer on lost device 2012-01-10 15:19:20 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All Unspecified RESOLVED FIXED P2 Normal --- 1 jbauman jbauman kbr twiz webkit.review.bot oldest_to_newest 532653 0 jbauman 2012-01-09 16:45:06 -0800 [chromium] Correctly recreate DrawingBuffer on lost device 532657 1 121760 jbauman 2012-01-09 16:50:10 -0800 Created attachment 121760 Patch 532660 2 webkit.review.bot 2012-01-09 16:52:44 -0800 Attachment 121760 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 532663 3 121761 jbauman 2012-01-09 16:56:31 -0800 Created attachment 121761 Patch 533095 4 121761 twiz 2012-01-10 08:33:52 -0800 Comment on attachment 121761 Patch Thanks for catching this, John. LGTM. 533168 5 121761 kbr 2012-01-10 10:21:47 -0800 Comment on attachment 121761 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121761&action=review > Source/WebCore/ChangeLog:11 > + No new tests. Have you tried to use LayoutTestController.loseCompositorContext() (see LayoutTests/platform/chromium/compositing/) or the WEBGL_lose_context extension (see LayoutTests/fast/canvas/webgl/) to force execution of this code path? In general we should add a test each time an issue like this is discovered to prevent future regressions. However, if the above primitives don't allow testing of this code path then I won't hold it up. 533369 6 121761 kbr 2012-01-10 14:13:13 -0800 Comment on attachment 121761 Patch After offline discussion it seems like the WEBGL_lose_context extension would need to lose the context at a deeper level in order to test this code path. Given that, r+'ing as is to get this fix in now. 533409 7 121761 webkit.review.bot 2012-01-10 15:19:16 -0800 Comment on attachment 121761 Patch Clearing flags on attachment: 121761 Committed r104636: <http://trac.webkit.org/changeset/104636> 533410 8 webkit.review.bot 2012-01-10 15:19:20 -0800 All reviewed patches have been landed. Closing bug. 121760 2012-01-09 16:50:10 -0800 2012-01-09 16:56:27 -0800 Patch bug-75912-20120109165008.patch text/plain 1777 jbauman U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0MjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTYyNzVjMWEzZTA1MDYx M2Q4NmEwNDAwYzNjYzQ2NDI1ZDQ1ZjMwZC4uY2Q2MTA5YzllZjQ2NDhmZWU0NjY0YTBjNmYzNjY0 ZmYwMDI4YWQzNSAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAxLTA5ICBKb2hu IEJhdW1hbiAgPGpiYXVtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gQ29y cmVjdGx5IHJlY3JlYXRlIERyYXdpbmdCdWZmZXIgb24gbG9zdCBkZXZpY2UKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1OTEyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKwlDcmVhdGUgbmV3IGRyYXdpbmcgYnVmZmVyIG9u IG5ldyBjb250ZXh0LCBub3Qgb2xkIGxvc3QgY29udGV4dC4gQWxzbywKKwltYWtlIHN1cmUgdG8g YmluZCBuZXcgZHJhd2luZyBidWZmZXIuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAg ICAgICogaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OldlYkdMUmVuZGVyaW5nQ29udGV4dDo6bWF5YmVSZXN0b3JlQ29udGV4dCk6CisKIDIw MTItMDEtMDUgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgSW5z ZXJ0aW5nIG5vZGVzIGlzIHNsb3cgZHVlIHRvIE5vZGU6Om5vdGlmeU5vZGVMaXN0c0F0dHJpYnV0 ZUNoYW5nZWQgKDIwJSspCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9X ZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2Vi R0xSZW5kZXJpbmdDb250ZXh0LmNwcAppbmRleCBhN2I5Y2Y2NDg2MGY1Y2UzY2QyMjcxYzYwYTk5 ZmE0Njk2OTY3ODRjLi5kMTc3NDFmYjMwYWUzOWI0OTYyN2YwM2I1ZTVmZDljNDIyY2I5ZTNkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRl eHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29u dGV4dC5jcHAKQEAgLTUwMzcsNyArNTAzNyw4IEBAIHZvaWQgV2ViR0xSZW5kZXJpbmdDb250ZXh0 OjptYXliZVJlc3RvcmVDb250ZXh0KFRpbWVyPFdlYkdMUmVuZGVyaW5nQ29udGV4dD4qKQogICAg IC8vIENvbnN0cnVjdCBhIG5ldyBkcmF3aW5nIGJ1ZmZlciB3aXRoIHRoZSBuZXcgR3JhcGhpY3ND b250ZXh0M0QuCiAgICAgaWYgKG1fZHJhd2luZ0J1ZmZlcikgewogICAgICAgICBtX2RyYXdpbmdC dWZmZXItPmRpc2NhcmRSZXNvdXJjZXMoKTsKLSAgICAgICAgbV9kcmF3aW5nQnVmZmVyID0gRHJh d2luZ0J1ZmZlcjo6Y3JlYXRlKG1fY29udGV4dC5nZXQoKSwgbV9kcmF3aW5nQnVmZmVyLT5zaXpl KCksICFtX2F0dHJpYnV0ZXMucHJlc2VydmVEcmF3aW5nQnVmZmVyKTsKKyAgICAgICAgbV9kcmF3 aW5nQnVmZmVyID0gRHJhd2luZ0J1ZmZlcjo6Y3JlYXRlKGNvbnRleHQuZ2V0KCksIG1fZHJhd2lu Z0J1ZmZlci0+c2l6ZSgpLCAhbV9hdHRyaWJ1dGVzLnByZXNlcnZlRHJhd2luZ0J1ZmZlcik7Cisg ICAgICAgIG1fZHJhd2luZ0J1ZmZlci0+YmluZCgpOwogICAgIH0KIAogICAgIG1fY29udGV4dCA9 IGNvbnRleHQ7Cg== 121761 2012-01-09 16:56:31 -0800 2012-01-10 15:19:16 -0800 Patch bug-75912-20120109165629.patch text/plain 1791 jbauman U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0MjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTYyNzVjMWEzZTA1MDYx M2Q4NmEwNDAwYzNjYzQ2NDI1ZDQ1ZjMwZC4uNzI5MjY1Zjg0NjNmNzQwNjAzYWVjMmE3YmRhZGJi ZTgzYzU3N2ZjOCAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAxLTA5ICBKb2hu IEJhdW1hbiAgPGpiYXVtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gQ29y cmVjdGx5IHJlY3JlYXRlIERyYXdpbmdCdWZmZXIgb24gbG9zdCBkZXZpY2UKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1OTEyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3JlYXRlIG5ldyBkcmF3aW5nIGJ1 ZmZlciBvbiBuZXcgY29udGV4dCwgbm90IG9sZCBsb3N0IGNvbnRleHQuIEFsc28sCisgICAgICAg IG1ha2Ugc3VyZSB0byBiaW5kIG5ldyBkcmF3aW5nIGJ1ZmZlci4KKworICAgICAgICBObyBuZXcg dGVzdHMuCisKKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6V2ViR0xSZW5kZXJpbmdDb250ZXh0OjptYXliZVJlc3RvcmVD b250ZXh0KToKKwogMjAxMi0wMS0wNSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4K IAogICAgICAgICBJbnNlcnRpbmcgbm9kZXMgaXMgc2xvdyBkdWUgdG8gTm9kZTo6bm90aWZ5Tm9k ZUxpc3RzQXR0cmlidXRlQ2hhbmdlZCAoMjAlKykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCmluZGV4IGE3YjljZjY0ODYwZjVj ZTNjZDIyNzFjNjBhOTlmYTQ2OTY5Njc4NGMuLmQxNzc0MWZiMzBhZTM5YjQ5NjI3ZjAzYjVlNWZk OWM0MjJjYjllM2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdM UmVuZGVyaW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2Vi R0xSZW5kZXJpbmdDb250ZXh0LmNwcApAQCAtNTAzNyw3ICs1MDM3LDggQEAgdm9pZCBXZWJHTFJl bmRlcmluZ0NvbnRleHQ6Om1heWJlUmVzdG9yZUNvbnRleHQoVGltZXI8V2ViR0xSZW5kZXJpbmdD b250ZXh0PiopCiAgICAgLy8gQ29uc3RydWN0IGEgbmV3IGRyYXdpbmcgYnVmZmVyIHdpdGggdGhl IG5ldyBHcmFwaGljc0NvbnRleHQzRC4KICAgICBpZiAobV9kcmF3aW5nQnVmZmVyKSB7CiAgICAg ICAgIG1fZHJhd2luZ0J1ZmZlci0+ZGlzY2FyZFJlc291cmNlcygpOwotICAgICAgICBtX2RyYXdp bmdCdWZmZXIgPSBEcmF3aW5nQnVmZmVyOjpjcmVhdGUobV9jb250ZXh0LmdldCgpLCBtX2RyYXdp bmdCdWZmZXItPnNpemUoKSwgIW1fYXR0cmlidXRlcy5wcmVzZXJ2ZURyYXdpbmdCdWZmZXIpOwor ICAgICAgICBtX2RyYXdpbmdCdWZmZXIgPSBEcmF3aW5nQnVmZmVyOjpjcmVhdGUoY29udGV4dC5n ZXQoKSwgbV9kcmF3aW5nQnVmZmVyLT5zaXplKCksICFtX2F0dHJpYnV0ZXMucHJlc2VydmVEcmF3 aW5nQnVmZmVyKTsKKyAgICAgICAgbV9kcmF3aW5nQnVmZmVyLT5iaW5kKCk7CiAgICAgfQogCiAg ICAgbV9jb250ZXh0ID0gY29udGV4dDsK