75911 2012-01-09 16:41:16 -0800 REGRESSION: d3 Bullet Charts demo doesn't work (call with argument assignment is broken) 2012-01-11 16:14:46 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ggaren ggaren fpizlo oldest_to_newest 532647 0 ggaren 2012-01-09 16:41:16 -0800 http://mbostock.github.com/d3/ex/bullet.html Displays no chart on ToT, but it works on Safari 5.1.2. 532658 1 ggaren 2012-01-09 16:51:15 -0800 <rdar://problem/10650878> 532698 2 121766 ggaren 2012-01-09 17:22:28 -0800 Created attachment 121766 Patch 532711 3 121766 fpizlo 2012-01-09 17:30:17 -0800 Comment on attachment 121766 Patch Yay! r=me 532712 4 fpizlo 2012-01-09 17:30:30 -0800 Any performance impact? 533207 5 ggaren 2012-01-10 11:03:59 -0800 > Any performance impact? Bencher says 1.002x worse on SunSpider and v8 -- seems reasonable to call that "no change". Bytecode generation for f.apply is definitely worse by one op_mov. This is theoretically fixable with more robust optimization information in the AST, but I think that's probably the wrong direction -- long-term, we just want to compile f.apply in the DFG, which will elide the op_mov. 533251 6 fpizlo 2012-01-10 11:46:03 -0800 (In reply to comment #5) > > Any performance impact? > > Bencher says 1.002x worse on SunSpider and v8 -- seems reasonable to call that "no change". > > Bytecode generation for f.apply is definitely worse by one op_mov. This is theoretically fixable with more robust optimization information in the AST, but I think that's probably the wrong direction -- long-term, we just want to compile f.apply in the DFG, which will elide the op_mov. Agree! 534370 7 ggaren 2012-01-11 16:14:46 -0800 Committed r104762: <http://trac.webkit.org/changeset/104762> 121766 2012-01-09 17:22:28 -0800 2012-01-09 17:30:17 -0800 Patch bug-75911-20120109172223.patch text/plain 6620 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTA0NTIxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEyLTAxLTA5ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg ICAgUkVHUkVTU0lPTjogZDMgQnVsbGV0IENoYXJ0cyBkZW1vIGRvZXNuJ3Qgd29yayAoY2FsbCB3 aXRoIGFyZ3VtZW50IGFzc2lnbm1lbnQgaXMgYnJva2VuKQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU5MTEKKworICAgICAgICAqIGJ5dGVjb21waWxl ci9CeXRlY29kZUdlbmVyYXRvci5oOgorICAgICAgICAoSlNDOjpCeXRlY29kZUdlbmVyYXRvcjo6 ZW1pdE5vZGVGb3JMZWZ0SGFuZFNpZGUpOiBDbGVhbnVwOiBObyBuZWVkIHRvCisgICAgICAgIGV4 cGxpY2l0bHkgY2FzdCB0byBvdXIgcmV0dXJuIHR5cGUgaW4gQysrLgorCisgICAgICAgICogYnl0 ZWNvbXBpbGVyL05vZGVzQ29kZWdlbi5jcHA6CisgICAgICAgIChKU0M6OkZ1bmN0aW9uQ2FsbFJl c29sdmVOb2RlOjplbWl0Qnl0ZWNvZGUpOgorICAgICAgICAoSlNDOjpBcHBseUZ1bmN0aW9uQ2Fs bERvdE5vZGU6OmVtaXRCeXRlY29kZSk6IE1ha2Ugc3VyZSB0byBjb3B5IG91ciBmdW5jdGlvbgor ICAgICAgICBpbnRvIGEgdGVtcG9yYXJ5IHJlZ2lzdGVyIGJlZm9yZSBldmFsdWF0aW5nIG91ciBh cmd1bWVudHMsIHNpbmNlIGFyZ3VtZW50CisgICAgICAgIGV2YWx1YXRpb24gbWlnaHQgaW5jbHVk ZSBmdW5jdGlvbiBjYWxscyBvciBhc3NpZ25tZW50cyB0aGF0IG92ZXJ3cml0ZSBvdXIgY2FsbGVl IGJ5IG5hbWUuCisKIDIwMTItMDEtMDkgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAog ICAgICAgICBKYXZhU2NyaXB0Q29yZSBleGVjdXRhYmxlIHRhcmdldHMgc2hvdWxkbid0IGV4cGxp Y2l0bHkgZGVwZW5kIG9uIHRoZSBKYXZhU2NyaXB0Q29yZSBmcmFtZXdvcmsgdGFyZ2V0CkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29k ZUdlbmVyYXRvci5oCShyZXZpc2lvbiAxMDQ0NzYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv Ynl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTI3NCw3 ICsyNzQsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgICAgICAgICByZXR1cm4gZHN0Owog ICAgICAgICAgICAgfQogCi0gICAgICAgICAgICByZXR1cm4gUGFzc1JlZlB0cjxSZWdpc3RlcklE PihlbWl0Tm9kZShuKSk7CisgICAgICAgICAgICByZXR1cm4gZW1pdE5vZGUobik7CiAgICAgICAg IH0KIAogICAgICAgICBSZWdpc3RlcklEKiBlbWl0TG9hZChSZWdpc3RlcklEKiBkc3QsIGJvb2wp OwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9Ob2Rlc0NvZGVnZW4u Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvTm9k ZXNDb2RlZ2VuLmNwcAkocmV2aXNpb24gMTA0NDc2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2J5dGVjb21waWxlci9Ob2Rlc0NvZGVnZW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNjUsOSAr MzY1LDEwIEBAIFJlZ2lzdGVySUQqIEZ1bmN0aW9uQ2FsbFZhbHVlTm9kZTo6ZW1pdEIKIFJlZ2lz dGVySUQqIEZ1bmN0aW9uQ2FsbFJlc29sdmVOb2RlOjplbWl0Qnl0ZWNvZGUoQnl0ZWNvZGVHZW5l cmF0b3ImIGdlbmVyYXRvciwgUmVnaXN0ZXJJRCogZHN0KQogewogICAgIGlmIChSZWZQdHI8UmVn aXN0ZXJJRD4gbG9jYWwgPSBnZW5lcmF0b3IucmVnaXN0ZXJGb3IobV9pZGVudCkpIHsKKyAgICAg ICAgUmVmUHRyPFJlZ2lzdGVySUQ+IGZ1bmN0aW9uID0gZ2VuZXJhdG9yLmVtaXRNb3ZlKGdlbmVy YXRvci50ZW1wRGVzdGluYXRpb24oZHN0KSwgbG9jYWwuZ2V0KCkpOwogICAgICAgICBDYWxsQXJn dW1lbnRzIGNhbGxBcmd1bWVudHMoZ2VuZXJhdG9yLCBtX2FyZ3MpOwogICAgICAgICBnZW5lcmF0 b3IuZW1pdExvYWQoY2FsbEFyZ3VtZW50cy50aGlzUmVnaXN0ZXIoKSwganNVbmRlZmluZWQoKSk7 Ci0gICAgICAgIHJldHVybiBnZW5lcmF0b3IuZW1pdENhbGwoZ2VuZXJhdG9yLmZpbmFsRGVzdGlu YXRpb25Pcklnbm9yZWQoZHN0LCBjYWxsQXJndW1lbnRzLnRoaXNSZWdpc3RlcigpKSwgbG9jYWwu Z2V0KCksIGNhbGxBcmd1bWVudHMsIGRpdm90KCksIHN0YXJ0T2Zmc2V0KCksIGVuZE9mZnNldCgp KTsKKyAgICAgICAgcmV0dXJuIGdlbmVyYXRvci5lbWl0Q2FsbChnZW5lcmF0b3IuZmluYWxEZXN0 aW5hdGlvbk9ySWdub3JlZChkc3QsIGNhbGxBcmd1bWVudHMudGhpc1JlZ2lzdGVyKCkpLCBmdW5j dGlvbi5nZXQoKSwgY2FsbEFyZ3VtZW50cywgZGl2b3QoKSwgc3RhcnRPZmZzZXQoKSwgZW5kT2Zm c2V0KCkpOwogICAgIH0KIAogICAgIGludCBpbmRleCA9IDA7CkBAIC01MDUsNiArNTA2LDcgQEAg UmVnaXN0ZXJJRCogQXBwbHlGdW5jdGlvbkNhbGxEb3ROb2RlOjplbQogICAgICAgICAgICAgUmVm UHRyPFJlZ2lzdGVySUQ+IHByb2ZpbGVIb29rUmVnaXN0ZXI7CiAgICAgICAgICAgICBpZiAoZ2Vu ZXJhdG9yLnNob3VsZEVtaXRQcm9maWxlSG9va3MoKSkKICAgICAgICAgICAgICAgICBwcm9maWxl SG9va1JlZ2lzdGVyID0gZ2VuZXJhdG9yLm5ld1RlbXBvcmFyeSgpOworICAgICAgICAgICAgUmVm UHRyPFJlZ2lzdGVySUQ+IHJlYWxGdW5jdGlvbiA9IGdlbmVyYXRvci5lbWl0TW92ZShnZW5lcmF0 b3IudGVtcERlc3RpbmF0aW9uKGRzdCksIGJhc2UuZ2V0KCkpOwogICAgICAgICAgICAgUmVmUHRy PFJlZ2lzdGVySUQ+IHRoaXNSZWdpc3RlciA9IGdlbmVyYXRvci5lbWl0Tm9kZShtX2FyZ3MtPm1f bGlzdE5vZGUtPm1fZXhwcik7CiAgICAgICAgICAgICBSZWZQdHI8UmVnaXN0ZXJJRD4gYXJnc1Jl Z2lzdGVyOwogICAgICAgICAgICAgQXJndW1lbnRMaXN0Tm9kZSogYXJncyA9IG1fYXJncy0+bV9s aXN0Tm9kZS0+bV9uZXh0OwpAQCAtNTE4LDcgKzUyMCw3IEBAIFJlZ2lzdGVySUQqIEFwcGx5RnVu Y3Rpb25DYWxsRG90Tm9kZTo6ZW0KICAgICAgICAgICAgIHdoaWxlICgoYXJncyA9IGFyZ3MtPm1f bmV4dCkpCiAgICAgICAgICAgICAgICAgZ2VuZXJhdG9yLmVtaXROb2RlKGFyZ3MtPm1fZXhwcik7 CiAKLSAgICAgICAgICAgIGdlbmVyYXRvci5lbWl0Q2FsbFZhcmFyZ3MoZmluYWxEZXN0aW5hdGlv bk9ySWdub3JlZC5nZXQoKSwgYmFzZS5nZXQoKSwgdGhpc1JlZ2lzdGVyLmdldCgpLCBhcmdzUmVn aXN0ZXIuZ2V0KCksIGdlbmVyYXRvci5uZXdUZW1wb3JhcnkoKSwgcHJvZmlsZUhvb2tSZWdpc3Rl ci5nZXQoKSwgZGl2b3QoKSwgc3RhcnRPZmZzZXQoKSwgZW5kT2Zmc2V0KCkpOworICAgICAgICAg ICAgZ2VuZXJhdG9yLmVtaXRDYWxsVmFyYXJncyhmaW5hbERlc3RpbmF0aW9uT3JJZ25vcmVkLmdl dCgpLCByZWFsRnVuY3Rpb24uZ2V0KCksIHRoaXNSZWdpc3Rlci5nZXQoKSwgYXJnc1JlZ2lzdGVy LmdldCgpLCBnZW5lcmF0b3IubmV3VGVtcG9yYXJ5KCksIHByb2ZpbGVIb29rUmVnaXN0ZXIuZ2V0 KCksIGRpdm90KCksIHN0YXJ0T2Zmc2V0KCksIGVuZE9mZnNldCgpKTsKICAgICAgICAgfQogICAg ICAgICBnZW5lcmF0b3IuZW1pdEp1bXAoZW5kLmdldCgpKTsKICAgICB9CkluZGV4OiBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZp c2lvbiAxMDQ1MjEpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwxMyBAQAorMjAxMi0wMS0wOSAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUu Y29tPgorCisgICAgICAgIFJFR1JFU1NJT046IGQzIEJ1bGxldCBDaGFydHMgZGVtbyBkb2Vzbid0 IHdvcmsgKGNhbGwgd2l0aCBhcmd1bWVudCBhc3NpZ25tZW50IGlzIGJyb2tlbikKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1OTExCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICAqIGZhc3QvanMv ZnVuY3Rpb24tYXJndW1lbnQtZXZhbHVhdGlvbi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAg ICAqIGZhc3QvanMvZnVuY3Rpb24tYXJndW1lbnQtZXZhbHVhdGlvbi5odG1sOiBBZGRlZC4KKwog MjAxMi0wMS0wOSAgSm9uIExlZSAgPGpvbmxlZUBhcHBsZS5jb20+CiAKICAgICAgICAgTmV3IHBp eGVsIHRlc3QgcmVzdWx0cyB3aXRoIHIxMDQzNTEuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pz L2Z1bmN0aW9uLWFyZ3VtZW50LWV2YWx1YXRpb24tZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL2Zhc3QvanMvZnVuY3Rpb24tYXJndW1lbnQtZXZhbHVhdGlvbi1leHBlY3Rl ZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL2Z1bmN0aW9uLWFyZ3Vt ZW50LWV2YWx1YXRpb24tZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDcgQEAK K1RoaXMgcGFnZSB0ZXN0cyBmdW5jdGlvbiBjYWxscyB3aG9zZSBhcmd1bWVudCBleHByZXNzaW9u cyBvdmVyd3JpdGUgdGhlIGNhbGxlZS4KKworSWYgdGhlIHRlc3QgcGFzc2VzLCB5b3UnbGwgc2Vl IFBBU1MgbWVzc2FnZXMgYmVsb3cuCisKK1BBU1M6IHRlc3QxKGNhbGxiYWNrLCAxKSBzaG91bGQg YmUgMSBhbmQgaXMuCitQQVNTOiB0ZXN0MihjYWxsYmFjaywgMSkgc2hvdWxkIGJlIDEgYW5kIGlz LgorCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pzL2Z1bmN0aW9uLWFyZ3VtZW50LWV2YWx1YXRp b24uaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL2Z1bmN0aW9uLWFyZ3Vt ZW50LWV2YWx1YXRpb24uaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvanMv ZnVuY3Rpb24tYXJndW1lbnQtZXZhbHVhdGlvbi5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsx LDQ4IEBACis8cD5UaGlzIHBhZ2UgdGVzdHMgZnVuY3Rpb24gY2FsbHMgd2hvc2UgYXJndW1lbnQg ZXhwcmVzc2lvbnMgb3ZlcndyaXRlIHRoZSBjYWxsZWUuPC9wPgorPHA+SWYgdGhlIHRlc3QgcGFz c2VzLCB5b3UnbGwgc2VlIFBBU1MgbWVzc2FnZXMgYmVsb3cuCis8L3A+Cis8cHJlIGlkPSJjb25z b2xlIj48L3ByZT4KKworPHNjcmlwdD4KK2Z1bmN0aW9uIGxvZyhzKQoreworICAgIGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJjb25zb2xlIikuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4 dE5vZGUocyArICJcbiIpKTsKK30KKworZnVuY3Rpb24gc2hvdWxkQmUoYURlc2NyaXB0aW9uLCBh LCBiKQoreworICAgIGlmIChhID09PSBiKSB7CisgICAgICAgIGxvZygiUEFTUzogIiArIGFEZXNj cmlwdGlvbiArICIgc2hvdWxkIGJlICIgKyBiICsgIiBhbmQgaXMuIik7CisgICAgfSBlbHNlIHsK KyAgICAgICAgbG9nKCJGQUlMOiAiICsgYURlc2NyaXB0aW9uICsgIiBzaG91bGQgYmUgIiArIGIg KyAiIGJ1dCBpbnN0ZWFkIGlzICIgKyBhICsgIi4iKTsKKyAgICB9Cit9CisKK2Z1bmN0aW9uIHRl c3QxKGNhbGxiYWNrLCB4KSB7CisgICAgdHJ5IHsKKyAgICAgICAgcmV0dXJuIGNhbGxiYWNrLmFw cGx5KHRoaXMsIFsgY2FsbGJhY2sgPSB4IF0pOworICAgIH0gY2F0Y2goZSkgeworICAgICAgICBy ZXR1cm4gZTsKKyAgICB9Cit9OworCitmdW5jdGlvbiB0ZXN0MihjYWxsYmFjaywgeCkgeworICAg IHRyeSB7CisgICAgICAgIHJldHVybiBjYWxsYmFjayhjYWxsYmFjayA9IHgpOworICAgIH0gY2F0 Y2goZSkgeworICAgICAgICByZXR1cm4gZTsKKyAgICB9Cit9OworCisoZnVuY3Rpb24gKCkgewor ICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgIGxheW91dFRlc3RD b250cm9sbGVyLmR1bXBBc1RleHQoKTsKKworICAgIHZhciBjYWxsYmFjayA9IGZ1bmN0aW9uIGNh bGxiYWNrKHgpIHsKKyAgICAgICAgcmV0dXJuIHg7CisgICAgfTsKKworICAgIHNob3VsZEJlKCJ0 ZXN0MShjYWxsYmFjaywgMSkiLCB0ZXN0MShjYWxsYmFjaywgMSksIDEpOworICAgIHNob3VsZEJl KCJ0ZXN0MihjYWxsYmFjaywgMSkiLCB0ZXN0MihjYWxsYmFjaywgMSksIDEpOworfSkoKTsKKzwv c2NyaXB0Pgo=