75908 2012-01-09 16:35:25 -0800 Avoid separate heap allocation for each RenderRegionRange in RenderFlowThread 2012-01-11 05:50:42 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cmarcelo cmarcelo darin kling webkit.review.bot oldest_to_newest 532640 0 cmarcelo 2012-01-09 16:35:25 -0800 Avoid separate heap allocation for each RenderRegionRange in RenderFlowThread 532648 1 121758 cmarcelo 2012-01-09 16:41:20 -0800 Created attachment 121758 Patch 533830 2 121758 webkit.review.bot 2012-01-11 05:50:35 -0800 Comment on attachment 121758 Patch Clearing flags on attachment: 121758 Committed r104705: <http://trac.webkit.org/changeset/104705> 533831 3 webkit.review.bot 2012-01-11 05:50:42 -0800 All reviewed patches have been landed. Closing bug. 121758 2012-01-09 16:41:20 -0800 2012-01-11 05:50:35 -0800 Patch bug-75908-20120109214239.patch text/plain 7503 cmarcelo U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0NTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjEzYTg3YmVkZjQ4MTAw ZDY3MmE2MzJkYTM2MGU4NzVhYWZkYTQ1NC4uMjBhMzRmOTgyY2IyMTRmYjhjZGQxNjUwYzUyODQ0 MDM2ZWE4YmFiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTAxLTA5ICBDYWlv IE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8gIDxjYWlvLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+ CisKKyAgICAgICAgQXZvaWQgc2VwYXJhdGUgaGVhcCBhbGxvY2F0aW9uIGZvciBlYWNoIFJlbmRl clJlZ2lvblJhbmdlIGluIFJlbmRlckZsb3dUaHJlYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1OTA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUncyBubyBiZW5lZml0IGluIGV4cGxpY2l0IGFs bG9jYXRpbmcgUmVuZGVyUmVnaW9uUmFuZ2UgaW4gdGhlIGhlYXAuIFNvIHRoaXMKKyAgICAgICAg cGF0Y2ggY2hhbmdlcyB0aGUgUmVuZGVyUmVnaW9uUmFuZ2VNYXAgdG8gdXNlIHRoZSB2YWx1ZSB0 eXBlIGRpcmVjdGx5IGluc3RlYWQgb2YKKyAgICAgICAgdGhlIHBvaW50ZXIuCisKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyRmxvd1RocmVhZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJGbG93VGhyZWFkOjpyZW1vdmVSZWdpb25Gcm9tVGhyZWFkKToKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlckZsb3dUaHJlYWQ6OmxheW91dCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJGbG93 VGhyZWFkOjpyZW1vdmVSZW5kZXJCb3hSZWdpb25JbmZvKToKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlckZsb3dUaHJlYWQ6OnNldFJlZ2lvblJhbmdlRm9yQm94KToKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlckZsb3dUaHJlYWQ6OmdldFJlZ2lvblJhbmdlRm9yQm94KToKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyRmxvd1RocmVhZC5oOiBhZGQgZGVmYXVsdCBjb25zdHJ1Y3RvciB0byBhY3Qg YXMgZW1wdHlWYWx1ZSgpCisgICAgICAgIGZvciBIYXNoTWFwLgorCiAyMDEyLTAxLTA5ICBKb3No dWEgQmVsbCAgPGpzYmVsbEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW5kZXhlZERCOiBUaHJv dyBleGNlcHRpb24gaWYgSURCQ3Vyc29yLmNvbnRpbnVlKCkgY2FsbGVkIHdpdGggbG93ZXIga2V5 IHRoYW4gY3VycmVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckZsb3dUaHJlYWQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsb3dUaHJl YWQuY3BwCmluZGV4IDk2N2M1ZDE2YjY1YTk1OGVmOWMyNmZkZThiMzYzNjhmZDE5ZTgwNmUuLmZh MDA2YmU0NmI1ZGY3NjI1YTdkYWNjMTM3Zjc3MDgxZTQ5NjhlNGIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFkLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyRmxvd1RocmVhZC5jcHAKQEAgLTU2LDE3ICs1Niw2IEBAIFJl bmRlckZsb3dUaHJlYWQ6OlJlbmRlckZsb3dUaHJlYWQoTm9kZSogbm9kZSwgY29uc3QgQXRvbWlj U3RyaW5nJiBmbG93VGhyZWFkKQogICAgIHNldEluUmVuZGVyRmxvd1RocmVhZCgpOwogfQogCi12 b2lkIFJlbmRlckZsb3dUaHJlYWQ6OmNsZWFyUmVuZGVyUmVnaW9uUmFuZ2VNYXAoKQotewotICAg IGRlbGV0ZUFsbFZhbHVlcyhtX3JlZ2lvblJhbmdlTWFwKTsKLSAgICBtX3JlZ2lvblJhbmdlTWFw LmNsZWFyKCk7Ci19Ci0KLVJlbmRlckZsb3dUaHJlYWQ6On5SZW5kZXJGbG93VGhyZWFkKCkKLXsK LSAgICBjbGVhclJlbmRlclJlZ2lvblJhbmdlTWFwKCk7Ci19Ci0KIFBhc3NSZWZQdHI8UmVuZGVy U3R5bGU+IFJlbmRlckZsb3dUaHJlYWQ6OmNyZWF0ZUZsb3dUaHJlYWRTdHlsZShSZW5kZXJTdHls ZSogcGFyZW50U3R5bGUpCiB7CiAgICAgUmVmUHRyPFJlbmRlclN0eWxlPiBuZXdTdHlsZShSZW5k ZXJTdHlsZTo6Y3JlYXRlKCkpOwpAQCAtMjE1LDcgKzIwNCw3IEBAIHZvaWQgUmVuZGVyRmxvd1Ro cmVhZDo6YWRkUmVnaW9uVG9UaHJlYWQoUmVuZGVyUmVnaW9uKiByZW5kZXJSZWdpb24pCiB2b2lk IFJlbmRlckZsb3dUaHJlYWQ6OnJlbW92ZVJlZ2lvbkZyb21UaHJlYWQoUmVuZGVyUmVnaW9uKiBy ZW5kZXJSZWdpb24pCiB7CiAgICAgQVNTRVJUKHJlbmRlclJlZ2lvbik7Ci0gICAgY2xlYXJSZW5k ZXJSZWdpb25SYW5nZU1hcCgpOworICAgIG1fcmVnaW9uUmFuZ2VNYXAuY2xlYXIoKTsKICAgICBt X3JlZ2lvbkxpc3QucmVtb3ZlKHJlbmRlclJlZ2lvbik7CiAKICAgICBpZiAocmVuZGVyUmVnaW9u LT5wYXJlbnRGbG93VGhyZWFkKCkpIHsKQEAgLTMxOCw3ICszMDcsNyBAQCB2b2lkIFJlbmRlckZs b3dUaHJlYWQ6OmxheW91dCgpCiAgICAgICAgIG1faGFzVmFsaWRSZWdpb25zID0gZmFsc2U7CiAg ICAgICAgIG1fcmVnaW9uc0hhdmVVbmlmb3JtTG9naWNhbFdpZHRoID0gdHJ1ZTsKICAgICAgICAg bV9yZWdpb25zSGF2ZVVuaWZvcm1Mb2dpY2FsSGVpZ2h0ID0gdHJ1ZTsKLSAgICAgICAgY2xlYXJS ZW5kZXJSZWdpb25SYW5nZU1hcCgpOworICAgICAgICBtX3JlZ2lvblJhbmdlTWFwLmNsZWFyKCk7 CiAgICAgICAgIExheW91dFVuaXQgcHJldmlvdXNSZWdpb25Mb2dpY2FsV2lkdGggPSAwOwogICAg ICAgICBMYXlvdXRVbml0IHByZXZpb3VzUmVnaW9uTG9naWNhbEhlaWdodCA9IDA7CiAgICAgICAg IGlmIChoYXNSZWdpb25zKCkpIHsKQEAgLTY0MSw3ICs2MzAsNyBAQCB2b2lkIFJlbmRlckZsb3dU aHJlYWQ6OnJlbW92ZVJlbmRlckJveFJlZ2lvbkluZm8oUmVuZGVyQm94KiBib3gpCiAgICAgICAg ICAgICBicmVhazsKICAgICB9CiAgICAgCi0gICAgZGVsZXRlIG1fcmVnaW9uUmFuZ2VNYXAudGFr ZShib3gpOworICAgIG1fcmVnaW9uUmFuZ2VNYXAucmVtb3ZlKGJveCk7CiB9CiAKIGJvb2wgUmVu ZGVyRmxvd1RocmVhZDo6bG9naWNhbFdpZHRoQ2hhbmdlZEluUmVnaW9ucyhjb25zdCBSZW5kZXJC bG9jayogYmxvY2ssIExheW91dFVuaXQgb2Zmc2V0RnJvbUxvZ2ljYWxUb3BPZkZpcnN0UGFnZSkK QEAgLTc1Miw0MyArNzQxLDQ1IEBAIHZvaWQgUmVuZGVyRmxvd1RocmVhZDo6c2V0UmVnaW9uUmFu Z2VGb3JCb3goY29uc3QgUmVuZGVyQm94KiBib3gsIExheW91dFVuaXQgb2ZmCiAgICAgLy8gRklY TUU6IE5vdCByaWdodCBmb3IgZGlmZmVyaW5nIHdyaXRpbmctbW9kZXMuCiAgICAgUmVuZGVyUmVn aW9uKiBzdGFydFJlZ2lvbiA9IHJlbmRlclJlZ2lvbkZvckxpbmUob2Zmc2V0RnJvbUxvZ2ljYWxU b3BPZkZpcnN0UGFnZSwgdHJ1ZSk7CiAgICAgUmVuZGVyUmVnaW9uKiBlbmRSZWdpb24gPSByZW5k ZXJSZWdpb25Gb3JMaW5lKG9mZnNldEZyb21Mb2dpY2FsVG9wT2ZGaXJzdFBhZ2UgKyBib3gtPmxv Z2ljYWxIZWlnaHQoKSwgdHJ1ZSk7Ci0gICAgUmVuZGVyUmVnaW9uUmFuZ2UqIHJhbmdlID0gbV9y ZWdpb25SYW5nZU1hcC5nZXQoYm94KTsKLSAgICBpZiAocmFuZ2UpIHsKLSAgICAgICAgLy8gSWYg bm90aGluZyBjaGFuZ2VkLCBqdXN0IGJhaWwuCi0gICAgICAgIGlmIChyYW5nZS0+c3RhcnRSZWdp b24oKSA9PSBzdGFydFJlZ2lvbiAmJiByYW5nZS0+ZW5kUmVnaW9uKCkgPT0gZW5kUmVnaW9uKQot ICAgICAgICAgICAgcmV0dXJuOwotCi0gICAgICAgIC8vIERlbGV0ZSBhbnkgaW5mbyB0aGF0IHdl IGZpbmQgYmVmb3JlIG91ciBuZXcgc3RhcnRSZWdpb24gYW5kIGFmdGVyIG91ciBuZXcgZW5kUmVn aW9uLgotICAgICAgICBmb3IgKFJlbmRlclJlZ2lvbkxpc3Q6Oml0ZXJhdG9yIGl0ZXIgPSBtX3Jl Z2lvbkxpc3QuYmVnaW4oKTsgaXRlciAhPSBtX3JlZ2lvbkxpc3QuZW5kKCk7ICsraXRlcikgewot ICAgICAgICAgICAgUmVuZGVyUmVnaW9uKiByZWdpb24gPSAqaXRlcjsKLSAgICAgICAgICAgIGlm IChyZWdpb24gPT0gc3RhcnRSZWdpb24pIHsKLSAgICAgICAgICAgICAgICBpdGVyID0gbV9yZWdp b25MaXN0LmZpbmQoZW5kUmVnaW9uKTsKLSAgICAgICAgICAgICAgICBjb250aW51ZTsKLSAgICAg ICAgICAgIH0KKyAgICBSZW5kZXJSZWdpb25SYW5nZU1hcDo6aXRlcmF0b3IgaXQgPSBtX3JlZ2lv blJhbmdlTWFwLmZpbmQoYm94KTsKKyAgICBpZiAoaXQgPT0gbV9yZWdpb25SYW5nZU1hcC5lbmQo KSkgeworICAgICAgICBtX3JlZ2lvblJhbmdlTWFwLnNldChib3gsIFJlbmRlclJlZ2lvblJhbmdl KHN0YXJ0UmVnaW9uLCBlbmRSZWdpb24pKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KIAotICAg ICAgICAgICAgcmVnaW9uLT5yZW1vdmVSZW5kZXJCb3hSZWdpb25JbmZvKGJveCk7CisgICAgLy8g SWYgbm90aGluZyBjaGFuZ2VkLCBqdXN0IGJhaWwuCisgICAgUmVuZGVyUmVnaW9uUmFuZ2UmIHJh bmdlID0gaXQtPnNlY29uZDsKKyAgICBpZiAocmFuZ2Uuc3RhcnRSZWdpb24oKSA9PSBzdGFydFJl Z2lvbiAmJiByYW5nZS5lbmRSZWdpb24oKSA9PSBlbmRSZWdpb24pCisgICAgICAgIHJldHVybjsK IAotICAgICAgICAgICAgaWYgKHJlZ2lvbiA9PSByYW5nZS0+ZW5kUmVnaW9uKCkpCi0gICAgICAg ICAgICAgICAgYnJlYWs7CisgICAgLy8gRGVsZXRlIGFueSBpbmZvIHRoYXQgd2UgZmluZCBiZWZv cmUgb3VyIG5ldyBzdGFydFJlZ2lvbiBhbmQgYWZ0ZXIgb3VyIG5ldyBlbmRSZWdpb24uCisgICAg Zm9yIChSZW5kZXJSZWdpb25MaXN0OjppdGVyYXRvciBpdGVyID0gbV9yZWdpb25MaXN0LmJlZ2lu KCk7IGl0ZXIgIT0gbV9yZWdpb25MaXN0LmVuZCgpOyArK2l0ZXIpIHsKKyAgICAgICAgUmVuZGVy UmVnaW9uKiByZWdpb24gPSAqaXRlcjsKKyAgICAgICAgaWYgKHJlZ2lvbiA9PSBzdGFydFJlZ2lv bikgeworICAgICAgICAgICAgaXRlciA9IG1fcmVnaW9uTGlzdC5maW5kKGVuZFJlZ2lvbik7Cisg ICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgfQogCi0gICAgICAgIHJhbmdlLT5zZXRSYW5n ZShzdGFydFJlZ2lvbiwgZW5kUmVnaW9uKTsKLSAgICAgICAgcmV0dXJuOworICAgICAgICByZWdp b24tPnJlbW92ZVJlbmRlckJveFJlZ2lvbkluZm8oYm94KTsKKworICAgICAgICBpZiAocmVnaW9u ID09IHJhbmdlLmVuZFJlZ2lvbigpKQorICAgICAgICAgICAgYnJlYWs7CiAgICAgfQotICAgIHJh bmdlID0gbmV3IFJlbmRlclJlZ2lvblJhbmdlKHN0YXJ0UmVnaW9uLCBlbmRSZWdpb24pOwotICAg IG1fcmVnaW9uUmFuZ2VNYXAuc2V0KGJveCwgcmFuZ2UpOworCisgICAgcmFuZ2Uuc2V0UmFuZ2Uo c3RhcnRSZWdpb24sIGVuZFJlZ2lvbik7CiB9CiAKIHZvaWQgUmVuZGVyRmxvd1RocmVhZDo6Z2V0 UmVnaW9uUmFuZ2VGb3JCb3goY29uc3QgUmVuZGVyQm94KiBib3gsIFJlbmRlclJlZ2lvbiomIHN0 YXJ0UmVnaW9uLCBSZW5kZXJSZWdpb24qJiBlbmRSZWdpb24pIGNvbnN0CiB7CiAgICAgc3RhcnRS ZWdpb24gPSAwOwogICAgIGVuZFJlZ2lvbiA9IDA7Ci0gICAgUmVuZGVyUmVnaW9uUmFuZ2UqIHJh bmdlID0gbV9yZWdpb25SYW5nZU1hcC5nZXQoYm94KTsKLSAgICBpZiAoIXJhbmdlKQorICAgIFJl bmRlclJlZ2lvblJhbmdlTWFwOjpjb25zdF9pdGVyYXRvciBpdCA9IG1fcmVnaW9uUmFuZ2VNYXAu ZmluZChib3gpOworICAgIGlmIChpdCA9PSBtX3JlZ2lvblJhbmdlTWFwLmVuZCgpKQogICAgICAg ICByZXR1cm47CiAKLSAgICBzdGFydFJlZ2lvbiA9IHJhbmdlLT5zdGFydFJlZ2lvbigpOwotICAg IGVuZFJlZ2lvbiA9IHJhbmdlLT5lbmRSZWdpb24oKTsKKyAgICBjb25zdCBSZW5kZXJSZWdpb25S YW5nZSYgcmFuZ2UgPSBpdC0+c2Vjb25kOworICAgIHN0YXJ0UmVnaW9uID0gcmFuZ2Uuc3RhcnRS ZWdpb24oKTsKKyAgICBlbmRSZWdpb24gPSByYW5nZS5lbmRSZWdpb24oKTsKICAgICBBU1NFUlQo bV9yZWdpb25MaXN0LmNvbnRhaW5zKHN0YXJ0UmVnaW9uKSAmJiBtX3JlZ2lvbkxpc3QuY29udGFp bnMoZW5kUmVnaW9uKSk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJGbG93VGhyZWFkLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxv d1RocmVhZC5oCmluZGV4IDdjNDExYzA5MTJjY2Y2OTg3ODkwMWE2MjQzNjVjOTQyNWU4MWIwNWEu LmUxMGM1ZmNkMWE1OWFlYmUxOGQ5ZjJmMmRmNzAzOTVlMzRmNDY2YTcgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFkLmgKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsb3dUaHJlYWQuaApAQCAtNTgsNyArNTgsNiBAQCB0eXBl ZGVmIExpc3RIYXNoU2V0PFJlbmRlclJlZ2lvbio+IFJlbmRlclJlZ2lvbkxpc3Q7CiBjbGFzcyBS ZW5kZXJGbG93VGhyZWFkOiBwdWJsaWMgUmVuZGVyQmxvY2sgewogcHVibGljOgogICAgIFJlbmRl ckZsb3dUaHJlYWQoTm9kZSosIGNvbnN0IEF0b21pY1N0cmluZyYgZmxvd1RocmVhZCk7Ci0gICAg flJlbmRlckZsb3dUaHJlYWQoKTsKIAogICAgIHZpcnR1YWwgYm9vbCBpc1JlbmRlckZsb3dUaHJl YWQoKSBjb25zdCB7IHJldHVybiB0cnVlOyB9CiAKQEAgLTEzNiw4ICsxMzUsNiBAQCBwcml2YXRl OgogCiAgICAgYm9vbCBzaG91bGRSZXBhaW50KGNvbnN0IExheW91dFJlY3QmKSBjb25zdDsKIAot ICAgIHZvaWQgY2xlYXJSZW5kZXJSZWdpb25SYW5nZU1hcCgpOwotCiAgICAgdHlwZWRlZiBMaXN0 SGFzaFNldDxSZW5kZXJPYmplY3QqPiBGbG93VGhyZWFkQ2hpbGRMaXN0OwogICAgIEZsb3dUaHJl YWRDaGlsZExpc3QgbV9mbG93VGhyZWFkQ2hpbGRMaXN0OwogCkBAIC0xNDYsNiArMTQzLDExIEBA IHByaXZhdGU6CiAKICAgICBjbGFzcyBSZW5kZXJSZWdpb25SYW5nZSB7CiAgICAgcHVibGljOgor ICAgICAgICBSZW5kZXJSZWdpb25SYW5nZSgpCisgICAgICAgIHsKKyAgICAgICAgICAgIHNldFJh bmdlKDAsIDApOworICAgICAgICB9CisKICAgICAgICAgUmVuZGVyUmVnaW9uUmFuZ2UoUmVuZGVy UmVnaW9uKiBzdGFydCwgUmVuZGVyUmVnaW9uKiBlbmQpCiAgICAgICAgIHsKICAgICAgICAgICAg IHNldFJhbmdlKHN0YXJ0LCBlbmQpOwpAQCAtMTc2LDcgKzE3OCw3IEBAIHByaXZhdGU6CiAgICAg UmVuZGVyRmxvd1RocmVhZENvdW50ZWRTZXQgbV9sYXlvdXRCZWZvcmVUaHJlYWRzU2V0OwogCiAg ICAgLy8gQSBtYXBzIGZyb20gUmVuZGVyQm94Ci0gICAgdHlwZWRlZiBIYXNoTWFwPGNvbnN0IFJl bmRlckJveCosIFJlbmRlclJlZ2lvblJhbmdlKj4gUmVuZGVyUmVnaW9uUmFuZ2VNYXA7CisgICAg dHlwZWRlZiBIYXNoTWFwPGNvbnN0IFJlbmRlckJveCosIFJlbmRlclJlZ2lvblJhbmdlPiBSZW5k ZXJSZWdpb25SYW5nZU1hcDsKICAgICBSZW5kZXJSZWdpb25SYW5nZU1hcCBtX3JlZ2lvblJhbmdl TWFwOwogCiAgICAgYm9vbCBtX2hhc1ZhbGlkUmVnaW9uczsK