75905 2012-01-09 16:22:42 -0800 REGRESSION(r94902): Disagrees with my view on encoding support in WebKit, and makes refactoring harder (Requested by ap on #webkit). 2012-01-11 11:35:29 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 67882 1 webkit.review.bot webkit.review.bot abarth dglazkov eric japhet oldest_to_newest 532624 0 webkit.review.bot 2012-01-09 16:22:42 -0800 http://trac.webkit.org/changeset/94902 broke the build: Disagrees with general direction for WebKit, and makes refactoring harder (Requested by ap on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 532625 1 121753 webkit.review.bot 2012-01-09 16:23:20 -0800 Created attachment 121753 ROLLOUT of r94902 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 532626 2 121753 abarth 2012-01-09 16:24:41 -0800 Comment on attachment 121753 ROLLOUT of r94902 Can we discuss this before landing this patch? 532633 3 ap 2012-01-09 16:30:27 -0800 I'm doing some refactoring, and the need to watch platform #ifdefs is making it harder than it needs to be. I've also discussed and confirmed that this is the behavior we want in foreseeable future, so phasing it out is not desirable. Not flipping cq+ just yet, although it seems that we already had a comprehensive discussion in bug 67882. 532637 4 121753 ap 2012-01-09 16:33:22 -0800 Comment on attachment 121753 ROLLOUT of r94902 Adam suggested that this should go through review, so marking as such. 532638 5 ap 2012-01-09 16:34:18 -0800 Also renaming the bug per Adam's request. 532662 6 121753 abarth 2012-01-09 16:56:07 -0800 Comment on attachment 121753 ROLLOUT of r94902 I'm trying to understand the motivation for reverting this patch. Here's my understanding of the situation: 1) This code is untested. 2) This code only benefits the AppleMac and AppleWin ports. 3) This code violates the RFCs. 4) This code has been known to crash in the past. My understanding of your point of view is that you prefer to have as few ifdefs in cross-platform code as possible. I don't think non-Apple ports should be forced to compile, execute, and possibly crash in code with these properties. I support the idea of having fewer ifdefs is cross-platform code. Perhaps a better solution is to refactor this logic so that only Apple port bear the costs of this non-standard, potentially crashing, code. We've managed to achieve such things in other situations without ifdefs. We might be able to achieve that here as well. 532672 7 121753 ap 2012-01-09 17:02:54 -0800 Comment on attachment 121753 ROLLOUT of r94902 These ifdefs do not have a material effect on any port's runtime behavior, and make WebKit hacking harder. We do not want behavior affecting ifdefs in WebCore if at all possible, and we certainly don't want a port that's used by commit-queue to ifdef out important functionality that has been known to crash in the past. 532679 8 ap 2012-01-09 17:10:08 -0800 Basically, the rollout is because the change being rolled out was never agreed upon, was not improving any material aspect of WebKit, and made WebKit development slightly harder. 532684 9 abarth 2012-01-09 17:12:40 -0800 (I'll respond again tomorrow. I don't think my responding now would be productive to this discussion.) 533182 10 121753 darin 2012-01-10 10:39:51 -0800 Comment on attachment 121753 ROLLOUT of r94902 Rolling this out seems better for the project overall at this time. If we could find a way to remove the code entirely in the future that would be nice. 533234 11 abarth 2012-01-10 11:29:32 -0800 I'm sad that you've made up your mind before I had a change to reply today. I wanted to wait a day to reply so that I could gather my thoughts with a cool head. IMHO, we should just remove this code. Removing the code has the following benefits: 1) Standards compliance. There was a discussion in the HTTP working group about whether the requesting context should be a factor in determining the character set used to decode the Content-Disposition header. The working group decided that we shouldn't use that information for several reasons: a) Varying the interpretation of an HTTP response based on the context of the request is contrary to the stateless nature of HTTP. The fact that HTTP request/response pairs can be understood irrespective of context is core to the design of HTTP. b) Most user agents, including most browsers, do not have this behavior. That means the compatibility risk for dropping the behavior in other user agents (e.g., Safari) is relatively low, especially for a feature likes this one that is not widely used on the mobile web. 2) Stability. This code has crashed in the past and will crash in the future (I can dig up the crash reports for the previous crashes, if you want to see them). While we could invest effort in fixing these crashes, that seems like we'd be better off removing this code and spending that effort improving stability elsewhere. In Bug 67882, Alexey objected to removing this code because he disagreed with the working group's consensus and wanted to retain this non-compliant behavior in Safari. That's ok with me, but I don't think all the other ports should need to pay the stability cost of executing this code. Having the code behind an ifdef seems like a reasonable compromise. In summary, I don't think we should land this patch because it shifts the cost for supporting this non-compliant behavior away from the one port that desires it and onto all the other ports. 533272 12 dglazkov 2012-01-10 11:57:05 -0800 I would prefer to first reach consensus between Aleksey and Adam. It seems wrong that we would act (or have acted in the past) without resolving this disagreement. It's not healthy for the community and people involved. We want to be encouraging development of code, not ulcers. 534022 13 ap 2012-01-11 10:39:29 -0800 Committed <http://trac.webkit.org/changeset/104723>. Reaching consensus is something that was needed in bug 67882, which got landed in a manner clearly designed to avoid discussion. I do not feel that rolling that out should be more difficult than it already was (the rollout even got a review!) 534067 14 dglazkov 2012-01-11 11:35:29 -0800 (In reply to comment #13) > Committed <http://trac.webkit.org/changeset/104723>. > > Reaching consensus is something that was needed in bug 67882, which got landed in a manner clearly designed to avoid discussion. I do not feel that rolling that out should be more difficult than it already was (the rollout even got a review!) Even though this bug is closed, the issue of reaching consensus is still unresolved. 121753 2012-01-09 16:23:20 -0800 2012-01-10 10:39:51 -0800 ROLLOUT of r94902 bug-75905-20120110002409.patch text/plain 8745 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0NTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjEzYTg3YmVkZjQ4MTAw ZDY3MmE2MzJkYTM2MGU4NzVhYWZkYTQ1NC4uOThiMmE5ODRhMTc1NTM1OGM3ZDI4ODM0YmI1ZjRk N2U0ZjMyMmJkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTAxLTA5ICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByOTQ5MDIuCisgICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcv Y2hhbmdlc2V0Lzk0OTAyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03NTkwNQorCisgICAgICAgIERpc2FncmVlcyB3aXRoIGdlbmVyYWwgZGlyZWN0aW9u IGZvciBXZWJLaXQsIGFuZCBtYWtlcworICAgICAgICByZWZhY3RvcmluZyBoYXJkZXIgKFJlcXVl c3RlZCBieSBhcCBvbiAjd2Via2l0KS4KKworICAgICAgICAqIGxvYWRlci9Eb2N1bWVudFdyaXRl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudFdyaXRlcjo6ZGVwcmVjYXRlZEZyYW1l RW5jb2RpbmcpOgorICAgICAgICAqIGxvYWRlci9Eb2N1bWVudFdyaXRlci5oOgorICAgICAgICAq IGxvYWRlci9GcmFtZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6 YWRkRXh0cmFGaWVsZHNUb1JlcXVlc3QpOgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvUmVz b3VyY2VSZXF1ZXN0QmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3RC YXNlOjphZG9wdCk6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3RCYXNlOjpjb3B5 RGF0YSk6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3RCYXNlOjpzZXRSZXNwb25z ZUNvbnRlbnREaXNwb3NpdGlvbkVuY29kaW5nRmFsbGJhY2tBcnJheSk6CisgICAgICAgICogcGxh dGZvcm0vbmV0d29yay9SZXNvdXJjZVJlcXVlc3RCYXNlLmg6CisKIDIwMTItMDEtMDkgIEpvc2h1 YSBCZWxsICA8anNiZWxsQGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbmRleGVkREI6IFRocm93 IGV4Y2VwdGlvbiBpZiBJREJDdXJzb3IuY29udGludWUoKSBjYWxsZWQgd2l0aCBsb3dlciBrZXkg dGhhbiBjdXJyZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRX cml0ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50V3JpdGVyLmNwcAppbmRl eCBhZDgwMjJkMjllNTZlMzk5OGMzOGY5MDM1ZWQ1MDAxNmE5ODg4ZmYxLi5iZTBkYzA0ZDI4NTZl NmRiYWRiMWM3MjA4NzAxNWNiZDJkMmJjNDcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9s b2FkZXIvRG9jdW1lbnRXcml0ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1 bWVudFdyaXRlci5jcHAKQEAgLTI0MSw3ICsyNDEsNiBAQCB2b2lkIERvY3VtZW50V3JpdGVyOjpz ZXRFbmNvZGluZyhjb25zdCBTdHJpbmcmIG5hbWUsIGJvb2wgdXNlckNob3NlbikKICAgICBtX2Vu Y29kaW5nV2FzQ2hvc2VuQnlVc2VyID0gdXNlckNob3NlbjsKIH0KIAotI2lmIFBMQVRGT1JNKE1B QykgfHwgUExBVEZPUk0oV0lOKQogU3RyaW5nIERvY3VtZW50V3JpdGVyOjpkZXByZWNhdGVkRnJh bWVFbmNvZGluZygpIGNvbnN0CiB7CiAgICAgRG9jdW1lbnQqIGRvY3VtZW50ID0gbV9mcmFtZS0+ ZG9jdW1lbnQoKTsKQEAgLTI1Niw3ICsyNTUsNiBAQCBTdHJpbmcgRG9jdW1lbnRXcml0ZXI6OmRl cHJlY2F0ZWRGcmFtZUVuY29kaW5nKCkgY29uc3QKIAogICAgIHJldHVybiBTdHJpbmcoKTsKIH0K LSNlbmRpZgogCiB2b2lkIERvY3VtZW50V3JpdGVyOjpzZXREb2N1bWVudFdhc0xvYWRlZEFzUGFy dE9mTmF2aWdhdGlvbigpCiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9j dW1lbnRXcml0ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudFdyaXRlci5oCmlu ZGV4IDgxODk2ZWQxZmQ2NmVkM2UxODQzMzU1NGJkMDAwYTYzMTMwMTI5MDIuLmYwYTFmOGM5MTNh NWMzYWI0NGEyYzQ2NjRiZTk1MGY3OTEzNjI5N2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2xvYWRlci9Eb2N1bWVudFdyaXRlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1 bWVudFdyaXRlci5oCkBAIC01OSwxMSArNTksMTAgQEAgcHVibGljOgogCiAgICAgdm9pZCBzZXRF bmNvZGluZyhjb25zdCBTdHJpbmcmIGVuY29kaW5nLCBib29sIHVzZXJDaG9zZW4pOwogCi0jaWYg UExBVEZPUk0oTUFDKSB8fCBQTEFURk9STShXSU4pCi0gICAgLy8gVGhpcyBjb2RlIGV4aXN0cyBv bmx5IHRvIHNlcnZpY2UgYSBxdWlyayBpbiB0aGUgQXBwbGUgTWFjIGFuZCBXaW5kb3dzIHBvcnRz LgotICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgcmVtb3ZlIHRoaXMgY29kZSBvbmNlIENGTmV0d29y ayBpbXBsZW1lbnRzIFJGQyA2MjY2LgorICAgIC8vIEZJWE1FOiBJdCdzIHJlYWxseSB1bmZvcnVu YXRlIHRvIG5lZWQgdG8gZXhwb3NlIHRoaXMgcGllY2Ugb2Ygc3RhdGUuCisgICAgLy8gSSBzdXNw ZWN0IGEgYmV0dGVyIGRlc2lnbiBpcyB0byBkaXNlbnRhbmdsZSB1c2VyLXByb3ZpZGVkIGVuY29k aW5ncywKKyAgICAvLyBkZWZhdWx0IGVuY29kaW5ncywgYW5kIHRoZSBkZWNvZGluZyB3ZSdyZSBj dXJyZW50bHkgdXNpbmcuCiAgICAgU3RyaW5nIGRlcHJlY2F0ZWRGcmFtZUVuY29kaW5nKCkgY29u c3Q7Ci0jZW5kaWYKIAogICAgIGNvbnN0IFN0cmluZyYgbWltZVR5cGUoKSBjb25zdCB7IHJldHVy biBtX21pbWVUeXBlOyB9CiAgICAgdm9pZCBzZXRNSU1FVHlwZShjb25zdCBTdHJpbmcmIHR5cGUp IHsgbV9taW1lVHlwZSA9IHR5cGU7IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9GcmFtZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3Bw CmluZGV4IDI5NDNjZGQ0ZDE3ZmYxODIyZDdhMWJiODJjYTQ1OWZmNDNlMzdmYmIuLjc1NjU2ZDg5 YjU2OGFmYmIyYjZlNTE2NzFjNzVmZGZlNGU0MTNlNTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0Zy YW1lTG9hZGVyLmNwcApAQCAtMjU4NSwxMyArMjU4NSwxMCBAQCB2b2lkIEZyYW1lTG9hZGVyOjph ZGRFeHRyYUZpZWxkc1RvUmVxdWVzdChSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QsIEZyYW1lTG9h ZFR5cAogICAgIC8vIE1ha2Ugc3VyZSB3ZSBzZW5kIHRoZSBPcmlnaW4gaGVhZGVyLgogICAgIGFk ZEhUVFBPcmlnaW5JZk5lZWRlZChyZXF1ZXN0LCBTdHJpbmcoKSk7CiAKLSNpZiBQTEFURk9STShN QUMpIHx8IFBMQVRGT1JNKFdJTikKLSAgICAvLyBUaGUgQXBwbGUgTWFjIGFuZCBXaW5kb3dzIHBv cnRzIGhhdmUgZGVjaWRlZCBub3QgdG8gYmVoYXZlIGxpa2Ugb3RoZXIKLSAgICAvLyBicm93c2Vy cyBhbmQgaW5zdGVhZCB1c2UgYSBxdWlya3kgZmFsbGJhY2sgYXJyYXkuCi0gICAgLy8gRklYTUU6 IFdlIHNob3VsZCByZW1vdmUgdGhpcyBjb2RlIG9uY2UgQ0ZOZXR3b3JrIGltcGxlbWVudHMgUkZD IDYyNjYuCisgICAgLy8gQWx3YXlzIHRyeSBVVEYtOC4gSWYgdGhhdCBmYWlscywgdHJ5IGZyYW1l IGVuY29kaW5nIChpZiBhbnkpIGFuZCB0aGVuIHRoZSBkZWZhdWx0LgorICAgIC8vIEZvciBhIG5l d2x5IG9wZW5lZCBmcmFtZSB3aXRoIGFuIGVtcHR5IFVSTCwgZW5jb2RpbmcoKSBzaG91bGQgbm90 IGJlIHVzZWQsIGJlY2F1c2UgdGhpcyBtZXRob2RzIGFza3MgZGVjb2Rlciwgd2hpY2ggdXNlcyBJ U08tODg1OS0xLgogICAgIFNldHRpbmdzKiBzZXR0aW5ncyA9IG1fZnJhbWUtPnNldHRpbmdzKCk7 CiAgICAgcmVxdWVzdC5zZXRSZXNwb25zZUNvbnRlbnREaXNwb3NpdGlvbkVuY29kaW5nRmFsbGJh Y2tBcnJheSgiVVRGLTgiLCBhY3RpdmVEb2N1bWVudExvYWRlcigpLT53cml0ZXIoKS0+ZGVwcmVj YXRlZEZyYW1lRW5jb2RpbmcoKSwgc2V0dGluZ3MgPyBzZXR0aW5ncy0+ZGVmYXVsdFRleHRFbmNv ZGluZ05hbWUoKSA6IFN0cmluZygpKTsKLSNlbmRpZgogfQogCiB2b2lkIEZyYW1lTG9hZGVyOjph ZGRIVFRQT3JpZ2luSWZOZWVkZWQoUmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0LCBjb25zdCBTdHJp bmcmIG9yaWdpbikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv UmVzb3VyY2VSZXF1ZXN0QmFzZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L1Jlc291cmNlUmVxdWVzdEJhc2UuY3BwCmluZGV4IGM1YmQzMDgxNDUyNGJmNTIwYjllZmM2NmVm MWEyODlkN2FmODYwZjAuLmUxZTk2YzQwOTI2YTM3MjdmOGQwN2VmMDBkZmVlNDQwZmRmZjQ1M2Yg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXF1 ZXN0QmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJj ZVJlcXVlc3RCYXNlLmNwcApAQCAtNTcsNyArNTcsNiBAQCBQYXNzT3duUHRyPFJlc291cmNlUmVx dWVzdD4gUmVzb3VyY2VSZXF1ZXN0QmFzZTo6YWRvcHQoUGFzc093blB0cjxDcm9zc1RocmVhZFJl cwogICAgIHJlcXVlc3QtPnVwZGF0ZVJlc291cmNlUmVxdWVzdCgpOwogICAgIHJlcXVlc3QtPm1f aHR0cEhlYWRlckZpZWxkcy5hZG9wdChkYXRhLT5tX2h0dHBIZWFkZXJzLnJlbGVhc2UoKSk7CiAK LSNpZiBQTEFURk9STShNQUMpIHx8IFBMQVRGT1JNKFdJTikKICAgICBzaXplX3QgZW5jb2RpbmdD b3VudCA9IGRhdGEtPm1fcmVzcG9uc2VDb250ZW50RGlzcG9zaXRpb25FbmNvZGluZ0ZhbGxiYWNr QXJyYXkuc2l6ZSgpOwogICAgIGlmIChlbmNvZGluZ0NvdW50ID4gMCkgewogICAgICAgICBTdHJp bmcgZW5jb2RpbmcxID0gZGF0YS0+bV9yZXNwb25zZUNvbnRlbnREaXNwb3NpdGlvbkVuY29kaW5n RmFsbGJhY2tBcnJheVswXTsKQEAgLTcxLDcgKzcwLDYgQEAgUGFzc093blB0cjxSZXNvdXJjZVJl cXVlc3Q+IFJlc291cmNlUmVxdWVzdEJhc2U6OmFkb3B0KFBhc3NPd25QdHI8Q3Jvc3NUaHJlYWRS ZXMKICAgICAgICAgQVNTRVJUKGVuY29kaW5nQ291bnQgPD0gMyk7CiAgICAgICAgIHJlcXVlc3Qt PnNldFJlc3BvbnNlQ29udGVudERpc3Bvc2l0aW9uRW5jb2RpbmdGYWxsYmFja0FycmF5KGVuY29k aW5nMSwgZW5jb2RpbmcyLCBlbmNvZGluZzMpOwogICAgIH0KLSNlbmRpZgogICAgIHJlcXVlc3Qt PnNldEhUVFBCb2R5KGRhdGEtPm1faHR0cEJvZHkpOwogICAgIHJlcXVlc3QtPnNldEFsbG93Q29v a2llcyhkYXRhLT5tX2FsbG93Q29va2llcyk7CiAgICAgcmVxdWVzdC0+ZG9QbGF0Zm9ybUFkb3B0 KGRhdGEpOwpAQCAtODksMTMgKzg3LDExIEBAIFBhc3NPd25QdHI8Q3Jvc3NUaHJlYWRSZXNvdXJj ZVJlcXVlc3REYXRhPiBSZXNvdXJjZVJlcXVlc3RCYXNlOjpjb3B5RGF0YSgpIGNvbnN0CiAgICAg ZGF0YS0+bV9odHRwSGVhZGVycyA9IGh0dHBIZWFkZXJGaWVsZHMoKS5jb3B5RGF0YSgpOwogICAg IGRhdGEtPm1fcHJpb3JpdHkgPSBwcmlvcml0eSgpOwogCi0jaWYgUExBVEZPUk0oTUFDKSB8fCBQ TEFURk9STShXSU4pCiAgICAgZGF0YS0+bV9yZXNwb25zZUNvbnRlbnREaXNwb3NpdGlvbkVuY29k aW5nRmFsbGJhY2tBcnJheS5yZXNlcnZlSW5pdGlhbENhcGFjaXR5KG1fcmVzcG9uc2VDb250ZW50 RGlzcG9zaXRpb25FbmNvZGluZ0ZhbGxiYWNrQXJyYXkuc2l6ZSgpKTsKICAgICBzaXplX3QgZW5j b2RpbmdBcnJheVNpemUgPSBtX3Jlc3BvbnNlQ29udGVudERpc3Bvc2l0aW9uRW5jb2RpbmdGYWxs YmFja0FycmF5LnNpemUoKTsKICAgICBmb3IgKHNpemVfdCBpbmRleCA9IDA7IGluZGV4IDwgZW5j b2RpbmdBcnJheVNpemU7ICsraW5kZXgpIHsKICAgICAgICAgZGF0YS0+bV9yZXNwb25zZUNvbnRl bnREaXNwb3NpdGlvbkVuY29kaW5nRmFsbGJhY2tBcnJheS5hcHBlbmQobV9yZXNwb25zZUNvbnRl bnREaXNwb3NpdGlvbkVuY29kaW5nRmFsbGJhY2tBcnJheVtpbmRleF0uaXNvbGF0ZWRDb3B5KCkp OwogICAgIH0KLSNlbmRpZgogICAgIGlmIChtX2h0dHBCb2R5KQogICAgICAgICBkYXRhLT5tX2h0 dHBCb2R5ID0gbV9odHRwQm9keS0+ZGVlcENvcHkoKTsKICAgICBkYXRhLT5tX2FsbG93Q29va2ll cyA9IG1fYWxsb3dDb29raWVzOwpAQCAtMjc1LDcgKzI3MSw2IEBAIHZvaWQgUmVzb3VyY2VSZXF1 ZXN0QmFzZTo6Y2xlYXJIVFRQT3JpZ2luKCkKICAgICAgICAgbV9wbGF0Zm9ybVJlcXVlc3RVcGRh dGVkID0gZmFsc2U7CiB9CiAKLSNpZiBQTEFURk9STShNQUMpIHx8IFBMQVRGT1JNKFdJTikKIHZv aWQgUmVzb3VyY2VSZXF1ZXN0QmFzZTo6c2V0UmVzcG9uc2VDb250ZW50RGlzcG9zaXRpb25FbmNv ZGluZ0ZhbGxiYWNrQXJyYXkoY29uc3QgU3RyaW5nJiBlbmNvZGluZzEsIGNvbnN0IFN0cmluZyYg ZW5jb2RpbmcyLCBjb25zdCBTdHJpbmcmIGVuY29kaW5nMykKIHsKICAgICB1cGRhdGVSZXNvdXJj ZVJlcXVlc3QoKTsgCkBAIC0yOTEsNyArMjg2LDYgQEAgdm9pZCBSZXNvdXJjZVJlcXVlc3RCYXNl OjpzZXRSZXNwb25zZUNvbnRlbnREaXNwb3NpdGlvbkVuY29kaW5nRmFsbGJhY2tBcnJheShjb24K ICAgICBpZiAodXJsKCkucHJvdG9jb2xJbkhUVFBGYW1pbHkoKSkKICAgICAgICAgbV9wbGF0Zm9y bVJlcXVlc3RVcGRhdGVkID0gZmFsc2U7CiB9Ci0jZW5kaWYKIAogRm9ybURhdGEqIFJlc291cmNl UmVxdWVzdEJhc2U6Omh0dHBCb2R5KCkgY29uc3QgCiB7IApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlcXVlc3RCYXNlLmggYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVxdWVzdEJhc2UuaAppbmRleCBiNWRjMTFl NGEyZWQ4Y2Q3YTFiZWRmYmIwZWFiZDQ5YmViODk1YWQ0Li4wYjE1NGQ2MGZhOTMxN2IzZDhjOTI5 MjRmNjY3MTA4YWE2NzIyYTI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL1Jlc291cmNlUmVxdWVzdEJhc2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL1Jlc291cmNlUmVxdWVzdEJhc2UuaApAQCAtMTAzLDExICsxMDMsNyBAQCBuYW1l c3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIFN0cmluZyBodHRwQWNjZXB0KCkgY29uc3QgeyByZXR1 cm4gaHR0cEhlYWRlckZpZWxkKCJBY2NlcHQiKTsgfQogICAgICAgICB2b2lkIHNldEhUVFBBY2Nl cHQoY29uc3QgU3RyaW5nJiBodHRwQWNjZXB0KSB7IHNldEhUVFBIZWFkZXJGaWVsZCgiQWNjZXB0 IiwgaHR0cEFjY2VwdCk7IH0KIAotI2lmIFBMQVRGT1JNKE1BQykgfHwgUExBVEZPUk0oV0lOKQot ICAgICAgICAvLyBGSVhNRTogVGhpcyBzdGF0ZSBzaG91bGQgZWl0aGVyIGJlIG1vdmVkIHRvIGEg Q0ZOZXR3b3JrLXNwZWNpZmljCi0gICAgICAgIC8vIFJlc291cmNlUmVxdWVzdCBvciBzaG91bGQg YmUgcmVtb3ZlZC4KICAgICAgICAgdm9pZCBzZXRSZXNwb25zZUNvbnRlbnREaXNwb3NpdGlvbkVu Y29kaW5nRmFsbGJhY2tBcnJheShjb25zdCBTdHJpbmcmIGVuY29kaW5nMSwgY29uc3QgU3RyaW5n JiBlbmNvZGluZzIgPSBTdHJpbmcoKSwgY29uc3QgU3RyaW5nJiBlbmNvZGluZzMgPSBTdHJpbmco KSk7Ci0jZW5kaWYKIAogICAgICAgICBGb3JtRGF0YSogaHR0cEJvZHkoKSBjb25zdDsKICAgICAg ICAgdm9pZCBzZXRIVFRQQm9keShQYXNzUmVmUHRyPEZvcm1EYXRhPiBodHRwQm9keSk7CkBAIC0x NzgsMTEgKzE3NCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgS1VSTCBtX2ZpcnN0 UGFydHlGb3JDb29raWVzOwogICAgICAgICBTdHJpbmcgbV9odHRwTWV0aG9kOwogICAgICAgICBI VFRQSGVhZGVyTWFwIG1faHR0cEhlYWRlckZpZWxkczsKLSNpZiBQTEFURk9STShNQUMpIHx8IFBM QVRGT1JNKFdJTikKLSAgICAgICAgLy8gRklYTUU6IFRoaXMgc3RhdGUgc2hvdWxkIGVpdGhlciBi ZSBtb3ZlZCB0byBhIENGTmV0d29yay1zcGVjaWZpYwotICAgICAgICAvLyBSZXNvdXJjZVJlcXVl c3Qgb3Igc2hvdWxkIGJlIHJlbW92ZWQuCiAgICAgICAgIFZlY3RvcjxTdHJpbmc+IG1fcmVzcG9u c2VDb250ZW50RGlzcG9zaXRpb25FbmNvZGluZ0ZhbGxiYWNrQXJyYXk7Ci0jZW5kaWYKICAgICAg ICAgUmVmUHRyPEZvcm1EYXRhPiBtX2h0dHBCb2R5OwogICAgICAgICBib29sIG1fYWxsb3dDb29r aWVzIDogMTsKICAgICAgICAgbXV0YWJsZSBib29sIG1fcmVzb3VyY2VSZXF1ZXN0VXBkYXRlZCA6 IDE7CkBAIC0yMTUsOSArMjA3LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAgICAgICAgIFN0 cmluZyBtX2h0dHBNZXRob2Q7CiAgICAgICAgIE93blB0cjxDcm9zc1RocmVhZEhUVFBIZWFkZXJN YXBEYXRhPiBtX2h0dHBIZWFkZXJzOwotI2lmIFBMQVRGT1JNKE1BQykgfHwgUExBVEZPUk0oV0lO KQogICAgICAgICBWZWN0b3I8U3RyaW5nPiBtX3Jlc3BvbnNlQ29udGVudERpc3Bvc2l0aW9uRW5j b2RpbmdGYWxsYmFja0FycmF5OwotI2VuZGlmCiAgICAgICAgIFJlZlB0cjxGb3JtRGF0YT4gbV9o dHRwQm9keTsKICAgICAgICAgYm9vbCBtX2FsbG93Q29va2llczsKICAgICAgICAgUmVzb3VyY2VM b2FkUHJpb3JpdHkgbV9wcmlvcml0eTsK