75894 2012-01-09 15:26:02 -0800 [Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication 2012-01-10 06:41:27 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ahf ahf ossy webkit.review.bot oldest_to_newest 532560 0 ahf 2012-01-09 15:26:02 -0800 SSIA. 532950 1 121824 ahf 2012-01-10 03:51:20 -0800 Created attachment 121824 Patch 532957 2 121824 ahf 2012-01-10 04:05:07 -0800 Comment on attachment 121824 Patch Gah, I need to start remembering asking for CQ... 532988 3 121824 webkit.review.bot 2012-01-10 05:25:13 -0800 Comment on attachment 121824 Patch Clearing flags on attachment: 121824 Committed r104556: <http://trac.webkit.org/changeset/104556> 532989 4 webkit.review.bot 2012-01-10 05:25:17 -0800 All reviewed patches have been landed. Closing bug. 532997 5 ossy 2012-01-10 05:34:12 -0800 Hey, you guys broke the build: cc1plus: warnings being treated as errors /ramdisk/qt-linux-32-release-webkit2/build/Tools/MiniBrowser/qt/MiniBrowserApplication.h: In constructor ‘MiniBrowserApplication::MiniBrowserApplication(int&, char**)’: /ramdisk/qt-linux-32-release-webkit2/build/Tools/MiniBrowser/qt/MiniBrowserApplication.h:120: error: ‘MiniBrowserApplication::m_windowOptions’ will be initialized after /ramdisk/qt-linux-32-release-webkit2/build/Tools/MiniBrowser/qt/MiniBrowserApplication.h:110: error: ‘bool MiniBrowserApplication::m_realTouchEventReceived’ /ramdisk/qt-linux-32-release-webkit2/build/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:64: error: when initialized here 533023 6 ossy 2012-01-10 06:41:27 -0800 Fixed in http://trac.webkit.org/changeset/104559. Thx. 121824 2012-01-10 03:51:20 -0800 2012-01-10 05:25:13 -0800 Patch bug-75894-20120110125115.patch text/plain 2628 ahf U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0NDQ2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzYyYWE2ODBlN2Q5ZTljZTE2ZTYxYWRmNTViYTdiNTM4 NmMyNGJkNC4uOTJlYmYxNDAwOTQ0NjBjY2E1YmRhNzdhOGRkMjU1MDQ2MzczNGMwZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTAxLTEwICBBbGV4YW5kZXIgRsOmcsO4eSAgPGFsZXhhbmRlci5mYWVyb3lAbm9r aWEuY29tPgorCisgICAgICAgIFtRdF0gRG9uJ3QgZXhwb3NlIG1fd2luZG93T3B0aW9ucyBhcyBw YXJ0IG9mIHRoZSBwdWJsaWMgaW50ZXJmYWNlIGluIE1pbmlCcm93c2VyQXBwbGljYXRpb24KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1ODk0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nl ci9xdC9NaW5pQnJvd3NlckFwcGxpY2F0aW9uLmg6CisgICAgICAgIChNaW5pQnJvd3NlckFwcGxp Y2F0aW9uOjp3aW5kb3dPcHRpb25zKToKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9xdC9tYWluLmNw cDoKKyAgICAgICAgKG1haW4pOgorCiAyMDEyLTAxLTA5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAg PGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBGaXggbWFrZSBkaXN0 Y2hlY2sgaXNzdWVzLgpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvcXQvTWluaUJyb3dz ZXJBcHBsaWNhdGlvbi5oIGIvVG9vbHMvTWluaUJyb3dzZXIvcXQvTWluaUJyb3dzZXJBcHBsaWNh dGlvbi5oCmluZGV4IDcxOWM3OWRlNjQ2MjIxMmEzOGM5ZmE0MWM4MTdmZDk0YTVmN2NmYzEuLjkz NzI3MGZjNjY0MjIyNDU5MzEyMmE1YmUzNzYwNDA5MDJiM2FiOTYgMTAwNjQ0Ci0tLSBhL1Rvb2xz L01pbmlCcm93c2VyL3F0L01pbmlCcm93c2VyQXBwbGljYXRpb24uaAorKysgYi9Ub29scy9NaW5p QnJvd3Nlci9xdC9NaW5pQnJvd3NlckFwcGxpY2F0aW9uLmgKQEAgLTg0LDggKzg0LDcgQEAgcHVi bGljOgogICAgIGJvb2wgaXNSb2JvdGl6ZWQoKSBjb25zdCB7IHJldHVybiBtX2lzUm9ib3RpemVk OyB9CiAgICAgaW50IHJvYm90VGltZW91dCgpIGNvbnN0IHsgcmV0dXJuIG1fcm9ib3RUaW1lb3V0 U2Vjb25kczsgfQogICAgIGludCByb2JvdEV4dHJhVGltZSgpIGNvbnN0IHsgcmV0dXJuIG1fcm9i b3RFeHRyYVRpbWVTZWNvbmRzOyB9Ci0KLSAgICBXaW5kb3dPcHRpb25zIG1fd2luZG93T3B0aW9u czsKKyAgICBXaW5kb3dPcHRpb25zKiB3aW5kb3dPcHRpb25zKCkgeyByZXR1cm4gJm1fd2luZG93 T3B0aW9uczsgfQogCiAgICAgdmlydHVhbCBib29sIG5vdGlmeShRT2JqZWN0KiwgUUV2ZW50Kik7 CiAKQEAgLTEwMyw2ICsxMDIsOCBAQCBwcml2YXRlOgogCiAgICAgUUhhc2g8aW50LCBRV2luZG93 U3lzdGVtSW50ZXJmYWNlOjpUb3VjaFBvaW50PiBtX3RvdWNoUG9pbnRzOwogICAgIFFTZXQ8aW50 PiBtX2hlbGRUb3VjaFBvaW50czsKKworICAgIFdpbmRvd09wdGlvbnMgbV93aW5kb3dPcHRpb25z OwogfTsKIAogUU1MX0RFQ0xBUkVfVFlQRShXaW5kb3dPcHRpb25zKTsKZGlmZiAtLWdpdCBhL1Rv b2xzL01pbmlCcm93c2VyL3F0L21haW4uY3BwIGIvVG9vbHMvTWluaUJyb3dzZXIvcXQvbWFpbi5j cHAKaW5kZXggMjY4NzdhZTc3MGVhMTZiZmQ0MTY3ZDU1NDVjMjU0NGZkZmY3MDVmMC4uZmVhZTE0 YWRlZjM4ZjU1YzYwMjBmNGZiZDYxNDQxYmY5OTA1OGUyOCAxMDA2NDQKLS0tIGEvVG9vbHMvTWlu aUJyb3dzZXIvcXQvbWFpbi5jcHAKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvcXQvbWFpbi5jcHAK QEAgLTQ1LDcgKzQ1LDcgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqKiBhcmd2KQogICAgIE1p bmlCcm93c2VyQXBwbGljYXRpb24gYXBwKGFyZ2MsIGFyZ3YpOwogCiAgICAgaWYgKGFwcC5pc1Jv Ym90aXplZCgpKSB7Ci0gICAgICAgIEJyb3dzZXJXaW5kb3cqIHdpbmRvdyA9IG5ldyBCcm93c2Vy V2luZG93KCZhcHAubV93aW5kb3dPcHRpb25zKTsKKyAgICAgICAgQnJvd3NlcldpbmRvdyogd2lu ZG93ID0gbmV3IEJyb3dzZXJXaW5kb3coYXBwLndpbmRvd09wdGlvbnMoKSk7CiAgICAgICAgIFVy bExvYWRlciBsb2FkZXIod2luZG93LCBhcHAudXJscygpLmF0KDApLCBhcHAucm9ib3RUaW1lb3V0 KCksIGFwcC5yb2JvdEV4dHJhVGltZSgpKTsKICAgICAgICAgbG9hZGVyLmxvYWROZXh0KCk7CiAg ICAgICAgIHdpbmRvdy0+c2hvdygpOwpAQCAtNjIsNyArNjIsNyBAQCBpbnQgbWFpbihpbnQgYXJn YywgY2hhcioqIGFyZ3YpCiAgICAgICAgICAgICB1cmxzLmFwcGVuZCgiaHR0cDovL3d3dy5nb29n bGUuY29tIik7CiAgICAgfQogCi0gICAgQnJvd3NlcldpbmRvdyogd2luZG93ID0gbmV3IEJyb3dz ZXJXaW5kb3coJmFwcC5tX3dpbmRvd09wdGlvbnMpOworICAgIEJyb3dzZXJXaW5kb3cqIHdpbmRv dyA9IG5ldyBCcm93c2VyV2luZG93KGFwcC53aW5kb3dPcHRpb25zKCkpOwogICAgIHdpbmRvdy0+ bG9hZCh1cmxzLmF0KDApKTsKIAogICAgIGZvciAoaW50IGkgPSAxOyBpIDwgdXJscy5zaXplKCk7 ICsraSkK