75892 2012-01-09 14:47:40 -0800 Possible bug: Number(new Date(1,1,1,1,1,1,1)) 2012-02-01 11:41:22 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 75692 1 barraclough webkit-unassigned darin loki ossy sullivan webkit.review.bot zherczeg oldest_to_newest 532540 0 barraclough 2012-01-09 14:47:40 -0800 I landed this in a test case and it looks like our results differ on OS X & Linux. This may indicate a bug. Firefox produces a still different result, but it looks like they have a bug (since they seem to be using historic information which is prohibited by the spec), so looks like we can't use them as a referee on the matter. :-) We should investigate further at some point & see if there is a real bug here, might have just been a lousy test case by me that failed to take timezone into account correctly. 546935 1 124912 szledan 2012-02-01 02:14:55 -0800 Created attachment 124912 Fixed some lines in the test 546948 2 ossy 2012-02-01 02:34:26 -0800 This test introduced in http://trac.webkit.org/changeset/12446 (https://bugs.webkit.org/show_bug.cgi?id=6870) 6 years ago. ECMA-262 said that the constructor of Date() has 7 parameters: 15.9.2.1 Date ( [ year [, month [, date [, hours [, minutes [, seconds [, ms ] ] ] ] ] ] ] ) But in this test you pass 9 parameters instead of 7. I think the 8th and 9th parameter is absolutely useless, and they are passed accidentally by r12446. Darin (as the author) or John (as the reviewer), could you confirm that we should remove useless 8th and 9th parameters in this testcase? PS. The discussion was started in https://bugs.webkit.org/show_bug.cgi?id=75692 547184 3 darin 2012-02-01 10:30:15 -0800 I do think that passing too many arguments in that test was just a programming error I made in 2006. However, we should have test cases covering what happens when you pass too many arguments; there is defined required behavior and we should test for it. If we remove the accidental testing, we should add make sure we keep intentional testing of extra arguments somewhere and have the correct behavior. 547204 4 barraclough 2012-02-01 10:54:00 -0800 Actually, the extra arguments on the lines in question were added in r104267 ( http://trac.webkit.org/changeset/104267 ), in part to deliberately provide additional testing of extra arguments being passed. We could split these out into two sets of tests, one for infinities, one for too many arguments, but there is a correlation here (albeit weak) – in that extra arguments of Infinity is one that could through programmer error be construed as an error, but shouldn't be. Let's leave this alone. 547244 5 124912 webkit.review.bot 2012-02-01 11:41:16 -0800 Comment on attachment 124912 Fixed some lines in the test Clearing flags on attachment: 124912 Committed r106480: <http://trac.webkit.org/changeset/106480> 547246 6 webkit.review.bot 2012-02-01 11:41:22 -0800 All reviewed patches have been landed. Closing bug. 124912 2012-02-01 02:14:55 -0800 2012-02-01 11:41:16 -0800 Fixed some lines in the test 0001-Fixed-some-lines-in-the-date-constructor.js-test.patch text/plain 5862 szledan RnJvbSA2ZTJkMjljZWQxZDQ3ODY2ZjcwYWI2YWEyZDAwNTMxZmUxMjBlZTVkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTemlsYXJkIExlZGFuIDxMZWRhbi1NdW50ZWFuLlN6aWxhcmRA c3R1ZC51LXN6ZWdlZC5odT4KRGF0ZTogVHVlLCAzMSBKYW4gMjAxMiAwMjoxMDowNyAtMDgwMApT dWJqZWN0OiBbUEFUQ0hdIEZpeGVkIHNvbWUgbGluZXMgaW4gdGhlIGRhdGUtY29uc3RydWN0b3Iu anMgdGVzdC4KIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTg5MgoK UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgoqIGZhc3QvanMvZGF0ZS1jb25zdHJ1Y3Rvci1l eHBlY3RlZC50eHQ6CiogZmFzdC9qcy9zY3JpcHQtdGVzdHMvZGF0ZS1jb25zdHJ1Y3Rvci5qczoK LS0tCiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8 ICAgMTAgKysrKysrKysrKwogTGF5b3V0VGVzdHMvZmFzdC9qcy9kYXRlLWNvbnN0cnVjdG9yLWV4 cGVjdGVkLnR4dCAgfCAgIDE1ICsrKysrKysrLS0tLS0tLQogLi4uL2Zhc3QvanMvc2NyaXB0LXRl c3RzL2RhdGUtY29uc3RydWN0b3IuanMgICAgICAgfCAgIDE1ICsrKysrKysrLS0tLS0tLQogMyBm aWxlcyBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspLCAxNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg NzNhMTBiNC4uY2Q0MDA1ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAxLTMxICBTemls YXJkIExlZGFuICA8TGVkYW4tTXVudGVhbi5TemlsYXJkQHN0dWQudS1zemVnZWQuaHU+CisKKyAg ICAgICAgRml4ZWQgc29tZSBsaW5lcyBpbiB0aGUgZGF0ZS1jb25zdHJ1Y3Rvci5qcyB0ZXN0Lgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU4OTIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvanMv ZGF0ZS1jb25zdHJ1Y3Rvci1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9qcy9zY3JpcHQt dGVzdHMvZGF0ZS1jb25zdHJ1Y3Rvci5qczoKKwogMjAxMi0wMS0zMSAgQ3NhYmEgT3N6dHJvZ29u w6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFR5cG8gZml4IGFmdGVyIHIxMDYzMzku CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2pzL2RhdGUtY29uc3RydWN0b3ItZXhwZWN0 ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9qcy9kYXRlLWNvbnN0cnVjdG9yLWV4cGVjdGVkLnR4 dAppbmRleCA2NmIxMjE1Li44ZGVkYjEyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2pz L2RhdGUtY29uc3RydWN0b3ItZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvanMv ZGF0ZS1jb25zdHJ1Y3Rvci1leHBlY3RlZC50eHQKQEAgLTI0LDEzICsyNCwxNCBAQCBQQVNTIG5l dyBEYXRlKG5ldyBEYXRlKDExMTEsIDEsIDEsIDEsIDEsIDEpKS5nZXRUaW1lKCkgLSB0aW1lWm9u ZU9mZnNldCBpcyAtMjcxMAogUEFTUyBuZXcgRGF0ZShuZXcgRGF0ZSgxMTExLCAxLCAxLCAxLCAx LCAxLCAxKSkuZ2V0VGltZSgpIC0gdGltZVpvbmVPZmZzZXQgaXMgLTI3MTA0Nzk5NTM4OTk5CiBQ QVNTIG5ldyBEYXRlKG5ldyBEYXRlKDExMTEsIDEsIDEsIDEsIDEsIDEsIDEsIDEpKS5nZXRUaW1l KCkgLSB0aW1lWm9uZU9mZnNldCBpcyAtMjcxMDQ3OTk1Mzg5OTkKIFBBU1MgbmV3IERhdGUobmV3 IERhdGUoMTExMSwgMSwgMSwgMSwgMSwgMSwgMSwgMSwgMSkpLmdldFRpbWUoKSAtIHRpbWVab25l T2Zmc2V0IGlzIC0yNzEwNDc5OTUzODk5OQotUEFTUyBOdW1iZXIobmV3IERhdGUobmV3IERhdGUo SW5maW5pdHksIDEsIDEsIDEsIDEsIDEsIDEsIDEsIDEpKSkgaXMgTnVtYmVyLk5hTgotUEFTUyBO dW1iZXIobmV3IERhdGUobmV3IERhdGUoMSwgSW5maW5pdHksIDEsIDEsIDEsIDEsIDEsIDEsIDEp KSkgaXMgTnVtYmVyLk5hTgotUEFTUyBOdW1iZXIobmV3IERhdGUobmV3IERhdGUoMSwgMSwgSW5m aW5pdHksIDEsIDEsIDEsIDEsIDEsIDEpKSkgaXMgTnVtYmVyLk5hTgotUEFTUyBOdW1iZXIobmV3 IERhdGUobmV3IERhdGUoMSwgMSwgMSwgSW5maW5pdHksIDEsIDEsIDEsIDEsIDEpKSkgaXMgTnVt YmVyLk5hTgotUEFTUyBOdW1iZXIobmV3IERhdGUobmV3IERhdGUoMSwgMSwgMSwgMSwgSW5maW5p dHksIDEsIDEsIDEsIDEpKSkgaXMgTnVtYmVyLk5hTgotUEFTUyBOdW1iZXIobmV3IERhdGUobmV3 IERhdGUoMSwgMSwgMSwgMSwgMSwgSW5maW5pdHksIDEsIDEsIDEpKSkgaXMgTnVtYmVyLk5hTgot UEFTUyBOdW1iZXIobmV3IERhdGUobmV3IERhdGUoMSwgMSwgMSwgMSwgMSwgMSwgSW5maW5pdHks IDEsIDEpKSkgaXMgTnVtYmVyLk5hTgorUEFTUyBOdW1iZXIobmV3IERhdGUobmV3IERhdGUoSW5m aW5pdHksIDEsIDEsIDEsIDEsIDEsIDEsIDEsIDEpKS5nZXRUaW1lKCkgLSB0aW1lWm9uZU9mZnNl dCkgaXMgTnVtYmVyLk5hTgorUEFTUyBOdW1iZXIobmV3IERhdGUobmV3IERhdGUoMSwgSW5maW5p dHksIDEsIDEsIDEsIDEsIDEsIDEsIDEpKS5nZXRUaW1lKCkgLSB0aW1lWm9uZU9mZnNldCkgaXMg TnVtYmVyLk5hTgorUEFTUyBOdW1iZXIobmV3IERhdGUobmV3IERhdGUoMSwgMSwgSW5maW5pdHks IDEsIDEsIDEsIDEsIDEsIDEpKS5nZXRUaW1lKCkgLSB0aW1lWm9uZU9mZnNldCkgaXMgTnVtYmVy Lk5hTgorUEFTUyBOdW1iZXIobmV3IERhdGUobmV3IERhdGUoMSwgMSwgMSwgSW5maW5pdHksIDEs IDEsIDEsIDEsIDEpKS5nZXRUaW1lKCkgLSB0aW1lWm9uZU9mZnNldCkgaXMgTnVtYmVyLk5hTgor UEFTUyBOdW1iZXIobmV3IERhdGUobmV3IERhdGUoMSwgMSwgMSwgMSwgSW5maW5pdHksIDEsIDEs IDEsIDEpKS5nZXRUaW1lKCkgLSB0aW1lWm9uZU9mZnNldCkgaXMgTnVtYmVyLk5hTgorUEFTUyBO dW1iZXIobmV3IERhdGUobmV3IERhdGUoMSwgMSwgMSwgMSwgMSwgSW5maW5pdHksIDEsIDEsIDEp KS5nZXRUaW1lKCkgLSB0aW1lWm9uZU9mZnNldCkgaXMgTnVtYmVyLk5hTgorUEFTUyBOdW1iZXIo bmV3IERhdGUobmV3IERhdGUoMSwgMSwgMSwgMSwgMSwgMSwgSW5maW5pdHksIDEsIDEpKS5nZXRU aW1lKCkgLSB0aW1lWm9uZU9mZnNldCkgaXMgTnVtYmVyLk5hTgorUEFTUyBOdW1iZXIobmV3IERh dGUobmV3IERhdGUoMSwgMSwgMSwgMSwgMSwgMSwgMSwgMSwgSW5maW5pdHkpKS5nZXRUaW1lKCkg LSB0aW1lWm9uZU9mZnNldCkgaXMgLTIxNzQ3NzA3Mzg5OTkKIFBBU1MgdGVzdFN0ciBpcyAiMTIz NDU2NyIKIFBBU1MgdGVzdFN0ciBpcyAiMTIzNDU2NyIKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2Vk IGlzIHRydWUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvanMvc2NyaXB0LXRlc3RzL2Rh dGUtY29uc3RydWN0b3IuanMgYi9MYXlvdXRUZXN0cy9mYXN0L2pzL3NjcmlwdC10ZXN0cy9kYXRl LWNvbnN0cnVjdG9yLmpzCmluZGV4IDNkZmM2MmEuLjZlODk1M2MgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL2Zhc3QvanMvc2NyaXB0LXRlc3RzL2RhdGUtY29uc3RydWN0b3IuanMKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvZGF0ZS1jb25zdHJ1Y3Rvci5qcwpAQCAtMzUs MTMgKzM1LDE0IEBAIHNob3VsZEJlKCduZXcgRGF0ZShuZXcgRGF0ZSgxMTExLCAxLCAxLCAxLCAx LCAxLCAxKSkuZ2V0VGltZSgpIC0gdGltZVpvbmVPZmZzZXQnCiBzaG91bGRCZSgnbmV3IERhdGUo bmV3IERhdGUoMTExMSwgMSwgMSwgMSwgMSwgMSwgMSwgMSkpLmdldFRpbWUoKSAtIHRpbWVab25l T2Zmc2V0JywgJy0yNzEwNDc5OTUzODk5OScpOwogc2hvdWxkQmUoJ25ldyBEYXRlKG5ldyBEYXRl KDExMTEsIDEsIDEsIDEsIDEsIDEsIDEsIDEsIDEpKS5nZXRUaW1lKCkgLSB0aW1lWm9uZU9mZnNl dCcsICctMjcxMDQ3OTk1Mzg5OTknKTsKIAotc2hvdWxkQmUoIk51bWJlcihuZXcgRGF0ZShuZXcg RGF0ZShJbmZpbml0eSwgMSwgMSwgMSwgMSwgMSwgMSwgMSwgMSkpKSIsICdOdW1iZXIuTmFOJyk7 Ci1zaG91bGRCZSgiTnVtYmVyKG5ldyBEYXRlKG5ldyBEYXRlKDEsIEluZmluaXR5LCAxLCAxLCAx LCAxLCAxLCAxLCAxKSkpIiwgJ051bWJlci5OYU4nKTsKLXNob3VsZEJlKCJOdW1iZXIobmV3IERh dGUobmV3IERhdGUoMSwgMSwgSW5maW5pdHksIDEsIDEsIDEsIDEsIDEsIDEpKSkiLCAnTnVtYmVy Lk5hTicpOwotc2hvdWxkQmUoIk51bWJlcihuZXcgRGF0ZShuZXcgRGF0ZSgxLCAxLCAxLCBJbmZp bml0eSwgMSwgMSwgMSwgMSwgMSkpKSIsICdOdW1iZXIuTmFOJyk7Ci1zaG91bGRCZSgiTnVtYmVy KG5ldyBEYXRlKG5ldyBEYXRlKDEsIDEsIDEsIDEsIEluZmluaXR5LCAxLCAxLCAxLCAxKSkpIiwg J051bWJlci5OYU4nKTsKLXNob3VsZEJlKCJOdW1iZXIobmV3IERhdGUobmV3IERhdGUoMSwgMSwg MSwgMSwgMSwgSW5maW5pdHksIDEsIDEsIDEpKSkiLCAnTnVtYmVyLk5hTicpOwotc2hvdWxkQmUo Ik51bWJlcihuZXcgRGF0ZShuZXcgRGF0ZSgxLCAxLCAxLCAxLCAxLCAxLCBJbmZpbml0eSwgMSwg MSkpKSIsICdOdW1iZXIuTmFOJyk7CitzaG91bGRCZSgiTnVtYmVyKG5ldyBEYXRlKG5ldyBEYXRl KEluZmluaXR5LCAxLCAxLCAxLCAxLCAxLCAxLCAxLCAxKSkuZ2V0VGltZSgpIC0gdGltZVpvbmVP ZmZzZXQpIiwgJ051bWJlci5OYU4nKTsKK3Nob3VsZEJlKCJOdW1iZXIobmV3IERhdGUobmV3IERh dGUoMSwgSW5maW5pdHksIDEsIDEsIDEsIDEsIDEsIDEsIDEpKS5nZXRUaW1lKCkgLSB0aW1lWm9u ZU9mZnNldCkiLCAnTnVtYmVyLk5hTicpOworc2hvdWxkQmUoIk51bWJlcihuZXcgRGF0ZShuZXcg RGF0ZSgxLCAxLCBJbmZpbml0eSwgMSwgMSwgMSwgMSwgMSwgMSkpLmdldFRpbWUoKSAtIHRpbWVa b25lT2Zmc2V0KSIsICdOdW1iZXIuTmFOJyk7CitzaG91bGRCZSgiTnVtYmVyKG5ldyBEYXRlKG5l dyBEYXRlKDEsIDEsIDEsIEluZmluaXR5LCAxLCAxLCAxLCAxLCAxKSkuZ2V0VGltZSgpIC0gdGlt ZVpvbmVPZmZzZXQpIiwgJ051bWJlci5OYU4nKTsKK3Nob3VsZEJlKCJOdW1iZXIobmV3IERhdGUo bmV3IERhdGUoMSwgMSwgMSwgMSwgSW5maW5pdHksIDEsIDEsIDEsIDEpKS5nZXRUaW1lKCkgLSB0 aW1lWm9uZU9mZnNldCkiLCAnTnVtYmVyLk5hTicpOworc2hvdWxkQmUoIk51bWJlcihuZXcgRGF0 ZShuZXcgRGF0ZSgxLCAxLCAxLCAxLCAxLCBJbmZpbml0eSwgMSwgMSwgMSkpLmdldFRpbWUoKSAt IHRpbWVab25lT2Zmc2V0KSIsICdOdW1iZXIuTmFOJyk7CitzaG91bGRCZSgiTnVtYmVyKG5ldyBE YXRlKG5ldyBEYXRlKDEsIDEsIDEsIDEsIDEsIDEsIEluZmluaXR5LCAxLCAxKSkuZ2V0VGltZSgp IC0gdGltZVpvbmVPZmZzZXQpIiwgJ051bWJlci5OYU4nKTsKK3Nob3VsZEJlKCJOdW1iZXIobmV3 IERhdGUobmV3IERhdGUoMSwgMSwgMSwgMSwgMSwgMSwgMSwgMSwgSW5maW5pdHkpKS5nZXRUaW1l KCkgLSB0aW1lWm9uZU9mZnNldCkiLCAnLTIxNzQ3NzA3Mzg5OTknKTsKIAogLy8gSW4gRmlyZWZv eCwgdGhlIHJlc3VsdHMgb2YgdGhlIGZvbGxvd2luZyB0ZXN0cyBhcmUgdGltZXpvbmUtZGVwZW5k ZW50LCB3aGljaCBsaWtlbHkgaW1wbGllcyB0aGF0IHRoZSBpbXBsZW1lbnRhdGlvbiBpcyBub3Qg cXVpdGUgY29ycmVjdC4KIC8vIE91ciByZXN1bHRzIGFyZSBldmVuIHdvcnNlLCB0aG91Z2gsIGFz IHRoZSBkYXRlcyBhcmUgY2xpcHBlZDogKG5ldyBEYXRlKDExMTEsIDEyMDEpLmdldFRpbWUoKSkg PT0gKG5ldyBEYXRlKDExMTEsIDYwMSkuZ2V0VGltZSgpKQotLSAKMS43LjUuNAoK