75890 2012-01-09 14:23:04 -0800 Small typo in AudioPannerNode.cpp 2012-02-21 18:42:26 -0800 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rtoy rtoy crogers webkit.review.bot oldest_to_newest 532528 0 rtoy 2012-01-09 14:23:04 -0800 I think there's a small typo in AudioPannerNode.cpp near line 210: // Elevation double elevation = 90.0 - 180.0 * acos(sourceListener.dot(up)) / piDouble; fixNANs(azimuth); // avoid illegal values That fixNANs should probably be elevation, not azimuth, because we tested that at line 197. 535209 1 crogers 2012-01-12 15:10:44 -0800 Probably easiest to just fix this as part of the other equal-power panner bug: https://bugs.webkit.org/show_bug.cgi?id=75767 559885 2 crogers 2012-02-19 00:46:06 -0800 Ray, could you please provide the fix here -- it seems easy... 561222 3 128046 rtoy 2012-02-21 14:19:59 -0800 Created attachment 128046 Patch 561458 4 128046 webkit.review.bot 2012-02-21 18:42:22 -0800 Comment on attachment 128046 Patch Clearing flags on attachment: 128046 Committed r108430: <http://trac.webkit.org/changeset/108430> 561459 5 webkit.review.bot 2012-02-21 18:42:26 -0800 All reviewed patches have been landed. Closing bug. 128046 2012-02-21 14:19:59 -0800 2012-02-21 18:42:22 -0800 Patch bug-75890-20120221141958.patch text/plain 1439 rtoy U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4MzI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGZmODgwNGM3YjBhMTdh ZDJmYmZlZmY5MjY2MWY0MzI0ZTA1ZjMxMi4uN2RiOGUzZTRkMGZkMDIzM2FjNmY0MjVlOGMxNzg2 NTgzZmM3MDZhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAyLTIxICBSYXlt b25kIFRveSAgPHJ0b3lAZ29vZ2xlLmNvbT4KKworICAgICAgICBTbWFsbCB0eXBvIGluIEF1ZGlv UGFubmVyTm9kZS5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTc1ODkwCisKKyAgICAgICAgQ2hhbmdlIHRvIGNoZWNrIGVsZXZhdGlvbiBhcyBpbnRl bmRlZCBpbnN0ZWFkIG9mIGF6aW11dGguCisgICAgICAgIAorICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgZm9yIGNvcnJlY3Rpb24gb2Yg dHlwby4KKworICAgICAgICAqIHdlYmF1ZGlvL0F1ZGlvUGFubmVyTm9kZS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpBdWRpb1Bhbm5lck5vZGU6OmdldEF6aW11dGhFbGV2YXRpb24pOgorCiAyMDEy LTAyLTE3ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAg ICBbR1N0cmVhbWVyXSBtZWRpYS9XM0MgZmFpbHVyZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3dlYmF1ZGlvL0F1ZGlvUGFubmVyTm9kZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS93ZWJhdWRp by9BdWRpb1Bhbm5lck5vZGUuY3BwCmluZGV4IDc3OTBiNWVlNWNhNWIyZTg0Zjg3ZDg3ZTBmZThl ODQ3NGNmOWIxM2EuLjExMDU3NzMyNjA0OGFmZjA4YWY5ZTRlN2Y5MWI3MzNiMTgzYTJhYzcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0F1ZGlvUGFubmVyTm9kZS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvd2ViYXVkaW8vQXVkaW9QYW5uZXJOb2RlLmNwcApAQCAtMjIyLDcg KzIyMiw3IEBAIHZvaWQgQXVkaW9QYW5uZXJOb2RlOjpnZXRBemltdXRoRWxldmF0aW9uKGRvdWJs ZSogb3V0QXppbXV0aCwgZG91YmxlKiBvdXRFbGV2YXRpCiAKICAgICAvLyBFbGV2YXRpb24KICAg ICBkb3VibGUgZWxldmF0aW9uID0gOTAuMCAtIDE4MC4wICogYWNvcyhzb3VyY2VMaXN0ZW5lci5k b3QodXApKSAvIHBpRG91YmxlOwotICAgIGZpeE5BTnMoYXppbXV0aCk7IC8vIGF2b2lkIGlsbGVn YWwgdmFsdWVzCisgICAgZml4TkFOcyhlbGV2YXRpb24pOyAvLyBhdm9pZCBpbGxlZ2FsIHZhbHVl cwogCiAgICAgaWYgKGVsZXZhdGlvbiA+IDkwLjApCiAgICAgICAgIGVsZXZhdGlvbiA9IDE4MC4w IC0gZWxldmF0aW9uOwo=