75869 2012-01-09 10:56:00 -0800 Compilation errors on build-webkit --debug --no-workers on mac. 2012-01-31 00:22:54 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED P2 Minor --- 0 pf webkit-unassigned abarth webkit.review.bot oldest_to_newest 532320 0 pf 2012-01-09 10:56:00 -0800 Compilation errors on build-webkit --debug --no-workers on mac. 532321 1 121691 pf 2012-01-09 10:57:13 -0800 Created attachment 121691 proposed patch 542083 2 121691 abarth 2012-01-25 01:49:53 -0800 Comment on attachment 121691 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=121691&action=review > Source/WebKit/mac/Workers/WebWorkersPrivate.mm:39 > -#if ENABLE_WORKERS > +#if defined(ENABLE_WORKERS) && ENABLE_WORKERS We can't used ENABLE(WORKERS) here? 542085 3 121691 pf 2012-01-25 01:51:21 -0800 Comment on attachment 121691 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=121691&action=review >> Source/WebKit/mac/Workers/WebWorkersPrivate.mm:39 >> +#if defined(ENABLE_WORKERS) && ENABLE_WORKERS > > We can't used ENABLE(WORKERS) here? Doesn't include config.h, i think. 542086 4 121691 abarth 2012-01-25 01:52:24 -0800 Comment on attachment 121691 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=121691&action=review >>> Source/WebKit/mac/Workers/WebWorkersPrivate.mm:39 >>> +#if defined(ENABLE_WORKERS) && ENABLE_WORKERS >> >> We can't used ENABLE(WORKERS) here? > > Doesn't include config.h, i think. Crazy 542146 5 121691 webkit.review.bot 2012-01-25 03:29:19 -0800 Comment on attachment 121691 proposed patch Rejecting attachment 121691 from commit-queue. New failing tests: media/audio-garbage-collect.html Full output: http://queues.webkit.org/results/11264467 542409 6 pf 2012-01-25 10:13:31 -0800 Test failure looks unrelated. 545803 7 121691 abarth 2012-01-30 22:59:54 -0800 Comment on attachment 121691 proposed patch Yeah, sorry. That test was flaky for a while. 545829 8 121691 webkit.review.bot 2012-01-31 00:22:50 -0800 Comment on attachment 121691 proposed patch Clearing flags on attachment: 121691 Committed r106342: <http://trac.webkit.org/changeset/106342> 545830 9 webkit.review.bot 2012-01-31 00:22:54 -0800 All reviewed patches have been landed. Closing bug. 121691 2012-01-09 10:57:13 -0800 2012-01-31 00:22:50 -0800 proposed patch bug-75869-20120109105715.patch text/plain 2604 pf U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0NDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDU3ZTliYzYzYjMyNmU5 YTE2MjUzNzUyM2U1ZjIzN2Q0ZjRlYjczMy4uZTI5ZTcxN2ZiYzc5NWY4OGI2ZTZlODEzOGJhOGNl Mzk2ZTU5N2QwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTAxLTA5ICBQYWJs byBGbG91cmV0ICA8cGFibG9mQG1vdG9yb2xhLmNvbT4KKworICAgICAgICBGaXggY29tcGlsYXRp b24gZXJyb3JzIG9uIGJ1aWxkLXdlYmtpdCAtLWRlYnVnIC0tbm8td29ya2VycyBvbiBtYWMuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTg2OQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZS5l eHAuaW46CisKIDIwMTItMDEtMDggIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAog ICAgICAgICBbQ2hyb21pdW1dIFJlbW92ZSB1c2Vfc2tpYSBvcHRpb24gZnJvbSBHWVAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvbWFjL0No YW5nZUxvZwppbmRleCA3ZTU4YTM5Zjg0OGYyMTVkZDQzNGIxNTAwYzAzZDIwMjkzYTBkNzkyLi5i NTNkYjhhZWFmODAzODdhMDg1ZTVkOWY2MDgxOTlkMWQwOTZhZDQ0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDEtMDkgIFBhYmxvIEZsb3VyZXQgIDxwYWJsb2ZAbW90 b3JvbGEuY29tPgorCisgICAgICAgIEZpeCBjb21waWxhdGlvbiBlcnJvcnMgb24gYnVpbGQtd2Vi a2l0IC0tZGVidWcgLS1uby13b3JrZXJzIG9uIG1hYy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1ODY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXb3JrZXJzL1dlYldvcmtlcnNQcml2YXRlLm1tOgor ICAgICAgICAoK1tXZWJXb3JrZXJzUHJpdmF0ZSB3b3JrZXJUaHJlYWRDb3VudF0pOgorCiAyMDEy LTAxLTA2ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAg IE1pdGlnYXRlIHNjcm9sbGJhciBkaWZmZXJlbmNlcyB3aGVuIHJ1bm5pbmcgcGl4ZWwgdGVzdHMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluIGIvU291cmNlL1dlYkNv cmUvV2ViQ29yZS5leHAuaW4KaW5kZXggOGU1MDVmZTg2ZmU1YThhYmIyNzUyY2YyMzE5ZjRlN2Q4 OGFhYmI3YS4uM2JiMTNlNTVhMjI3YmZmMjUwNjY2ZjU0YmQ4YzJlOGY4ZGJlMTM2MCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4KKysrIGIvU291cmNlL1dlYkNvcmUv V2ViQ29yZS5leHAuaW4KQEAgLTI5OSw3ICsyOTksOSBAQCBfX1pON1dlYkNvcmUxMlRleHRJdGVy YXRvcjdhZHZhbmNlRXYKIF9fWk43V2ViQ29yZTEyVGV4dEl0ZXJhdG9yOHN1YnJhbmdlRVBOU181 UmFuZ2VFaWkKIF9fWk43V2ViQ29yZTEyVGV4dEl0ZXJhdG9yQzFFUEtOU181UmFuZ2VFTlNfMjBU ZXh0SXRlcmF0b3JCZWhhdmlvckUKIF9fWk43V2ViQ29yZTEyVGV4dEl0ZXJhdG9yRDFFdgorI2lm IEVOQUJMRShXT1JLRVJTKQogX19aTjdXZWJDb3JlMTJXb3JrZXJUaHJlYWQxN3dvcmtlclRocmVh ZENvdW50RXYKKyNlbmRpZgogX19aTjdXZWJDb3JlMTJjYWNoZVN0b3JhZ2VFdgogX19aTjdXZWJD b3JlMTJjcmVhdGVNYXJrdXBFUEtOU180Tm9kZUVOU18xM0VDaGlsZHJlbk9ubHlFUE4zV1RGNlZl Y3RvcklQUzBfTG0wRUVFTlNfMTNFQWJzb2x1dGVVUkxzRQogX19aTjdXZWJDb3JlMTJjcmVhdGVN YXJrdXBFUEtOU181UmFuZ2VFUE4zV1RGNlZlY3RvcklQTlNfNE5vZGVFTG0wRUVFTlNfMjNFQW5u b3RhdGVGb3JJbnRlcmNoYW5nZUViTlNfMTNFQWJzb2x1dGVVUkxzRQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9tYWMvV29ya2Vycy9XZWJXb3JrZXJzUHJpdmF0ZS5tbSBiL1NvdXJjZS9XZWJL aXQvbWFjL1dvcmtlcnMvV2ViV29ya2Vyc1ByaXZhdGUubW0KaW5kZXggMmMxNGFkMWI2NGY4NWE3 NjlmN2NlYWUwYWEyZTkyN2Y3ODZlM2Q2Yi4uZTZlYThjMDUxYjg4NzU2NWM1YzA0ZTM3YmM5NWE3 ZjFkYjBmNzYxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvV29ya2Vycy9XZWJXb3Jr ZXJzUHJpdmF0ZS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9Xb3JrZXJzL1dlYldvcmtlcnNQ cml2YXRlLm1tCkBAIC0zNiw3ICszNiw3IEBACiAKICsgKHVuc2lnbmVkKSB3b3JrZXJUaHJlYWRD b3VudAogewotI2lmIEVOQUJMRV9XT1JLRVJTCisjaWYgZGVmaW5lZChFTkFCTEVfV09SS0VSUykg JiYgRU5BQkxFX1dPUktFUlMKICAgICByZXR1cm4gV2ViQ29yZTo6V29ya2VyVGhyZWFkOjp3b3Jr ZXJUaHJlYWRDb3VudCgpOwogI2Vsc2UKICAgICByZXR1cm4gMDsK