75868 2012-01-09 10:51:17 -0800 [EFL] Add getter for Ewk_JS_Object::view. 2012-01-10 05:47:42 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco g.czajkowski gyuyoung.kim hyuki.kim kenneth leandro lucas.de.marchi tonikitoo oldest_to_newest 532315 0 rakuco 2012-01-09 10:51:17 -0800 [EFL] Add getter for Ewk_JS_Object::view. 532316 1 121687 rakuco 2012-01-09 10:51:47 -0800 Created attachment 121687 Patch 532775 2 121687 gyuyoung.kim 2012-01-09 19:18:19 -0800 Comment on attachment 121687 Patch LGTM. 532851 3 hyuki.kim 2012-01-10 00:03:58 -0800 > Source/WebKit/efl/ewk/ewk_js.cpp:615 > +Evas_Object* ewk_js_object_view_get(const Ewk_JS_Object *jsObject) As far as I know, renewed coding style doesn't like '*' in front of parameter, Would you check the position of '*' in front of jsObject ? > Source/WebKit/efl/ewk/ewk_js.cpp:718 > +Evas_Object* ewk_js_object_view_get(const Ewk_JS_Object *jsObject) Ditto. 532860 4 g.czajkowski 2012-01-10 00:24:52 -0800 Wouldn't it be better to move checking NETSCAPE_PLUGIN_API macro to functions definition instead of duplicate them in source depending on macro value? It is known practice in WebKit and EFL port. Reviewing patches like this may confuse reviewer if he sees the same API in the same file whose return value and implementation are different (especially if macro isn't included in patch). What do you think about it? 532983 5 121830 rakuco 2012-01-10 05:13:15 -0800 Created attachment 121830 Coding style fixes 532985 6 rakuco 2012-01-10 05:14:43 -0800 (In reply to comment #4) > Wouldn't it be better to move checking NETSCAPE_PLUGIN_API macro to functions definition instead of duplicate them in source depending on macro value? Yeah, but it makes more sense to do that in a separate patch IMO. Doing so here would make the patch bigger and the function inconsistent with the rest of the file (the other option, fixing everything here, would be even worse). 532991 7 hyuki.kim 2012-01-10 05:30:12 -0800 (In reply to comment #5) > Created an attachment (id=121830) [details] > Coding style fixes LGTM. :) 532996 8 g.czajkowski 2012-01-10 05:33:51 -0800 (In reply to comment #6) > (In reply to comment #4) > > Wouldn't it be better to move checking NETSCAPE_PLUGIN_API macro to functions definition instead of duplicate them in source depending on macro value? > > Yeah, but it makes more sense to do that in a separate patch IMO. Doing so here would make the patch bigger and the function inconsistent with the rest of the file (the other option, fixing everything here, would be even worse). LGTM. 533005 9 rakuco 2012-01-10 05:47:42 -0800 Committed r104562: <http://trac.webkit.org/changeset/104562> 121687 2012-01-09 10:51:47 -0800 2012-01-10 05:13:08 -0800 Patch bug-75868-20120109165232.patch text/plain 2906 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0NDI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggZmZlN2ExMGNm NDkwZDY3ZjdiNDJiM2E4ODNkMDA4YTQzZmRhMDVjYy4uNGFiMjgxNGU1NzI0Yzc1N2VkYmEyYTcy NTY2NzYyY2NjM2E4ZGQyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEy LTAxLTA5ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxrdWJvQHByb2Z1c2lvbi5tb2JpPgorCisg ICAgICAgIFtFRkxdIEFkZCBnZXR0ZXIgZm9yIEV3a19KU19PYmplY3Q6OnZpZXcuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTg2OAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNvIGZhciB0aGUgdmlldyBh c3NvY2lhdGVkIHdpdGggYSBnaXZlbiBKUyBvYmplY3Qgd2FzIGEgcHJpdmF0ZQorICAgICAgICBw cm9wZXJ0eSBvbmx5IGFjY2Vzc2libGUgdG8gZXdrIGl0c2VsZi4gVGhpcyBkb2VzIG5vdCBtYWtl IG11Y2ggc2Vuc2UsCisgICAgICAgIGFzIG9uZSBvZnRlbiBuZWVkcyB0byBrbm93IHdoaWNoIHZp ZXcgYSBjZXJ0YWluIG1ldGhvZCB3YXMgaW52b2tlZAorICAgICAgICBmcm9tLCBmb3IgZXhhbXBs ZS4KKworICAgICAgICAqIGV3ay9ld2tfanMuY3BwOgorICAgICAgICAoZXdrX2pzX29iamVjdF92 aWV3X2dldCk6CisgICAgICAgICogZXdrL2V3a19qcy5oOgorCiAyMDEyLTAxLTA2ICBKdW5nSmlr IExlZSAgPGp1bmdqaWsubGVlQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIEFkZCBuZXcg cHJlLXJlbmRlcmluZyBjb2RlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a19qcy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2pzLmNwcAppbmRleCA2OTQwYjNi M2Y3M2M0MzYzZjhmZDRmY2NmN2I5MjY3YmU2ZTc5MWVhLi4yMjhlMDBkYzY0ZTRlMzE0NzRlNjM1 YTcwNGQ2ZDg4YzM3NzE3YjRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdr X2pzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2pzLmNwcApAQCAtNjEyLDYg KzYxMiwxMyBAQCB2b2lkIGV3a19qc19vYmplY3RfZnJlZShFd2tfSlNfT2JqZWN0KiBqc09iamVj dCkKICAgICAgICAgZnJlZShqc09iamVjdCk7CiB9CiAKK0V2YXNfT2JqZWN0KiBld2tfanNfb2Jq ZWN0X3ZpZXdfZ2V0KGNvbnN0IEV3a19KU19PYmplY3QgKmpzT2JqZWN0KQoreworICAgIEVJTkFf U0FGRVRZX09OX05VTExfUkVUVVJOX1ZBTChqc09iamVjdCwgMCk7CisgICAgRUlOQV9NQUdJQ19D SEVDS19PUl9SRVRVUk4oanNPYmplY3QsIDApOworICAgIHJldHVybiBqc09iamVjdC0+dmlldzsK K30KKwogRWluYV9IYXNoKiBld2tfanNfb2JqZWN0X3Byb3BlcnRpZXNfZ2V0KGNvbnN0IEV3a19K U19PYmplY3QqIGpzT2JqZWN0KQogewogICAgIEVJTkFfU0FGRVRZX09OX05VTExfUkVUVVJOX1ZB TChqc09iamVjdCwgMCk7CkBAIC03MDgsNiArNzE1LDExIEBAIGNvbnN0IGNoYXIqIGV3a19qc19v YmplY3RfbmFtZV9nZXQoY29uc3QgRXdrX0pTX09iamVjdCoganNPYmplY3QpCiAgICAgcmV0dXJu IDA7CiB9CiAKK0V2YXNfT2JqZWN0KiBld2tfanNfb2JqZWN0X3ZpZXdfZ2V0KGNvbnN0IEV3a19K U19PYmplY3QgKmpzT2JqZWN0KQoreworICAgIHJldHVybiAwOworfQorCiB2b2lkIGV3a19qc192 YXJpYW50X2ZyZWUoRXdrX0pTX1ZhcmlhbnQqIGpzVmFyaWFudCkKIHsKIH0KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfanMuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9l d2tfanMuaAppbmRleCA3MzMxZGEyODliMDQxMzM0MGU3NTljZjNlNDNiNDFkOGYxNGMxN2Q3Li42 Mjc5MzU3ZWNlNThjNGQyYmVkMjIyMDE3MWU0ZjgwMWNiN2IzMmI2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2VmbC9ld2svZXdrX2pzLmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a19qcy5oCkBAIC0xMTksNiArMTE5LDIxIEBAIEVBUEkgRWluYV9IYXNoICpld2tfanNfb2JqZWN0 X3Byb3BlcnRpZXNfZ2V0KGNvbnN0IEV3a19KU19PYmplY3QgKm9iaik7CiBFQVBJIGNvbnN0IGNo YXIgKmV3a19qc19vYmplY3RfbmFtZV9nZXQoY29uc3QgRXdrX0pTX09iamVjdCAqb2JqKTsKIAog LyoqCisgKiBSZXR1cm5zIHRoZSB2aWV3IGFzc29jaWF0ZWQgd2l0aCBhbiBFd2tfSlNfT2JqZWN0 LgorICoKKyAqIFRoZSByZXR1cm5lZCB2aWV3IGlzIHRoZSBvbmUgcGFzc2VkIHRvIGV3a192aWV3 X2pzX29iamVjdF9hZGQuIFJpZ2h0IG5vdywKKyAqIHRoZSBvYmplY3QgaXMgYWx3YXlzIGFkZGVk IHRvIHRoZSB2aWV3J3MgbWFpbiBmcmFtZS4KKyAqCisgKiBAcGFyYW0gb2JqIFRoZSBvYmplY3Qg dG8gYmUgcXVlcmllZC4KKyAqCisgKiBAcmV0dXJuIFRoZSB2aWV3IHdob3NlIG1haW4gZnJhbWUg dGhlIG9iamVjdCBoYXMgYmVlbiBpbnNlcnRlZCBpbnRvLCBvcgorICogICAgICAgICBAYyBOVUxM IGlmIHRoZSBvYmplY3QgaGFzIG5vdCBiZWVuIGFkZGVkIHRvIGEgdmlldyB5ZXQuCisgKgorICog QHNhIGV3a192aWV3X2pzX29iamVjdF9hZGQsIGV3a192aWV3X2ZyYW1lX21haW5fZ2V0CisgKi8K K0VBUEkgRXZhc19PYmplY3QgKmV3a19qc19vYmplY3Rfdmlld19nZXQoY29uc3QgRXdrX0pTX09i amVjdCAqb2JqKTsKKworLyoqCiAgKiBSZWxlYXNlIHJlc291cmNlcyBhbGxvY2F0ZWQgYnkgQGEg dmFyLgogICoKICAqIEBwYXJhbSB2YXIgQGEgRXdrX0pTX1ZhcmlhbnQgdG8gYmUgcmVsZWFzZQo= 121830 2012-01-10 05:13:15 -0800 2012-01-10 05:41:09 -0800 Coding style fixes bug-75868-20120110111400.patch text/plain 2906 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0NDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggZmZlN2ExMGNm NDkwZDY3ZjdiNDJiM2E4ODNkMDA4YTQzZmRhMDVjYy4uNGFiMjgxNGU1NzI0Yzc1N2VkYmEyYTcy NTY2NzYyY2NjM2E4ZGQyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEy LTAxLTA5ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxrdWJvQHByb2Z1c2lvbi5tb2JpPgorCisg ICAgICAgIFtFRkxdIEFkZCBnZXR0ZXIgZm9yIEV3a19KU19PYmplY3Q6OnZpZXcuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTg2OAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNvIGZhciB0aGUgdmlldyBh c3NvY2lhdGVkIHdpdGggYSBnaXZlbiBKUyBvYmplY3Qgd2FzIGEgcHJpdmF0ZQorICAgICAgICBw cm9wZXJ0eSBvbmx5IGFjY2Vzc2libGUgdG8gZXdrIGl0c2VsZi4gVGhpcyBkb2VzIG5vdCBtYWtl IG11Y2ggc2Vuc2UsCisgICAgICAgIGFzIG9uZSBvZnRlbiBuZWVkcyB0byBrbm93IHdoaWNoIHZp ZXcgYSBjZXJ0YWluIG1ldGhvZCB3YXMgaW52b2tlZAorICAgICAgICBmcm9tLCBmb3IgZXhhbXBs ZS4KKworICAgICAgICAqIGV3ay9ld2tfanMuY3BwOgorICAgICAgICAoZXdrX2pzX29iamVjdF92 aWV3X2dldCk6CisgICAgICAgICogZXdrL2V3a19qcy5oOgorCiAyMDEyLTAxLTA2ICBKdW5nSmlr IExlZSAgPGp1bmdqaWsubGVlQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIEFkZCBuZXcg cHJlLXJlbmRlcmluZyBjb2RlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a19qcy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2pzLmNwcAppbmRleCA2OTQwYjNi M2Y3M2M0MzYzZjhmZDRmY2NmN2I5MjY3YmU2ZTc5MWVhLi4zZTU4MTdiOWZkOGU5M2ZlMzNlYmNj YjM1ZTRjZDc0YWUwNmVkOTQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdr X2pzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2pzLmNwcApAQCAtNjEyLDYg KzYxMiwxMyBAQCB2b2lkIGV3a19qc19vYmplY3RfZnJlZShFd2tfSlNfT2JqZWN0KiBqc09iamVj dCkKICAgICAgICAgZnJlZShqc09iamVjdCk7CiB9CiAKK0V2YXNfT2JqZWN0KiBld2tfanNfb2Jq ZWN0X3ZpZXdfZ2V0KGNvbnN0IEV3a19KU19PYmplY3QqIGpzT2JqZWN0KQoreworICAgIEVJTkFf U0FGRVRZX09OX05VTExfUkVUVVJOX1ZBTChqc09iamVjdCwgMCk7CisgICAgRUlOQV9NQUdJQ19D SEVDS19PUl9SRVRVUk4oanNPYmplY3QsIDApOworICAgIHJldHVybiBqc09iamVjdC0+dmlldzsK K30KKwogRWluYV9IYXNoKiBld2tfanNfb2JqZWN0X3Byb3BlcnRpZXNfZ2V0KGNvbnN0IEV3a19K U19PYmplY3QqIGpzT2JqZWN0KQogewogICAgIEVJTkFfU0FGRVRZX09OX05VTExfUkVUVVJOX1ZB TChqc09iamVjdCwgMCk7CkBAIC03MDgsNiArNzE1LDExIEBAIGNvbnN0IGNoYXIqIGV3a19qc19v YmplY3RfbmFtZV9nZXQoY29uc3QgRXdrX0pTX09iamVjdCoganNPYmplY3QpCiAgICAgcmV0dXJu IDA7CiB9CiAKK0V2YXNfT2JqZWN0KiBld2tfanNfb2JqZWN0X3ZpZXdfZ2V0KGNvbnN0IEV3a19K U19PYmplY3QqIGpzT2JqZWN0KQoreworICAgIHJldHVybiAwOworfQorCiB2b2lkIGV3a19qc192 YXJpYW50X2ZyZWUoRXdrX0pTX1ZhcmlhbnQqIGpzVmFyaWFudCkKIHsKIH0KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfanMuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9l d2tfanMuaAppbmRleCA3MzMxZGEyODliMDQxMzM0MGU3NTljZjNlNDNiNDFkOGYxNGMxN2Q3Li42 Mjc5MzU3ZWNlNThjNGQyYmVkMjIyMDE3MWU0ZjgwMWNiN2IzMmI2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2VmbC9ld2svZXdrX2pzLmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a19qcy5oCkBAIC0xMTksNiArMTE5LDIxIEBAIEVBUEkgRWluYV9IYXNoICpld2tfanNfb2JqZWN0 X3Byb3BlcnRpZXNfZ2V0KGNvbnN0IEV3a19KU19PYmplY3QgKm9iaik7CiBFQVBJIGNvbnN0IGNo YXIgKmV3a19qc19vYmplY3RfbmFtZV9nZXQoY29uc3QgRXdrX0pTX09iamVjdCAqb2JqKTsKIAog LyoqCisgKiBSZXR1cm5zIHRoZSB2aWV3IGFzc29jaWF0ZWQgd2l0aCBhbiBFd2tfSlNfT2JqZWN0 LgorICoKKyAqIFRoZSByZXR1cm5lZCB2aWV3IGlzIHRoZSBvbmUgcGFzc2VkIHRvIGV3a192aWV3 X2pzX29iamVjdF9hZGQuIFJpZ2h0IG5vdywKKyAqIHRoZSBvYmplY3QgaXMgYWx3YXlzIGFkZGVk IHRvIHRoZSB2aWV3J3MgbWFpbiBmcmFtZS4KKyAqCisgKiBAcGFyYW0gb2JqIFRoZSBvYmplY3Qg dG8gYmUgcXVlcmllZC4KKyAqCisgKiBAcmV0dXJuIFRoZSB2aWV3IHdob3NlIG1haW4gZnJhbWUg dGhlIG9iamVjdCBoYXMgYmVlbiBpbnNlcnRlZCBpbnRvLCBvcgorICogICAgICAgICBAYyBOVUxM IGlmIHRoZSBvYmplY3QgaGFzIG5vdCBiZWVuIGFkZGVkIHRvIGEgdmlldyB5ZXQuCisgKgorICog QHNhIGV3a192aWV3X2pzX29iamVjdF9hZGQsIGV3a192aWV3X2ZyYW1lX21haW5fZ2V0CisgKi8K K0VBUEkgRXZhc19PYmplY3QgKmV3a19qc19vYmplY3Rfdmlld19nZXQoY29uc3QgRXdrX0pTX09i amVjdCAqb2JqKTsKKworLyoqCiAgKiBSZWxlYXNlIHJlc291cmNlcyBhbGxvY2F0ZWQgYnkgQGEg dmFyLgogICoKICAqIEBwYXJhbSB2YXIgQGEgRXdrX0pTX1ZhcmlhbnQgdG8gYmUgcmVsZWFzZQo=