75863 2012-01-09 09:25:55 -0800 [Qt] REGRESSION(r100130): Clean build feature is broken. 2012-01-10 03:30:53 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Critical --- 75777 1 ossy ossy hausmann kenneth noam ossy vestbo oldest_to_newest 532237 0 ossy 2012-01-09 09:25:55 -0800 This bug is revealed by http://trac.webkit.org/changeset/104403 . r104402 - everything is OK: http://build.webkit.sed.hu/builders/x86-32%20Linux%20Qt%20Release%20-%20Qt5-WebKit1/builds/2048 r104403 - everything is broken: http://build.webkit.sed.hu/builders/x86-32%20Linux%20Qt%20Release%20-%20Qt5-WebKit1/builds/2049 The build log said that "Feature ENABLE_CSS_FILTERS added, clean build needed!", but somehow all layout tests fails. After removing WebKitBuild manually, everything is OK. 532240 1 ossy 2012-01-09 09:31:28 -0800 You can easily reproduce this bug: - update to r104402 - build - update to r104403 - build - run layout tests on css2.1 532276 2 ossy 2012-01-09 10:25:39 -0800 I dig a little bit and it seems HAVE_FONTCONFIG=1 is absolutely missing during the second build and it makes all tests fail, because webkit testsfonts aren't used. 532305 3 ossy 2012-01-09 10:40:07 -0800 I think the problem is in webkitdirs.pm - sub qtFeatureDefaults. configure.pro is only called in build phase to determine if we have fontconfig or not. But feauteres.prf is called by build-webkit to set all defines passed to the build before build phase. I'll continue digging tomorrow. 532552 4 vestbo 2012-01-09 15:12:04 -0800 (In reply to comment #3) > I think the problem is in webkitdirs.pm - sub qtFeatureDefaults. > configure.pro is only called in build phase to determine if we have fontconfig or not. But feauteres.prf is called by build-webkit to set all defines passed to the build before build phase. > > I'll continue digging tomorrow. The configure-checks run by configure.pro cache their results in Tools/qmake/.qmake.cache, which should get loaded by features.prf on subsequent runs. I'll help you dig tomorrow. 532923 5 ossy 2012-01-10 02:58:05 -0800 The original change caused this regression: http://trac.webkit.org/changeset/100130?format=diff&new=100130 I managed to catch what cause this bug. Now the build phases are the following if a feature define changes: - configure.pro is called to determine feature defines (and config tests too which generates Tools/qmake/.qmake.cache) - clean build triggered because a feature define changes (rmtree WebKitBuild) - make, which will be incorrect, because Tools/qmake/.qmake.cache is non-existent and HAVE_FONTCONFIG=1 macro doesn't exist, but it should be. 532929 6 121820 ossy 2012-01-10 03:14:13 -0800 Created attachment 121820 Patch 532931 7 121820 vestbo 2012-01-10 03:18:43 -0800 Comment on attachment 121820 Patch cool, thanks! 532939 8 121820 ossy 2012-01-10 03:30:45 -0800 Comment on attachment 121820 Patch Clearing flags on attachment: 121820 Committed r104548: <http://trac.webkit.org/changeset/104548> 532940 9 ossy 2012-01-10 03:30:53 -0800 All reviewed patches have been landed. Closing bug. 121820 2012-01-10 03:14:13 -0800 2012-01-10 03:30:45 -0800 Patch bug-75863-20120110121411.patch text/plain 1297 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0NTQ2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmQ1OTgwMjc4MzQ0MDhlOWZmYTEwMTRiZGM5NDY3MTA0 YTQyZWZhYS4uM2QxOTNlOTkzMjNhOTkwMWU1NGQ2Y2U2MTFhNjNkNTA3ZmE2ZjY3ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEyLTAxLTEwICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgW1F0XSBSRUdSRVNTSU9OKHIxMDAxMzApOiBDbGVhbiBidWlsZCBmZWF0dXJlIGlz IGJyb2tlbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc1ODYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAgIChidWlsZFFNYWtlUHJvamVjdCk6CisK IDIwMTItMDEtMTAgIFplbm8gQWxiaXNzZXIgIDx6ZW5vQHdlYmtpdC5vcmc+CiAKICAgICAgICAg W1F0XVtXSzJdIEZpeCBrZXlib2FyZCBzaG9ydGN1dHMgaW4gTWluaUJyb3dzZXIuCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRp cnMucG0KaW5kZXggZWMwZDQzZjlhYzY4NmMyOTI2OGNmNTk3ZjA1YWJiNWM1Njc1MDU1NS4uYzhm YTA1YWQ1NDdhMDhiMGYzYzk2MzY1ZTYyNTgwMTk1MTlmYjE2ZiAxMDA3NTUKLS0tIGEvVG9vbHMv U2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpA QCAtMjExMSw2ICsyMTExLDEwIEBAIHN1YiBidWlsZFFNYWtlUHJvamVjdCgkQCkKICAgICAgICAg ICAgIEZpbGU6OlBhdGg6OnJtdHJlZSgkZGlyKTsKICAgICAgICAgICAgIEZpbGU6OlBhdGg6Om1r cGF0aCgkZGlyKTsKICAgICAgICAgICAgIGNoZGlyICRkaXIgb3IgZGllICJGYWlsZWQgdG8gY2Qg aW50byAiIC4gJGRpciAuICJcbiI7CisKKyAgICAgICAgICAgICMgQWZ0ZXIgcmVtb3ZpbmcgV2Vi S2l0QnVpbGQgZGlyZWN0b3J5LCB3ZSBoYXZlIHRvIGNhbGwgcXRGZWF0dXJlRGVmYXVsdHMoKQor ICAgICAgICAgICAgIyB0byBydW4gY29uZmlnIHRlc3RzIGFuZCBnZW5lcmF0ZSB0aGUgcmVtb3Zl ZCBUb29scy9xbWFrZS8ucW1ha2UuY2FjaGUgYWdhaW4uCisgICAgICAgICAgICBxdEZlYXR1cmVE ZWZhdWx0cyhcQGJ1aWxkQXJncyk7CiAgICAgICAgICN9CiAgICAgfQogCg==