75851 2012-01-09 06:26:22 -0800 NULL ptr in WebCore::RenderSVGInlineText::localCaretRect 2012-01-17 18:03:48 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC Windows Vista RESOLVED FIXED P1 Normal --- 1 skylined schenney rniwa schenney webkit.review.bot oldest_to_newest 532151 0 121659 skylined 2012-01-09 06:26:22 -0800 Created attachment 121659 Repro Chromium: http://code.google.com/p/chromium/issues/detail?id=109607 Repro: <svg xmlns="http://www.w3.org/2000/svg"><style> * { border-top-style: inset } </style><script> window.onload=function() { _Selection_0=getSelection(); _Selection_0.setBaseAndExtent(document,5,document,5); _Selection_0.deleteFromDocument(); _Selection_0.modify('extend','backward','line'); } </script> <text></text><text> 1 535966 1 122495 schenney 2012-01-13 13:56:34 -0800 Created attachment 122495 Patch Every other implementation of localCaretRect(...) checks for a null box. This makes the SVG inline text do the same, which fixes the reported chromium crash. I was unable to create a LayoutTest that crashed, so there is none added. 535989 2 122495 rniwa 2012-01-13 14:22:04 -0800 Comment on attachment 122495 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122495&action=review > Source/WebCore/ChangeLog:10 > + Reviewed by NOBODY (OOPS!). This line should appear before the description. 536053 3 rniwa 2012-01-13 15:47:35 -0800 Kelly, please see my review comment. "Reviewed by" line in the change log is inserted at the wrong location and that's why I didn't cq+ it. 536071 4 122517 schenney 2012-01-13 16:11:40 -0800 Created attachment 122517 Patch Fixed review line location. Apologies for not fixing pre-commit. 536107 5 rniwa 2012-01-13 17:34:36 -0800 Wait a minute, you didn't a test. Please add a new layout test. 537133 6 schenney 2012-01-17 08:52:52 -0800 I could not figure out how to make LayoutTestController generate this stack trace, which is the crash stack trace. I'll try some more, but any help would be appreciated. #0 0x00007ffff396646c in WebCore::RenderSVGInlineText::localCaretRect (this=0x7fffe2494658, box=0x0, caretOffset=0) at third_party/WebKit/Source/WebCore/rendering/svg/RenderSVGInlineText.cpp:141 #1 0x00007ffff314d9d3 in WebCore::RenderedPosition::absoluteRect (this=0x7fffffff9b90, extraWidthToEndOfLine= 0x7fffffff9cec) at third_party/WebKit/Source/WebCore/editing/RenderedPosition.cpp:232 #2 0x00007ffff3130cfb in WebCore::RenderedPosition::absoluteRect (this=0x7fffffff9b90, extraWidthToEndOfLine= @0x7fffffff9cec) at third_party/WebKit/Source/WebCore/editing/RenderedPosition.h:71 #3 0x00007ffff312d097 in WebCore::Editor::firstRectForRange (this=0x7fffe23feef8, range=0x7fffe14b4600) at third_party/WebKit/Source/WebCore/editing/Editor.cpp:2640 #4 0x00007ffff294cd02 in WebKit::WebViewImpl::selectionBounds (this=0x7fffefe22600, start=..., end=...) at third_party/WebKit/Source/WebKit/chromium/src/WebViewImpl.cpp:1674 #5 0x00007ffff43f4823 in RenderWidget::GetSelectionBounds (this=0x7fffefe53000, start=0x7fffffff9fa0, end= 0x7fffffff9f90) at content/renderer/render_widget.cc:1454 #6 0x00007ffff43dcfcd in RenderViewImpl::GetSelectionBounds (this=0x7fffefe53000, start=0x7fffffff9fa0, end= 0x7fffffff9f90) at content/renderer/render_view_impl.cc:4551 #7 0x00007ffff43f48ea in RenderWidget::UpdateSelectionBounds (this=0x7fffefe53000) at content/renderer/render_widget.cc:1465 #8 0x00007ffff43f204e in RenderWidget::DoDeferredUpdate (this=0x7fffefe53000) at content/renderer/render_widget.cc:908 #9 0x00007ffff43f0b43 in RenderWidget::DoDeferredUpdateAndSendInputAck (this=0x7fffefe53000) at content/renderer/render_widget.cc:730 #10 0x00007ffff43eee2c in RenderWidget::OnUpdateRectAck (this=0x7fffefe53000) at content/renderer/render_widget.cc:383 537332 7 122807 schenney 2012-01-17 13:42:23 -0800 Created attachment 122807 Patch Adding a manual test case, as the issue was not reproducable with DRT. 537337 8 schenney 2012-01-17 13:50:43 -0800 Damn. Crash isn't happening with this test - swear it was. 537339 9 122810 schenney 2012-01-17 13:59:20 -0800 Created attachment 122810 Patch This test file crashes. 537373 10 122810 rniwa 2012-01-17 15:03:58 -0800 Comment on attachment 122810 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122810&action=review It's still sad that we can't add an automated test. > ManualTests/svg-modify-deleted-selection.svg:12 > + _Selection_0=getSelection(); > + _Selection_0.setBaseAndExtent(document,5,document,5); > + _Selection_0.deleteFromDocument(); > + _Selection_0.modify('extend','backward','line'); Why do we need _Selection_0? You can just call getSelection() on every line. 537387 11 122824 schenney 2012-01-17 15:28:10 -0800 Created attachment 122824 Patch Got rid of the _Selection_0 variable. 537516 12 122824 webkit.review.bot 2012-01-17 18:03:43 -0800 Comment on attachment 122824 Patch Clearing flags on attachment: 122824 Committed r105224: <http://trac.webkit.org/changeset/105224> 537517 13 webkit.review.bot 2012-01-17 18:03:48 -0800 All reviewed patches have been landed. Closing bug. 121659 2012-01-09 06:26:22 -0800 2012-01-09 06:26:22 -0800 Repro repro.svg image/svg+xml 350 skylined PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPjxzdHlsZT4KICAqIHsKICAg IGJvcmRlci10b3Atc3R5bGU6IGluc2V0CiAgfQo8L3N0eWxlPjxzY3JpcHQ+CiAgd2luZG93Lm9u bG9hZD1mdW5jdGlvbigpIHsKICAgIF9TZWxlY3Rpb25fMD1nZXRTZWxlY3Rpb24oKTsKICAgIF9T ZWxlY3Rpb25fMC5zZXRCYXNlQW5kRXh0ZW50KGRvY3VtZW50LDUsZG9jdW1lbnQsNSk7CiAgICBf U2VsZWN0aW9uXzAuZGVsZXRlRnJvbURvY3VtZW50KCk7CiAgICBfU2VsZWN0aW9uXzAubW9kaWZ5 KCdleHRlbmQnLCdiYWNrd2FyZCcsJ2xpbmUnKTsKICB9Cjwvc2NyaXB0Pgo8dGV4dD48L3RleHQ+ PHRleHQ+IDE= 122495 2012-01-13 13:56:34 -0800 2012-01-13 16:11:36 -0800 Patch bug-75851-20120113165632.patch text/plain 1622 schenney SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNDk4NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAxLTEzICBTdGVwaGVu IENoZW5uZXkgIDxzY2hlbm5leUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTlVMTCBwdHIgaW4g V2ViQ29yZTo6UmVuZGVyU1ZHSW5saW5lVGV4dDo6bG9jYWxDYXJldFJlY3QKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1ODUxCisKKyAgICAgICAgRXZl cnkgaW1wbGVtZW50YXRpb24gb2YgUmVuZGVyT2JqZWN0Ojpsb2NhbENhcmV0UmVjdCBjaGVja3Mg Zm9yIGEgbnVsbAorICAgICAgICBib3gsIGV4Y2VwdCBSZW5kZXJTVkdJbmxpbmVUZXh0LiBUaGlz IHBhdGNoIGFkZHMgdGhlIG51bGwgY2hlY2ssIHdoaWNoIGZpeGVzCisgICAgICAgIGEgQ2hyb21p dW0gY3Jhc2ggKGFuZCBwcm9iYWJseSBvdGhlciBwbGF0Zm9ybXMgdG9vKS4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgSSBj b3VsZCBub3QgcHJvZHVjZSBhIExheW91dFRlc3QgdGhhdCByZXByb2R1Y2VzLgorCisgICAgICAg ICogcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdJbmxpbmVUZXh0LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlclNWR0lubGluZVRleHQ6OmxvY2FsQ2FyZXRSZWN0KTogQWRkIGNoZWNrIGZvciBu dWxsIGJveCBiZWZvcmUgdXNpbmcgdGhlIGJveC4KKwogMjAxMi0wMS0xMyAgQW5kZXJzIENhcmxz c29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIC1bV2ViVGlsZUNhY2hlTGF5ZXIg c2V0TmVlZHNEaXNwbGF5XSBkb2Vzbid0IHRyaWdnZXIgaW52YWxpZGF0aW9uCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1JlbmRlclNWR0lubGluZVRleHQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHSW5saW5lVGV4dC5j cHAJKHJldmlzaW9uIDEwNDk0MikKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVu ZGVyU1ZHSW5saW5lVGV4dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwNiw3ICsxMDYsNyBAQCBJ bmxpbmVUZXh0Qm94KiBSZW5kZXJTVkdJbmxpbmVUZXh0OjpjcmVhCiAKIExheW91dFJlY3QgUmVu ZGVyU1ZHSW5saW5lVGV4dDo6bG9jYWxDYXJldFJlY3QoSW5saW5lQm94KiBib3gsIGludCBjYXJl dE9mZnNldCwgTGF5b3V0VW5pdCopCiB7Ci0gICAgaWYgKCFib3gtPmlzSW5saW5lVGV4dEJveCgp KQorICAgIGlmICghYm94IHx8ICFib3gtPmlzSW5saW5lVGV4dEJveCgpKQogICAgICAgICByZXR1 cm4gTGF5b3V0UmVjdCgpOwogCiAgICAgSW5saW5lVGV4dEJveCogdGV4dEJveCA9IHN0YXRpY19j YXN0PElubGluZVRleHRCb3gqPihib3gpOwo= 122517 2012-01-13 16:11:40 -0800 2012-01-17 13:42:19 -0800 Patch bug-75851-20120113191138.patch text/plain 1620 schenney SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNDk4NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAxLTEzICBTdGVwaGVu IENoZW5uZXkgIDxzY2hlbm5leUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTlVMTCBwdHIgaW4g V2ViQ29yZTo6UmVuZGVyU1ZHSW5saW5lVGV4dDo6bG9jYWxDYXJldFJlY3QKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1ODUxCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgUnlvc3VrZSBOaXdhLgorCisgICAgICAgIEV2ZXJ5IGltcGxlbWVudGF0aW9uIG9m IFJlbmRlck9iamVjdDo6bG9jYWxDYXJldFJlY3QgY2hlY2tzIGZvciBhIG51bGwKKyAgICAgICAg Ym94LCBleGNlcHQgUmVuZGVyU1ZHSW5saW5lVGV4dC4gVGhpcyBwYXRjaCBhZGRzIHRoZSBudWxs IGNoZWNrLCB3aGljaCBmaXhlcworICAgICAgICBhIENocm9taXVtIGNyYXNoIChhbmQgcHJvYmFi bHkgb3RoZXIgcGxhdGZvcm1zIHRvbykuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGFzIEkgY291 bGQgbm90IHByb2R1Y2UgYSBMYXlvdXRUZXN0IHRoYXQgcmVwcm9kdWNlcy4KKworICAgICAgICAq IHJlbmRlcmluZy9zdmcvUmVuZGVyU1ZHSW5saW5lVGV4dC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJTVkdJbmxpbmVUZXh0Ojpsb2NhbENhcmV0UmVjdCk6IEFkZCBjaGVjayBmb3IgbnVs bCBib3ggYmVmb3JlIHVzaW5nIHRoZSBib3guCisKIDIwMTItMDEtMTMgIEFuZGVycyBDYXJsc3Nv biAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICAtW1dlYlRpbGVDYWNoZUxheWVyIHNl dE5lZWRzRGlzcGxheV0gZG9lc24ndCB0cmlnZ2VyIGludmFsaWRhdGlvbgpJbmRleDogU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdJbmxpbmVUZXh0LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1JlbmRlclNWR0lubGluZVRleHQuY3Bw CShyZXZpc2lvbiAxMDQ5NDIpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1JlbmRl clNWR0lubGluZVRleHQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDYsNyArMTA2LDcgQEAgSW5s aW5lVGV4dEJveCogUmVuZGVyU1ZHSW5saW5lVGV4dDo6Y3JlYQogCiBMYXlvdXRSZWN0IFJlbmRl clNWR0lubGluZVRleHQ6OmxvY2FsQ2FyZXRSZWN0KElubGluZUJveCogYm94LCBpbnQgY2FyZXRP ZmZzZXQsIExheW91dFVuaXQqKQogewotICAgIGlmICghYm94LT5pc0lubGluZVRleHRCb3goKSkK KyAgICBpZiAoIWJveCB8fCAhYm94LT5pc0lubGluZVRleHRCb3goKSkKICAgICAgICAgcmV0dXJu IExheW91dFJlY3QoKTsKIAogICAgIElubGluZVRleHRCb3gqIHRleHRCb3ggPSBzdGF0aWNfY2Fz dDxJbmxpbmVUZXh0Qm94Kj4oYm94KTsK 122807 2012-01-17 13:42:23 -0800 2012-01-17 13:59:16 -0800 Patch bug-75851-20120117164222.patch text/plain 3023 schenney SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTE4 OCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAx LTE3ICBTdGVwaGVuIENoZW5uZXkgIDxzY2hlbm5leUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAg TlVMTCBwdHIgaW4gV2ViQ29yZTo6UmVuZGVyU1ZHSW5saW5lVGV4dDo6bG9jYWxDYXJldFJlY3QK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1ODUxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgYSBj aGVjayBmb3IgbnVsbCBib3ggaW4gbG9jYWxDYXJldFJlY3QsIHRvIG1hdGNoIHRlc3QgaW4gb3Ro ZXIKKyAgICAgICAgaW1wbGVtZW50YXRpb25zLiBBZGRpbmcgYSBtYW51YWwgdGVzdCBiZWNhdXNl IHRoZSBjcmFzaCBpcyBub3QKKyAgICAgICAgcmVwcm9kdWNpYmxlIGluIERSVC4KKworICAgICAg ICAqIE1hbnVhbFRlc3RzL3N2Zy1tb2RpZnktZGVsZXRlZC1zZWxlY3Rpb24uc3ZnOiBBZGRlZC4K KwogMjAxMi0wMS0xNyAgUmF1bCBIdWRlYSAgPHJodWRlYUBhZG9iZS5jb20+CiAKICAgICAgICAg TW92ZSB0ZXN0cyBvdXQgb2YgV2ViQ29yZS9tYW51YWwtdGVzdHMgdG8gdG9wbGV2ZWwgTWFudWFs VGVzdHMuCkluZGV4OiBNYW51YWxUZXN0cy9zdmctbW9kaWZ5LWRlbGV0ZWQtc2VsZWN0aW9uLnN2 Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBNYW51YWxUZXN0cy9zdmctbW9kaWZ5LWRlbGV0ZWQtc2VsZWN0aW9u LnN2ZwkocmV2aXNpb24gMCkKKysrIE1hbnVhbFRlc3RzL3N2Zy1tb2RpZnktZGVsZXRlZC1zZWxl Y3Rpb24uc3ZnCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE3IEBACis8c3ZnIGlkPSJib2R5IiB4 bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPgorICA8c3R5bGU+CisgICAgKiB7Cisg ICAgICBib3JkZXItdG9wLXN0eWxlOiBpbnNldAorICAgIH0KKyAgPC9zdHlsZT4KKyAgPHNjcmlw dD4KKyAgICB3aW5kb3cub25jbGljaz1mdW5jdGlvbigpIHsKKyAgICAgIF9TZWxlY3Rpb25fMD1n ZXRTZWxlY3Rpb24oKTsKKyAgICAgIF9TZWxlY3Rpb25fMC5zZXRCYXNlQW5kRXh0ZW50KGRvY3Vt ZW50LDUsZG9jdW1lbnQsNSk7CisgICAgICBfU2VsZWN0aW9uXzAuZGVsZXRlRnJvbURvY3VtZW50 KCk7CisgICAgICBfU2VsZWN0aW9uXzAubW9kaWZ5KCdleHRlbmQnLCdiYWNrd2FyZCcsJ2xpbmUn KTsKKyAgICB9CisgIDwvc2NyaXB0PgorICA8dGV4dCB5PSI1MCIgZm9udC1zaXplPSIyMCIgZmls bD0iZ3JlZW4iPlRlc3QgcGFzc2VzIGlmIHlvdSBjbGljayBhbmQgaXQgZG9lcyBub3QgY3Jhc2gu PC90ZXh0PgorICA8dGV4dD4xPC90ZXh0PgorPC9zdmc+CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lv biAxMDUxODgpCisrKyBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwxOSBAQAorMjAxMi0wMS0xNyAgU3RlcGhlbiBDaGVubmV5ICA8c2NoZW5uZXlAY2hy b21pdW0ub3JnPgorCisgICAgICAgIE5VTEwgcHRyIGluIFdlYkNvcmU6OlJlbmRlclNWR0lubGlu ZVRleHQ6OmxvY2FsQ2FyZXRSZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD03NTg1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFkZGVkIGEgY2hlY2sgZm9yIG51bGwgYm94IGluIGxvY2FsQ2FyZXRSZWN0 LCB0byBtYXRjaCB0ZXN0IGluIG90aGVyCisgICAgICAgIGltcGxlbWVudGF0aW9ucy4gQWRkaW5n IGEgbWFudWFsIHRlc3QgYmVjYXVzZSB0aGUgY3Jhc2ggaXMgbm90IHJlcHJvZHVjaWJsZQorICAg ICAgICBpbiBEUlQuCisKKyAgICAgICAgVGVzdDogTWFudWFsVGVzdHMvc3ZnLW1vZGlmeS1kZWxl dGVkLXNlbGVjdGlvbi5zdmcKKworICAgICAgICAqIHJlbmRlcmluZy9zdmcvUmVuZGVyU1ZHSW5s aW5lVGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJTVkdJbmxpbmVUZXh0Ojpsb2Nh bENhcmV0UmVjdCk6CisKIDIwMTItMDEtMTcgIEFuZHJlYXMgS2xpbmcgIDxhd2Vzb21la2xpbmdA YXBwbGUuY29tPgogCiAgICAgICAgIFNwYWNlU3BsaXRTdHJpbmc6IFNoYXJlIGVxdWl2YWxlbnQg c3RyaW5nIHBpZWNlIHZlY3RvcnMuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3Zn L1JlbmRlclNWR0lubGluZVRleHQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9zdmcvUmVuZGVyU1ZHSW5saW5lVGV4dC5jcHAJKHJldmlzaW9uIDEwNTE2MCkKKysr IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHSW5saW5lVGV4dC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTEzOCw3ICsxMzgsNyBAQCBJbmxpbmVUZXh0Qm94KiBSZW5kZXJTVkdJ bmxpbmVUZXh0OjpjcmVhCiAKIExheW91dFJlY3QgUmVuZGVyU1ZHSW5saW5lVGV4dDo6bG9jYWxD YXJldFJlY3QoSW5saW5lQm94KiBib3gsIGludCBjYXJldE9mZnNldCwgTGF5b3V0VW5pdCopCiB7 Ci0gICAgaWYgKCFib3gtPmlzSW5saW5lVGV4dEJveCgpKQorICAgIGlmICghYm94IHx8ICFib3gt PmlzSW5saW5lVGV4dEJveCgpKQogICAgICAgICByZXR1cm4gTGF5b3V0UmVjdCgpOwogCiAgICAg SW5saW5lVGV4dEJveCogdGV4dEJveCA9IHN0YXRpY19jYXN0PElubGluZVRleHRCb3gqPihib3gp Owo= 122810 2012-01-17 13:59:20 -0800 2012-01-17 15:28:06 -0800 Patch bug-75851-20120117165919.patch text/plain 3002 schenney SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTE4 OCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAx LTE3ICBTdGVwaGVuIENoZW5uZXkgIDxzY2hlbm5leUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAg TlVMTCBwdHIgaW4gV2ViQ29yZTo6UmVuZGVyU1ZHSW5saW5lVGV4dDo6bG9jYWxDYXJldFJlY3QK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1ODUxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgYSBj aGVjayBmb3IgbnVsbCBib3ggaW4gbG9jYWxDYXJldFJlY3QsIHRvIG1hdGNoIHRlc3QgaW4gb3Ro ZXIKKyAgICAgICAgaW1wbGVtZW50YXRpb25zLiBBZGRpbmcgYSBtYW51YWwgdGVzdCBiZWNhdXNl IHRoZSBjcmFzaCBpcyBub3QKKyAgICAgICAgcmVwcm9kdWNpYmxlIGluIERSVC4KKworICAgICAg ICAqIE1hbnVhbFRlc3RzL3N2Zy1tb2RpZnktZGVsZXRlZC1zZWxlY3Rpb24uc3ZnOiBBZGRlZC4K KwogMjAxMi0wMS0xNyAgUmF1bCBIdWRlYSAgPHJodWRlYUBhZG9iZS5jb20+CiAKICAgICAgICAg TW92ZSB0ZXN0cyBvdXQgb2YgV2ViQ29yZS9tYW51YWwtdGVzdHMgdG8gdG9wbGV2ZWwgTWFudWFs VGVzdHMuCkluZGV4OiBNYW51YWxUZXN0cy9zdmctbW9kaWZ5LWRlbGV0ZWQtc2VsZWN0aW9uLnN2 Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBNYW51YWxUZXN0cy9zdmctbW9kaWZ5LWRlbGV0ZWQtc2VsZWN0aW9u LnN2ZwkocmV2aXNpb24gMCkKKysrIE1hbnVhbFRlc3RzL3N2Zy1tb2RpZnktZGVsZXRlZC1zZWxl Y3Rpb24uc3ZnCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE3IEBACis8c3ZnIHhtbG5zPSJodHRw Oi8vd3d3LnczLm9yZy8yMDAwL3N2ZyI+Cis8c3R5bGU+CisgICogeworICAgIGJvcmRlci10b3At c3R5bGU6IGluc2V0CisgIH0KKzwvc3R5bGU+Cis8c2NyaXB0PgorICB3aW5kb3cub25jbGljaz1m dW5jdGlvbigpIHsKKyAgICBfU2VsZWN0aW9uXzA9Z2V0U2VsZWN0aW9uKCk7CisgICAgX1NlbGVj dGlvbl8wLnNldEJhc2VBbmRFeHRlbnQoZG9jdW1lbnQsNSxkb2N1bWVudCw1KTsKKyAgICBfU2Vs ZWN0aW9uXzAuZGVsZXRlRnJvbURvY3VtZW50KCk7CisgICAgX1NlbGVjdGlvbl8wLm1vZGlmeSgn ZXh0ZW5kJywnYmFja3dhcmQnLCdsaW5lJyk7CisgIH0KKzwvc2NyaXB0PgorPHRleHQgeT0iNTAi IGZpbGw9ImdyZWVuIiBmb250LXNpemU9IjIwIj5UZXN0IHBhc3NlcyBpZiBubyBjcmFzaCBvbiBt b3VzZSBjbGljay4gVGV4dCBtYXkgYmUgaGlnaGxpZ2h0ZWQuPC90ZXh0PgorPHRleHQ+IDEgPC90 ZXh0PgorPC9zdmc+CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMDUxODgpCisrKyBTb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0w MS0xNyAgU3RlcGhlbiBDaGVubmV5ICA8c2NoZW5uZXlAY2hyb21pdW0ub3JnPgorCisgICAgICAg IE5VTEwgcHRyIGluIFdlYkNvcmU6OlJlbmRlclNWR0lubGluZVRleHQ6OmxvY2FsQ2FyZXRSZWN0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTg1MQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIGEg Y2hlY2sgZm9yIG51bGwgYm94IGluIGxvY2FsQ2FyZXRSZWN0LCB0byBtYXRjaCB0ZXN0IGluIG90 aGVyCisgICAgICAgIGltcGxlbWVudGF0aW9ucy4gQWRkaW5nIGEgbWFudWFsIHRlc3QgYmVjYXVz ZSB0aGUgY3Jhc2ggaXMgbm90IHJlcHJvZHVjaWJsZQorICAgICAgICBpbiBEUlQuCisKKyAgICAg ICAgVGVzdDogTWFudWFsVGVzdHMvc3ZnLW1vZGlmeS1kZWxldGVkLXNlbGVjdGlvbi5zdmcKKwor ICAgICAgICAqIHJlbmRlcmluZy9zdmcvUmVuZGVyU1ZHSW5saW5lVGV4dC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJTVkdJbmxpbmVUZXh0Ojpsb2NhbENhcmV0UmVjdCk6CisKIDIwMTIt MDEtMTcgIEFuZHJlYXMgS2xpbmcgIDxhd2Vzb21la2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAg IFNwYWNlU3BsaXRTdHJpbmc6IFNoYXJlIGVxdWl2YWxlbnQgc3RyaW5nIHBpZWNlIHZlY3RvcnMu CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1JlbmRlclNWR0lubGluZVRleHQu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZH SW5saW5lVGV4dC5jcHAJKHJldmlzaW9uIDEwNTE2MCkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9zdmcvUmVuZGVyU1ZHSW5saW5lVGV4dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzOCw3 ICsxMzgsNyBAQCBJbmxpbmVUZXh0Qm94KiBSZW5kZXJTVkdJbmxpbmVUZXh0OjpjcmVhCiAKIExh eW91dFJlY3QgUmVuZGVyU1ZHSW5saW5lVGV4dDo6bG9jYWxDYXJldFJlY3QoSW5saW5lQm94KiBi b3gsIGludCBjYXJldE9mZnNldCwgTGF5b3V0VW5pdCopCiB7Ci0gICAgaWYgKCFib3gtPmlzSW5s aW5lVGV4dEJveCgpKQorICAgIGlmICghYm94IHx8ICFib3gtPmlzSW5saW5lVGV4dEJveCgpKQog ICAgICAgICByZXR1cm4gTGF5b3V0UmVjdCgpOwogCiAgICAgSW5saW5lVGV4dEJveCogdGV4dEJv eCA9IHN0YXRpY19jYXN0PElubGluZVRleHRCb3gqPihib3gpOwo= 122824 2012-01-17 15:28:10 -0800 2012-01-17 18:03:43 -0800 Patch bug-75851-20120117182809.patch text/plain 2970 schenney SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTE4 OCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAx LTE3ICBTdGVwaGVuIENoZW5uZXkgIDxzY2hlbm5leUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAg TlVMTCBwdHIgaW4gV2ViQ29yZTo6UmVuZGVyU1ZHSW5saW5lVGV4dDo6bG9jYWxDYXJldFJlY3QK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1ODUxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgUnlvc3VrZSBOaXdhLgorCisgICAgICAgIEFkZGVkIGEgY2hl Y2sgZm9yIG51bGwgYm94IGluIGxvY2FsQ2FyZXRSZWN0LCB0byBtYXRjaCB0ZXN0IGluIG90aGVy CisgICAgICAgIGltcGxlbWVudGF0aW9ucy4gQWRkaW5nIGEgbWFudWFsIHRlc3QgYmVjYXVzZSB0 aGUgY3Jhc2ggaXMgbm90CisgICAgICAgIHJlcHJvZHVjaWJsZSBpbiBEUlQuCisKKyAgICAgICAg KiBNYW51YWxUZXN0cy9zdmctbW9kaWZ5LWRlbGV0ZWQtc2VsZWN0aW9uLnN2ZzogQWRkZWQuCisK IDIwMTItMDEtMTcgIFJhdWwgSHVkZWEgIDxyaHVkZWFAYWRvYmUuY29tPgogCiAgICAgICAgIE1v dmUgdGVzdHMgb3V0IG9mIFdlYkNvcmUvbWFudWFsLXRlc3RzIHRvIHRvcGxldmVsIE1hbnVhbFRl c3RzLgpJbmRleDogTWFudWFsVGVzdHMvc3ZnLW1vZGlmeS1kZWxldGVkLXNlbGVjdGlvbi5zdmcK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTWFudWFsVGVzdHMvc3ZnLW1vZGlmeS1kZWxldGVkLXNlbGVjdGlvbi5z dmcJKHJldmlzaW9uIDApCisrKyBNYW51YWxUZXN0cy9zdmctbW9kaWZ5LWRlbGV0ZWQtc2VsZWN0 aW9uLnN2ZwkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxNiBAQAorPHN2ZyB4bWxucz0iaHR0cDov L3d3dy53My5vcmcvMjAwMC9zdmciPgorPHN0eWxlPgorICAqIHsKKyAgICBib3JkZXItdG9wLXN0 eWxlOiBpbnNldAorICB9Cis8L3N0eWxlPgorPHNjcmlwdD4KKyAgd2luZG93Lm9uY2xpY2s9ZnVu Y3Rpb24oKSB7CisgICAgZ2V0U2VsZWN0aW9uKCkuc2V0QmFzZUFuZEV4dGVudChkb2N1bWVudCw1 LGRvY3VtZW50LDUpOworICAgIGdldFNlbGVjdGlvbigpLmRlbGV0ZUZyb21Eb2N1bWVudCgpOwor ICAgIGdldFNlbGVjdGlvbigpLm1vZGlmeSgnZXh0ZW5kJywnYmFja3dhcmQnLCdsaW5lJyk7Cisg IH0KKzwvc2NyaXB0PgorPHRleHQgeT0iNTAiIGZpbGw9ImdyZWVuIiBmb250LXNpemU9IjIwIj5U ZXN0IHBhc3NlcyBpZiBubyBjcmFzaCBvbiBtb3VzZSBjbGljay4gVGV4dCBtYXkgYmUgaGlnaGxp Z2h0ZWQuPC90ZXh0PgorPHRleHQ+IDEgPC90ZXh0PgorPC9zdmc+CkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCShy ZXZpc2lvbiAxMDUxODgpCisrKyBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w eSkKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0wMS0xNyAgU3RlcGhlbiBDaGVubmV5ICA8c2NoZW5u ZXlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIE5VTEwgcHRyIGluIFdlYkNvcmU6OlJlbmRlclNW R0lubGluZVRleHQ6OmxvY2FsQ2FyZXRSZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03NTg1MQorCisgICAgICAgIFJldmlld2VkIGJ5IFJ5b3N1a2Ug Tml3YS4KKworICAgICAgICBBZGRlZCBhIGNoZWNrIGZvciBudWxsIGJveCBpbiBsb2NhbENhcmV0 UmVjdCwgdG8gbWF0Y2ggdGVzdCBpbiBvdGhlcgorICAgICAgICBpbXBsZW1lbnRhdGlvbnMuIEFk ZGluZyBhIG1hbnVhbCB0ZXN0IGJlY2F1c2UgdGhlIGNyYXNoIGlzIG5vdCByZXByb2R1Y2libGUK KyAgICAgICAgaW4gRFJULgorCisgICAgICAgIFRlc3Q6IE1hbnVhbFRlc3RzL3N2Zy1tb2RpZnkt ZGVsZXRlZC1zZWxlY3Rpb24uc3ZnCisKKyAgICAgICAgKiByZW5kZXJpbmcvc3ZnL1JlbmRlclNW R0lubGluZVRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyU1ZHSW5saW5lVGV4dDo6 bG9jYWxDYXJldFJlY3QpOgorCiAyMDEyLTAxLTE3ICBBbmRyZWFzIEtsaW5nICA8YXdlc29tZWts aW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBTcGFjZVNwbGl0U3RyaW5nOiBTaGFyZSBlcXVpdmFs ZW50IHN0cmluZyBwaWVjZSB2ZWN0b3JzLgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L3N2Zy9SZW5kZXJTVkdJbmxpbmVUZXh0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvc3ZnL1JlbmRlclNWR0lubGluZVRleHQuY3BwCShyZXZpc2lvbiAxMDUxNjAp CisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1JlbmRlclNWR0lubGluZVRleHQuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0xMzgsNyArMTM4LDcgQEAgSW5saW5lVGV4dEJveCogUmVuZGVy U1ZHSW5saW5lVGV4dDo6Y3JlYQogCiBMYXlvdXRSZWN0IFJlbmRlclNWR0lubGluZVRleHQ6Omxv Y2FsQ2FyZXRSZWN0KElubGluZUJveCogYm94LCBpbnQgY2FyZXRPZmZzZXQsIExheW91dFVuaXQq KQogewotICAgIGlmICghYm94LT5pc0lubGluZVRleHRCb3goKSkKKyAgICBpZiAoIWJveCB8fCAh Ym94LT5pc0lubGluZVRleHRCb3goKSkKICAgICAgICAgcmV0dXJuIExheW91dFJlY3QoKTsKIAog ICAgIElubGluZVRleHRCb3gqIHRleHRCb3ggPSBzdGF0aWNfY2FzdDxJbmxpbmVUZXh0Qm94Kj4o Ym94KTsK