75827 2012-01-08 22:54:11 -0800 Build fix: ScrollAnimatorMac has missing initializer in systemUptime() 2012-01-08 23:15:31 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin webkit.review.bot oldest_to_newest 531989 0 benjamin 2012-01-08 22:54:11 -0800 I have this local fix on my laptop. I don't know why I am the only one with the issue, on only on this particular computer... Here is error I get without the patch: /Users/benjamin/dev/WebKit.git/Source/WebCore/platform/mac/ScrollAnimatorMac.mm: In function 'NSTimeInterval systemUptime()': /Users/benjamin/dev/WebKit.git/Source/WebCore/platform/mac/ScrollAnimatorMac.mm:85: warning: missing initializer for member 'timeval::tv_sec' /Users/benjamin/dev/WebKit.git/Source/WebCore/platform/mac/ScrollAnimatorMac.mm:85: warning: missing initializer for member 'timeval::tv_usec' Anyway, the fix seems harmless so I might as well share.... 531992 1 121621 benjamin 2012-01-08 22:57:52 -0800 Created attachment 121621 Patch 531995 2 121621 darin 2012-01-08 23:00:49 -0800 Comment on attachment 121621 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121621&action=review > Source/WebCore/platform/mac/ScrollAnimatorMac.mm:85 > + static struct timeval boottime = {0, 0}; Since statics are initialized to zero anyway, this could instead just be: static struct timeval boottime; 532000 3 121621 webkit.review.bot 2012-01-08 23:15:27 -0800 Comment on attachment 121621 Patch Clearing flags on attachment: 121621 Committed r104435: <http://trac.webkit.org/changeset/104435> 532001 4 webkit.review.bot 2012-01-08 23:15:31 -0800 All reviewed patches have been landed. Closing bug. 121621 2012-01-08 22:57:52 -0800 2012-01-08 23:15:27 -0800 Patch bug-75827-20120108225748.patch text/plain 1532 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0NDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTZhMmQ4YTNkMjg0NWYy ZTlhMzliMjI0NWNmN2ZjMjNkMTU4YzcxNC4uYzM4YWE1MzY4ZWQzOWVmMzkzNjgzYjY1OWRmMjM5 YmRmNDdjYjM2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAxLTA4ICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBCdWlsZCBmaXg6 IFNjcm9sbEFuaW1hdG9yTWFjIGhhcyBtaXNzaW5nIGluaXRpYWxpemVyIGluIHN5c3RlbVVwdGlt ZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTgy NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4cGxp Y2l0bHkgaW5pdGlhbGl6ZSB0aGUgc3RydWN0IHRpbWV2YWwgdG8gYXZvaWQgY29tcGlsZXIgd2Fy bmluZ3MuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvU2Nyb2xsQW5pbWF0b3JNYWMubW06Cisg ICAgICAgIChzeXN0ZW1VcHRpbWUpOgorCiAyMDEyLTAxLTA4ICBMZW8gWWFuZyAgPGxlby55YW5n QHRvcmNobW9iaWxlLmNvbS5jbj4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gVXNlIHRoZSBjb25j cmV0ZSBGcmFtZU5ldHdvcmtpbmdDb250ZXh0QmxhY2tCZXJyeSB0byBhY2Nlc3MgRnJhbWUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxBbmltYXRvck1hYy5t bSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxBbmltYXRvck1hYy5tbQppbmRl eCBhNzhiNTI0MzcxNmMzY2I4YjdjZWM2MDZkOTIxYjhkOWQwYTM1NmUzLi40MDExZjMzZTg1Mzc2 OWQ0NDBjZDc1M2Q2MGNiNzk4NDM2MTUyNmU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9tYWMvU2Nyb2xsQW5pbWF0b3JNYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFjLm1tCkBAIC04Miw3ICs4Miw3IEBAIHN0YXRpYyBO U1RpbWVJbnRlcnZhbCBzeXN0ZW1VcHRpbWUoKQogICAgICAgICByZXR1cm4gW1tOU1Byb2Nlc3NJ bmZvIHByb2Nlc3NJbmZvXSBzeXN0ZW1VcHRpbWVdOwogCiAgICAgLy8gR2V0IGhvdyBsb25nIHN5 c3RlbSBoYXMgYmVlbiB1cC4gRm91bmQgYnkgbG9va2luZyBnZXR0aW5nICJib290dGltZSIgZnJv bSB0aGUga2VybmVsLgotICAgIHN0YXRpYyBzdHJ1Y3QgdGltZXZhbCBib290dGltZSA9IHt9Owor ICAgIHN0YXRpYyBzdHJ1Y3QgdGltZXZhbCBib290dGltZSA9IHswLCAwfTsKICAgICBpZiAoIWJv b3R0aW1lLnR2X3NlYykgewogICAgICAgICBpbnQgbWliWzJdID0ge0NUTF9LRVJOLCBLRVJOX0JP T1RUSU1FfTsKICAgICAgICAgc2l6ZV90IHNpemUgPSBzaXplb2YoYm9vdHRpbWUpOwo=