75787 2012-01-07 16:01:43 -0800 Layout Test fast/text/international/spaces-combined-in-vertical-text.html is failing 2012-01-19 10:05:53 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dslomov kenrb hyatt inferno kenrb mitz pnormand simon.fraser webkit.review.bot oldest_to_newest 531696 0 dslomov 2012-01-07 16:01:43 -0800 The following layout test is failing (timing out) on chromium-linux, chromium-mac fast/text/international/spaces-combined-in-vertical-text.html Probable cause: http://trac.webkit.org/changeset/104322. 531953 1 inferno 2012-01-08 21:30:38 -0800 Did anyone rollout his patch or landed a test expectations update ?? Are you sure it is his patch, because cq landed it and chrome bots look green. Me and him are both on vacation this week. Ken, should take a look at this early next week. 532312 2 ap 2012-01-09 10:50:34 -0800 *** Bug 75833 has been marked as a duplicate of this bug. *** 532314 3 ap 2012-01-09 10:51:04 -0800 *** Bug 75752 has been marked as a duplicate of this bug. *** 538708 4 123129 kenrb 2012-01-19 07:54:44 -0800 Created attachment 123129 Patch 538714 5 kenrb 2012-01-19 07:58:36 -0800 The test is the one that I added in r104322, but the problem is that in the patch I was sloppy with handling loop iteration in skipLeadingWhitespace. I think the fix is fairly straightforward. ap do you care to review? 538730 6 simon.fraser 2012-01-19 08:30:23 -0800 *** Bug 76554 has been marked as a duplicate of this bug. *** 538741 7 kenrb 2012-01-19 08:45:23 -0800 smfr can you review this? I don't know that I need to be picky about the reviewer, it's just a logic fix to prevent getting stuck in that loop. 538781 8 123129 webkit.review.bot 2012-01-19 10:05:48 -0800 Comment on attachment 123129 Patch Clearing flags on attachment: 123129 Committed r105423: <http://trac.webkit.org/changeset/105423> 538782 9 webkit.review.bot 2012-01-19 10:05:53 -0800 All reviewed patches have been landed. Closing bug. 123129 2012-01-19 07:54:44 -0800 2012-01-19 10:05:48 -0800 Patch bug-75787-20120119105320.patch text/plain 2283 kenrb U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1MjI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKb2xkIG1vZGUgMTAwNjQ0Cm5ldyBt b2RlIDEwMDc1NQppbmRleCAzYWNjMWU3NGM3ZDMyNGZlMGM0MzUyNWZlZWJlOThmNmNkOWJlY2Yz Li41MTdjMTg1Y2I1OGI1M2U2ZjJkOTRkMjIwNDcyYmUyOTFmNDM3ZmM5Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwyMSBAQAorMjAxMi0wMS0xOSAgS2VuIEJ1Y2hhbmFuIDxrZW5yYkBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgTGF5b3V0IFRlc3QgZmFzdC90ZXh0L2ludGVybmF0aW9uYWwvc3BhY2VzLWNvbWJp bmVkLWluLXZlcnRpY2FsLXRleHQuaHRtbCBpcyBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTc4NworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgYSB0d2VhayB0byBteSBwYXRjaCBp biByMTA0MzIyLiBPbiBzb21lIHBsYXRmb3JtcworICAgICAgICBSZW5kZXJDb21iaW5lVGV4dDo6 Y29tYmluZVRleHQoKSBjYW4gYWJvcnQgZWFybHkgZHVyaW5nIGlubGluZQorICAgICAgICBpdGVy YXRpb24sIGNhdXNpbmcgdGhpcyBsb29wIGluIHNraXBMZWFkaW5nV2hpdGVzcGFjZSB0byBzcGlu LAorICAgICAgICBoZW5jZSB0aGUgbGF5b3V0IHRlc3QgdGltZW91dHMuIFRoaXMgcGF0Y2ggYWNj b3VudHMgZm9yIHRoYXQKKyAgICAgICAgY29uZGl0aW9uIGFuZCBtYWtlcyB0aGUgbG9vcCBpdGVy YXRpb24gbW9yZSByb2J1c3QuCisKKyAgICAgICAgTm8gbmV3IHRlc3QgYmVjYXVzZSB0aGlzIGlz IGZpeGluZyBhIGZhaWx1cmUgb24gYW4gZXhpc3RpbmcgdGVzdC4KKworICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy QmxvY2s6OkxpbmVCcmVha2VyOjpza2lwTGVhZGluZ1doaXRlc3BhY2UpOgorCiAyMDEyLTAxLTE3 ICBOYXRlIENoYXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRW5zdXJlIHdl IGRvbid0IGNhbmNlbCByZXZhbGlkYXRpb24gb2YgYSBDYWNoZWRSZXNvdXJjZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcAppbmRleCBi NWE4NjYxOGI2OWJlMmI4NzZjZWVkYzJkZGJjZDFjYTU5OWU3MzYxLi4zOGY2MWFjZGViZDM1M2I0 ODFlZDYxMzJhY2ZhOTAwMDUxOGI1YmMzIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcApAQCAtMTg5Myw5ICsxODkzLDEwIEBAIHZv aWQgUmVuZGVyQmxvY2s6OkxpbmVCcmVha2VyOjpza2lwTGVhZGluZ1doaXRlc3BhY2UoSW5saW5l QmlkaVJlc29sdmVyJiByZXNvbHZlCiAgICAgICAgICAgICB9CiAgICAgICAgIH0gZWxzZSBpZiAo b2JqZWN0LT5pc0Zsb2F0aW5nKCkpCiAgICAgICAgICAgICBtX2Jsb2NrLT5wb3NpdGlvbk5ld0Zs b2F0T25MaW5lKG1fYmxvY2stPmluc2VydEZsb2F0aW5nT2JqZWN0KHRvUmVuZGVyQm94KG9iamVj dCkpLCBsYXN0RmxvYXRGcm9tUHJldmlvdXNMaW5lLCBsaW5lSW5mbywgd2lkdGgpOwotICAgICAg ICBlbHNlIGlmIChvYmplY3QtPmlzVGV4dCgpICYmIG9iamVjdC0+c3R5bGUoKS0+aGFzVGV4dENv bWJpbmUoKSAmJiBvYmplY3QtPmlzQ29tYmluZVRleHQoKSkgeworICAgICAgICBlbHNlIGlmIChv YmplY3QtPmlzVGV4dCgpICYmIG9iamVjdC0+c3R5bGUoKS0+aGFzVGV4dENvbWJpbmUoKSAmJiBv YmplY3QtPmlzQ29tYmluZVRleHQoKSAmJiAhdG9SZW5kZXJDb21iaW5lVGV4dChvYmplY3QpLT5p c0NvbWJpbmVkKCkpIHsKICAgICAgICAgICAgIHRvUmVuZGVyQ29tYmluZVRleHQob2JqZWN0KS0+ Y29tYmluZVRleHQoKTsKLSAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICAgICAgaWYgKHRv UmVuZGVyQ29tYmluZVRleHQob2JqZWN0KS0+aXNDb21iaW5lZCgpKQorICAgICAgICAgICAgICAg IGNvbnRpbnVlOwogICAgICAgICB9CiAgICAgICAgIHJlc29sdmVyLmluY3JlbWVudCgpOwogICAg IH0K