75783 2012-01-07 13:44:27 -0800 [Chromium] REGRESSION(r104368): Broke CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers 2012-01-09 16:12:37 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dslomov wjmaclean dslomov jamesr webkit.review.bot wjmaclean oldest_to_newest 531688 0 dslomov 2012-01-07 13:44:27 -0800 Build with the break: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux%2032/builds/11207. 532204 1 wjmaclean 2012-01-09 08:01:39 -0800 I think this is my fault, I forgot to update this test as part of my tile culling patch - sorry. The test expectations for this test need to be modified (layer1 should now *not* draw once the opaque layer2 is added, since it is completely occluded by layer2 and thus gets culled). I'll submit a patch this morning, plus add another test case just to confirm that layer1 does draw if layer2 becomes non-opaque. 532346 2 121697 wjmaclean 2012-01-09 11:17:38 -0800 Created attachment 121697 Patch 532367 3 121702 wjmaclean 2012-01-09 11:32:42 -0800 Created attachment 121702 Patch 532368 4 wjmaclean 2012-01-09 11:33:13 -0800 Removed "FAILS_". 532548 5 121702 jamesr 2012-01-09 15:04:33 -0800 Comment on attachment 121702 Patch R=me. I'm surprised EWS bots don't run webkit_unit_tests, will look into that. 532607 6 121702 webkit.review.bot 2012-01-09 16:12:33 -0800 Comment on attachment 121702 Patch Clearing flags on attachment: 121702 Committed r104505: <http://trac.webkit.org/changeset/104505> 532608 7 webkit.review.bot 2012-01-09 16:12:37 -0800 All reviewed patches have been landed. Closing bug. 121697 2012-01-09 11:17:38 -0800 2012-01-09 11:32:38 -0800 Patch bug-75783-20120109141737.patch text/plain 3003 wjmaclean U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0NDYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGVlZmMyZjkxM2MyYTNhNWNjYjRiZmZiZDg4YmY3OThjZTEzZmI0YTUuLmY1Njg5YjYxMjYwYzFh OTI2ZDI3MTRiNTgwODU3OTUyNzNhN2M5MzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDEtMDkgIFcuIEphbWVzIE1hY0xlYW4gIDx3am1hY2xlYW5A Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gUkVHUkVTU0lPTihyMTA0MzY4KTog QnJva2UgQ0NMYXllclRyZWVIb3N0SW1wbFRlc3QuYmxlbmRpbmdPZmZXaGVuRHJhd2luZ09wYXF1 ZUxheWVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzU3ODMKKworICAgICAgICBVcGRhdGVkIHVuaXQgdGVzdCB0byByZWZsZWN0IGRlc2lyZWQgYmVo YXZpb3VyIG5vdyB0aGF0IHRpbGUvcXVhZCBjdWxsaW5nCisgICAgICAgIGlzIGltcGxlbWVudGVk LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogdGVz dHMvQ0NMYXllclRyZWVIb3N0SW1wbFRlc3QuY3BwOgorICAgICAgICAoV2ViS2l0OjpURVNUX0Yp OgorCiAyMDEyLTAxLTA5ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNv bT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTA0NDE4LgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RJbXBsVGVzdC5j cHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdEltcGxUZXN0 LmNwcAppbmRleCBmNWI4ZGIyZTUwMmVlZDRlZjNiZDY0NmYyYjZjYzBjNGRhN2MzZjg0Li43ZDlm ZjljNmI5OGFkMzg4YTUxMmRlOTk3OTRkOTk0MmEyNThiZjUyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdEltcGxUZXN0LmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdEltcGxUZXN0LmNwcApA QCAtMjY0LDcgKzI2NCw3IEBAIFRFU1RfRihDQ0xheWVyVHJlZUhvc3RJbXBsVGVzdCwgRkFJTFNf YmxlbmRpbmdPZmZXaGVuRHJhd2luZ09wYXF1ZUxheWVycykKICAgICBsYXllcjItPnNldE9wYWNp dHkoMSk7CiAgICAgbGF5ZXIyLT5zZXRFeHBlY3RhdGlvbihmYWxzZSwgZmFsc2UpOwogICAgIG1f aG9zdEltcGwtPmRyYXdMYXllcnMoKTsKLSAgICBFWFBFQ1RfVFJVRShsYXllcjEtPmRyYXduKCkp OworICAgIEVYUEVDVF9GQUxTRShsYXllcjEtPmRyYXduKCkpOwogICAgIEVYUEVDVF9UUlVFKGxh eWVyMi0+ZHJhd24oKSk7CiAKICAgICAvLyBQYXJlbnQgbGF5ZXIgd2l0aCB0cmFuc2x1Y2VudCBj b250ZW50LCBkcmF3biB3aXRoIGJsZW5kaW5nLgpAQCAtMjczLDcgKzI3Myw3IEBAIFRFU1RfRihD Q0xheWVyVHJlZUhvc3RJbXBsVGVzdCwgRkFJTFNfYmxlbmRpbmdPZmZXaGVuRHJhd2luZ09wYXF1 ZUxheWVycykKICAgICBsYXllcjEtPnNldEV4cGVjdGF0aW9uKHRydWUsIGZhbHNlKTsKICAgICBs YXllcjItPnNldEV4cGVjdGF0aW9uKGZhbHNlLCBmYWxzZSk7CiAgICAgbV9ob3N0SW1wbC0+ZHJh d0xheWVycygpOwotICAgIEVYUEVDVF9UUlVFKGxheWVyMS0+ZHJhd24oKSk7CisgICAgRVhQRUNU X0ZBTFNFKGxheWVyMS0+ZHJhd24oKSk7CiAgICAgRVhQRUNUX1RSVUUobGF5ZXIyLT5kcmF3bigp KTsKIAogICAgIC8vIFBhcmVudCBsYXllciB3aXRoIHRyYW5zbHVjZW50IG9wYWNpdHkgYW5kIG9w YXF1ZSBjb250ZW50LiBTaW5jZSBpdCBoYXMgYQpAQCAtMjg2LDYgKzI4NiwyOSBAQCBURVNUX0Yo Q0NMYXllclRyZWVIb3N0SW1wbFRlc3QsIEZBSUxTX2JsZW5kaW5nT2ZmV2hlbkRyYXdpbmdPcGFx dWVMYXllcnMpCiAgICAgbGF5ZXIxLT5zZXRFeHBlY3RhdGlvbihmYWxzZSwgdHJ1ZSk7CiAgICAg bGF5ZXIyLT5zZXRFeHBlY3RhdGlvbihmYWxzZSwgZmFsc2UpOwogICAgIG1faG9zdEltcGwtPmRy YXdMYXllcnMoKTsKKyAgICBFWFBFQ1RfRkFMU0UobGF5ZXIxLT5kcmF3bigpKTsKKyAgICBFWFBF Q1RfVFJVRShsYXllcjItPmRyYXduKCkpOworCisgICAgLy8gRHJhdyBhZ2FpbiwgYnV0IHdpdGgg Y2hpbGQgbm9uLW9wYXF1ZSwgdG8gbWFrZSBzdXJlCisgICAgLy8gbGF5ZXIxIG5vdCBjdWxsZWQu CisgICAgbGF5ZXIxLT5zZXRPcGFxdWUodHJ1ZSk7CisgICAgbGF5ZXIxLT5zZXRPcGFjaXR5KDEp OworICAgIGxheWVyMS0+c2V0RXhwZWN0YXRpb24oZmFsc2UsIGZhbHNlKTsKKyAgICBsYXllcjIt PnNldE9wYXF1ZSh0cnVlKTsKKyAgICBsYXllcjItPnNldE9wYWNpdHkoMC41KTsKKyAgICBsYXll cjItPnNldEV4cGVjdGF0aW9uKHRydWUsIGZhbHNlKTsKKyAgICBtX2hvc3RJbXBsLT5kcmF3TGF5 ZXJzKCk7CisgICAgRVhQRUNUX1RSVUUobGF5ZXIxLT5kcmF3bigpKTsKKyAgICBFWFBFQ1RfVFJV RShsYXllcjItPmRyYXduKCkpOworCisgICAgLy8gQSBzZWNvbmQgd2F5IG9mIG1ha2luZyB0aGUg Y2hpbGQgbm9uLW9wYXF1ZS4KKyAgICBsYXllcjEtPnNldE9wYXF1ZSh0cnVlKTsKKyAgICBsYXll cjEtPnNldE9wYWNpdHkoMSk7CisgICAgbGF5ZXIxLT5zZXRFeHBlY3RhdGlvbihmYWxzZSwgZmFs c2UpOworICAgIGxheWVyMi0+c2V0T3BhcXVlKGZhbHNlKTsKKyAgICBsYXllcjItPnNldE9wYWNp dHkoMSk7CisgICAgbGF5ZXIyLT5zZXRFeHBlY3RhdGlvbih0cnVlLCBmYWxzZSk7CisgICAgbV9o b3N0SW1wbC0+ZHJhd0xheWVycygpOwogICAgIEVYUEVDVF9UUlVFKGxheWVyMS0+ZHJhd24oKSk7 CiAgICAgRVhQRUNUX1RSVUUobGF5ZXIyLT5kcmF3bigpKTsKIH0K 121702 2012-01-09 11:32:42 -0800 2012-01-09 16:12:33 -0800 Patch bug-75783-20120109143241.patch text/plain 3526 wjmaclean U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0NDYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGVlZmMyZjkxM2MyYTNhNWNjYjRiZmZiZDg4YmY3OThjZTEzZmI0YTUuLmY1Njg5YjYxMjYwYzFh OTI2ZDI3MTRiNTgwODU3OTUyNzNhN2M5MzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDEtMDkgIFcuIEphbWVzIE1hY0xlYW4gIDx3am1hY2xlYW5A Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gUkVHUkVTU0lPTihyMTA0MzY4KTog QnJva2UgQ0NMYXllclRyZWVIb3N0SW1wbFRlc3QuYmxlbmRpbmdPZmZXaGVuRHJhd2luZ09wYXF1 ZUxheWVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzU3ODMKKworICAgICAgICBVcGRhdGVkIHVuaXQgdGVzdCB0byByZWZsZWN0IGRlc2lyZWQgYmVo YXZpb3VyIG5vdyB0aGF0IHRpbGUvcXVhZCBjdWxsaW5nCisgICAgICAgIGlzIGltcGxlbWVudGVk LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogdGVz dHMvQ0NMYXllclRyZWVIb3N0SW1wbFRlc3QuY3BwOgorICAgICAgICAoV2ViS2l0OjpURVNUX0Yp OgorCiAyMDEyLTAxLTA5ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNv bT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTA0NDE4LgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RJbXBsVGVzdC5j cHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdEltcGxUZXN0 LmNwcAppbmRleCBmNWI4ZGIyZTUwMmVlZDRlZjNiZDY0NmYyYjZjYzBjNGRhN2MzZjg0Li5iY2Uz Yjk2ZmI4YzBlMGU4NmExOWJjNTkyMmFkZGI3MGEwZTU2MDA4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdEltcGxUZXN0LmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdEltcGxUZXN0LmNwcApA QCAtMjE4LDcgKzIxOCw3IEBAIHByaXZhdGU6CiB9OwogCiAvLyBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU3ODMKLVRFU1RfRihDQ0xheWVyVHJlZUhvc3RJbXBsVGVz dCwgRkFJTFNfYmxlbmRpbmdPZmZXaGVuRHJhd2luZ09wYXF1ZUxheWVycykKK1RFU1RfRihDQ0xh eWVyVHJlZUhvc3RJbXBsVGVzdCwgYmxlbmRpbmdPZmZXaGVuRHJhd2luZ09wYXF1ZUxheWVycykK IHsKICAgICBHcmFwaGljc0NvbnRleHQzRDo6QXR0cmlidXRlcyBhdHRyczsKICAgICBSZWZQdHI8 R3JhcGhpY3NDb250ZXh0M0Q+IGNvbnRleHQgPSBHcmFwaGljc0NvbnRleHQzRFByaXZhdGU6OmNy ZWF0ZUdyYXBoaWNzQ29udGV4dEZyb21XZWJDb250ZXh0KGFkb3B0UHRyKG5ldyBCbGVuZFN0YXRl VHJhY2tlckNvbnRleHQoKSksIGF0dHJzLCAwLCBHcmFwaGljc0NvbnRleHQzRDo6UmVuZGVyRGly ZWN0bHlUb0hvc3RXaW5kb3csIEdyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZTo6Rm9yVXNlT25UaGlz VGhyZWFkKTsKQEAgLTI2NCw3ICsyNjQsNyBAQCBURVNUX0YoQ0NMYXllclRyZWVIb3N0SW1wbFRl c3QsIEZBSUxTX2JsZW5kaW5nT2ZmV2hlbkRyYXdpbmdPcGFxdWVMYXllcnMpCiAgICAgbGF5ZXIy LT5zZXRPcGFjaXR5KDEpOwogICAgIGxheWVyMi0+c2V0RXhwZWN0YXRpb24oZmFsc2UsIGZhbHNl KTsKICAgICBtX2hvc3RJbXBsLT5kcmF3TGF5ZXJzKCk7Ci0gICAgRVhQRUNUX1RSVUUobGF5ZXIx LT5kcmF3bigpKTsKKyAgICBFWFBFQ1RfRkFMU0UobGF5ZXIxLT5kcmF3bigpKTsKICAgICBFWFBF Q1RfVFJVRShsYXllcjItPmRyYXduKCkpOwogCiAgICAgLy8gUGFyZW50IGxheWVyIHdpdGggdHJh bnNsdWNlbnQgY29udGVudCwgZHJhd24gd2l0aCBibGVuZGluZy4KQEAgLTI3Myw3ICsyNzMsNyBA QCBURVNUX0YoQ0NMYXllclRyZWVIb3N0SW1wbFRlc3QsIEZBSUxTX2JsZW5kaW5nT2ZmV2hlbkRy YXdpbmdPcGFxdWVMYXllcnMpCiAgICAgbGF5ZXIxLT5zZXRFeHBlY3RhdGlvbih0cnVlLCBmYWxz ZSk7CiAgICAgbGF5ZXIyLT5zZXRFeHBlY3RhdGlvbihmYWxzZSwgZmFsc2UpOwogICAgIG1faG9z dEltcGwtPmRyYXdMYXllcnMoKTsKLSAgICBFWFBFQ1RfVFJVRShsYXllcjEtPmRyYXduKCkpOwor ICAgIEVYUEVDVF9GQUxTRShsYXllcjEtPmRyYXduKCkpOwogICAgIEVYUEVDVF9UUlVFKGxheWVy Mi0+ZHJhd24oKSk7CiAKICAgICAvLyBQYXJlbnQgbGF5ZXIgd2l0aCB0cmFuc2x1Y2VudCBvcGFj aXR5IGFuZCBvcGFxdWUgY29udGVudC4gU2luY2UgaXQgaGFzIGEKQEAgLTI4Niw2ICsyODYsMjkg QEAgVEVTVF9GKENDTGF5ZXJUcmVlSG9zdEltcGxUZXN0LCBGQUlMU19ibGVuZGluZ09mZldoZW5E cmF3aW5nT3BhcXVlTGF5ZXJzKQogICAgIGxheWVyMS0+c2V0RXhwZWN0YXRpb24oZmFsc2UsIHRy dWUpOwogICAgIGxheWVyMi0+c2V0RXhwZWN0YXRpb24oZmFsc2UsIGZhbHNlKTsKICAgICBtX2hv c3RJbXBsLT5kcmF3TGF5ZXJzKCk7CisgICAgRVhQRUNUX0ZBTFNFKGxheWVyMS0+ZHJhd24oKSk7 CisgICAgRVhQRUNUX1RSVUUobGF5ZXIyLT5kcmF3bigpKTsKKworICAgIC8vIERyYXcgYWdhaW4s IGJ1dCB3aXRoIGNoaWxkIG5vbi1vcGFxdWUsIHRvIG1ha2Ugc3VyZQorICAgIC8vIGxheWVyMSBu b3QgY3VsbGVkLgorICAgIGxheWVyMS0+c2V0T3BhcXVlKHRydWUpOworICAgIGxheWVyMS0+c2V0 T3BhY2l0eSgxKTsKKyAgICBsYXllcjEtPnNldEV4cGVjdGF0aW9uKGZhbHNlLCBmYWxzZSk7Cisg ICAgbGF5ZXIyLT5zZXRPcGFxdWUodHJ1ZSk7CisgICAgbGF5ZXIyLT5zZXRPcGFjaXR5KDAuNSk7 CisgICAgbGF5ZXIyLT5zZXRFeHBlY3RhdGlvbih0cnVlLCBmYWxzZSk7CisgICAgbV9ob3N0SW1w bC0+ZHJhd0xheWVycygpOworICAgIEVYUEVDVF9UUlVFKGxheWVyMS0+ZHJhd24oKSk7CisgICAg RVhQRUNUX1RSVUUobGF5ZXIyLT5kcmF3bigpKTsKKworICAgIC8vIEEgc2Vjb25kIHdheSBvZiBt YWtpbmcgdGhlIGNoaWxkIG5vbi1vcGFxdWUuCisgICAgbGF5ZXIxLT5zZXRPcGFxdWUodHJ1ZSk7 CisgICAgbGF5ZXIxLT5zZXRPcGFjaXR5KDEpOworICAgIGxheWVyMS0+c2V0RXhwZWN0YXRpb24o ZmFsc2UsIGZhbHNlKTsKKyAgICBsYXllcjItPnNldE9wYXF1ZShmYWxzZSk7CisgICAgbGF5ZXIy LT5zZXRPcGFjaXR5KDEpOworICAgIGxheWVyMi0+c2V0RXhwZWN0YXRpb24odHJ1ZSwgZmFsc2Up OworICAgIG1faG9zdEltcGwtPmRyYXdMYXllcnMoKTsKICAgICBFWFBFQ1RfVFJVRShsYXllcjEt PmRyYXduKCkpOwogICAgIEVYUEVDVF9UUlVFKGxheWVyMi0+ZHJhd24oKSk7CiB9Cg==