75773 2012-01-07 01:28:49 -0800 [GTK] Enable requestAnimationFrame in build-webkit 2012-01-09 00:55:07 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 zan webkit-unassigned mrobinson rniwa webkit.review.bot oldest_to_newest 531626 0 zan 2012-01-07 01:28:49 -0800 requestAnimationFrame should be enabled in the developer builds for the Gtk port. Currently the timer-based implementation will be used, but should be replaced by a more complete solution (vsync-like). All the relevant layout tests pass, except for a test that utilizes modal dialogs, for which the Gtk port does not have support yet. After the patch lands, clean builds will be required on the bots. 531628 1 121543 zan 2012-01-07 01:41:37 -0800 Created attachment 121543 Patch Enable the feature and unskip the passing tests. 531629 2 zan 2012-01-07 01:45:57 -0800 Requesting a review. 531659 3 121543 webkit.review.bot 2012-01-07 09:18:30 -0800 Comment on attachment 121543 Patch Clearing flags on attachment: 121543 Committed r104386: <http://trac.webkit.org/changeset/104386> 531660 4 webkit.review.bot 2012-01-07 09:18:34 -0800 All reviewed patches have been landed. Closing bug. 531860 5 rniwa 2012-01-08 16:09:12 -0800 It seems like this patch broke GTK+ builds: http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/20601 532028 6 zan 2012-01-09 00:55:07 -0800 (In reply to comment #5) > It seems like this patch broke GTK+ builds: > http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/20601 It probably did as a clean build is required. I do not have access to the linked buildbot, though, but I'm sure someone will poke it today. 121543 2012-01-07 01:41:37 -0800 2012-01-07 09:18:30 -0800 Patch bug-75773-20120107104135.patch text/plain 3184 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0MzYxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjU5ZjgyNDJkZjRhNmU4ZDJjN2U2YmM5MDcyZGNkYWEx NzNhMWQwOS4uMTc1ZGRjMmRlOGQzZmMyOWE3MjFmZjFmNTNiMTMwNDAxMzc5YTZjYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTAxLTA3ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisK KyAgICAgICAgW0dUS10gRW5hYmxlIHJlcXVlc3RBbmltYXRpb25GcmFtZSBpbiBidWlsZC13ZWJr aXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1Nzcz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRW5hYmxl IHJlcXVlc3RBbmltYXRpb25GcmFtZSBmb3IgdGhlIEd0ayBwb3J0LgorCisgICAgICAgICogU2Ny aXB0cy9idWlsZC13ZWJraXQ6CisKIDIwMTItMDEtMDYgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZy YXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IERSVCBidWlsZCBvbiBjYXNlLXNlbnNpdGl2 ZSBmaWxlIHN5c3RlbXMuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCBi L1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CmluZGV4IGIxZDc3ODUyM2ZlYWE5YmE3YzUwYjA1 YmJlODEwZGNjNTI1ZTlhOGQuLmM4MTgyMTQ4YmUxOGU0MDZlZDNiOTVmNzNmZWQ5ZDEzZDgzZDVm Y2MgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CisrKyBiL1Rvb2xzL1Nj cmlwdHMvYnVpbGQtd2Via2l0CkBAIC0xMzcsNyArMTM3LDcgQEAgbXkgKAogCiBteSBAZmVhdHVy ZXMgPSAoCiAgICAgeyBvcHRpb24gPT4gInJlcXVlc3QtYW5pbWF0aW9uLWZyYW1lIiwgZGVzYyA9 PiAiVG9nZ2xlIHJlcXVlc3RBbmltYXRpb25GcmFtZSBzdXBwb3J0IiwKLSAgICAgIGRlZmluZSA9 PiAiRU5BQkxFX1JFUVVFU1RfQU5JTUFUSU9OX0ZSQU1FIiwgZGVmYXVsdCA9PiAoaXNBcHBsZU1h Y1dlYktpdCgpKSwgdmFsdWUgPT4gXCRyZXF1ZXN0QW5pbWF0aW9uRnJhbWVTdXBwb3J0IH0sCisg ICAgICBkZWZpbmUgPT4gIkVOQUJMRV9SRVFVRVNUX0FOSU1BVElPTl9GUkFNRSIsIGRlZmF1bHQg PT4gKGlzQXBwbGVNYWNXZWJLaXQoKSB8fCBpc0d0aygpKSwgdmFsdWUgPT4gXCRyZXF1ZXN0QW5p bWF0aW9uRnJhbWVTdXBwb3J0IH0sCiAKICAgICB7IG9wdGlvbiA9PiAiZG93bmxvYWQtYXR0cmli dXRlIiwgZGVzYyA9PiAiVG9nZ2xlIGRvd25sb2FkIGF0dHJpYnV0ZSBzdXBwb3J0IiwKICAgICAg IGRlZmluZSA9PiAiRU5BQkxFX0RPV05MT0FEX0FUVFJJQlVURSIsIGRlZmF1bHQgPT4gaXNCbGFj a0JlcnJ5KCksIHZhbHVlID0+XCRkb3dubG9hZEF0dHJpYnV0ZVN1cHBvcnQgfSwKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBk MjRjMTBkMjE3Nzc0NTA4YTE1NmZlYjJlMjJmMjk0NzQwOGIyMzJlLi41ZDVjNjNkOWNkNGEzODM1 NDE2YmJkNDgwMThkZTkwZGNkYjYwMzkxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDEt MDcgIFphbiBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KKworICAgICAgICBbR1RL XSBFbmFibGUgcmVxdWVzdEFuaW1hdGlvbkZyYW1lIGluIGJ1aWxkLXdlYmtpdAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU3NzMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTa2lwIHRoZSBwYXNzaW5nIHJl cXVlc3RBbmltYXRpb25GcmFtZS1yZWxhdGVkIHRlc3RzIGFuZCBwdXQKKyAgICAgICAgdGhlIHJl bWFpbmluZyBmYWlsaW5nIG9uZSB1bmRlciB0aGUgdGVzdHMgdGhhdCByZXF1aXJlIG1vZGFsCisg ICAgICAgIGRpYWxvZyBpbXBsZW1lbnRhdGlvbi4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9T a2lwcGVkOgorCiAyMDEyLTAxLTA2ICBEbWl0cnkgTG9tb3YgIDxkc2xvbW92QGdvb2dsZS5jb20+ CiAKICAgICAgICAgVW5yZXZpZXdlZDogbW9yZSByZWJhc2VsaW5lcyBpbiBjaHJvbWl1bSBhZnRl ciByMTA0MjQwLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAppbmRleCAyMzEzMDRkMTUxMDYwZTRj YjgyNjI5YjBiNWFjM2FiZmFhNjE2OGMyLi4xMWJjMjZiN2RhODc0YzVjZTYwNTA4N2ZjZTY0N2Ix MDU0MDJlYTljIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAor KysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZApAQCAtMjg2LDkgKzI4Niw2IEBA IGh0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5Ymkvc2VuZC1maWxlLWJsb2ItZmFpbC5odG1s CiBmYXN0L2NhbnZhcy9jYW52YXMtdG9EYXRhVVJMLXdlYnAuaHRtbAogZmFzdC9pbWFnZXMvd2Vi cC1pbWFnZS1kZWNvZGluZy5odG1sCiAKLSMgUmVxdWVzdCBFTkFCTEUoUkVRVUVTVF9BTklNQVRJ T05fRlJBTUUpIHN1cHBvcnQKLWZhc3QvYW5pbWF0aW9uCi0KICMgUmVxdWlyZXMgbWVkaWEgZW5n aW5lIGNsb3NlZCBjYXB0aW9uIHN1cHBvcnQKIG1lZGlhL21lZGlhLWNhcHRpb25zLmh0bWwKIApA QCAtOTUxLDYgKzk0OCw3IEBAIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQucGF0dGVybi5wYWludC5y ZXBlYXR5Lm91dHNpZGUuaHRtbAogCiAjIFRlc3RzIHRoYXQgdXNlciBtb2RhbCBkaWFsb2dzIGZh aWwgaW4gdGhlIERSVCBmb3Igc29tZSByZWFzb24uCiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01MzYwMAorZmFzdC9hbmltYXRpb24vcmVxdWVzdC1hbmltYXRpb24t ZnJhbWUtZHVyaW5nLW1vZGFsLmh0bWwKIGZhc3QvZXZlbnRzL3Nob3ctbW9kYWwtZGlhbG9nLW9u Ymx1ci1vbmZvY3VzLmh0bWwKIGZhc3QvZXZlbnRzL3Njcm9sbC1ldmVudC1kdXJpbmctbW9kYWwt ZGlhbG9nLmh0bWwKIGZhc3QvaGFybmVzcy9zaG93LW1vZGFsLWRpYWxvZy5odG1sCg==