75759 2012-01-06 16:39:47 -0800 Web Inspector: Missing Implementation of Public InspectorDOMAgent Function 2012-01-10 10:45:00 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 joepeck webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 531510 0 joepeck 2012-01-06 16:39:47 -0800 • InspectorDOMAgent::searchingForNodeInPage is missing an implementation. • We should also make setSearchingForNodeInPage public. 531512 1 121521 joepeck 2012-01-06 16:41:38 -0800 Created attachment 121521 [PATCH] Proposed Fix 531578 2 121521 webkit.review.bot 2012-01-06 19:10:58 -0800 Comment on attachment 121521 [PATCH] Proposed Fix Clearing flags on attachment: 121521 Committed r104371: <http://trac.webkit.org/changeset/104371> 531579 3 webkit.review.bot 2012-01-06 19:11:03 -0800 All reviewed patches have been landed. Closing bug. 531600 4 pfeldman 2012-01-06 22:40:09 -0800 (In reply to comment #0) > • InspectorDOMAgent::searchingForNodeInPage is missing an implementation. > • We should also make setSearchingForNodeInPage public. This change is wrong. I was putting a lot of effort into breaking the: WebKit -> InspectorController -> agents control flows. As of now, only front-end should talk to the agents for control. Acting that way we don't need to sync front-end 'inspect mode' state with backend's 'searching for node'. The getter in the header should have been removed along with its implementation (my oversight), while setter should remain private. 532318 5 121689 joepeck 2012-01-09 10:55:23 -0800 Created attachment 121689 [PATCH] Removed Unused Method Reopening based on Pavel's comments. Lets remove the method. 532494 6 121689 eric 2012-01-09 13:34:43 -0800 Comment on attachment 121689 [PATCH] Removed Unused Method Cleared review? from attachment 121689 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 532512 7 joepeck 2012-01-09 14:02:06 -0800 Apparently the bug wasn't reopened? Resetting flags. 532936 8 121689 pfeldman 2012-01-10 03:22:48 -0800 Comment on attachment 121689 [PATCH] Removed Unused Method Thanks for fixing this. 533188 9 121689 webkit.review.bot 2012-01-10 10:44:55 -0800 Comment on attachment 121689 [PATCH] Removed Unused Method Clearing flags on attachment: 121689 Committed r104596: <http://trac.webkit.org/changeset/104596> 533189 10 webkit.review.bot 2012-01-10 10:45:00 -0800 All reviewed patches have been landed. Closing bug. 121521 2012-01-06 16:41:38 -0800 2012-01-09 10:55:23 -0800 [PATCH] Proposed Fix fix.patch text/plain 2367 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiZDg1YjdmLi4yOTUyNDFjIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDEtMDYgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBNaXNzaW5nIEltcGxlbWVudGF0aW9uIG9mIFB1YmxpYyBJ bnNwZWN0b3JET01BZ2VudCBGdW5jdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzU3NTkKKworICAgICAgICBJbXBsZW1lbnQgbWlzc2luZyBhY2Nl c3NvciBhbmQgbWFrZSBzZXR0ZXIgcHVibGljLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckRPTUFnZW50OjpzZWFyY2hpbmdGb3JOb2RlSW5Q YWdlKToKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuaDoKKwogMjAxMi0w MS0wNSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBB dm9pZCBmYWxsaW5nIGludG8gdGlsZWQgbGF5ZXJzIG1vcmUgb2Z0ZW4gd2hlbiB0aGUgZGV2aWNl IHNjYWxlIGZhY3RvciBpcyA+IDEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JET01BZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9yRE9NQWdlbnQuY3BwCmluZGV4IDBjNWNhYzAuLjJmOTVjMjMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcApAQCAtOTQzLDYgKzk0MywxMSBA QCB2b2lkIEluc3BlY3RvckRPTUFnZW50Ojptb3VzZURpZE1vdmVPdmVyRWxlbWVudChjb25zdCBI aXRUZXN0UmVzdWx0JiByZXN1bHQsIHVucwogICAgIH0KIH0KIAorYm9vbCBJbnNwZWN0b3JET01B Z2VudDo6c2VhcmNoaW5nRm9yTm9kZUluUGFnZSgpIGNvbnN0Cit7CisgICAgcmV0dXJuIG1fc2Vh cmNoaW5nRm9yTm9kZTsKK30KKwogdm9pZCBJbnNwZWN0b3JET01BZ2VudDo6c2V0U2VhcmNoaW5n Rm9yTm9kZShib29sIGVuYWJsZWQsIEluc3BlY3Rvck9iamVjdCogaGlnaGxpZ2h0Q29uZmlnKQog ewogICAgIGlmIChtX3NlYXJjaGluZ0Zvck5vZGUgPT0gZW5hYmxlZCkKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5oIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmgKaW5kZXggMzFkZTM5OS4uYmJkODdlMSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmgK KysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmgKQEAgLTE2 OSw4ICsxNjksOSBAQCBwdWJsaWM6CiAKICAgICBQYXNzUmVmUHRyPEluc3BlY3Rvck9iamVjdD4g cmVzb2x2ZU5vZGUoTm9kZSosIGNvbnN0IFN0cmluZyYgb2JqZWN0R3JvdXApOwogICAgIGJvb2wg aGFuZGxlTW91c2VQcmVzcygpOwotICAgIGJvb2wgc2VhcmNoaW5nRm9yTm9kZUluUGFnZSgpIGNv bnN0OwogICAgIHZvaWQgbW91c2VEaWRNb3ZlT3ZlckVsZW1lbnQoY29uc3QgSGl0VGVzdFJlc3Vs dCYsIHVuc2lnbmVkIG1vZGlmaWVyRmxhZ3MpOworICAgIGJvb2wgc2VhcmNoaW5nRm9yTm9kZUlu UGFnZSgpIGNvbnN0OworICAgIHZvaWQgc2V0U2VhcmNoaW5nRm9yTm9kZShib29sIGVuYWJsZWQs IEluc3BlY3Rvck9iamVjdCogaGlnaGxpZ2h0Q29uZmlnKTsKICAgICB2b2lkIGluc3BlY3QoTm9k ZSopOwogICAgIHZvaWQgZm9jdXNOb2RlKCk7CiAKQEAgLTE5MSw3ICsxOTIsNiBAQCBwdWJsaWM6 CiBwcml2YXRlOgogICAgIEluc3BlY3RvckRPTUFnZW50KEluc3RydW1lbnRpbmdBZ2VudHMqLCBJ bnNwZWN0b3JQYWdlQWdlbnQqLCBJbnNwZWN0b3JDbGllbnQqLCBJbnNwZWN0b3JTdGF0ZSosIElu amVjdGVkU2NyaXB0TWFuYWdlciopOwogCi0gICAgdm9pZCBzZXRTZWFyY2hpbmdGb3JOb2RlKGJv b2wgZW5hYmxlZCwgSW5zcGVjdG9yT2JqZWN0KiBoaWdobGlnaHRDb25maWcpOwogICAgIGJvb2wg c2V0SGlnaGxpZ2h0RGF0YUZyb21Db25maWcoSW5zcGVjdG9yT2JqZWN0KiBoaWdobGlnaHRDb25m aWcpOwogICAgIHZvaWQgaGlnaGxpZ2h0KCk7CiAK 121689 2012-01-09 10:55:23 -0800 2012-01-10 10:44:55 -0800 [PATCH] Removed Unused Method follow-up.patch text/plain 2229 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlOTc1NDg0Li5hMWVjYzE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMDEtMDkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBNaXNzaW5nIEltcGxlbWVudGF0aW9uIG9mIFB1YmxpYyBJ bnNwZWN0b3JET01BZ2VudCBGdW5jdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzU3NTkKKworICAgICAgICBGb2xsb3ctdXA6IFJlbW92ZSB0aGUg dW51c2VkIG1ldGhvZC4gS2VlcCB0aGUgc2V0dGVyIHByaXZhdGUuCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRE9N QWdlbnQuY3BwOgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5oOgorCiAy MDEyLTAxLTA5ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAog ICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTA0NDE4LgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcCBiL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAKaW5kZXggMmY5NWMyMy4uMGM1Y2Fj MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3Bw CkBAIC05NDMsMTEgKzk0Myw2IEBAIHZvaWQgSW5zcGVjdG9yRE9NQWdlbnQ6Om1vdXNlRGlkTW92 ZU92ZXJFbGVtZW50KGNvbnN0IEhpdFRlc3RSZXN1bHQmIHJlc3VsdCwgdW5zCiAgICAgfQogfQog Ci1ib29sIEluc3BlY3RvckRPTUFnZW50OjpzZWFyY2hpbmdGb3JOb2RlSW5QYWdlKCkgY29uc3QK LXsKLSAgICByZXR1cm4gbV9zZWFyY2hpbmdGb3JOb2RlOwotfQotCiB2b2lkIEluc3BlY3RvckRP TUFnZW50OjpzZXRTZWFyY2hpbmdGb3JOb2RlKGJvb2wgZW5hYmxlZCwgSW5zcGVjdG9yT2JqZWN0 KiBoaWdobGlnaHRDb25maWcpCiB7CiAgICAgaWYgKG1fc2VhcmNoaW5nRm9yTm9kZSA9PSBlbmFi bGVkKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFn ZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuaAppbmRl eCBiYmQ4N2UxLi4xN2Y2MmE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yRE9NQWdlbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9yRE9NQWdlbnQuaApAQCAtMTcwLDggKzE3MCw2IEBAIHB1YmxpYzoKICAgICBQYXNzUmVmUHRy PEluc3BlY3Rvck9iamVjdD4gcmVzb2x2ZU5vZGUoTm9kZSosIGNvbnN0IFN0cmluZyYgb2JqZWN0 R3JvdXApOwogICAgIGJvb2wgaGFuZGxlTW91c2VQcmVzcygpOwogICAgIHZvaWQgbW91c2VEaWRN b3ZlT3ZlckVsZW1lbnQoY29uc3QgSGl0VGVzdFJlc3VsdCYsIHVuc2lnbmVkIG1vZGlmaWVyRmxh Z3MpOwotICAgIGJvb2wgc2VhcmNoaW5nRm9yTm9kZUluUGFnZSgpIGNvbnN0OwotICAgIHZvaWQg c2V0U2VhcmNoaW5nRm9yTm9kZShib29sIGVuYWJsZWQsIEluc3BlY3Rvck9iamVjdCogaGlnaGxp Z2h0Q29uZmlnKTsKICAgICB2b2lkIGluc3BlY3QoTm9kZSopOwogICAgIHZvaWQgZm9jdXNOb2Rl KCk7CiAKQEAgLTE5Miw2ICsxOTAsNyBAQCBwdWJsaWM6CiBwcml2YXRlOgogICAgIEluc3BlY3Rv ckRPTUFnZW50KEluc3RydW1lbnRpbmdBZ2VudHMqLCBJbnNwZWN0b3JQYWdlQWdlbnQqLCBJbnNw ZWN0b3JDbGllbnQqLCBJbnNwZWN0b3JTdGF0ZSosIEluamVjdGVkU2NyaXB0TWFuYWdlciopOwog CisgICAgdm9pZCBzZXRTZWFyY2hpbmdGb3JOb2RlKGJvb2wgZW5hYmxlZCwgSW5zcGVjdG9yT2Jq ZWN0KiBoaWdobGlnaHRDb25maWcpOwogICAgIGJvb2wgc2V0SGlnaGxpZ2h0RGF0YUZyb21Db25m aWcoSW5zcGVjdG9yT2JqZWN0KiBoaWdobGlnaHRDb25maWcpOwogICAgIHZvaWQgaGlnaGxpZ2h0 KCk7CiAK