75751 2012-01-06 15:19:25 -0800 IndexedDB: Make WebIDBDatabase::close() idempotent 2012-01-09 13:08:50 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jsbell jsbell dgrogan hans tony webkit.review.bot oldest_to_newest 531445 0 jsbell 2012-01-06 15:19:25 -0800 IndexedDB: Make WebIDBDatabase::close() idempotent 531447 1 121508 jsbell 2012-01-06 15:22:12 -0800 Created attachment 121508 Patch 531449 2 jsbell 2012-01-06 15:23:59 -0800 The simplest/cleanest fix for http://code.google.com/p/chromium/issues/detail?id=80111 requires that chromium's implementation of WebIDBDatabase::close() be idempotent. This is one way to achieve that, which keeps the assertion behavior when called directly (i.e. non-Chromium builds) That said, I'm not positive that this is the best approach. 531534 3 121508 dgrogan 2012-01-06 17:12:49 -0800 Comment on attachment 121508 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121508&action=review LGTM > Source/WebKit/chromium/src/WebIDBDatabaseImpl.cpp:106 > ASSERT(m_databaseCallbacks); You can delete this line now. 531547 4 121527 jsbell 2012-01-06 17:53:03 -0800 Created attachment 121527 Patch 532282 5 jsbell 2012-01-09 10:30:29 -0800 tony@ - r? cq? 532306 6 121527 tony 2012-01-09 10:40:12 -0800 Comment on attachment 121527 Patch Nit: Should we have a layout test that calls close() twice? The assert should be hit in a debug build without this change. 532339 7 jsbell 2012-01-09 11:13:45 -0800 (In reply to comment #6) > (From update of attachment 121527 [details]) > Nit: Should we have a layout test that calls close() twice? The assert should be hit in a debug build without this change. The IDBDatabase object has an internal m_closePending flag which makes a script's call to db.close() exit early if called twice. If that wasn't present, then in the Chromium port the call would eventually make it into WebIDBDatabase::close() and we'd hit this assert. All that said, we didn't appear to have a layout test that called close() twice, so I've added that to database-basics, but it passes both with and without this patch. 532356 8 121700 jsbell 2012-01-09 11:25:11 -0800 Created attachment 121700 Patch 532458 9 121700 webkit.review.bot 2012-01-09 13:08:46 -0800 Comment on attachment 121700 Patch Clearing flags on attachment: 121700 Committed r104481: <http://trac.webkit.org/changeset/104481> 532459 10 webkit.review.bot 2012-01-09 13:08:50 -0800 All reviewed patches have been landed. Closing bug. 121508 2012-01-06 15:22:12 -0800 2012-01-06 17:53:01 -0800 Patch bug-75751-20120106152211.patch text/plain 1549 jsbell U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0MjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDM1OGFhMGM3ZDViMmJlMDNlYmVhNmY3OWMxNGU5NDUzYjczMDdiNTEuLjE0NDY1ZGVhMTNlMzg0 YjhhZjkzN2M5NWEzZGM0MTBkZTYxOTQyNGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTItMDEtMDYgIEpvc2h1YSBCZWxsICA8anNiZWxsQGNocm9taXVt Lm9yZz4KKworICAgICAgICBJbmRleGVkREI6IE1ha2UgV2ViSURCRGF0YWJhc2U6OmNsb3NlKCkg aWRlbXBvdGVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzU3NTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHNyYy9XZWJJREJEYXRhYmFzZUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJREJE YXRhYmFzZUltcGw6OmNsb3NlKToKKwogMjAxMi0wMS0wNSAgSm9jaGVuIEVpc2luZ2VyICA8am9j aGVuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBDaGVjayB3aGV0aGVyIGEgV2ViVmlldyBleGlz dHMgYmVmb3JlIGFjY2Vzc2luZyBpdCBpbiBTdG9yYWdlQXJlYVByb3h5LiBUaGlzIGlzIG5vdCBu ZWNlc3NhcmlseSB0aGUgY2FzZSwgZS5nLiBmb3IgZGV0YWNoZWQgaWZyYW1lcy4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklEQkRhdGFiYXNlSW1wbC5jcHAgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJREJEYXRhYmFzZUltcGwuY3BwCmluZGV4IGY0 MGUwMjBiYmI2ZTk3MTI4ZmZjZjZjMjVhMTk4NmMxZDgzNzRmYzguLjZhMjE1YWUzMDAyYTdlMzNm NjczMGI0NTI0YmEyNzMzYzA5YjIzZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYklEQkRhdGFiYXNlSW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViSURCRGF0YWJhc2VJbXBsLmNwcApAQCAtMTAxLDggKzEwMSwxMSBAQCB2b2lkIFdl YklEQkRhdGFiYXNlSW1wbDo6Y2xvc2UoKQogewogICAgIC8vIFVzZSB0aGUgY2FsbGJhY2tzIHRo YXQgOjpvcGVuIGdhdmUgdXMgc28gdGhhdCB0aGUgYmFja2VuZCBpbgogICAgIC8vIG11bHRpLXBy b2Nlc3MgY2hyb21pdW0ga25vd3Mgd2hpY2ggZGF0YWJhc2UgY29ubmVjdGlvbiBpcyBjbG9zaW5n LgorICAgIGlmICghbV9kYXRhYmFzZUNhbGxiYWNrcykKKyAgICAgICAgcmV0dXJuOwogICAgIEFT U0VSVChtX2RhdGFiYXNlQ2FsbGJhY2tzKTsKICAgICBtX2RhdGFiYXNlQmFja2VuZC0+Y2xvc2Uo bV9kYXRhYmFzZUNhbGxiYWNrcyk7CisgICAgbV9kYXRhYmFzZUNhbGxiYWNrcyA9IDA7CiB9CiAK IHZvaWQgV2ViSURCRGF0YWJhc2VJbXBsOjpvcGVuKFdlYklEQkRhdGFiYXNlQ2FsbGJhY2tzKiBj YWxsYmFja3MpCg== 121527 2012-01-06 17:53:03 -0800 2012-01-09 11:25:08 -0800 Patch bug-75751-20120106175302.patch text/plain 1549 jsbell U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0MjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDM1OGFhMGM3ZDViMmJlMDNlYmVhNmY3OWMxNGU5NDUzYjczMDdiNTEuLjE0NDY1ZGVhMTNlMzg0 YjhhZjkzN2M5NWEzZGM0MTBkZTYxOTQyNGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTItMDEtMDYgIEpvc2h1YSBCZWxsICA8anNiZWxsQGNocm9taXVt Lm9yZz4KKworICAgICAgICBJbmRleGVkREI6IE1ha2UgV2ViSURCRGF0YWJhc2U6OmNsb3NlKCkg aWRlbXBvdGVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzU3NTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHNyYy9XZWJJREJEYXRhYmFzZUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJREJE YXRhYmFzZUltcGw6OmNsb3NlKToKKwogMjAxMi0wMS0wNSAgSm9jaGVuIEVpc2luZ2VyICA8am9j aGVuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBDaGVjayB3aGV0aGVyIGEgV2ViVmlldyBleGlz dHMgYmVmb3JlIGFjY2Vzc2luZyBpdCBpbiBTdG9yYWdlQXJlYVByb3h5LiBUaGlzIGlzIG5vdCBu ZWNlc3NhcmlseSB0aGUgY2FzZSwgZS5nLiBmb3IgZGV0YWNoZWQgaWZyYW1lcy4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklEQkRhdGFiYXNlSW1wbC5jcHAgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJREJEYXRhYmFzZUltcGwuY3BwCmluZGV4IGY0 MGUwMjBiYmI2ZTk3MTI4ZmZjZjZjMjVhMTk4NmMxZDgzNzRmYzguLjQ0N2I5OTNjNmE0ZjkwN2Rj MDQzYTdhMmY1NGFjNTY4NmQ2Mzk4MTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYklEQkRhdGFiYXNlSW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViSURCRGF0YWJhc2VJbXBsLmNwcApAQCAtMTAxLDggKzEwMSwxMCBAQCB2b2lkIFdl YklEQkRhdGFiYXNlSW1wbDo6Y2xvc2UoKQogewogICAgIC8vIFVzZSB0aGUgY2FsbGJhY2tzIHRo YXQgOjpvcGVuIGdhdmUgdXMgc28gdGhhdCB0aGUgYmFja2VuZCBpbgogICAgIC8vIG11bHRpLXBy b2Nlc3MgY2hyb21pdW0ga25vd3Mgd2hpY2ggZGF0YWJhc2UgY29ubmVjdGlvbiBpcyBjbG9zaW5n LgotICAgIEFTU0VSVChtX2RhdGFiYXNlQ2FsbGJhY2tzKTsKKyAgICBpZiAoIW1fZGF0YWJhc2VD YWxsYmFja3MpCisgICAgICAgIHJldHVybjsKICAgICBtX2RhdGFiYXNlQmFja2VuZC0+Y2xvc2Uo bV9kYXRhYmFzZUNhbGxiYWNrcyk7CisgICAgbV9kYXRhYmFzZUNhbGxiYWNrcyA9IDA7CiB9CiAK IHZvaWQgV2ViSURCRGF0YWJhc2VJbXBsOjpvcGVuKFdlYklEQkRhdGFiYXNlQ2FsbGJhY2tzKiBj YWxsYmFja3MpCg== 121700 2012-01-09 11:25:11 -0800 2012-01-09 13:08:46 -0800 Patch bug-75751-20120109112510.patch text/plain 5334 jsbell U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0NDYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGVlZmMyZjkxM2MyYTNhNWNjYjRiZmZiZDg4YmY3OThjZTEzZmI0YTUuLmE3MGZmYjFkMDNjZDAz NjQ5ZGNjOGI5NDgzMTljNjY4OTZjZmJjM2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTItMDEtMDkgIEpvc2h1YSBCZWxsICA8anNiZWxsQGNocm9taXVt Lm9yZz4KKworICAgICAgICBJbmRleGVkREI6IE1ha2UgV2ViSURCRGF0YWJhc2U6OmNsb3NlKCkg aWRlbXBvdGVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzU3NTEKKworICAgICAgICBBbGxvdyBDaHJvbWl1bSdzIGJhY2stZW5kIHRvIHNhZmVseSB0 cmlnZ2VyIHRoZSBjbGVhbnVwIHRoYXQgb2NjdXJzCisgICAgICAgIHdoZW4gYSBkYXRhYmFzZSBj b25uZWN0aW9uIGlzIGNsb3NlZCwgd2l0aG91dCB0cmFja2luZyB3aGV0aGVyIG9yIG5vdAorICAg ICAgICB0aGUgY29ubmVjdGlvbiB3YXMgcHJldmlvdXMgY2xvc2VkIGJ5IHNjcmlwdC4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHNyYy9XZWJJREJE YXRhYmFzZUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJREJEYXRhYmFzZUltcGw6OmNs b3NlKToKKwogMjAxMi0wMS0wOSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFp bC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEwNDQxOC4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklEQkRhdGFiYXNlSW1wbC5jcHAg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJREJEYXRhYmFzZUltcGwuY3BwCmluZGV4 IGY0MGUwMjBiYmI2ZTk3MTI4ZmZjZjZjMjVhMTk4NmMxZDgzNzRmYzguLjQ0N2I5OTNjNmE0Zjkw N2RjMDQzYTdhMmY1NGFjNTY4NmQ2Mzk4MTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYklEQkRhdGFiYXNlSW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViSURCRGF0YWJhc2VJbXBsLmNwcApAQCAtMTAxLDggKzEwMSwxMCBAQCB2b2lk IFdlYklEQkRhdGFiYXNlSW1wbDo6Y2xvc2UoKQogewogICAgIC8vIFVzZSB0aGUgY2FsbGJhY2tz IHRoYXQgOjpvcGVuIGdhdmUgdXMgc28gdGhhdCB0aGUgYmFja2VuZCBpbgogICAgIC8vIG11bHRp LXByb2Nlc3MgY2hyb21pdW0ga25vd3Mgd2hpY2ggZGF0YWJhc2UgY29ubmVjdGlvbiBpcyBjbG9z aW5nLgotICAgIEFTU0VSVChtX2RhdGFiYXNlQ2FsbGJhY2tzKTsKKyAgICBpZiAoIW1fZGF0YWJh c2VDYWxsYmFja3MpCisgICAgICAgIHJldHVybjsKICAgICBtX2RhdGFiYXNlQmFja2VuZC0+Y2xv c2UobV9kYXRhYmFzZUNhbGxiYWNrcyk7CisgICAgbV9kYXRhYmFzZUNhbGxiYWNrcyA9IDA7CiB9 CiAKIHZvaWQgV2ViSURCRGF0YWJhc2VJbXBsOjpvcGVuKFdlYklEQkRhdGFiYXNlQ2FsbGJhY2tz KiBjYWxsYmFja3MpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKaW5kZXggN2JiNGJhZjAwMWNiNmM4ZDZhYzkzOTJmOTc0MTc1NTAzYjUw MmRiYy4uNjcxY2NiNGIzNGZlMGNjMDU2M2FiNDZjMDFhMTJmYTNmNTgyNDhlNCAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE3IEBACisyMDEyLTAxLTA5ICBKb3NodWEgQmVsbCAgPGpzYmVsbEBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgSW5kZXhlZERCOiBNYWtlIFdlYklEQkRhdGFiYXNlOjpjbG9zZSgpIGlk ZW1wb3RlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc1NzUxCisKKyAgICAgICAgVmVyaWZ5IHRoYXQgY2FsbGluZyBJREJEYXRhYmFzZS5jbG9zZSgp IHR3aWNlIGZyb20gc2NyaXB0IGlzIGhhcm1sZXNzLgorICAgICAgICBOb3RlIHRoYXQgdGhlIHRl c3RzIHBhc3Mgd2l0aG91dCB0aGUgcmVsYXRlZCBjb2RlIGNoYW5nZSBpbiB0aGUgYnVnLAorICAg ICAgICB3aGljaCBpcyBqdXN0IGZvciBub24tc2NyaXB0IHVzZSBieSB0aGUgY2hyb21pdW0gcG9y dC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0 b3JhZ2UvaW5kZXhlZGRiL2RhdGFiYXNlLWJhc2ljcy1leHBlY3RlZC50eHQ6CisgICAgICAgICog c3RvcmFnZS9pbmRleGVkZGIvZGF0YWJhc2UtYmFzaWNzLmh0bWw6CisKIDIwMTItMDEtMDkgIEpv aG4gS25vdHRlbmJlbHQgIDxqa25vdHRlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9t aXVtXSBVcGRhdGUgdGVzdCBleHBlY3RhdGlvbnMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9z dG9yYWdlL2luZGV4ZWRkYi9kYXRhYmFzZS1iYXNpY3MtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvc3RvcmFnZS9pbmRleGVkZGIvZGF0YWJhc2UtYmFzaWNzLWV4cGVjdGVkLnR4dAppbmRleCBl MWFmMTFlOTk0MDQ0ODNiYzMyZDNjOGM3OTRjYTZmZGVhOGEwNWZiLi40OWQxY2FjM2MwMzQ2ZmRj NTA3Y2Q0OGM4ZDA2ZDdjN2MxNzlkY2E2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9zdG9yYWdl L2luZGV4ZWRkYi9kYXRhYmFzZS1iYXNpY3MtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3Rz L3N0b3JhZ2UvaW5kZXhlZGRiL2RhdGFiYXNlLWJhc2ljcy1leHBlY3RlZC50eHQKQEAgLTMsNyAr MywxMSBAQCBUZXN0IHRoZSBiYXNpY3Mgb2YgSW5kZXhlZERCJ3MgSURCRGF0YWJhc2UuCiBPbiBz dWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dl ZCBieSAiVEVTVCBDT01QTEVURSIuCiAKIAotd2Via2l0SW5kZXhlZERCLm9wZW4oJ2RhdGFiYXNl LWJhc2ljcycpCitpbmRleGVkREIgPSB3aW5kb3cuaW5kZXhlZERCIHx8IHdpbmRvdy53ZWJraXRJ bmRleGVkREIKK1BBU1MgaW5kZXhlZERCICE9IG51bGwgaXMgdHJ1ZQorSURCRGF0YWJhc2VFeGNl cHRpb24gPSB3aW5kb3cuSURCRGF0YWJhc2VFeGNlcHRpb24gfHwgd2luZG93LndlYmtpdElEQkRh dGFiYXNlRXhjZXB0aW9uCitQQVNTIElEQkRhdGFiYXNlRXhjZXB0aW9uICE9IG51bGwgaXMgdHJ1 ZQoraW5kZXhlZERCLm9wZW4oJ2RhdGFiYXNlLWJhc2ljcycpCiBkYiA9IGV2ZW50LnRhcmdldC5y ZXN1bHQKIGRiLnNldFZlcnNpb24oJ25ldyB2ZXJzaW9uJykKIHNldFZlcnNpb25TdWNjZXNzKCk6 CkBAIC00Myw2ICs0NywxMyBAQCBQQVNTIGRiLm9iamVjdFN0b3JlTmFtZXMubGVuZ3RoIGlzIDEK IFBBU1MgZGIub2JqZWN0U3RvcmVOYW1lcy5jb250YWlucygnJykgaXMgZmFsc2UKIFBBU1MgZGIu b2JqZWN0U3RvcmVOYW1lcy5jb250YWlucygndGVzdDQ1NicpIGlzIGZhbHNlCiBQQVNTIGRiLm9i amVjdFN0b3JlTmFtZXMuY29udGFpbnMoJ3Rlc3QxMjMnKSBpcyB0cnVlCitkYi5jbG9zZSgpCitO b3cgdGhhdCB0aGUgY29ubmVjdGlvbiBpcyBjbG9zZWQsIHRyYW5zYWN0aW9uIGNyZWF0aW9uIHNo b3VsZCBmYWlsCitFeHBlY3RpbmcgZXhjZXB0aW9uIGZyb20gZGIudHJhbnNhY3Rpb24oJ3Rlc3Qx MjMnKQorUEFTUyBFeGNlcHRpb24gd2FzIHRocm93bi4KK1BBU1MgY29kZSBpcyBJREJEYXRhYmFz ZUV4Y2VwdGlvbi5OT1RfQUxMT1dFRF9FUlIKK0NhbGwgdHdpY2UsIG1ha2Ugc3VyZSBpdCdzIGhh cm1sZXNzCitkYi5jbG9zZSgpCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRF U1QgQ09NUExFVEUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2Rh dGFiYXNlLWJhc2ljcy5odG1sIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvZGF0YWJh c2UtYmFzaWNzLmh0bWwKaW5kZXggMjczZjE2Nzg1YzRmOTNmODRiYzhlNTE3NTMyN2I2Njg3ZGJl MzVjOC4uNDc2ODNlODcwZWE3MmQ4YjFlYzIwMWI0MzJjMzU5Njc3MDE0MTMwOSAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvZGF0YWJhc2UtYmFzaWNzLmh0bWwKKysr IGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvZGF0YWJhc2UtYmFzaWNzLmh0bWwKQEAg LTE0LDcgKzE0LDEyIEBAIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCiAKIGZ1bmN0 aW9uIHRlc3QoKQogewotICAgIHJlcXVlc3QgPSBldmFsQW5kTG9nKCJ3ZWJraXRJbmRleGVkREIu b3BlbignZGF0YWJhc2UtYmFzaWNzJykiKTsKKyAgICBldmFsQW5kTG9nKCJpbmRleGVkREIgPSB3 aW5kb3cuaW5kZXhlZERCIHx8IHdpbmRvdy53ZWJraXRJbmRleGVkREIiKTsKKyAgICBzaG91bGRC ZVRydWUoImluZGV4ZWREQiAhPSBudWxsIik7CisgICAgZXZhbEFuZExvZygiSURCRGF0YWJhc2VF eGNlcHRpb24gPSB3aW5kb3cuSURCRGF0YWJhc2VFeGNlcHRpb24gfHwgd2luZG93LndlYmtpdElE QkRhdGFiYXNlRXhjZXB0aW9uIik7CisgICAgc2hvdWxkQmVUcnVlKCJJREJEYXRhYmFzZUV4Y2Vw dGlvbiAhPSBudWxsIik7CisKKyAgICByZXF1ZXN0ID0gZXZhbEFuZExvZygiaW5kZXhlZERCLm9w ZW4oJ2RhdGFiYXNlLWJhc2ljcycpIik7CiAgICAgcmVxdWVzdC5vbnN1Y2Nlc3MgPSBvcGVuU3Vj Y2VzczsKICAgICByZXF1ZXN0Lm9uZXJyb3IgPSB1bmV4cGVjdGVkRXJyb3JDYWxsYmFjazsKIH0K QEAgLTEwNCw2ICsxMDksMTYgQEAgZnVuY3Rpb24gY2hlY2tNZXRhZGF0YSgpCiB7CiAgICAgc2hv dWxkQmVFcXVhbFRvU3RyaW5nKCJkYi52ZXJzaW9uIiwgInZlcnNpb24gYiIpOwogICAgIGNoZWNr T2JqZWN0U3RvcmUoKTsKKyAgICB0ZXN0Q2xvc2UoKTsKK30KKworZnVuY3Rpb24gdGVzdENsb3Nl KCkKK3sKKyAgICBldmFsQW5kTG9nKCJkYi5jbG9zZSgpIik7CisgICAgZGVidWcoIk5vdyB0aGF0 IHRoZSBjb25uZWN0aW9uIGlzIGNsb3NlZCwgdHJhbnNhY3Rpb24gY3JlYXRpb24gc2hvdWxkIGZh aWwiKTsKKyAgICBldmFsQW5kRXhwZWN0RXhjZXB0aW9uKCJkYi50cmFuc2FjdGlvbigndGVzdDEy MycpIiwgIklEQkRhdGFiYXNlRXhjZXB0aW9uLk5PVF9BTExPV0VEX0VSUiIpOworICAgIGRlYnVn KCJDYWxsIHR3aWNlLCBtYWtlIHN1cmUgaXQncyBoYXJtbGVzcyIpOworICAgIGV2YWxBbmRMb2co ImRiLmNsb3NlKCkiKTsKICAgICBkb25lKCk7CiB9CiAK