75738 2012-01-06 13:45:34 -0800 [Mac] Thread verifier assertions when printing 2012-01-06 14:02:07 -0800 1 1 1 Unclassified WebKit Printing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap mitz mrowe oldest_to_newest 531351 0 ap 2012-01-06 13:45:34 -0800 We're doing too much from secondary thread. We need it to avoid being blocked on WebProcess, but not to manipulate UI process objects. 531354 1 121484 ap 2012-01-06 13:48:33 -0800 Created attachment 121484 proposed fix I'm not sure if I'm using the right magic to deallocate on main thread (do we need the first part in WK2?) 531378 2 121484 mrowe 2012-01-06 13:58:43 -0800 Comment on attachment 121484 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=121484&action=review > Source/WebKit2/UIProcess/API/mac/WKPrintingView.mm:51 > ++ (void)initialize > +{ > + WebCoreObjCFinalizeOnMainThread(self); > +} I think this is not necessary in WebKit2. > Source/WebKit2/UIProcess/API/mac/WKPrintingView.mm:127 > + ASSERT(isMainThread()); // This funciton calls the client, which should only be done on main thread. "funciton" 531380 3 ap 2012-01-06 14:02:07 -0800 Committed <http://trac.webkit.org/changeset/104334>. Removed WebCoreObjCFinalizeOnMainThread. > "funciton" Oops, didn't see this before landing. 121484 2012-01-06 13:48:33 -0800 2012-01-06 13:58:43 -0800 proposed fix PrintingAssertions.txt text/plain 2776 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNDMzMCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAxLTA2ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIFRocmVhZCB2ZXJp ZmllciBhc3NlcnRpb25zIHdoZW4gcHJpbnRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTc1NzM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9XS1ByaW50aW5nVmlldy5t bToKKyAgICAgICAgKCtbV0tQcmludGluZ1ZpZXcgaW5pdGlhbGl6ZV0pOiBEZWFsbG9jIGluIG1h aW4gdGhyZWFkLCBzbyB0aGF0IFdlYkZyYW1lUHJveHkgZG9lc24ndCBnZXQKKyAgICAgICAgZGVy ZWYnZWQgZnJvbSBhIHNlY29uZGFyeSBvbmUuCisgICAgICAgICgtW1dLUHJpbnRpbmdWaWV3IGRl YWxsb2NdKTogRGl0dG8uCisgICAgICAgICgtW1dLUHJpbnRpbmdWaWV3IF9hZGp1c3RQcmludGlu Z01hcmdpbnNGb3JIZWFkZXJBbmRGb290ZXJdKTogVGhpcyBtZXRob2QgY2FsbHMgb3V0IHRvIGNs aWVudCwKKyAgICAgICAgd2hpY2ggb25seSBleHBlY3RzIHRoYXQgb24gbWFpbiB0aHJlYWQuCisg ICAgICAgICgtW1dLUHJpbnRpbmdWaWV3IGtub3dzUGFnZVJhbmdlOl0pOiBDYWxsIF9hZGp1c3RQ cmludGluZ01hcmdpbnNGb3JIZWFkZXJBbmRGb290ZXIgb24gbWFpbgorICAgICAgICB0aHJlYWQu CisKIDIwMTItMDEtMDYgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAg ICAgICAgTmVlZCB0byBhbGxvdyBTQ05ldHdvcmtSZWFjaGFiaWxpdHkgc2VydmljZSBpbiBzYW5k Ym94IHByb2ZpbGUKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLUHJp bnRpbmdWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv bWFjL1dLUHJpbnRpbmdWaWV3Lm1tCShyZXZpc2lvbiAxMDQwNjEpCisrKyBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ByaW50aW5nVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAt MzAsNiArMzAsNyBAQAogI2ltcG9ydCAiUHJpbnRJbmZvLmgiCiAjaW1wb3J0ICJXZWJEYXRhLmgi CiAjaW1wb3J0ICJXZWJQYWdlUHJveHkuaCIKKyNpbXBvcnQgPFdlYkNvcmUvV2ViQ29yZU9iakNF eHRyYXMuaD4KICNpbXBvcnQgPHd0Zi9NYWluVGhyZWFkLmg+CiAKIHVzaW5nIG5hbWVzcGFjZSBX ZWJLaXQ7CkBAIC00NCw2ICs0NSwxMSBAQCBzdGF0aWMgQk9PTCBpc0ZvcmNpbmdQcmV2aWV3VXBk YXRlOwogCiBAaW1wbGVtZW50YXRpb24gV0tQcmludGluZ1ZpZXcKIAorKyAodm9pZClpbml0aWFs aXplCit7CisgICAgV2ViQ29yZU9iakNGaW5hbGl6ZU9uTWFpblRocmVhZChzZWxmKTsKK30KKwog LSAoaWQpaW5pdFdpdGhGcmFtZVByb3h5OihXZWJLaXQ6OldlYkZyYW1lUHJveHkqKWZyYW1lIHZp ZXc6KE5TVmlldyAqKXdrVmlldwogewogICAgIHNlbGYgPSBbc3VwZXIgaW5pdF07IC8vIE5vIGZy YW1lIHJlY3QgdG8gcGFzcyB0byBOU1ZpZXcuCkBAIC01Niw2ICs2MiwxNCBAQCAtIChpZClpbml0 V2l0aEZyYW1lUHJveHk6KFdlYktpdDo6V2ViRnJhCiAgICAgcmV0dXJuIHNlbGY7CiB9CiAKKy0g KHZvaWQpZGVhbGxvYworeworICAgIGlmIChXZWJDb3JlT2JqQ1NjaGVkdWxlRGVhbGxvY2F0ZU9u TWFpblRocmVhZChbV0tQcmludGluZ1ZpZXcgY2xhc3NdLCBzZWxmKSkKKyAgICAgICAgcmV0dXJu OworCisgICAgW3N1cGVyIGRlYWxsb2NdOworfQorCiAtIChCT09MKWlzRmxpcHBlZAogewogICAg IHJldHVybiBZRVM7CkBAIC0xMTAsNiArMTI0LDggQEAgLSAodm9pZClfZGVsYXllZFJlc3VtZUF1 dG9kaXNwbGF5CiAKIC0gKHZvaWQpX2FkanVzdFByaW50aW5nTWFyZ2luc0ZvckhlYWRlckFuZEZv b3RlcgogeworICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7IC8vIFRoaXMgZnVuY2l0b24gY2Fs bHMgdGhlIGNsaWVudCwgd2hpY2ggc2hvdWxkIG9ubHkgYmUgZG9uZSBvbiBtYWluIHRocmVhZC4K KwogICAgIE5TUHJpbnRJbmZvICppbmZvID0gW19wcmludE9wZXJhdGlvbiBwcmludEluZm9dOwog ICAgIE5TTXV0YWJsZURpY3Rpb25hcnkgKmluZm9EaWN0aW9uYXJ5ID0gW2luZm8gZGljdGlvbmFy eV07CiAKQEAgLTM2NCw3ICszODAsNyBAQCAtIChCT09MKWtub3dzUGFnZVJhbmdlOihOU1Jhbmdl UG9pbnRlcilyCiAKICAgICBbc2VsZiBfc3VzcGVuZEF1dG9kaXNwbGF5XTsKICAgICAKLSAgICBb c2VsZiBfYWRqdXN0UHJpbnRpbmdNYXJnaW5zRm9ySGVhZGVyQW5kRm9vdGVyXTsKKyAgICBbc2Vs ZiBwZXJmb3JtU2VsZWN0b3JPbk1haW5UaHJlYWQ6QHNlbGVjdG9yKF9hZGp1c3RQcmludGluZ01h cmdpbnNGb3JIZWFkZXJBbmRGb290ZXIpIHdpdGhPYmplY3Q6bmlsIHdhaXRVbnRpbERvbmU6WUVT XTsKIAogICAgIGlmIChbc2VsZiBfaGFzUGFnZVJlY3RzXSkKICAgICAgICAgKnJhbmdlID0gTlNN YWtlUmFuZ2UoMSwgX3ByaW50aW5nUGFnZVJlY3RzLnNpemUoKSk7Cg==