<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>75736</bug_id>
          
          <creation_ts>2012-01-06 13:39:01 -0800</creation_ts>
          <short_desc>build failure in jit/JITStubs.h</short_desc>
          <delta_ts>2012-01-09 12:02:29 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P3</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Pavel Heimlich (hajma)">tropikhajma</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>531345</commentid>
    <comment_count>0</comment_count>
    <who name="Pavel Heimlich (hajma)">tropikhajma</who>
    <bug_when>2012-01-06 13:39:01 -0800</bug_when>
    <thetext>building Qt 4.8 on Solaris fails with the below error.
This is because Solaris Studio does not support fastcall

/opt/test2/SolarisStudio12.3-solaris-x86-bin/solarisstudio12.3/bin/CC -c -I../../../../../mkspecs/solaris-cc -I. -I../../../../../include/QtCore -I../../../../../include -I. -I../../Source -I../ThirdParty -Iassembler -Ibytecode -Ibytecompiler -Iheap -Idfg -Idebugger -Iinterpreter -Ijit -Iparser -Iprofiler -Iruntime -Iwtf -Iwtf/gobject -I/opt/test2/packages/BUILD/qt-4.8.0/i386/qt-everywhere-opensource-src-4.8.0/src/3rdparty/webkit/Source/JavaScriptCore/wtf/symbian -Iwtf/unicode -Iyarr -IAPI -IForwardingHeaders -Igenerated -I../../Source -I../../include -I/include/QtWebKit -I/include -I.moc/debug-static -I/usr/sfw/include -D_REENTRANT -DNDEBUG -D__EXTENSIONS__ -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_POSIX_PTHREAD_SEMANTICS -DSOLARIS -DNO_DEBUG -D_UNICODE -DUNICODE -D_RWSTD_REENTRANT -D_XOPEN_SOURCE=500 -D_XPG5 -I/opt/kde4/include -m32 -xarch=sse2 -features=extensions,nestedaccess,tmplrefstatic -template=geninlinefuncs -s -xlang=c99 -xustr=ascii_utf16_ushort -Qoption ccfe -features=gcc -Qoption ccfe -features=zla -Qoption ccfe ++boolflag:sunwcch=false -R/opt/kde4/lib -library=stdcxx4 -lCrun -I/usr/include/libpng14 -I/opt/kde4/include -I/usr/mysql/5.1/include/mysql -I/usr/include/libmng -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/odbc -KPIC -mt -DNDEBUG -DBUILDING_QT__=1 -DQT_ASCII_CAST_WARNINGS -DBUILDING_JavaScriptCore -DBUILDING_WTF -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -DQT_CORE_LIB -DQT_HAVE_MMX -DQT_HAVE_SSE -DQT_HAVE_MMXEXT -DQT_HAVE_SSE2 -DQT_HAVE_SSE3 -DQT_SHARED -o .obj/debug-static/DateMath.o wtf/DateMath.cpp
&quot;./wtf/OSAllocator.h&quot;, line 43: Warning: Identifier expected instead of &quot;}&quot;.
&quot;jit/JITStubs.h&quot;, line 270: Error: #error &quot;JIT_STUB function calls require fastcall conventions on x86, add appropriate directive/attribute here for your compiler!&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>531367</commentid>
    <comment_count>1</comment_count>
      <attachid>121488</attachid>
    <who name="Pavel Heimlich (hajma)">tropikhajma</who>
    <bug_when>2012-01-06 13:53:24 -0800</bug_when>
    <thetext>Created attachment 121488
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>532281</commentid>
    <comment_count>2</comment_count>
      <attachid>121488</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2012-01-09 10:30:16 -0800</bug_when>
    <thetext>Comment on attachment 121488
Patch

I assume that you want this landed. 

In the future, please mark patches with cq? to make the intention clear.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>532401</commentid>
    <comment_count>3</comment_count>
      <attachid>121488</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-01-09 12:02:24 -0800</bug_when>
    <thetext>Comment on attachment 121488
Patch

Clearing flags on attachment: 121488

Committed r104473: &lt;http://trac.webkit.org/changeset/104473&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>532402</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-01-09 12:02:29 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>121488</attachid>
            <date>2012-01-06 13:53:24 -0800</date>
            <delta_ts>2012-01-09 12:02:24 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-75736-20120106225058.patch</filename>
            <type>text/plain</type>
            <size>1169</size>
            <attacher name="Pavel Heimlich (hajma)">tropikhajma</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTA0MzMxKQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA
CisyMDEyLTAxLTA2ICBQYXZlbCBIZWltbGljaCAgPHRyb3Bpa2hham1hQGdtYWlsLmNvbT4KKwor
ICAgICAgICBUaGVyZSBpcyBubyBzdXBwb3J0IGZvciBmYXN0Y2FsbCBpbiBTb2xhcmlzIFN0dWRp
by4KKyAgICAgICAgRml4ZXMgYnVpbGQgb24gU29sYXJpcy4KKyAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1NzM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBqaXQvSklUU3R1YnMuaDoKKwogMjAxMi0wMS0w
NiAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEdldEJ5dGVBcnJh
eUxlbmd0aCBpcyBpbmNvcnJlY3QKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklU
U3R1YnMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJz
LmgJKHJldmlzaW9uIDEwMzE4MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1
YnMuaAkod29ya2luZyBjb3B5KQpAQCAtMjY5LDYgKzI2OSw4IEBAIG5hbWVzcGFjZSBKU0Mgewog
ICAgICNkZWZpbmUgSklUX1NUVUIgX19mYXN0Y2FsbAogICAgICNlbGlmIENPTVBJTEVSKEdDQykK
ICAgICAjZGVmaW5lIEpJVF9TVFVCICBfX2F0dHJpYnV0ZV9fICgoZmFzdGNhbGwpKQorICAgICNl
bGlmIENPTVBJTEVSKFNVTkNDKQorICAgICNkZWZpbmUgSklUX1NUVUIKICAgICAjZWxzZQogICAg
ICNlcnJvciAiSklUX1NUVUIgZnVuY3Rpb24gY2FsbHMgcmVxdWlyZSBmYXN0Y2FsbCBjb252ZW50
aW9ucyBvbiB4ODYsIGFkZCBhcHByb3ByaWF0ZSBkaXJlY3RpdmUvYXR0cmlidXRlIGhlcmUgZm9y
IHlvdXIgY29tcGlsZXIhIgogICAgICNlbmRpZgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>