75734 2012-01-06 13:07:56 -0800 Use HashMap<OwnPtr> in SVGAttributeToPropertyMap 2013-05-07 09:14:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 115653 P2 Normal --- 73757 1 cmarcelo cmarcelo darin dbates mrowe webkit.review.bot oldest_to_newest 531313 0 cmarcelo 2012-01-06 13:07:56 -0800 Use HashMap<OwnPtr> in SVGAttributeToPropertyMap 531318 1 121480 cmarcelo 2012-01-06 13:10:14 -0800 Created attachment 121480 Patch 531539 2 121480 webkit.review.bot 2012-01-06 17:24:23 -0800 Comment on attachment 121480 Patch Clearing flags on attachment: 121480 Committed r104362: <http://trac.webkit.org/changeset/104362> 531540 3 webkit.review.bot 2012-01-06 17:24:27 -0800 All reviewed patches have been landed. Closing bug. 531569 4 mrowe 2012-01-06 18:40:55 -0800 This broke the build by introducing a link error. It results in code trying to find __ZN3WTF6OwnPtrINS_6VectorIPKN7WebCore15SVGPropertyInfoELm0EEEEC1ERKS7_ (WTF::OwnPtr<WTF::Vector<WebCore::SVGPropertyInfo const*, 0ul> >::OwnPtr(WTF::OwnPtr<WTF::Vector<WebCore::SVGPropertyInfo const*, 0ul> > const&)). That's a copy-constructor for OwnPtr. OwnPtr can't be copied. 531570 5 mrowe 2012-01-06 18:46:36 -0800 Rolled out in r104369. 531571 6 mrowe 2012-01-06 18:47:50 -0800 Anders tells me that a HashMap with a KeyType whose traits specify emptyValueIsZero=false and whose ValueType is OwnPtr will result in a call to OwnPtr's copy constructor being generated, causing a build failure like this. 531704 7 dbates 2012-01-07 19:13:02 -0800 (In reply to comment #5) > Rolled out in r104369. Thank you Mark for looking into the failure and rolling this patch out. 532116 8 cmarcelo 2012-01-09 05:37:21 -0800 (In reply to comment #6) > Anders tells me that a HashMap with a KeyType whose traits specify emptyValueIsZero=false and whose ValueType is OwnPtr will result in a call to OwnPtr's copy constructor being generated, causing a build failure like this. Thanks for the rollout, Mark. I will look into this. 885762 9 darin 2013-05-07 09:14:42 -0700 *** This bug has been marked as a duplicate of bug 115653 *** 121480 2012-01-06 13:10:14 -0800 2012-01-06 17:24:23 -0800 Patch bug-75734-20120106181131.patch text/plain 4153 cmarcelo U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0MzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzQ4NjQzMWI0NTQ4ZDIy MDQ0ZTEyYWIzMjQ2OWFkZjM4M2VkYjAwYi4uYjYxZGRjNTgxODIwYTFmNjY5OTEwNzdjM2Q0YWZj MWJkNWEwOTBiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAxLTA2ICBDYWlv IE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8gIDxjYWlvLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+ CisKKyAgICAgICAgVXNlIEhhc2hNYXA8T3duUHRyPiBpbiBTVkdBdHRyaWJ1dGVUb1Byb3BlcnR5 TWFwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTcz NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3Zn L3Byb3BlcnRpZXMvU1ZHQXR0cmlidXRlVG9Qcm9wZXJ0eU1hcC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpTVkdBdHRyaWJ1dGVUb1Byb3BlcnR5TWFwOjphZGRQcm9wZXJ0aWVzKToKKyAgICAgICAg KFdlYkNvcmU6OlNWR0F0dHJpYnV0ZVRvUHJvcGVydHlNYXA6OmFkZFByb3BlcnR5KTogdXNlIEhh c2hNYXA6OmFkZCgpIHRvIGF2b2lkIGFuCisgICAgICAgIGV4dHJhIGhhc2ggbG9va3VwIHRvIHNl dCBhIG5ldyBQcm9wZXJ0aWVzVmVjdG9yLgorICAgICAgICAoV2ViQ29yZTo6U1ZHQXR0cmlidXRl VG9Qcm9wZXJ0eU1hcDo6c3luY2hyb25pemVQcm9wZXJ0aWVzKToKKyAgICAgICAgKiBzdmcvcHJv cGVydGllcy9TVkdBdHRyaWJ1dGVUb1Byb3BlcnR5TWFwLmg6CisKIDIwMTItMDEtMDYgIEplciBO b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgRnVsbHNjcmVlbiB2aWRlbyBj b250cm9sbGVyIGNhbid0IGJlIGRyYWdnZWQgdGhlIGZpcnN0IHRpbWUgSSBlbnRlciBmdWxsc2Ny ZWVuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvcHJvcGVydGllcy9TVkdBdHRyaWJ1 dGVUb1Byb3BlcnR5TWFwLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9wcm9wZXJ0aWVzL1NWR0F0 dHJpYnV0ZVRvUHJvcGVydHlNYXAuY3BwCmluZGV4IGJlMzFjYzNjN2RhMmY1MGY1MWY2OWI1NTQ0 MDI2NWRiMTM1YjUyOGMuLjczZThhMmQxMmVjMzNiZjNjMWQzZGU1NWYwNGU2Y2RkOWE2ZDU2MmUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9wcm9wZXJ0aWVzL1NWR0F0dHJpYnV0ZVRv UHJvcGVydHlNYXAuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9wcm9wZXJ0aWVzL1NWR0F0 dHJpYnV0ZVRvUHJvcGVydHlNYXAuY3BwCkBAIC0zMSw3ICszMSw3IEBAIHZvaWQgU1ZHQXR0cmli dXRlVG9Qcm9wZXJ0eU1hcDo6YWRkUHJvcGVydGllcyhTVkdBdHRyaWJ1dGVUb1Byb3BlcnR5TWFw JiBtYXApCiB7CiAgICAgQXR0cmlidXRlVG9Qcm9wZXJ0aWVzTWFwOjppdGVyYXRvciBlbmQgPSBt YXAubV9tYXAuZW5kKCk7CiAgICAgZm9yIChBdHRyaWJ1dGVUb1Byb3BlcnRpZXNNYXA6Oml0ZXJh dG9yIGl0ID0gbWFwLm1fbWFwLmJlZ2luKCk7IGl0ICE9IGVuZDsgKytpdCkgewotICAgICAgICBQ cm9wZXJ0aWVzVmVjdG9yKiB2ZWN0b3IgPSBpdC0+c2Vjb25kOworICAgICAgICBQcm9wZXJ0aWVz VmVjdG9yKiB2ZWN0b3IgPSBpdC0+c2Vjb25kLmdldCgpOwogICAgICAgICBBU1NFUlQodmVjdG9y KTsKIAogICAgICAgICBQcm9wZXJ0aWVzVmVjdG9yOjppdGVyYXRvciB2ZWN0b3JFbmQgPSB2ZWN0 b3ItPmVuZCgpOwpAQCAtNDQsMTMgKzQ0LDEwIEBAIHZvaWQgU1ZHQXR0cmlidXRlVG9Qcm9wZXJ0 eU1hcDo6YWRkUHJvcGVydHkoY29uc3QgU1ZHUHJvcGVydHlJbmZvKiBpbmZvKQogewogICAgIEFT U0VSVChpbmZvKTsKICAgICBBU1NFUlQoaW5mby0+YXR0cmlidXRlTmFtZSAhPSBhbnlRTmFtZSgp KTsKLSAgICBpZiAoUHJvcGVydGllc1ZlY3RvciogdmVjdG9yID0gbV9tYXAuZ2V0KGluZm8tPmF0 dHJpYnV0ZU5hbWUpKSB7Ci0gICAgICAgIHZlY3Rvci0+YXBwZW5kKGluZm8pOwotICAgICAgICBy ZXR1cm47Ci0gICAgfQotICAgIFByb3BlcnRpZXNWZWN0b3IqIHZlY3RvciA9IG5ldyBQcm9wZXJ0 aWVzVmVjdG9yOworICAgIE93blB0cjxQcm9wZXJ0aWVzVmVjdG9yPiYgdmVjdG9yID0gbV9tYXAu YWRkKGluZm8tPmF0dHJpYnV0ZU5hbWUsIG51bGxwdHIpLmZpcnN0LT5zZWNvbmQ7CisgICAgaWYg KCF2ZWN0b3IpCisgICAgICAgIHZlY3RvciA9IGFkb3B0UHRyKG5ldyBQcm9wZXJ0aWVzVmVjdG9y KTsKICAgICB2ZWN0b3ItPmFwcGVuZChpbmZvKTsKLSAgICBtX21hcC5zZXQoaW5mby0+YXR0cmli dXRlTmFtZSwgdmVjdG9yKTsKIH0KIAogdm9pZCBTVkdBdHRyaWJ1dGVUb1Byb3BlcnR5TWFwOjph bmltYXRlZFByb3BlcnRpZXNGb3JBdHRyaWJ1dGUoU1ZHRWxlbWVudCogb3duZXJUeXBlLCBjb25z dCBRdWFsaWZpZWROYW1lJiBhdHRyaWJ1dGVOYW1lLCBWZWN0b3I8UmVmUHRyPFNWR0FuaW1hdGVk UHJvcGVydHk+ID4mIHByb3BlcnRpZXMpCkBAIC04MSw3ICs3OCw3IEBAIHZvaWQgU1ZHQXR0cmli dXRlVG9Qcm9wZXJ0eU1hcDo6c3luY2hyb25pemVQcm9wZXJ0aWVzKFNWR0VsZW1lbnQqIGNvbnRl eHRFbGVtZW50CiAgICAgQVNTRVJUKGNvbnRleHRFbGVtZW50KTsKICAgICBBdHRyaWJ1dGVUb1By b3BlcnRpZXNNYXA6Oml0ZXJhdG9yIGVuZCA9IG1fbWFwLmVuZCgpOwogICAgIGZvciAoQXR0cmli dXRlVG9Qcm9wZXJ0aWVzTWFwOjppdGVyYXRvciBpdCA9IG1fbWFwLmJlZ2luKCk7IGl0ICE9IGVu ZDsgKytpdCkgewotICAgICAgICBQcm9wZXJ0aWVzVmVjdG9yKiB2ZWN0b3IgPSBpdC0+c2Vjb25k OworICAgICAgICBQcm9wZXJ0aWVzVmVjdG9yKiB2ZWN0b3IgPSBpdC0+c2Vjb25kLmdldCgpOwog ICAgICAgICBBU1NFUlQodmVjdG9yKTsKIAogICAgICAgICBQcm9wZXJ0aWVzVmVjdG9yOjppdGVy YXRvciB2ZWN0b3JFbmQgPSB2ZWN0b3ItPmVuZCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvc3ZnL3Byb3BlcnRpZXMvU1ZHQXR0cmlidXRlVG9Qcm9wZXJ0eU1hcC5oIGIvU291cmNlL1dl YkNvcmUvc3ZnL3Byb3BlcnRpZXMvU1ZHQXR0cmlidXRlVG9Qcm9wZXJ0eU1hcC5oCmluZGV4IDhl NGNkNTc3ZTZkZjQzY2ZkZmQ0MDQ1NTQxMTIzMTJjMzEyNmFkNmMuLjQyMDgzOTJiM2E2NDkwM2Zh YWE5YzU5MzRjOTA4ODk5ZjliZTRhN2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9w cm9wZXJ0aWVzL1NWR0F0dHJpYnV0ZVRvUHJvcGVydHlNYXAuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9zdmcvcHJvcGVydGllcy9TVkdBdHRyaWJ1dGVUb1Byb3BlcnR5TWFwLmgKQEAgLTMzLDkgKzMz LDYgQEAgc3RydWN0IFNWR1Byb3BlcnR5SW5mbzsKIAogY2xhc3MgU1ZHQXR0cmlidXRlVG9Qcm9w ZXJ0eU1hcCB7CiBwdWJsaWM6Ci0gICAgU1ZHQXR0cmlidXRlVG9Qcm9wZXJ0eU1hcCgpIHsgfQot ICAgIH5TVkdBdHRyaWJ1dGVUb1Byb3BlcnR5TWFwKCkgeyBkZWxldGVBbGxWYWx1ZXMobV9tYXAp OyB9Ci0KICAgICBib29sIGlzRW1wdHkoKSBjb25zdCB7IHJldHVybiBtX21hcC5pc0VtcHR5KCk7 IH0KIAogICAgIHZvaWQgYWRkUHJvcGVydGllcyhTVkdBdHRyaWJ1dGVUb1Byb3BlcnR5TWFwJik7 CkBAIC01Miw3ICs0OSw3IEBAIHByaXZhdGU6CiAgICAgUGFzc1JlZlB0cjxTVkdBbmltYXRlZFBy b3BlcnR5PiBhbmltYXRlZFByb3BlcnR5KFNWR0VsZW1lbnQqIGNvbnRleHRFbGVtZW50LCBjb25z dCBRdWFsaWZpZWROYW1lJiBhdHRyaWJ1dGVOYW1lLCBjb25zdCBTVkdQcm9wZXJ0eUluZm8qKTsK IAogICAgIHR5cGVkZWYgVmVjdG9yPGNvbnN0IFNWR1Byb3BlcnR5SW5mbyo+IFByb3BlcnRpZXNW ZWN0b3I7Ci0gICAgdHlwZWRlZiBIYXNoTWFwPFF1YWxpZmllZE5hbWUsIFByb3BlcnRpZXNWZWN0 b3IqPiBBdHRyaWJ1dGVUb1Byb3BlcnRpZXNNYXA7CisgICAgdHlwZWRlZiBIYXNoTWFwPFF1YWxp ZmllZE5hbWUsIE93blB0cjxQcm9wZXJ0aWVzVmVjdG9yPiA+IEF0dHJpYnV0ZVRvUHJvcGVydGll c01hcDsKICAgICBBdHRyaWJ1dGVUb1Byb3BlcnRpZXNNYXAgbV9tYXA7CiB9OwogCg==