75733 2012-01-06 13:01:14 -0800 build failure in wtf/ByteArray.cpp 2012-01-09 11:44:56 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Other RESOLVED FIXED P3 Normal --- 0 tropikhajma webkit-unassigned ap webkit.review.bot oldest_to_newest 531308 0 tropikhajma 2012-01-06 13:01:14 -0800 building Qt 4.8 fails with the below error. This is because Solaris Studio is stricter about the C++ standard than gcc. Adding Solaris Studio to the already existing ifdef for MSVC makes this go away. test2@solaris:~/packages/BUILD/qt-4.8.0/i386/qt-everywhere-opensource-src-4.8.0/src/3rdparty/webkit/Source/JavaScriptCore$ /opt/test2/SolarisStudio12.3-solaris-x86-bin/solarisstudio12.3/bin/CC -c -I../../../../../mkspecs/solaris-cc -I. -I../../../../../include/QtCore -I../../../../../include -I. -I../../Source -I../ThirdParty -Iassembler -Ibytecode -Ibytecompiler -Iheap -Idfg -Idebugger -Iinterpreter -Ijit -Iparser -Iprofiler -Iruntime -Iwtf -Iwtf/gobject -I/opt/test2/packages/BUILD/qt-4.8.0/i386/qt-everywhere-opensource-src-4.8.0/src/3rdparty/webkit/Source/JavaScriptCore/wtf/symbian -Iwtf/unicode -Iyarr -IAPI -IForwardingHeaders -Igenerated -I../../Source -I../../include -I/include/QtWebKit -I/include -I.moc/debug-static -I/usr/sfw/include -D_REENTRANT -DNDEBUG -D__EXTENSIONS__ -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_POSIX_PTHREAD_SEMANTICS -DSOLARIS -DNO_DEBUG -D_UNICODE -DUNICODE -D_RWSTD_REENTRANT -D_XOPEN_SOURCE=500 -D_XPG5 -I/opt/kde4/include -m32 -xarch=sse2 -features=extensions,nestedaccess,tmplrefstatic -template=geninlinefuncs -s -xlang=c99 -xustr=ascii_utf16_ushort -Qoption ccfe -features=gcc -Qoption ccfe -features=zla -Qoption ccfe ++boolflag:sunwcch=false -R/opt/kde4/lib -library=stdcxx4 -lCrun -I/usr/include/libpng14 -I/opt/kde4/include -I/usr/mysql/5.1/include/mysql -I/usr/include/libmng -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/odbc -KPIC -mt -DNDEBUG -DBUILDING_QT__=1 -DQT_ASCII_CAST_WARNINGS -DBUILDING_JavaScriptCore -DBUILDING_WTF -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -DQT_CORE_LIB -DQT_HAVE_MMX -DQT_HAVE_SSE -DQT_HAVE_MMXEXT -DQT_HAVE_SSE2 -DQT_HAVE_SSE3 -DQT_SHARED -o .obj/debug-static/ByteArray.o wtf/ByteArray.cpp "wtf/ByteArray.h", line 97: Error: In this declaration "m_data" is of an incomplete type "unsigned char[]". 1 Error(s) detected. This is on Solaris 11 using Solaris Studio 12.3 531317 1 121479 tropikhajma 2012-01-06 13:09:59 -0800 Created attachment 121479 Patch 532283 2 121479 ap 2012-01-09 10:30:41 -0800 Comment on attachment 121479 Patch I assume that you want this landed. In the future, please mark patches with cq? to make the intention clear. 532378 3 121479 webkit.review.bot 2012-01-09 11:44:52 -0800 Comment on attachment 121479 Patch Clearing flags on attachment: 121479 Committed r104471: <http://trac.webkit.org/changeset/104471> 532379 4 webkit.review.bot 2012-01-09 11:44:56 -0800 All reviewed patches have been landed. Closing bug. 121479 2012-01-06 13:09:59 -0800 2012-01-09 11:44:52 -0800 Patch bug-75733-20120106220732.patch text/plain 1184 tropikhajma SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTA0MzI2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDEyLTAxLTA2ICBQYXZlbCBIZWltbGljaCAgPHRyb3Bpa2hham1hQGdtYWlsLmNvbT4KKwor ICAgICAgICBGaXggYnVpbGQgZmFpbHVyZSBvbiBTb2xhcmlzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTczMworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL0J5dGVBcnJheS5oOgorCiAyMDEyLTAx LTA2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgRml4IGJ1aWxk LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9CeXRlQXJyYXkuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0J5dGVBcnJheS5oCShyZXZpc2lvbiAxMDMx ODApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0J5dGVBcnJheS5oCSh3b3JraW5nIGNv cHkpCkBAIC05Nyw3ICs5Nyw3IEBAIG5hbWVzcGFjZSBXVEYgewogLy8gTVNWQyBjYW4ndCBoYW5k bGUgY29ycmVjdGx5IHVuc2l6ZWQgYXJyYXkuCiAvLyB3YXJuaW5nIEM0MjAwOiBub25zdGFuZGFy ZCBleHRlbnNpb24gdXNlZCA6IHplcm8tc2l6ZWQgYXJyYXkgaW4gc3RydWN0L3VuaW9uCiAvLyBD YW5ub3QgZ2VuZXJhdGUgY29weS1jdG9yIG9yIGNvcHktYXNzaWdubWVudCBvcGVyYXRvciB3aGVu IFVEVCBjb250YWlucyBhIHplcm8tc2l6ZWQgYXJyYXkKLSNpZiBDT01QSUxFUihNU1ZDKSAmJiAh Q09NUElMRVIoSU5URUwpCisjaWYgKENPTVBJTEVSKE1TVkMpICB8fCBDT01QSUxFUihTVU5DQykp ICYmICFDT01QSUxFUihJTlRFTCkKICAgICAgICAgdW5zaWduZWQgY2hhciBtX2RhdGFbSU5UX01B WF07CiAjZWxzZQogICAgICAgICB1bnNpZ25lZCBjaGFyIG1fZGF0YVtdOwo=