75717 2012-01-06 11:10:29 -0800 [Chromium] Move setVisibleRect() calls for mask and replica layers into calculateDrawTransformAndVisibility() 2012-10-18 17:03:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 wangxianzhu webkit-unassigned enne shawnsingh wjmaclean oldest_to_newest 531179 0 wangxianzhu 2012-01-06 11:10:29 -0800 This is a followup of bug 72162 - Move setVisibleRect() calls into calculateDrawTransformAndVisibility(). setVisibleRect() calls for mask and replica layers are still in CCLayerTreeHost.cpp but they seem also belong to calculateDrawTransformAndVisibility(). Also some questions (copied from my comments to the patch of bug 72162 after it has been committed): 1. Why setVisibleLayerRect to the whole content bounds of the renderSurfaceLayer instead of the actual visible rect? 2. setVisibleLayerRect() for the replica layer seems lost after the patch. 531186 1 enne 2012-01-06 11:16:47 -0800 (In reply to comment #0) > This is a followup of bug 72162 - Move setVisibleRect() calls into calculateDrawTransformAndVisibility(). > setVisibleRect() calls for mask and replica layers are still in CCLayerTreeHost.cpp but they seem also belong to calculateDrawTransformAndVisibility(). > > Also some questions (copied from my comments to the patch of bug 72162 after it has been committed): > 1. Why setVisibleLayerRect to the whole content bounds of the renderSurfaceLayer instead of the actual visible rect? This sounds like an oversight. I can't think of why it would need to be this way. > 2. setVisibleLayerRect() for the replica layer seems lost after the patch. This sounds like it could be a bug. 745758 2 wangxianzhu 2012-10-18 17:03:35 -0700 The bug has been fixed in chromium.