75705 2012-01-06 08:54:03 -0800 [Chromium] Disable per-tile painting support on Windows. 2012-02-15 11:32:42 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P1 Critical --- 1 reveman reveman cc-bugs enne jamesr webkit.review.bot oldest_to_newest 531086 0 reveman 2012-01-06 08:54:03 -0800 Per-tile painting on WIN32 is not currently supported. Prevent it from being used and add ASSERT to reveal causes for it being enabled. 531087 1 reveman 2012-01-06 08:55:59 -0800 This is to fix http://code.google.com/p/chromium/issues/detail?id=107461 which still seem to be happening. 531088 2 121436 reveman 2012-01-06 08:58:21 -0800 Created attachment 121436 Patch 531093 3 enne 2012-01-06 09:10:40 -0800 Isn't perTilePainting exposed in about:flags? Wouldn't that be the cause of it being turned on? (That's really sad that per-tile painting is not supported on Windows. Are there bugs open to address this? I was really hoping that we could get that to be the default texture uploader sometime soon.) 531106 4 reveman 2012-01-06 09:22:00 -0800 (In reply to comment #3) > Isn't perTilePainting exposed in about:flags? Wouldn't that be the cause of it being turned on? Oh, that's right. We're probably still seeing this crash because users explicitly enable it. > > (That's really sad that per-tile painting is not supported on Windows. Are there bugs open to address this? I was really hoping that we could get that to be the default texture uploader sometime soon.) I haven't been able to determine the exact reason for why it's not working as don't have access to a Windows machine. I know that skia on Windows uses a HDC for text rendering and that breaks when using SkPictures. It still shouldn't crash the way it's currently doing. 531155 5 enne 2012-01-06 10:38:35 -0800 (In reply to comment #4) > I haven't been able to determine the exact reason for why it's not working as don't have access to a Windows machine. I know that skia on Windows uses a HDC for text rendering and that breaks when using SkPictures. It still shouldn't crash the way it's currently doing. If a bug isn't filed, can you file one? 531166 6 reveman 2012-01-06 10:49:51 -0800 (In reply to comment #5) > (In reply to comment #4) > > > I haven't been able to determine the exact reason for why it's not working as don't have access to a Windows machine. I know that skia on Windows uses a HDC for text rendering and that breaks when using SkPictures. It still shouldn't crash the way it's currently doing. > > If a bug isn't filed, can you file one? Done. https://bugs.webkit.org/show_bug.cgi?id=75715 531198 7 jamesr 2012-01-06 11:25:29 -0800 Please disable the about:flags entry on windows on the chrome side if it doesn't work. That might be sufficient for this issue. 531203 8 121436 jamesr 2012-01-06 11:29:18 -0800 Comment on attachment 121436 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121436&action=review > Source/WebCore/platform/graphics/chromium/ContentLayerChromium.cpp:127 > +#if defined(WIN32) in WebKit we use OS(WINDOWS) > Source/WebCore/platform/graphics/chromium/ContentLayerChromium.cpp:128 > + ASSERT(!host->settings().perTilePainting); not sure this is useful to have. if we don't want to support the flag, then we should just ignore it > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:99 > +#if defined(WIN32) > + ASSERT(!m_settings.perTilePainting); // No per-tile painting support on Windows. > +#endif how is this helpful? it won't help us with crashes in the field, since ASSERT()s are only active in debug builds 531249 9 121464 reveman 2012-01-06 12:13:39 -0800 Created attachment 121464 Patch 531282 10 121464 jamesr 2012-01-06 12:36:51 -0800 Comment on attachment 121464 Patch This looks good. It will make life a little harder for people trying to fix per-tile painting, so would you mind waiting to see if the about:flags entry gets the crashrate down low enough on canaries such that we don't need to do this before landing it? R=me 531284 11 reveman 2012-01-06 12:41:06 -0800 (In reply to comment #10) > (From update of attachment 121464 [details]) > This looks good. It will make life a little harder for people trying to fix per-tile painting, so would you mind waiting to see if the about:flags entry gets the crashrate down low enough on canaries such that we don't need to do this before landing it? > > R=me yup, I think that's a good idea. 121436 2012-01-06 08:58:21 -0800 2012-01-06 12:13:36 -0800 Patch bug-75705-20120106115820.patch text/plain 3105 reveman U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0MjkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWI1ZTRiYzQ3MGFkZTNl NWY5ZDk4ZDYzZWY0MzI1NjczMjg2YjYwNy4uY2I3MzZmNzg5ZWIxYWQ0MzZkY2I4NTIwMGMyZTc3 ZGEzMmU3ODJlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTAxLTA2ICBEYXZp ZCBSZXZlbWFuICA8cmV2ZW1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBE aXNhYmxlIHBlci10aWxlIHBhaW50aW5nIHN1cHBvcnQgb24gV2luZG93cy4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1NzA1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGVyLXRpbGUgcGFpbnRpbmcgb24g V0lOMzIgaXMgbm90IGN1cnJlbnRseSBzdXBwb3J0ZWQuIFByZXZlbnQgaXQKKyAgICAgICAgZnJv bSBiZWluZyB1c2VkIGFuZCBhZGQgQVNTRVJUIHRvIHJldmVhbCBjYXVzZXMgZm9yIGl0IGJlaW5n IGVuYWJsZWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vQ29udGVudExheWVyQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2Vi Q29yZTo6Q29udGVudExheWVyQ2hyb21pdW06OmNyZWF0ZVRleHR1cmVVcGRhdGVyKToKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3QuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Q0NMYXllclRyZWVIb3N0Ojppbml0aWFsaXplKToKKwogMjAxMi0w MS0wNSAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVT U0lPTiAocjEwNDA2MCk6IGZhc3QvZm9ybXMvdGV4dGFyZWEtbWV0cmljcy5odG1sIGlzIGZhaWxp bmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L0NvbnRlbnRMYXllckNocm9taXVtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL0NvbnRlbnRMYXllckNocm9taXVtLmNwcAppbmRleCBlZjEwNWI1M2ZmZWFi MTM5OWI1MjNkOGM3ZDc5MDI1MTI1YTM2Yzk3Li4zMjA2YjdlNTU2MDM3ZDdlOTE5YzVkNWVlOWMw OTVhODgyNjAyOWVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9Db250ZW50TGF5ZXJDaHJvbWl1bS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vQ29udGVudExheWVyQ2hyb21pdW0uY3BwCkBAIC0x MjQsMTAgKzEyNCwxNCBAQCB2b2lkIENvbnRlbnRMYXllckNocm9taXVtOjpjcmVhdGVUZXh0dXJl VXBkYXRlcihjb25zdCBDQ0xheWVyVHJlZUhvc3QqIGhvc3QpCiAgICAgICAgIHJldHVybjsKICAg ICB9CiAKKyNpZiBkZWZpbmVkKFdJTjMyKQorICAgIEFTU0VSVCghaG9zdC0+c2V0dGluZ3MoKS5w ZXJUaWxlUGFpbnRpbmcpOworI2Vsc2UKICAgICBpZiAoaG9zdC0+c2V0dGluZ3MoKS5wZXJUaWxl UGFpbnRpbmcpIHsKICAgICAgICAgbV90ZXh0dXJlVXBkYXRlciA9IEJpdG1hcFNrUGljdHVyZUNh bnZhc0xheWVyVGV4dHVyZVVwZGF0ZXI6OmNyZWF0ZShDb250ZW50TGF5ZXJQYWludGVyOjpjcmVh dGUobV9kZWxlZ2F0ZSksIGhvc3QtPmxheWVyUmVuZGVyZXJDYXBhYmlsaXRpZXMoKS51c2luZ01h cFN1Yik7CiAgICAgICAgIHJldHVybjsKICAgICB9CisjZW5kaWYgLy8gV0lOMzIKICNlbmRpZiAv LyBVU0UoU0tJQSkKIAogICAgIG1fdGV4dHVyZVVwZGF0ZXIgPSBCaXRtYXBDYW52YXNMYXllclRl eHR1cmVVcGRhdGVyOjpjcmVhdGUoQ29udGVudExheWVyUGFpbnRlcjo6Y3JlYXRlKG1fZGVsZWdh dGUpLCBob3N0LT5sYXllclJlbmRlcmVyQ2FwYWJpbGl0aWVzKCkudXNpbmdNYXBTdWIpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NM YXllclRyZWVIb3N0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL2NjL0NDTGF5ZXJUcmVlSG9zdC5jcHAKaW5kZXggMzc5ZDE2MDgzNzU5ODRlNTk0YjI1OGIw MjgwN2JkZDUwYzY1NTRhOS4uN2IxOWUwNTAxMWY3ZDNmY2FlM2NjNzMzN2I4YWM2MTEwY2QwMGI3 OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0v Y2MvQ0NMYXllclRyZWVIb3N0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3QuY3BwCkBAIC05NCw2ICs5NCwxMCBAQCBi b29sIENDTGF5ZXJUcmVlSG9zdDo6aW5pdGlhbGl6ZSgpCiAgICAgLy8gVXBkYXRlIG1fc2V0dGlu Z3MgYmFzZWQgb24gY2FwYWJpbGl0aWVzIHRoYXQgd2UgZ290IGJhY2sgZnJvbSB0aGUgcmVuZGVy ZXIuCiAgICAgbV9zZXR0aW5ncy5hY2NlbGVyYXRlUGFpbnRpbmcgPSBtX3Byb3h5LT5sYXllclJl bmRlcmVyQ2FwYWJpbGl0aWVzKCkudXNpbmdBY2NlbGVyYXRlZFBhaW50aW5nOwogCisjaWYgZGVm aW5lZChXSU4zMikKKyAgICBBU1NFUlQoIW1fc2V0dGluZ3MucGVyVGlsZVBhaW50aW5nKTsgLy8g Tm8gcGVyLXRpbGUgcGFpbnRpbmcgc3VwcG9ydCBvbiBXaW5kb3dzLgorI2VuZGlmCisKICAgICBt X2NvbnRlbnRzVGV4dHVyZU1hbmFnZXIgPSBUZXh0dXJlTWFuYWdlcjo6Y3JlYXRlKFRleHR1cmVN YW5hZ2VyOjpoaWdoTGltaXRCeXRlcyh2aWV3cG9ydFNpemUoKSksCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBUZXh0dXJlTWFuYWdlcjo6cmVj bGFpbUxpbWl0Qnl0ZXModmlld3BvcnRTaXplKCkpLAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbV9wcm94eS0+bGF5ZXJSZW5kZXJlckNhcGFi aWxpdGllcygpLm1heFRleHR1cmVTaXplKTsK 121464 2012-01-06 12:13:39 -0800 2012-01-06 12:36:51 -0800 Patch bug-75705-20120106151338.patch text/plain 1796 reveman U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0MjkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWI1ZTRiYzQ3MGFkZTNl NWY5ZDk4ZDYzZWY0MzI1NjczMjg2YjYwNy4uMmIzYTI4ZTAwOWUwYTU4NDBkYTRjMGY0NjdiNmY2 OTVjYmUzMTMyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAxLTA2ICBEYXZp ZCBSZXZlbWFuICA8cmV2ZW1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBE aXNhYmxlIHBlci10aWxlIHBhaW50aW5nIHN1cHBvcnQgb24gV2luZG93cy4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1NzA1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHJldmVudCBwZXItdGlsZSBwYWlu dGluZyBmcm9tIGJlaW5nIHVzZWQgb24gV2luZG93cy4KKworICAgICAgICBObyBuZXcgdGVzdHMu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Db250ZW50TGF5ZXJDaHJv bWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb250ZW50TGF5ZXJDaHJvbWl1bTo6Y3JlYXRl VGV4dHVyZVVwZGF0ZXIpOgorCiAyMDEyLTAxLTA1ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFw cGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMTA0MDYwKTogZmFzdC9mb3Jtcy90ZXh0 YXJlYS1tZXRyaWNzLmh0bWwgaXMgZmFpbGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vQ29udGVudExheWVyQ2hyb21pdW0uY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vQ29udGVudExheWVyQ2hyb21p dW0uY3BwCmluZGV4IGVmMTA1YjUzZmZlYWIxMzk5YjUyM2Q4YzdkNzkwMjUxMjVhMzZjOTcuLjNi NGEzNTNjMzI2MzhiNGFlMDAzM2UyMjMwYjEzMWE3NGU5ODNlOGQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0NvbnRlbnRMYXllckNocm9taXVt LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Db250 ZW50TGF5ZXJDaHJvbWl1bS5jcHAKQEAgLTEyNCwxMCArMTI0LDEyIEBAIHZvaWQgQ29udGVudExh eWVyQ2hyb21pdW06OmNyZWF0ZVRleHR1cmVVcGRhdGVyKGNvbnN0IENDTGF5ZXJUcmVlSG9zdCog aG9zdCkKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAorI2lmICFPUyhXSU5ET1dTKQogICAgIGlm IChob3N0LT5zZXR0aW5ncygpLnBlclRpbGVQYWludGluZykgewogICAgICAgICBtX3RleHR1cmVV cGRhdGVyID0gQml0bWFwU2tQaWN0dXJlQ2FudmFzTGF5ZXJUZXh0dXJlVXBkYXRlcjo6Y3JlYXRl KENvbnRlbnRMYXllclBhaW50ZXI6OmNyZWF0ZShtX2RlbGVnYXRlKSwgaG9zdC0+bGF5ZXJSZW5k ZXJlckNhcGFiaWxpdGllcygpLnVzaW5nTWFwU3ViKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0K KyNlbmRpZiAvLyAhT1MoV0lORE9XUykKICNlbmRpZiAvLyBVU0UoU0tJQSkKIAogICAgIG1fdGV4 dHVyZVVwZGF0ZXIgPSBCaXRtYXBDYW52YXNMYXllclRleHR1cmVVcGRhdGVyOjpjcmVhdGUoQ29u dGVudExheWVyUGFpbnRlcjo6Y3JlYXRlKG1fZGVsZWdhdGUpLCBob3N0LT5sYXllclJlbmRlcmVy Q2FwYWJpbGl0aWVzKCkudXNpbmdNYXBTdWIpOwo=