75703 2012-01-06 08:29:25 -0800 [Chromium] Shift PathSkia to use Skia's new RawIter 2012-01-10 08:54:48 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 71820 1 schenney schenney dglazkov jamesr kbr senorblanco thakis webkit.review.bot zimmermann oldest_to_newest 531079 0 schenney 2012-01-06 08:29:25 -0800 Skia Changeset 2962, now used by the Chromium port, includes a path iterator that returns all points without clean-up or embellishment. The WebCore::Path::apply method should use this new iterator, as it provides information necessary for correct marker and linecap drawing. 531220 1 zimmermann 2012-01-06 11:49:53 -0800 This won't help other platforms, and it should really be fixed for all. I vote against this. 531241 2 121462 schenney 2012-01-06 12:06:17 -0800 Created attachment 121462 Patch 531246 3 schenney 2012-01-06 12:10:15 -0800 I verified the behavior for canvas layout tests and SVG layout tests. Some SVG results are fixed by this, hence the test_expectations update. 531253 4 schenney 2012-01-06 12:17:21 -0800 (In reply to comment #1) > This won't help other platforms, and it should really be fixed for all. I vote against this. It doesn't change anything for other platforms, but is a pre-requisite for fixing all platforms. See https://bugs.webkit.org/show_bug.cgi?id=71820 for the linecap issues, which I will put a patch up for as soon as this is in. Then there another bug someplace for marker drawing issues, that I will deal with next. 531314 5 121462 zimmermann 2012-01-06 13:08:13 -0800 Comment on attachment 121462 Patch Sorry Stephen, I misunderstood! This looks fine, especially if its required to fix the linecaps bugs, r=me. 531328 6 121462 senorblanco 2012-01-06 13:15:47 -0800 Comment on attachment 121462 Patch Will this change affect non-SVG callers of Path::apply()? Also, you'll probably also need to roll webkit's chromium DEPS (in Source/WebKit/chromium/DEPS) to past the Skia roll that brought in the RawIter, in order to avoid breaking the compile of the build.webkit.org bots. 531333 7 121462 webkit.review.bot 2012-01-06 13:20:03 -0800 Comment on attachment 121462 Patch Attachment 121462 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11173068 531435 8 schenney 2012-01-06 15:08:50 -0800 (In reply to comment #6) > (From update of attachment 121462 [details]) > Will this change affect non-SVG callers of Path::apply()? > > Also, you'll probably also need to roll webkit's chromium DEPS (in Source/WebKit/chromium/DEPS) to past the Skia roll that brought in the RawIter, in order to avoid breaking the compile of the build.webkit.org bots. Argh. I was not requesting commit queue so that we could sort out the Skia deps or other Chromium issues, but I guess it was attempted anyway. The only other code that uses the platform/graphics/Path... code is canvas, and all the canvas checks pass. I'll look for explicit usage before committing, but I'm confident we're good to go. I also verified that the JS code does not rely on this representation when reporting on SVG data (and canvas is purely imperative). Let's have the US east coast teams coordinate on Monday morning to roll the WebKit Skia deps so we can first deal with any issues that arise, without the complication of another change at the same time. Then, when all is clear, we can commit this. 531895 9 121462 krit 2012-01-08 17:40:18 -0800 Comment on attachment 121462 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121462&action=review > Source/WebCore/platform/graphics/Path.h:83 > + PathElementMoveToPoint, // points contains 1 value I assume you mean // Points contain 1 value. Use sentences for comments. s/contains/contain/ Please fix that before landing. 533084 10 121850 schenney 2012-01-10 08:10:08 -0800 Created attachment 121850 Patch This slightly modified patch addresses the comment issue. 533118 11 121850 webkit.review.bot 2012-01-10 08:54:43 -0800 Comment on attachment 121850 Patch Clearing flags on attachment: 121850 Committed r104585: <http://trac.webkit.org/changeset/104585> 533119 12 webkit.review.bot 2012-01-10 08:54:48 -0800 All reviewed patches have been landed. Closing bug. 121462 2012-01-06 12:06:17 -0800 2012-01-10 08:10:03 -0800 Patch bug-75703-20120106150616.patch text/plain 4771 schenney SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNDMxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDEyLTAxLTA2ICBTdGVwaGVu IENoZW5uZXkgIDxzY2hlbm5leUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBT aGlmdCBQYXRoU2tpYSB0byB1c2UgU2tpYSdzIG5ldyBSYXdJdGVyCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTcwMworCisgICAgICAgIFRoZSBwcmlv ciBTa2lhIHBhdGggaXRlcmF0aW9uIGNvZGUgY2xlYW5lZCB0aGUgcGF0aCBhcyBpdCBpdGVyYXRl ZCwKKyAgICAgICAgY2xvc2luZyBzZWdtZW50cyBhbmQgYWRkaW5nIG1vdmVzIGV0Yy4gVGhpcyBj YXVzZWQgcHJvYmxlbXMgZm9yIFdlYktpdAorICAgICAgICBTVkcsIHdoZXJlIHRoZSB1bi1tb2Rp ZmllZCBwYXRoIGRhdGEgaXMgcmVxdWlyZWQgZm9yCisgICAgICAgIG1hcmtlcnMgYW5kIGxpbmVj YXBzLiBTa2lhIGhhZCBhIG5ldyBTa1BhdGg6OjpSYXdJdGVyIGFkZGVkIHRvIHByb3ZpZGUKKyAg ICAgICAgcmF3IGRhdGEsIGFuZCB0aGlzIHBhdGNoIG1vZGlmaWVzIFBhdGhTa2lhIHRvIHVzZSB0 aGUgbmV3IHRlY2huaXF1ZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBQcmUtZXhpc3RpbmcgdGVzdGluZyBjb3ZlcnMgdGhlIGJlaGF2aW9yLCBhbHRo b3VnaCB0aGUgcHJlLWV4aXN0aW5nCisgICAgICAgIHRlc3QgcmVzdWx0cyBhcmUgaW4gZmFjdCBp bmNvcnJlY3QgYWNjb3JkaW5nIHRvIHRoZSBTVkcgc3BlYy4gVGhpcworICAgICAgICBjaGFuZ2Ug Zml4ZXMgdGhvc2UgcmVzdWx0cy4gVGhleSBhcmUgbWFya2VkIGZsYWtleSBmb3Igbm93IHBlbmRp bmcgbmV3CisgICAgICAgIGJhc2VsaW5lcy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L1BhdGguaDogQWRkIGNvbW1lbnRzIGZvciB0aGUgZXhwZWN0ZWQgYmVoYXZpb3Igb2YgcGF0aCBp dGVyYXRpb24uCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QYXRoU2tpYS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpQYXRoOjphcHBseSk6IFN3aXRjaCBmcm9tIFNrUGF0aDo6SXRl ciB0byBTa1BhdGg6OlJhd0l0ZXIuCisKIDIwMTItMDEtMDYgIFdlaSBKYW1lcyAgPGphbWVzLndl aUBpbnRlbC5jb20+CiAKICAgICAgICAgVXNlIFZlY3Rvck1hdGggbGliIHdoZW4gcG9zc2libGUg dG8gb3B0aW1pemUgdGhlIHByb2Nlc3NpbmcgaW4gV2ViQXVkaW8gQXVkaW9CdXMKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1BhdGguaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9QYXRoLmgJKHJldmlzaW9uIDEwNDI5MykKKysr IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1BhdGguaAkod29ya2luZyBjb3B5KQpA QCAtODAsMTMgKzgwLDE2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICBjbGFzcyBTdHJva2VT dHlsZUFwcGxpZXI7CiAKICAgICBlbnVtIFBhdGhFbGVtZW50VHlwZSB7Ci0gICAgICAgIFBhdGhF bGVtZW50TW92ZVRvUG9pbnQsCi0gICAgICAgIFBhdGhFbGVtZW50QWRkTGluZVRvUG9pbnQsCi0g ICAgICAgIFBhdGhFbGVtZW50QWRkUXVhZEN1cnZlVG9Qb2ludCwKLSAgICAgICAgUGF0aEVsZW1l bnRBZGRDdXJ2ZVRvUG9pbnQsCi0gICAgICAgIFBhdGhFbGVtZW50Q2xvc2VTdWJwYXRoCisgICAg ICAgIFBhdGhFbGVtZW50TW92ZVRvUG9pbnQsIC8vIHBvaW50cyBjb250YWlucyAxIHZhbHVlCisg ICAgICAgIFBhdGhFbGVtZW50QWRkTGluZVRvUG9pbnQsIC8vIHBvaW50cyBjb250YWlucyAxIHZh bHVlCisgICAgICAgIFBhdGhFbGVtZW50QWRkUXVhZEN1cnZlVG9Qb2ludCwgLy8gcG9pbnRzIGNv bnRhaW5zIDIgdmFsdWVzCisgICAgICAgIFBhdGhFbGVtZW50QWRkQ3VydmVUb1BvaW50LCAvLyBw b2ludHMgY29udGFpbnMgMyB2YWx1ZXMKKyAgICAgICAgUGF0aEVsZW1lbnRDbG9zZVN1YnBhdGgg Ly8gcG9pbnRzIGNvbnRhaW5zIG5vdGhpbmcKICAgICB9OwogCisgICAgLy8gVGhlIHBvaW50cyBp biB0aGUgc3R1cmN0dXJlIGFyZSB0aGUgc2FtZSBhcyB0aG9zZSB0aGF0IHdvdWxkIGJlIHVzZWQg d2l0aCB0aGUKKyAgICAvLyBhZGQuLi4gbWV0aG9kLiBGb3IgZXhhbXBsZSwgYSBsaW5lIHJldHVy bnMgdGhlIGVuZHBvaW50LCB3aGlsZSBhIGN1YmljIHJldHVybnMKKyAgICAvLyB0d28gdGFuZ2Vu dCBwb2ludHMgYW5kIHRoZSBlbmRwb2ludC4KICAgICBzdHJ1Y3QgUGF0aEVsZW1lbnQgewogICAg ICAgICBQYXRoRWxlbWVudFR5cGUgdHlwZTsKICAgICAgICAgRmxvYXRQb2ludCogcG9pbnRzOwpJ bmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QYXRoU2tpYS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QYXRo U2tpYS5jcHAJKHJldmlzaW9uIDEwNDI5MykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3NraWEvUGF0aFNraWEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xOTcsNyArMTk3LDcg QEAgc3RhdGljIEZsb2F0UG9pbnQqIGNvbnZlcnRQYXRoUG9pbnRzKEZsbwogCiB2b2lkIFBhdGg6 OmFwcGx5KHZvaWQqIGluZm8sIFBhdGhBcHBsaWVyRnVuY3Rpb24gZnVuY3Rpb24pIGNvbnN0CiB7 Ci0gICAgU2tQYXRoOjpJdGVyIGl0ZXIoKm1fcGF0aCwgZmFsc2UpOworICAgIFNrUGF0aDo6UmF3 SXRlciBpdGVyKCptX3BhdGgpOwogICAgIFNrUG9pbnQgcHRzWzRdOwogICAgIFBhdGhFbGVtZW50 IHBhdGhFbGVtZW50OwogICAgIEZsb2F0UG9pbnQgcGF0aFBvaW50c1szXTsKSW5kZXg6IExheW91 dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwNDMxMCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDEyLTAxLTA2ICBTdGVwaGVuIENoZW5uZXkgIDxzY2hlbm5leUBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBTaGlmdCBQYXRoU2tpYSB0byB1c2Ug U2tpYSdzIG5ldyBSYXdJdGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD03NTcwMworCisgICAgICAgIE1hcmtpbmcgdGVzdHMgYXMgZmxha2V5IHdoaWxl IHRoaXMgcGF0Y2ggbW92ZXMgdGhyb3VnaCB0aGUgYnVpbGQgc3lzdGVtLiBOZXcgYmFzZWxpbmVz IGFyZSByZXF1aXJlZC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoKKwogMjAx Mi0wMS0wNiAgRG1pdHJ5IExvbW92ICA8ZHNsb21vdkBnb29nbGUuY29tPgogCiAgICAgICAgIFVu cmV2aWV3ZWQ6IFtDaHJvbWl1bV0gcmViYXNlbGluaW5nIElNQUdFIGV4cGVjdGF0aW9ucyBhZnRl ciBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xMDQyNDAvCkluZGV4OiBMYXlvdXRU ZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CShy ZXZpc2lvbiAxMDQyOTMpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4 cGVjdGF0aW9ucy50eHQJKHdvcmtpbmcgY29weSkKQEAgLTg3OCw2ICs4NzgsMTEgQEAgQlVHQ1Iy MzQ2MyBMSU5VWCBXSU4gOiBzdmcvVzNDLVNWRy0xLjEvcwogLy8gTWVyZ2UgMzk3NDQ6Mzk4Mjkg LSByZWdyZXNzaW9uCiBCVUdDUjEwMjg0IE1BQyA6IHN2Zy9jdXN0b20vcGF0aC1iYWQtZGF0YS5z dmcgPSBGQUlMCiAKKy8vIE5lZWRzIHJlYmFzZWxpbmluZyBhZnRlciBCVUdXSzc1NzAzLiBPbGQg cmVzdWx0cyBhcmUsIGluIGZhY3QsIGluY29ycmVjdC4KK0JVR1dLNzU3MDMgOiBzdmcvY3VzdG9t L3NoYXBlcy1zdXBwb3J0aW5nLW1hcmtlcnMuc3ZnID0gUEFTUyBJTUFHRStURVhUIFRFWFQgSU1B R0UKK0JVR1dLNzU3MDMgOiBzdmcvVzNDLVNWRy0xLjEvcGFpbnRpbmctbWFya2VyLTAyLWYuc3Zn ID0gUEFTUyBJTUFHRSAKK0JVR1dLNzU3MDMgOiBzdmcvVzNDLVNWRy0xLjEvcGFpbnRpbmctbWFy a2VyLTAzLWYuc3ZnID0gUEFTUyBJTUFHRSAKKwogLy8gVGV4dCBtaXNtYXRjaCBzaW5jZSByNjUz NzAuCiAvLyBUaGVyZSB3YXMgYWxzbyBhbiB1bm5vdGljZWQgaW1hZ2UgbWlzbWF0Y2ggYmVmb3Jl IHRoaXMgcmV2aXNpb24KIC8vICh3cm9uZyBiYXNlbGluZSB3YXMgY29tbWl0dGVkKS4gTm8gaWRl YSBhYm91dCB3aGVuIGl0IHJlYWxseSBzdGFydGVkIHRvIGZhaWwuCg== 121850 2012-01-10 08:10:08 -0800 2012-01-10 08:54:43 -0800 Patch bug-75703-20120110111007.patch text/plain 4206 schenney SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNDU3OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAxLTEwICBTdGVwaGVu IENoZW5uZXkgIDxzY2hlbm5leUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBT aGlmdCBQYXRoU2tpYSB0byB1c2UgU2tpYSdzIG5ldyBSYXdJdGVyCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTcwMworCisgICAgICAgIFJldmlld2Vk IGJ5IE5pa29sYXMgWmltbWVybWFubi4KKworICAgICAgICBObyBuZXcgdGVzdHMgcmVxdWlyZWQg LSBjb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvUGF0aC5oOiBBZGRlZCBjb21tZW50cyBvbnQgaGUgcmV0dXJuIHZhbHVlcyBmcm9tIGl0ZXJh dGlvbi4KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BhdGhTa2lhLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlBhdGg6OmFwcGx5KTogU3dpdGNoZWQgdG8gU2tQYXRoOjpSYXdJdGVy CisKIDIwMTItMDEtMTAgIFBldGVyIEJldmVybG9vICA8cGV0ZXJAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFtDaHJvbWl1bV0gVXNlIFNrRm9udEhvc3Q6OkdldFVuaXRzUGVyRW0gaW5zdGVhZCBv ZiBhZHZhbmNlZCB0eXBlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Q YXRoLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGF0 aC5oCShyZXZpc2lvbiAxMDQ1NzUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9QYXRoLmgJKHdvcmtpbmcgY29weSkKQEAgLTgwLDEzICs4MCwxNiBAQCBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAgICAgY2xhc3MgU3Ryb2tlU3R5bGVBcHBsaWVyOwogCiAgICAgZW51bSBQYXRoRWxl bWVudFR5cGUgewotICAgICAgICBQYXRoRWxlbWVudE1vdmVUb1BvaW50LAotICAgICAgICBQYXRo RWxlbWVudEFkZExpbmVUb1BvaW50LAotICAgICAgICBQYXRoRWxlbWVudEFkZFF1YWRDdXJ2ZVRv UG9pbnQsCi0gICAgICAgIFBhdGhFbGVtZW50QWRkQ3VydmVUb1BvaW50LAotICAgICAgICBQYXRo RWxlbWVudENsb3NlU3VicGF0aAorICAgICAgICBQYXRoRWxlbWVudE1vdmVUb1BvaW50LCAvLyBU aGUgcG9pbnRzIG1lbWJlciB3aWxsIGNvbnRhaW4gMSB2YWx1ZS4KKyAgICAgICAgUGF0aEVsZW1l bnRBZGRMaW5lVG9Qb2ludCwgLy8gVGhlIHBvaW50cyBtZW1iZXIgd2lsbCBjb250YWluIDEgdmFs dWUuCisgICAgICAgIFBhdGhFbGVtZW50QWRkUXVhZEN1cnZlVG9Qb2ludCwgLy8gVGhlIHBvaW50 cyBtZW1iZXIgd2lsbCBjb250YWluIDIgdmFsdWVzLgorICAgICAgICBQYXRoRWxlbWVudEFkZEN1 cnZlVG9Qb2ludCwgLy8gVGhlIHBvaW50cyBtZW1iZXIgd2lsbCBjb250YWluIDMgdmFsdWVzLgor ICAgICAgICBQYXRoRWxlbWVudENsb3NlU3VicGF0aCAvLyBUaGUgcG9pbnRzIG1lbWJlciB3aWxs IGNvbnRhaW4gbm8gdmFsdWVzLgogICAgIH07CiAKKyAgICAvLyBUaGUgcG9pbnRzIGluIHRoZSBz dHVyY3R1cmUgYXJlIHRoZSBzYW1lIGFzIHRob3NlIHRoYXQgd291bGQgYmUgdXNlZCB3aXRoIHRo ZQorICAgIC8vIGFkZC4uLiBtZXRob2QuIEZvciBleGFtcGxlLCBhIGxpbmUgcmV0dXJucyB0aGUg ZW5kcG9pbnQsIHdoaWxlIGEgY3ViaWMgcmV0dXJucworICAgIC8vIHR3byB0YW5nZW50IHBvaW50 cyBhbmQgdGhlIGVuZHBvaW50LgogICAgIHN0cnVjdCBQYXRoRWxlbWVudCB7CiAgICAgICAgIFBh dGhFbGVtZW50VHlwZSB0eXBlOwogICAgICAgICBGbG9hdFBvaW50KiBwb2ludHM7CkluZGV4OiBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BhdGhTa2lhLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BhdGhTa2lhLmNw cAkocmV2aXNpb24gMTA0NTc1KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv c2tpYS9QYXRoU2tpYS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE5Nyw3ICsxOTcsNyBAQCBzdGF0 aWMgRmxvYXRQb2ludCogY29udmVydFBhdGhQb2ludHMoRmxvCiAKIHZvaWQgUGF0aDo6YXBwbHko dm9pZCogaW5mbywgUGF0aEFwcGxpZXJGdW5jdGlvbiBmdW5jdGlvbikgY29uc3QKIHsKLSAgICBT a1BhdGg6Okl0ZXIgaXRlcigqbV9wYXRoLCBmYWxzZSk7CisgICAgU2tQYXRoOjpSYXdJdGVyIGl0 ZXIoKm1fcGF0aCk7CiAgICAgU2tQb2ludCBwdHNbNF07CiAgICAgUGF0aEVsZW1lbnQgcGF0aEVs ZW1lbnQ7CiAgICAgRmxvYXRQb2ludCBwYXRoUG9pbnRzWzNdOwpJbmRleDogTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24g MTA0NTc4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTMgQEAKKzIwMTItMDEtMTAgIFN0ZXBoZW4gQ2hlbm5leSAgPHNjaGVubmV5QGNocm9taXVt Lm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIFNoaWZ0IFBhdGhTa2lhIHRvIHVzZSBTa2lhJ3Mg bmV3IFJhd0l0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTc1NzAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTmlrb2xhcyBaaW1tZXJtYW5uLgorCisg ICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0OiBVcGRhdGVk IGVweGVjdGF0aW9uIGZvcgorICAgICAgICAgIHRlc3RzIHRoYXQgbWF5IGNoYW5nZSBhZnRlciB0 aGlzIG1vZGlmaWNhdGlvbi4KKwogMjAxMi0wMS0xMCAgSnVsaWVuIENoYWZmcmFpeCAgPGpjaGFm ZnJhaXhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSRUdSRVNTSU9OIChyOTM2MTQpOiBTYWZhcmkg UmVhZGVyIGRvZXNuJ3QgcmVwYWludCBjb3JyZWN0bHkgd2hlbiBzY3JvbGxpbmcKSW5kZXg6IExh eW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50 eHQJKHJldmlzaW9uIDEwNDU3NSkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rl c3RfZXhwZWN0YXRpb25zLnR4dAkod29ya2luZyBjb3B5KQpAQCAtODc5LDYgKzg3OSwxMSBAQCBC VUdDUjIzNDYzIExJTlVYIFdJTiA6IHN2Zy9XM0MtU1ZHLTEuMS9zCiAvLyBNZXJnZSAzOTc0NDoz OTgyOSAtIHJlZ3Jlc3Npb24KIEJVR0NSMTAyODQgTUFDIDogc3ZnL2N1c3RvbS9wYXRoLWJhZC1k YXRhLnN2ZyA9IEZBSUwKIAorLy8gTmVlZHMgcmViYXNlbGluaW5nIGFmdGVyIEJVR1dLNzU3MDMu IE9sZCByZXN1bHRzIGFyZSwgaW4gZmFjdCwgaW5jb3JyZWN0LgorQlVHV0s3NTcwMyA6IHN2Zy9j dXN0b20vc2hhcGVzLXN1cHBvcnRpbmctbWFya2Vycy5zdmcgPSBQQVNTIElNQUdFK1RFWFQgVEVY VCBJTUFHRQorQlVHV0s3NTcwMyA6IHN2Zy9XM0MtU1ZHLTEuMS9wYWludGluZy1tYXJrZXItMDIt Zi5zdmcgPSBQQVNTIElNQUdFIAorQlVHV0s3NTcwMyA6IHN2Zy9XM0MtU1ZHLTEuMS9wYWludGlu Zy1tYXJrZXItMDMtZi5zdmcgPSBQQVNTIElNQUdFIAorCiAvLyBUZXh0IG1pc21hdGNoIHNpbmNl IHI2NTM3MC4KIC8vIFRoZXJlIHdhcyBhbHNvIGFuIHVubm90aWNlZCBpbWFnZSBtaXNtYXRjaCBi ZWZvcmUgdGhpcyByZXZpc2lvbgogLy8gKHdyb25nIGJhc2VsaW5lIHdhcyBjb21taXR0ZWQpLiBO byBpZGVhIGFib3V0IHdoZW4gaXQgcmVhbGx5IHN0YXJ0ZWQgdG8gZmFpbC4K