75702 2012-01-06 07:31:54 -0800 [Chromium] Use SkFontHost::GetUnitsPerEm instead of advanced type metrics for Android in FontPlatformData 2012-01-10 08:04:04 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66689 1 peter peter jrg reed senorblanco tony webkit.review.bot oldest_to_newest 531068 0 peter 2012-01-06 07:31:54 -0800 [Chromium] Use SkFontHost::GetUnitsPerEm instead of advanced type metrics for Android in FontPlatformData 531069 1 121431 peter 2012-01-06 07:34:59 -0800 Created attachment 121431 Patch 531072 2 peter 2012-01-06 07:43:29 -0800 Hi Tony, could you take a look please? 531130 3 121431 tony 2012-01-06 10:08:28 -0800 Comment on attachment 121431 Patch What's the difference between getAdvancedTypefaceMetrics and GetUnitsPerEm? Is one faster? On platforms other than Android, do they return the same value? If so, should we use GetUnitsPerEm on all platforms? 531131 4 tony 2012-01-06 10:09:03 -0800 Also, feel free to loop in someone who works on skia to review. 532068 5 peter 2012-01-09 03:32:38 -0800 (In reply to comment #3) > (From update of attachment 121431 [details]) > What's the difference between getAdvancedTypefaceMetrics and GetUnitsPerEm? Is one faster? On platforms other than Android, do they return the same value? If so, should we use GetUnitsPerEm on all platforms? It's an Android-specific function which solely retrieves the em size from the font header, whereas getAdvancedTypefaceMetrics retrieves other information (such as the name, font type and italic angle) as well. The latter invokes Freetype's FT_Get_PS_Font_Info function which is defined in the "type1" extension, which is not available in Android. +senorblanco 532264 6 tony 2012-01-09 10:12:41 -0800 (In reply to comment #5) > It's an Android-specific function which solely retrieves the em size from the font header, whereas getAdvancedTypefaceMetrics retrieves other information (such as the name, font type and italic angle) as well. The latter invokes Freetype's FT_Get_PS_Font_Info function which is defined in the "type1" extension, which is not available in Android. Should we implement GetUnitsPerEm on all platforms so we don't have to have an #if here? 533015 7 peter 2012-01-10 06:28:53 -0800 Stephen, could you comment on that option? Removing the #if-guards in Skia code and getting that rolled into WebKit would be an option as well. 533030 8 senorblanco 2012-01-10 06:57:29 -0800 +reed, who knows Skia text code far better than me. Mike, any thoughts on this? Should we fold this into Skia, or leave it here in WebKit? 533039 9 reed 2012-01-10 07:10:15 -0800 UnitsPerEm should be an API on SkTypeface (we shouldn't be making calls on SkFontHost). For now do whatever is easier I guess, until the new API arrives. http://code.google.com/p/skia/issues/detail?id=441 533048 10 121431 senorblanco 2012-01-10 07:19:08 -0800 Comment on attachment 121431 Patch In that case, I'm fine with going ahead with this. You might want to add a comment referencing the skia bug Mike just created. r=me 533054 11 peter 2012-01-10 07:28:36 -0800 I prefer to keep references local to WebKit, so I filed bug 75961. Since it involves the current Android-hack, I'll take care of that cleanup. 533061 12 121845 peter 2012-01-10 07:35:14 -0800 Created attachment 121845 Patch for landing Patch for landing 533079 13 121845 webkit.review.bot 2012-01-10 08:03:59 -0800 Comment on attachment 121845 Patch for landing Clearing flags on attachment: 121845 Committed r104578: <http://trac.webkit.org/changeset/104578> 533080 14 webkit.review.bot 2012-01-10 08:04:04 -0800 All reviewed patches have been landed. Closing bug. 121431 2012-01-06 07:34:59 -0800 2012-01-10 07:35:14 -0800 Patch bug-75702-20120106153457.patch text/plain 2299 peter U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0Mjg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGZmYzI3MzcwMGNjZmRk NWJiNjMzMTc4OWI2MGNhN2Y2MGVjNmRhMy4uOTNlYWUzYzQ5YTBhYzkyZTUyMDExMzBhMDlkNDYw M2FjMjU1ZDZhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAxLTA2ICBQZXRl ciBCZXZlcmxvbyAgPHBldGVyQGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIFVz ZSBTa0ZvbnRIb3N0OjpHZXRVbml0c1BlckVtIGluc3RlYWQgb2YgYWR2YW5jZWQgdHlwZQorICAg ICAgICBtZXRyaWNzIGZvciBBbmRyb2lkIGluIEZvbnRQbGF0Zm9ybURhdGEKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1NzAyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgU2tpYSBmb3IgQW5kcm9p ZCBkb2Vzbid0IGltcGxlbWVudCBhZHZhbmNlZCB0eXBlIG1ldHJpYyByb3V0aW5lcywKKyAgICAg ICAgdXNlIGFuIGFsdGVybmF0aXZlIG1ldGhvZCB0byBjYWxjdWxhdGUgdGhlIG51bWJlciBvZiBm b250IHVuaXRzIGZvciBhbgorICAgICAgICBlbSBzaXplLiBUaGlzIHdpbGwgYmUgZXhlcmNpemVk IGJ5IGV4aXN0aW5nIGxheW91dCB0ZXN0cywgYXMgaXQncyBiZWluZworICAgICAgICB1c2VkIGJ5 IHRoZSBDb21wbGV4VGV4dENvbnRyb2xsZXIuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9oYXJmYnV6ei9Gb250UGxhdGZvcm1EYXRhSGFyZkJ1enouY3BwOgorICAgICAgICAoV2ViQ29y ZTo6Rm9udFBsYXRmb3JtRGF0YTo6ZW1TaXplSW5Gb250VW5pdHMpOgorCiAyMDEyLTAxLTA2ICBU b3IgQXJuZSBWZXN0YsO4ICA8dG9yLmFybmUudmVzdGJvQG5va2lhLmNvbT4KIAogICAgICAgICBb UXRdIE1vdmUgbGlzdGluZyBvZiBpbmNsdWRlIHBhdGhzIGFuZCBsaWJzIHRvIHByaSBmaWxlcyBp biBzb3VyY2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9o YXJmYnV6ei9Gb250UGxhdGZvcm1EYXRhSGFyZkJ1enouY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovRm9udFBsYXRmb3JtRGF0YUhhcmZCdXp6LmNwcAppbmRl eCA1MDQ1ZTEwNzA0MDhkNTY4MWRmOGJjZTg2NGIxYmYyNzY5MTgyNDI4Li42OTM2MDUyZmM3Nzll ZDc5ODYwYWQyMmQzMTMyZWE1MDJkZjQ5ZTU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9Gb250UGxhdGZvcm1EYXRhSGFyZkJ1enouY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6L0ZvbnRQbGF0Zm9y bURhdGFIYXJmQnV6ei5jcHAKQEAgLTM2LDYgKzM2LDcgQEAKICNpbmNsdWRlICJQbGF0Zm9ybVN1 cHBvcnQuaCIKIAogI2luY2x1ZGUgIlNrQWR2YW5jZWRUeXBlZmFjZU1ldHJpY3MuaCIKKyNpbmNs dWRlICJTa0ZvbnRIb3N0LmgiCiAjaW5jbHVkZSAiU2tQYWludC5oIgogI2luY2x1ZGUgIlNrVHlw ZWZhY2UuaCIKIApAQCAtMTE2LDkgKzExNywxNSBAQCBpbnQgRm9udFBsYXRmb3JtRGF0YTo6ZW1T aXplSW5Gb250VW5pdHMoKSBjb25zdAogICAgIGlmIChtX2VtU2l6ZUluRm9udFVuaXRzKQogICAg ICAgICByZXR1cm4gbV9lbVNpemVJbkZvbnRVbml0czsKIAorI2lmIE9TKEFORFJPSUQpCisgICAg Ly8gQW5kcm9pZCBkb2Vzbid0IGN1cnJlbnRseSBzdXBwb3J0IFNraWEncyBnZXRBZHZhbmNlZFR5 cGVmYWNlTWV0cmljcygpLAorICAgIC8vIGJ1dCBpdCBoYXMgYWNjZXNzIHRvIGFub3RoZXIgbWV0 aG9kIHRvIHJlcGxhY2UgdGhpcyBmdW5jdGlvbmFsaXR5LgorICAgIG1fZW1TaXplSW5Gb250VW5p dHMgPSBTa0ZvbnRIb3N0OjpHZXRVbml0c1BlckVtKG1fdHlwZWZhY2UtPnVuaXF1ZUlEKCkpOwor I2Vsc2UKICAgICBTa0FkdmFuY2VkVHlwZWZhY2VNZXRyaWNzKiBtZXRyaWNzID0gbV90eXBlZmFj ZS0+Z2V0QWR2YW5jZWRUeXBlZmFjZU1ldHJpY3MoU2tBZHZhbmNlZFR5cGVmYWNlTWV0cmljczo6 a05vX1BlckdseXBoSW5mbyk7CiAgICAgbV9lbVNpemVJbkZvbnRVbml0cyA9IG1ldHJpY3MtPmZF bVNpemU7CiAgICAgbWV0cmljcy0+dW5yZWYoKTsKKyNlbmRpZgogICAgIHJldHVybiBtX2VtU2l6 ZUluRm9udFVuaXRzOwogfQogCg== 121845 2012-01-10 07:35:14 -0800 2012-01-10 08:03:59 -0800 Patch for landing skia-patch-2.patch text/plain 2276 peter ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmYWE2MzMyLi4xYzcxNDk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMDEtMDYgIFBldGVyIEJldmVybG9vICA8cGV0ZXJAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIFtDaHJvbWl1bV0gVXNlIFNrRm9udEhvc3Q6OkdldFVuaXRzUGVyRW0gaW5zdGVhZCBv ZiBhZHZhbmNlZCB0eXBlCisgICAgICAgIG1ldHJpY3MgZm9yIEFuZHJvaWQgaW4gRm9udFBsYXRm b3JtRGF0YQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzU3MDIKKworICAgICAgICBSZXZpZXdlZCBieSBTdGVwaGVuIFdoaXRlLgorCisgICAgICAgIFNp bmNlIFNraWEgZm9yIEFuZHJvaWQgZG9lc24ndCBpbXBsZW1lbnQgYWR2YW5jZWQgdHlwZSBtZXRy aWMgcm91dGluZXMsCisgICAgICAgIHVzZSBhbiBhbHRlcm5hdGl2ZSBtZXRob2QgdG8gY2FsY3Vs YXRlIHRoZSBudW1iZXIgb2YgZm9udCB1bml0cyBmb3IgYW4KKyAgICAgICAgZW0gc2l6ZS4gVGhp cyB3aWxsIGJlIGV4ZXJjaXplZCBieSBleGlzdGluZyBsYXlvdXQgdGVzdHMsIGFzIGl0J3MgYmVp bmcKKyAgICAgICAgdXNlZCBieSB0aGUgQ29tcGxleFRleHRDb250cm9sbGVyLgorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovRm9udFBsYXRmb3JtRGF0YUhhcmZCdXp6LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnRQbGF0Zm9ybURhdGE6OmVtU2l6ZUluRm9udFVuaXRz KToKKwogMjAxMi0wMS0wNiAgU3RlcGhlbiBXaGl0ZSAgPHNlbm9yYmxhbmNvQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBbU2tpYV0gU3dpdGNoIEZFQ29sb3JNYXRyaXggdG8gdXNlIGEgc2tpYS1i YXNlZCBpbXBsZW1lbnRhdGlvbiB3aGVuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9Gb250UGxhdGZvcm1EYXRhSGFyZkJ1enouY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovRm9udFBsYXRmb3JtRGF0YUhh cmZCdXp6LmNwcAppbmRleCA1MDQ1ZTEwLi5mOGJlZjVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9Gb250UGxhdGZvcm1EYXRhSGFyZkJ1enou Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6L0ZvbnRQ bGF0Zm9ybURhdGFIYXJmQnV6ei5jcHAKQEAgLTM2LDYgKzM2LDcgQEAKICNpbmNsdWRlICJQbGF0 Zm9ybVN1cHBvcnQuaCIKIAogI2luY2x1ZGUgIlNrQWR2YW5jZWRUeXBlZmFjZU1ldHJpY3MuaCIK KyNpbmNsdWRlICJTa0ZvbnRIb3N0LmgiCiAjaW5jbHVkZSAiU2tQYWludC5oIgogI2luY2x1ZGUg IlNrVHlwZWZhY2UuaCIKIApAQCAtMTE2LDkgKzExNywxNyBAQCBpbnQgRm9udFBsYXRmb3JtRGF0 YTo6ZW1TaXplSW5Gb250VW5pdHMoKSBjb25zdAogICAgIGlmIChtX2VtU2l6ZUluRm9udFVuaXRz KQogICAgICAgICByZXR1cm4gbV9lbVNpemVJbkZvbnRVbml0czsKIAorICAgIC8vIEZJWE1FOiBT d2l0Y2ggdG8gdGhlIFNrVHlwZWZhY2U6OkdldFVuaXRzUGVyRW0gQVBJIG9uY2UgdGhpcyBiZWNv bWVzIGF2YWlsYWJsZS4KKyAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzU5NjEKKyNpZiBPUyhBTkRST0lEKQorICAgIC8vIEFuZHJvaWQgZG9lc24ndCBjdXJy ZW50bHkgc3VwcG9ydCBTa2lhJ3MgZ2V0QWR2YW5jZWRUeXBlZmFjZU1ldHJpY3MoKSwKKyAgICAv LyBidXQgaXQgaGFzIGFjY2VzcyB0byBhbm90aGVyIG1ldGhvZCB0byByZXBsYWNlIHRoaXMgZnVu Y3Rpb25hbGl0eS4KKyAgICBtX2VtU2l6ZUluRm9udFVuaXRzID0gU2tGb250SG9zdDo6R2V0VW5p dHNQZXJFbShtX3R5cGVmYWNlLT51bmlxdWVJRCgpKTsKKyNlbHNlCiAgICAgU2tBZHZhbmNlZFR5 cGVmYWNlTWV0cmljcyogbWV0cmljcyA9IG1fdHlwZWZhY2UtPmdldEFkdmFuY2VkVHlwZWZhY2VN ZXRyaWNzKFNrQWR2YW5jZWRUeXBlZmFjZU1ldHJpY3M6OmtOb19QZXJHbHlwaEluZm8pOwogICAg IG1fZW1TaXplSW5Gb250VW5pdHMgPSBtZXRyaWNzLT5mRW1TaXplOwogICAgIG1ldHJpY3MtPnVu cmVmKCk7CisjZW5kaWYKICAgICByZXR1cm4gbV9lbVNpemVJbkZvbnRVbml0czsKIH0KIAo=