75695 2012-01-06 02:43:39 -0800 [EFL] Modify some API's implementation to let it directly pass Eina_Rectangle into IntRect. 2012-01-12 01:51:16 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 hyuki.kim webkit-unassigned gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 531010 0 hyuki.kim 2012-01-06 02:43:39 -0800 For the simple assignment from Eina_Rectagle to IntRect, IntRect(const Eina_Rectangle*) will be added. And some API's implementation will be modified to let it directly pass Eina_Rectangle* into IntRect. 533014 1 121840 hyuki.kim 2012-01-10 06:27:49 -0800 Created attachment 121840 Propose a patch. 533027 2 121840 kling 2012-01-10 06:51:55 -0800 Comment on attachment 121840 Propose a patch. View in context: https://bugs.webkit.org/attachment.cgi?id=121840&action=review > Source/WebCore/platform/graphics/IntRect.h:192 > explicit IntRect(const Eina_Rectangle&); > + explicit IntRect(const Eina_Rectangle*); This looks like a bad idea to me, it would be better to update call sites to dereference the Eina_Rectangle* so they can go through the Eina_Rectangle& constructor, e.g: WebCore::IntRect rect(*area); The problem with either approach is that you have no handling of null Eina_Rectangle*, but I suppose that's something for the call sites to know about. 533041 3 hyuki.kim 2012-01-10 07:13:31 -0800 (In reply to comment #2) > (From update of attachment 121840 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=121840&action=review > > > Source/WebCore/platform/graphics/IntRect.h:192 > > explicit IntRect(const Eina_Rectangle&); > > + explicit IntRect(const Eina_Rectangle*); > > This looks like a bad idea to me, it would be better to update call sites to dereference the Eina_Rectangle* so they can go through the Eina_Rectangle& constructor, e.g: > WebCore::IntRect rect(*area); Yes,It might be the reason why other ports didn't add pointer type. Ok, I will try it. > The problem with either approach is that you have no handling of null Eina_Rectangle*, but I suppose that's something for the call sites to know about. I have considered handling of null. But, as far as I know, WebCore doesn't like null handling for every cases. :) 533158 4 hyuki.kim 2012-01-10 10:06:13 -0800 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 121840 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=121840&action=review > > > > > Source/WebCore/platform/graphics/IntRect.h:192 > > > explicit IntRect(const Eina_Rectangle&); > > > + explicit IntRect(const Eina_Rectangle*); > > > > This looks like a bad idea to me, it would be better to update call sites to dereference the Eina_Rectangle* so they can go through the Eina_Rectangle& constructor, e.g: > > WebCore::IntRect rect(*area); > Yes,It might be the reason why other ports didn't add pointer type. > Ok, I will try it. > > > > The problem with either approach is that you have no handling of null Eina_Rectangle*, but I suppose that's something for the call sites to know about. > I have considered handling of null. > But, as far as I know, WebCore doesn't like null handling for every cases. :) "WebCore doesn't like null handling for every cases." meant "WebCore doesn't seem to force it to check null for every cases." :) 534491 5 122148 hyuki.kim 2012-01-11 18:42:26 -0800 Created attachment 122148 Patch is updated according to Kling's suggestion. 534492 6 hyuki.kim 2012-01-11 18:43:11 -0800 (In reply to comment #2) > (From update of attachment 121840 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=121840&action=review > > > Source/WebCore/platform/graphics/IntRect.h:192 > > explicit IntRect(const Eina_Rectangle&); > > + explicit IntRect(const Eina_Rectangle*); > > This looks like a bad idea to me, it would be better to update call sites to dereference the Eina_Rectangle* so they can go through the Eina_Rectangle& constructor, e.g: > WebCore::IntRect rect(*area); > The problem with either approach is that you have no handling of null Eina_Rectangle*, but I suppose that's something for the call sites to know about. I updated patch according to your suggestion. Thx. :) 534538 7 122148 rakuco 2012-01-11 20:11:43 -0800 Comment on attachment 122148 Patch is updated according to Kling's suggestion. View in context: https://bugs.webkit.org/attachment.cgi?id=122148&action=review Looks OK. > Source/WebKit/efl/ChangeLog:10 > + As some APIs in ewk_view doesn't make the best use of direct passing of > + Eina_Rectangle parameter into IntRect although IntRect supports it, > + I just refactor the code to let it directly pass Eina_Rectangle into IntRect. I'd just reword it as "Dereference Eina_Rectangle pointers so the shorter IntRect constructor can be used". 534554 8 122164 hyuki.kim 2012-01-11 21:24:07 -0800 Created attachment 122164 ChangeLog updated. 534556 9 hyuki.kim 2012-01-11 21:25:27 -0800 (In reply to comment #7) > (From update of attachment 122148 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=122148&action=review > > Looks OK. > > > Source/WebKit/efl/ChangeLog:10 > > + As some APIs in ewk_view doesn't make the best use of direct passing of > > + Eina_Rectangle parameter into IntRect although IntRect supports it, > > + I just refactor the code to let it directly pass Eina_Rectangle into IntRect. > > I'd just reword it as "Dereference Eina_Rectangle pointers so the shorter IntRect constructor can be used". Ok, it looks easier to understand. So, I have changed ChangeLog. :) 534658 10 122164 webkit.review.bot 2012-01-12 01:51:09 -0800 Comment on attachment 122164 ChangeLog updated. Clearing flags on attachment: 122164 Committed r104799: <http://trac.webkit.org/changeset/104799> 534659 11 webkit.review.bot 2012-01-12 01:51:16 -0800 All reviewed patches have been landed. Closing bug. 121840 2012-01-10 06:27:49 -0800 2012-01-11 18:42:26 -0800 Propose a patch. 0110_IntRect.patch text/plain 5192 hyuki.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1MTc3NWU1Li5mNWIzOTViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTItMDEtMDkgIEt3YW5nSHl1ayBLaW0gIDxoeXVraS5raW1Ac2Ftc3VuZy5jb20+CisK KyAgICAgICAgW0VGTF0gQWRkIEludFJlY3QoY29uc3QgRWluYV9SZWN0YW5nbGUqKSBjb25zdHJ1 Y3Rvci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1 Njk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9y IHRoZSBzaW1wbGUgYXNzaWdubWVudCBmcm9tIEVpbmFfUmVjdGFnbGUgdG8gSW50UmVjdCwKKyAg ICAgICAgSW50UmVjdChjb25zdCBFaW5hX1JlY3RhbmdsZSopIGlzIGFkZGVkLgorICAgICAgICBJ biBhZGR0aW9uLCBwYXJhbWV0ZXIgYW5kIHZhcmlhYmxlIG5hbWUgJ3InIGluIEludFJlY3RFZmwu Y3BwIGlzIHJlcGxhY2VkIHdpdGggZnVsbCBuYW1lIHN0cmluZy4KKworICAgICAgICBObyBuZXcg dGVzdHMgOiBqdXN0IGFkZCBFRkwgc3BlY2lmaWMgSW50UmVjdCBjb25zdHJ1Y3Rvci4KKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ludFJlY3QuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9lZmwvSW50UmVjdEVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnRSZWN0OjpJ bnRSZWN0KToKKyAgICAgICAgKFdlYkNvcmU6OkludFJlY3Q6Om9wZXJhdG9yIEVpbmFfUmVjdGFu Z2xlKToKKwogMjAxMi0wMS0wOSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFp bC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEwNDUwNy4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ludFJlY3QuaCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ludFJlY3QuaAppbmRleCAyZTJmZjBiLi4xOTkx NzVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbnRSZWN0 LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW50UmVjdC5oCkBAIC0x ODksNiArMTg5LDcgQEAgcHVibGljOgogI2VuZGlmCiAjZWxpZiBQTEFURk9STShFRkwpCiAgICAg ZXhwbGljaXQgSW50UmVjdChjb25zdCBFaW5hX1JlY3RhbmdsZSYpOworICAgIGV4cGxpY2l0IElu dFJlY3QoY29uc3QgRWluYV9SZWN0YW5nbGUqKTsKICAgICBvcGVyYXRvciBFaW5hX1JlY3Rhbmds ZSgpIGNvbnN0OwogI2VuZGlmCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2VmbC9JbnRSZWN0RWZsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2VmbC9JbnRSZWN0RWZsLmNwcAppbmRleCAwYzkyZjYzLi5hMmIxZjA3IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9lZmwvSW50UmVjdEVmbC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZWZsL0ludFJlY3RFZmwuY3Bw CkBAIC0yNSwxNiArMjUsMjIgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi1JbnRSZWN0OjpJ bnRSZWN0KGNvbnN0IEVpbmFfUmVjdGFuZ2xlJiByKQotICAgIDogbV9sb2NhdGlvbihJbnRQb2lu dChyLngsIHIueSkpCi0gICAgLCBtX3NpemUoci53LCByLmgpCitJbnRSZWN0OjpJbnRSZWN0KGNv bnN0IEVpbmFfUmVjdGFuZ2xlJiByZWN0KQorICAgIDogbV9sb2NhdGlvbihJbnRQb2ludChyZWN0 LngsIHJlY3QueSkpCisgICAgLCBtX3NpemUocmVjdC53LCByZWN0LmgpCit7Cit9CisKK0ludFJl Y3Q6OkludFJlY3QoY29uc3QgRWluYV9SZWN0YW5nbGUqIHJlY3QpCisgICAgOiBtX2xvY2F0aW9u KEludFBvaW50KHJlY3QtPngsIHJlY3QtPnkpKQorICAgICwgbV9zaXplKHJlY3QtPncsIHJlY3Qt PmgpCiB7CiB9CiAKIEludFJlY3Q6Om9wZXJhdG9yIEVpbmFfUmVjdGFuZ2xlKCkgY29uc3QKIHsK LSAgICBFaW5hX1JlY3RhbmdsZSByID0ge3goKSwgeSgpLCB3aWR0aCgpLCBoZWlnaHQoKX07Ci0g ICAgcmV0dXJuIHI7CisgICAgRWluYV9SZWN0YW5nbGUgcmVjdCA9IHt4KCksIHkoKSwgd2lkdGgo KSwgaGVpZ2h0KCl9OworICAgIHJldHVybiByZWN0OwogfQogCiB9CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5k ZXggZmZlN2ExMC4uOTg3NDliMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisy MDEyLTAxLTA5ICBLd2FuZ0h5dWsgS2ltICA8aHl1a2kua2ltQHNhbXN1bmcuY29tPgorCisgICAg ICAgIFtFRkxdIEFkZCBJbnRSZWN0KGNvbnN0IEVpbmFfUmVjdGFuZ2xlKikgY29uc3RydWN0b3Iu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTY5NQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vZGlmeSBz b21lIEFQSSdzIGltcGxlbWVudGF0aW9uIHRvIGxldCBpdCBkaXJlY3RseSBwYXNzIEVpbmFfUmVj dGFuZ2xlIGludG8gSW50UmVjdC4KKworICAgICAgICAqIGV3ay9ld2tfdmlldy5jcHA6CisgICAg ICAgIChld2tfdmlld19wYWludF9jb250ZXh0X2NsaXApOgorICAgICAgICAoZXdrX3ZpZXdfcGFp bnRfY29udGV4dF9wYWludCk6CisgICAgICAgIChld2tfdmlld19wYWludF9jb250ZXh0X3BhaW50 X2NvbnRlbnRzKToKKyAgICAgICAgKGV3a192aWV3X3BhaW50KToKKyAgICAgICAgKGV3a192aWV3 X3BhaW50X2NvbnRlbnRzKToKKwogMjAxMi0wMS0wNiAgSnVuZ0ppayBMZWUgIDxqdW5namlrLmxl ZUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBBZGQgbmV3IHByZS1yZW5kZXJpbmcgY29k ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAgYi9Tb3Vy Y2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCmluZGV4IDUzYTJkMGEuLjRiZGIyYjMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKKysrIGIvU291cmNl L1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcApAQCAtMjYxMyw3ICsyNjEzLDcgQEAgdm9pZCBl d2tfdmlld19wYWludF9jb250ZXh0X2NsaXAoRXdrX1ZpZXdfUGFpbnRfQ29udGV4dCogY29udGV4 dCwgY29uc3QgRWluYV9SZWMKIHsKICAgICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JFVFVSTihjb250 ZXh0KTsKICAgICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JFVFVSTihhcmVhKTsKLSAgICBjb250ZXh0 LT5ncmFwaGljQ29udGV4dC0+Y2xpcChXZWJDb3JlOjpJbnRSZWN0KGFyZWEtPngsIGFyZWEtPnks IGFyZWEtPncsIGFyZWEtPmgpKTsKKyAgICBjb250ZXh0LT5ncmFwaGljQ29udGV4dC0+Y2xpcChX ZWJDb3JlOjpJbnRSZWN0KGFyZWEpKTsKIH0KIAogdm9pZCBld2tfdmlld19wYWludF9jb250ZXh0 X3BhaW50KEV3a19WaWV3X1BhaW50X0NvbnRleHQqIGNvbnRleHQsIGNvbnN0IEVpbmFfUmVjdGFu Z2xlKiBhcmVhKQpAQCAtMjYyMSw3ICsyNjIxLDcgQEAgdm9pZCBld2tfdmlld19wYWludF9jb250 ZXh0X3BhaW50KEV3a19WaWV3X1BhaW50X0NvbnRleHQqIGNvbnRleHQsIGNvbnN0IEVpbmFfUmUK ICAgICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JFVFVSTihjb250ZXh0KTsKICAgICBFSU5BX1NBRkVU WV9PTl9OVUxMX1JFVFVSTihhcmVhKTsKIAotICAgIFdlYkNvcmU6OkludFJlY3QgcmVjdChhcmVh LT54LCBhcmVhLT55LCBhcmVhLT53LCBhcmVhLT5oKTsKKyAgICBXZWJDb3JlOjpJbnRSZWN0IHJl Y3QoYXJlYSk7CiAKICAgICBpZiAoY29udGV4dC0+dmlldy0+aXNUcmFuc3BhcmVudCgpKQogICAg ICAgICBjb250ZXh0LT5ncmFwaGljQ29udGV4dC0+Y2xlYXJSZWN0KHJlY3QpOwpAQCAtMjYzMyw3 ICsyNjMzLDcgQEAgdm9pZCBld2tfdmlld19wYWludF9jb250ZXh0X3BhaW50X2NvbnRlbnRzKEV3 a19WaWV3X1BhaW50X0NvbnRleHQqIGNvbnRleHQsIGNvbnMKICAgICBFSU5BX1NBRkVUWV9PTl9O VUxMX1JFVFVSTihjb250ZXh0KTsKICAgICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JFVFVSTihhcmVh KTsKIAotICAgIFdlYkNvcmU6OkludFJlY3QgcmVjdChhcmVhLT54LCBhcmVhLT55LCBhcmVhLT53 LCBhcmVhLT5oKTsKKyAgICBXZWJDb3JlOjpJbnRSZWN0IHJlY3QoYXJlYSk7CiAKICAgICBpZiAo Y29udGV4dC0+dmlldy0+aXNUcmFuc3BhcmVudCgpKQogICAgICAgICBjb250ZXh0LT5ncmFwaGlj Q29udGV4dC0+Y2xlYXJSZWN0KHJlY3QpOwpAQCAtMjY2Niw3ICsyNjY2LDcgQEAgRWluYV9Cb29s IGV3a192aWV3X3BhaW50KEV3a19WaWV3X1ByaXZhdGVfRGF0YSogcHJpdiwgY2Fpcm9fdCogY3Is IGNvbnN0IEVpbmFfUmUKICAgICBpZiAodmlldy0+bmVlZHNMYXlvdXQoKSkKICAgICAgICAgdmll dy0+Zm9yY2VMYXlvdXQoKTsKICAgICBXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQgZ3JhcGhpY3ND b250ZXh0KGNyKTsKLSAgICBXZWJDb3JlOjpJbnRSZWN0IHJlY3QoYXJlYS0+eCwgYXJlYS0+eSwg YXJlYS0+dywgYXJlYS0+aCk7CisgICAgV2ViQ29yZTo6SW50UmVjdCByZWN0KGFyZWEpOwogCiAg ICAgY2Fpcm9fc2F2ZShjcik7CiAgICAgZ3JhcGhpY3NDb250ZXh0LnNhdmUoKTsKQEAgLTI2ODks NyArMjY4OSw3IEBAIEVpbmFfQm9vbCBld2tfdmlld19wYWludF9jb250ZW50cyhFd2tfVmlld19Q cml2YXRlX0RhdGEqIHByaXYsIGNhaXJvX3QqIGNyLCBjb25zCiAgICAgRUlOQV9TQUZFVFlfT05f TlVMTF9SRVRVUk5fVkFMKHZpZXcsIGZhbHNlKTsKIAogICAgIFdlYkNvcmU6OkdyYXBoaWNzQ29u dGV4dCBncmFwaGljc0NvbnRleHQoY3IpOwotICAgIFdlYkNvcmU6OkludFJlY3QgcmVjdChhcmVh LT54LCBhcmVhLT55LCBhcmVhLT53LCBhcmVhLT5oKTsKKyAgICBXZWJDb3JlOjpJbnRSZWN0IHJl Y3QoYXJlYSk7CiAKICAgICBjYWlyb19zYXZlKGNyKTsKICAgICBncmFwaGljc0NvbnRleHQuc2F2 ZSgpOwo= 122148 2012-01-11 18:42:26 -0800 2012-01-11 21:24:07 -0800 Patch is updated according to Kling's suggestion. 0112_IntRect.patch text/plain 3139 hyuki.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA5OWI2MTAyLi5lYTdkZjI4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMDEtMTEgIEt3YW5nSHl1ayBLaW0gIDxoeXVraS5raW1Ac2Ft c3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gTW9kaWZ5IHNvbWUgQVBJJ3MgaW1wbGVtZW50YXRp b24gdG8gbGV0IGl0IGRpcmVjdGx5IHBhc3MgRWluYV9SZWN0YW5nbGUgaW50byBJbnRSZWN0Lgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU2OTUKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBcyBzb21lIEFQ SXMgaW4gZXdrX3ZpZXcgZG9lc24ndCBtYWtlIHRoZSBiZXN0IHVzZSBvZiBkaXJlY3QgcGFzc2lu ZyBvZgorICAgICAgICBFaW5hX1JlY3RhbmdsZSBwYXJhbWV0ZXIgaW50byBJbnRSZWN0IGFsdGhv dWdoIEludFJlY3Qgc3VwcG9ydHMgaXQsCisgICAgICAgIEkganVzdCByZWZhY3RvciB0aGUgY29k ZSB0byBsZXQgaXQgZGlyZWN0bHkgcGFzcyBFaW5hX1JlY3RhbmdsZSBpbnRvIEludFJlY3QuCisK KyAgICAgICAgKiBld2svZXdrX3ZpZXcuY3BwOgorICAgICAgICAoZXdrX3ZpZXdfcGFpbnRfY29u dGV4dF9jbGlwKToKKyAgICAgICAgKGV3a192aWV3X3BhaW50X2NvbnRleHRfcGFpbnQpOgorICAg ICAgICAoZXdrX3ZpZXdfcGFpbnRfY29udGV4dF9wYWludF9jb250ZW50cyk6CisgICAgICAgIChl d2tfdmlld19wYWludCk6CisgICAgICAgIChld2tfdmlld19wYWludF9jb250ZW50cyk6CisKIDIw MTItMDEtMTEgIEp1bmdKaWsgTGVlICA8anVuZ2ppay5sZWVAc2Ftc3VuZy5jb20+CiAKICAgICAg ICAgW0VGTF0gUmVmYWN0b3Igc2luZ2xlIGJhY2tpbmcgc3RvcmUgc2Nyb2xsIGNvZGUuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktp dC9lZmwvZXdrL2V3a192aWV3LmNwcAppbmRleCA4ZTA4OWUxLi43ZmRiYzExIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv ZWZsL2V3ay9ld2tfdmlldy5jcHAKQEAgLTI2MDksOCArMjYwOSw3IEBAIHZvaWQgZXdrX3ZpZXdf cGFpbnRfY29udGV4dF9jbGlwKEV3a19WaWV3X1BhaW50X0NvbnRleHQqIGNvbnRleHQsIGNvbnN0 IEVpbmFfUmVjCiB7CiAgICAgRUlOQV9TQUZFVFlfT05fTlVMTF9SRVRVUk4oY29udGV4dCk7CiAg ICAgRUlOQV9TQUZFVFlfT05fTlVMTF9SRVRVUk4oYXJlYSk7Ci0KLSAgICBjb250ZXh0LT5ncmFw aGljQ29udGV4dC0+Y2xpcChXZWJDb3JlOjpJbnRSZWN0KGFyZWEtPngsIGFyZWEtPnksIGFyZWEt PncsIGFyZWEtPmgpKTsKKyAgICBjb250ZXh0LT5ncmFwaGljQ29udGV4dC0+Y2xpcChXZWJDb3Jl OjpJbnRSZWN0KCphcmVhKSk7CiB9CiAKIHZvaWQgZXdrX3ZpZXdfcGFpbnRfY29udGV4dF9wYWlu dChFd2tfVmlld19QYWludF9Db250ZXh0KiBjb250ZXh0LCBjb25zdCBFaW5hX1JlY3RhbmdsZSog YXJlYSkKQEAgLTI2MTgsNyArMjYxNyw3IEBAIHZvaWQgZXdrX3ZpZXdfcGFpbnRfY29udGV4dF9w YWludChFd2tfVmlld19QYWludF9Db250ZXh0KiBjb250ZXh0LCBjb25zdCBFaW5hX1JlCiAgICAg RUlOQV9TQUZFVFlfT05fTlVMTF9SRVRVUk4oY29udGV4dCk7CiAgICAgRUlOQV9TQUZFVFlfT05f TlVMTF9SRVRVUk4oYXJlYSk7CiAKLSAgICBXZWJDb3JlOjpJbnRSZWN0IHJlY3QoYXJlYS0+eCwg YXJlYS0+eSwgYXJlYS0+dywgYXJlYS0+aCk7CisgICAgV2ViQ29yZTo6SW50UmVjdCByZWN0KCph cmVhKTsKIAogICAgIGlmIChjb250ZXh0LT52aWV3LT5pc1RyYW5zcGFyZW50KCkpCiAgICAgICAg IGNvbnRleHQtPmdyYXBoaWNDb250ZXh0LT5jbGVhclJlY3QocmVjdCk7CkBAIC0yNjMwLDcgKzI2 MjksNyBAQCB2b2lkIGV3a192aWV3X3BhaW50X2NvbnRleHRfcGFpbnRfY29udGVudHMoRXdrX1Zp ZXdfUGFpbnRfQ29udGV4dCogY29udGV4dCwgY29ucwogICAgIEVJTkFfU0FGRVRZX09OX05VTExf UkVUVVJOKGNvbnRleHQpOwogICAgIEVJTkFfU0FGRVRZX09OX05VTExfUkVUVVJOKGFyZWEpOwog Ci0gICAgV2ViQ29yZTo6SW50UmVjdCByZWN0KGFyZWEtPngsIGFyZWEtPnksIGFyZWEtPncsIGFy ZWEtPmgpOworICAgIFdlYkNvcmU6OkludFJlY3QgcmVjdCgqYXJlYSk7CiAKICAgICBpZiAoY29u dGV4dC0+dmlldy0+aXNUcmFuc3BhcmVudCgpKQogICAgICAgICBjb250ZXh0LT5ncmFwaGljQ29u dGV4dC0+Y2xlYXJSZWN0KHJlY3QpOwpAQCAtMjY2Myw3ICsyNjYyLDcgQEAgRWluYV9Cb29sIGV3 a192aWV3X3BhaW50KEV3a19WaWV3X1ByaXZhdGVfRGF0YSogcHJpdiwgY2Fpcm9fdCogY3IsIGNv bnN0IEVpbmFfUmUKICAgICBpZiAodmlldy0+bmVlZHNMYXlvdXQoKSkKICAgICAgICAgdmlldy0+ Zm9yY2VMYXlvdXQoKTsKICAgICBXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQgZ3JhcGhpY3NDb250 ZXh0KGNyKTsKLSAgICBXZWJDb3JlOjpJbnRSZWN0IHJlY3QoYXJlYS0+eCwgYXJlYS0+eSwgYXJl YS0+dywgYXJlYS0+aCk7CisgICAgV2ViQ29yZTo6SW50UmVjdCByZWN0KCphcmVhKTsKIAogICAg IGNhaXJvX3NhdmUoY3IpOwogICAgIGdyYXBoaWNzQ29udGV4dC5zYXZlKCk7CkBAIC0yNjg2LDcg KzI2ODUsNyBAQCBFaW5hX0Jvb2wgZXdrX3ZpZXdfcGFpbnRfY29udGVudHMoRXdrX1ZpZXdfUHJp dmF0ZV9EYXRhKiBwcml2LCBjYWlyb190KiBjciwgY29ucwogICAgIEVJTkFfU0FGRVRZX09OX05V TExfUkVUVVJOX1ZBTCh2aWV3LCBmYWxzZSk7CiAKICAgICBXZWJDb3JlOjpHcmFwaGljc0NvbnRl eHQgZ3JhcGhpY3NDb250ZXh0KGNyKTsKLSAgICBXZWJDb3JlOjpJbnRSZWN0IHJlY3QoYXJlYS0+ eCwgYXJlYS0+eSwgYXJlYS0+dywgYXJlYS0+aCk7CisgICAgV2ViQ29yZTo6SW50UmVjdCByZWN0 KCphcmVhKTsKIAogICAgIGNhaXJvX3NhdmUoY3IpOwogICAgIGdyYXBoaWNzQ29udGV4dC5zYXZl KCk7Cg== 122164 2012-01-11 21:24:07 -0800 2012-01-12 01:51:09 -0800 ChangeLog updated. 0112_IntRect_2.patch text/plain 2987 hyuki.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA5OWI2MTAyLi5mYmRlMjVkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTItMDEtMTEgIEt3YW5nSHl1ayBLaW0gIDxoeXVraS5raW1Ac2Ft c3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gTW9kaWZ5IHNvbWUgQVBJJ3MgaW1wbGVtZW50YXRp b24gdG8gbGV0IGl0IGRpcmVjdGx5IHBhc3MgRWluYV9SZWN0YW5nbGUgaW50byBJbnRSZWN0Lgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU2OTUKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEZXJlZmVyZW5j ZSBFaW5hX1JlY3RhbmdsZSBwb2ludGVycyBzbyB0aGUgc2hvcnRlciBJbnRSZWN0IGNvbnN0cnVj dG9yIGNhbiBiZSB1c2VkLgorCisgICAgICAgICogZXdrL2V3a192aWV3LmNwcDoKKyAgICAgICAg KGV3a192aWV3X3BhaW50X2NvbnRleHRfY2xpcCk6CisgICAgICAgIChld2tfdmlld19wYWludF9j b250ZXh0X3BhaW50KToKKyAgICAgICAgKGV3a192aWV3X3BhaW50X2NvbnRleHRfcGFpbnRfY29u dGVudHMpOgorICAgICAgICAoZXdrX3ZpZXdfcGFpbnQpOgorICAgICAgICAoZXdrX3ZpZXdfcGFp bnRfY29udGVudHMpOgorCiAyMDEyLTAxLTExICBKdW5nSmlrIExlZSAgPGp1bmdqaWsubGVlQHNh bXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIFJlZmFjdG9yIHNpbmdsZSBiYWNraW5nIHN0b3Jl IHNjcm9sbCBjb2RlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3 LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKaW5kZXggOGUwODllMS4u N2ZkYmMxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCkBAIC0yNjA5LDggKzI2MDks NyBAQCB2b2lkIGV3a192aWV3X3BhaW50X2NvbnRleHRfY2xpcChFd2tfVmlld19QYWludF9Db250 ZXh0KiBjb250ZXh0LCBjb25zdCBFaW5hX1JlYwogewogICAgIEVJTkFfU0FGRVRZX09OX05VTExf UkVUVVJOKGNvbnRleHQpOwogICAgIEVJTkFfU0FGRVRZX09OX05VTExfUkVUVVJOKGFyZWEpOwot Ci0gICAgY29udGV4dC0+Z3JhcGhpY0NvbnRleHQtPmNsaXAoV2ViQ29yZTo6SW50UmVjdChhcmVh LT54LCBhcmVhLT55LCBhcmVhLT53LCBhcmVhLT5oKSk7CisgICAgY29udGV4dC0+Z3JhcGhpY0Nv bnRleHQtPmNsaXAoV2ViQ29yZTo6SW50UmVjdCgqYXJlYSkpOwogfQogCiB2b2lkIGV3a192aWV3 X3BhaW50X2NvbnRleHRfcGFpbnQoRXdrX1ZpZXdfUGFpbnRfQ29udGV4dCogY29udGV4dCwgY29u c3QgRWluYV9SZWN0YW5nbGUqIGFyZWEpCkBAIC0yNjE4LDcgKzI2MTcsNyBAQCB2b2lkIGV3a192 aWV3X3BhaW50X2NvbnRleHRfcGFpbnQoRXdrX1ZpZXdfUGFpbnRfQ29udGV4dCogY29udGV4dCwg Y29uc3QgRWluYV9SZQogICAgIEVJTkFfU0FGRVRZX09OX05VTExfUkVUVVJOKGNvbnRleHQpOwog ICAgIEVJTkFfU0FGRVRZX09OX05VTExfUkVUVVJOKGFyZWEpOwogCi0gICAgV2ViQ29yZTo6SW50 UmVjdCByZWN0KGFyZWEtPngsIGFyZWEtPnksIGFyZWEtPncsIGFyZWEtPmgpOworICAgIFdlYkNv cmU6OkludFJlY3QgcmVjdCgqYXJlYSk7CiAKICAgICBpZiAoY29udGV4dC0+dmlldy0+aXNUcmFu c3BhcmVudCgpKQogICAgICAgICBjb250ZXh0LT5ncmFwaGljQ29udGV4dC0+Y2xlYXJSZWN0KHJl Y3QpOwpAQCAtMjYzMCw3ICsyNjI5LDcgQEAgdm9pZCBld2tfdmlld19wYWludF9jb250ZXh0X3Bh aW50X2NvbnRlbnRzKEV3a19WaWV3X1BhaW50X0NvbnRleHQqIGNvbnRleHQsIGNvbnMKICAgICBF SU5BX1NBRkVUWV9PTl9OVUxMX1JFVFVSTihjb250ZXh0KTsKICAgICBFSU5BX1NBRkVUWV9PTl9O VUxMX1JFVFVSTihhcmVhKTsKIAotICAgIFdlYkNvcmU6OkludFJlY3QgcmVjdChhcmVhLT54LCBh cmVhLT55LCBhcmVhLT53LCBhcmVhLT5oKTsKKyAgICBXZWJDb3JlOjpJbnRSZWN0IHJlY3QoKmFy ZWEpOwogCiAgICAgaWYgKGNvbnRleHQtPnZpZXctPmlzVHJhbnNwYXJlbnQoKSkKICAgICAgICAg Y29udGV4dC0+Z3JhcGhpY0NvbnRleHQtPmNsZWFyUmVjdChyZWN0KTsKQEAgLTI2NjMsNyArMjY2 Miw3IEBAIEVpbmFfQm9vbCBld2tfdmlld19wYWludChFd2tfVmlld19Qcml2YXRlX0RhdGEqIHBy aXYsIGNhaXJvX3QqIGNyLCBjb25zdCBFaW5hX1JlCiAgICAgaWYgKHZpZXctPm5lZWRzTGF5b3V0 KCkpCiAgICAgICAgIHZpZXctPmZvcmNlTGF5b3V0KCk7CiAgICAgV2ViQ29yZTo6R3JhcGhpY3ND b250ZXh0IGdyYXBoaWNzQ29udGV4dChjcik7Ci0gICAgV2ViQ29yZTo6SW50UmVjdCByZWN0KGFy ZWEtPngsIGFyZWEtPnksIGFyZWEtPncsIGFyZWEtPmgpOworICAgIFdlYkNvcmU6OkludFJlY3Qg cmVjdCgqYXJlYSk7CiAKICAgICBjYWlyb19zYXZlKGNyKTsKICAgICBncmFwaGljc0NvbnRleHQu c2F2ZSgpOwpAQCAtMjY4Niw3ICsyNjg1LDcgQEAgRWluYV9Cb29sIGV3a192aWV3X3BhaW50X2Nv bnRlbnRzKEV3a19WaWV3X1ByaXZhdGVfRGF0YSogcHJpdiwgY2Fpcm9fdCogY3IsIGNvbnMKICAg ICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JFVFVSTl9WQUwodmlldywgZmFsc2UpOwogCiAgICAgV2Vi Q29yZTo6R3JhcGhpY3NDb250ZXh0IGdyYXBoaWNzQ29udGV4dChjcik7Ci0gICAgV2ViQ29yZTo6 SW50UmVjdCByZWN0KGFyZWEtPngsIGFyZWEtPnksIGFyZWEtPncsIGFyZWEtPmgpOworICAgIFdl YkNvcmU6OkludFJlY3QgcmVjdCgqYXJlYSk7CiAKICAgICBjYWlyb19zYXZlKGNyKTsKICAgICBn cmFwaGljc0NvbnRleHQuc2F2ZSgpOwo=