75692 2012-01-06 02:29:10 -0800 [Qt] REGRESSION(r104267): fast/js/date-constructor.html fails 2012-01-30 16:01:34 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 75892 70998 1 ossy webkit-unassigned barraclough fpizlo loki ossy szledan webkit-sed zherczeg oldest_to_newest 531002 0 ossy 2012-01-06 02:29:10 -0800 After r104267 fast/js/date-constructor.html started to fail on Qt: --- /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/layout-test-results/fast/js/date-constructor-expected.txt +++ /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/layout-test-results/fast/js/date-constructor-actual.txt @@ -31,7 +31,7 @@ PASS Number(new Date(new Date(1, 1, 1, 1, Infinity, 1, 1, 1, 1))) is Number.NaN PASS Number(new Date(new Date(1, 1, 1, 1, 1, Infinity, 1, 1, 1))) is Number.NaN PASS Number(new Date(new Date(1, 1, 1, 1, 1, 1, Infinity, 1, 1))) is Number.NaN -PASS Number(new Date(new Date(1, 1, 1, 1, 1, 1, 1, 1, Infinity))) is -2174741938999 +FAIL Number(new Date(new Date(1, 1, 1, 1, 1, 1, 1, 1, Infinity))) should be -2174741938999. Was -2174770738999. PASS testStr is "1234567" PASS testStr is "1234567" PASS successfullyParsed is true 531039 1 ossy 2012-01-06 04:28:18 -0800 I skipped it to paint the Qt bot green: http://trac.webkit.org/changeset/104283 Could you guys check this regression? 531702 2 barraclough 2012-01-07 18:53:11 -0800 (In reply to comment #1) > I skipped it to paint the Qt bot green: http://trac.webkit.org/changeset/104283 > > Could you guys check this regression? Hey Ossy, Will do. I don't think this is a regression as such - probably an error in a new test case I added. I think it's probably not being timezone-agnostic, I'm guessing my new test case probably only works in California time. Should be an easy fix. cheers, G. 532153 3 ossy 2012-01-09 06:27:54 -0800 Our bots are in California timezone to avoid this kind of problems. ( export TZ=/usr/share/zoneinfo/America/Los_Angeles ) 532539 4 barraclough 2012-01-09 14:43:39 -0800 Hmm, this last test case that I added wasn't particularly useful from the perspective of testing the bug fixed by the patch that introduced it, so I think it can just be removed for now. I haven't yet figured out whether this is indicating a real bug, or is an error in the test itself. Firefox produces a different result here too, but it looks like it's getting it wrong. It shows PST as having been -0700 in 1901, however the spec prohibits use of historic data here, and requires that DST calculations are based on the current algorithm for the geographic region. I'm going to open a new bug to track this. Removing the offending test in r104492. 532541 5 barraclough 2012-01-09 14:48:25 -0800 Bugzilla tracking the possible bug being exposed is here: https://bugs.webkit.org/show_bug.cgi?id=75892 538543 6 szledan 2012-01-19 01:03:34 -0800 The 'Number(new Date(new Date(1, 1, 1, 1, 1, 1, 1, 1, Infinity)))' line fails due to the time zone difference. The last two arguments of the DateConstructor (8. and 9.) isn't even used, so this line is equivalent to the 'Number(new Date(new Date(1, 1, 1, 1, 1, 1, 1)))', but the timezone is always added to it. The older version of this test uses '(new Date(1, 1, 1, 1, 1, 1, 1) - timezone)', and it doesn't fail. 539447 7 123300 szledan 2012-01-20 05:56:12 -0800 Created attachment 123300 Fixed some lines in the test This test is timezone dependent, the incomplete lines have been corrected. 'Infinity' used int the first seven parameters does not have any effect. Line 'Number(new Date(new Date(1, 1, 1, 1, 1, 1, 1, 1, Infinity)).getTime() - timeZoneOffset)' works the same way as Number(new Date(new Date(1, 1, 1, 1, 1, 1, 1)).getTime() - timeZoneOffset). 539451 8 ossy 2012-01-20 05:59:06 -0800 But why do we still pass 9 parameters to the Date candtructor when it handles only 7 parameters? 545533 9 123300 eric 2012-01-30 16:01:34 -0800 Comment on attachment 123300 Fixed some lines in the test Cleared review? from attachment 123300 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 123300 2012-01-20 05:56:12 -0800 2012-01-30 16:01:34 -0800 Fixed some lines in the test 0001-Fixed-some-lines-in-the-date-constructor.js-test.patch text/plain 5880 szledan RnJvbSBjNmNjYzM5YzdlYWM4MmEzOTRiZGJiNzFlYzA5MzQ0NGE2MGJjZTUwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTemlsYXJkIExlZGFuIDxMZWRhbi1NdW50ZWFuLlN6aWxhcmRA c3R1ZC51LXN6ZWdlZC5odT4KRGF0ZTogRnJpLCAyMCBKYW4gMjAxMiAwNToyOTo0OSAtMDgwMApT dWJqZWN0OiBbUEFUQ0hdIEZpeGVkIHNvbWUgbGluZXMgaW4gdGhlIGRhdGUtY29uc3RydWN0b3Iu anMgdGVzdC4KIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTY5MgoK UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgoqIGZhc3QvanMvZGF0ZS1jb25zdHJ1Y3Rvci1l eHBlY3RlZC50eHQ6CiogZmFzdC9qcy9zY3JpcHQtdGVzdHMvZGF0ZS1jb25zdHJ1Y3Rvci5qczoK LS0tCiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8 ICAgMTAgKysrKysrKysrKwogTGF5b3V0VGVzdHMvZmFzdC9qcy9kYXRlLWNvbnN0cnVjdG9yLWV4 cGVjdGVkLnR4dCAgfCAgIDE1ICsrKysrKysrLS0tLS0tLQogLi4uL2Zhc3QvanMvc2NyaXB0LXRl c3RzL2RhdGUtY29uc3RydWN0b3IuanMgICAgICAgfCAgIDE1ICsrKysrKysrLS0tLS0tLQogMyBm aWxlcyBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspLCAxNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg YTgzYTZiYy4uMjRjZmFmNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAxLTIwICBTemls YXJkIExlZGFuICA8TGVkYW4tTXVudGVhbi5TemlsYXJkQHN0dWQudS1zemVnZWQuaHU+CisKKyAg ICAgICAgRml4ZWQgc29tZSBsaW5lcyBpbiB0aGUgZGF0ZS1jb25zdHJ1Y3Rvci5qcyB0ZXN0Lgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU2OTIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvanMv ZGF0ZS1jb25zdHJ1Y3Rvci1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9qcy9zY3JpcHQt dGVzdHMvZGF0ZS1jb25zdHJ1Y3Rvci5qczoKKwogMjAxMi0wMS0yMCAgQ3NhYmEgT3N6dHJvZ29u w6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgZ2FyZGVuaW5nLiBT a2lwIGZhaWxpbmcgdGVzdHMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2pzL2RhdGUt Y29uc3RydWN0b3ItZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9qcy9kYXRlLWNvbnN0 cnVjdG9yLWV4cGVjdGVkLnR4dAppbmRleCA2NmIxMjE1Li44ZGVkYjEyIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9mYXN0L2pzL2RhdGUtY29uc3RydWN0b3ItZXhwZWN0ZWQudHh0CisrKyBiL0xh eW91dFRlc3RzL2Zhc3QvanMvZGF0ZS1jb25zdHJ1Y3Rvci1leHBlY3RlZC50eHQKQEAgLTI0LDEz ICsyNCwxNCBAQCBQQVNTIG5ldyBEYXRlKG5ldyBEYXRlKDExMTEsIDEsIDEsIDEsIDEsIDEpKS5n ZXRUaW1lKCkgLSB0aW1lWm9uZU9mZnNldCBpcyAtMjcxMAogUEFTUyBuZXcgRGF0ZShuZXcgRGF0 ZSgxMTExLCAxLCAxLCAxLCAxLCAxLCAxKSkuZ2V0VGltZSgpIC0gdGltZVpvbmVPZmZzZXQgaXMg LTI3MTA0Nzk5NTM4OTk5CiBQQVNTIG5ldyBEYXRlKG5ldyBEYXRlKDExMTEsIDEsIDEsIDEsIDEs IDEsIDEsIDEpKS5nZXRUaW1lKCkgLSB0aW1lWm9uZU9mZnNldCBpcyAtMjcxMDQ3OTk1Mzg5OTkK IFBBU1MgbmV3IERhdGUobmV3IERhdGUoMTExMSwgMSwgMSwgMSwgMSwgMSwgMSwgMSwgMSkpLmdl dFRpbWUoKSAtIHRpbWVab25lT2Zmc2V0IGlzIC0yNzEwNDc5OTUzODk5OQotUEFTUyBOdW1iZXIo bmV3IERhdGUobmV3IERhdGUoSW5maW5pdHksIDEsIDEsIDEsIDEsIDEsIDEsIDEsIDEpKSkgaXMg TnVtYmVyLk5hTgotUEFTUyBOdW1iZXIobmV3IERhdGUobmV3IERhdGUoMSwgSW5maW5pdHksIDEs IDEsIDEsIDEsIDEsIDEsIDEpKSkgaXMgTnVtYmVyLk5hTgotUEFTUyBOdW1iZXIobmV3IERhdGUo bmV3IERhdGUoMSwgMSwgSW5maW5pdHksIDEsIDEsIDEsIDEsIDEsIDEpKSkgaXMgTnVtYmVyLk5h TgotUEFTUyBOdW1iZXIobmV3IERhdGUobmV3IERhdGUoMSwgMSwgMSwgSW5maW5pdHksIDEsIDEs IDEsIDEsIDEpKSkgaXMgTnVtYmVyLk5hTgotUEFTUyBOdW1iZXIobmV3IERhdGUobmV3IERhdGUo MSwgMSwgMSwgMSwgSW5maW5pdHksIDEsIDEsIDEsIDEpKSkgaXMgTnVtYmVyLk5hTgotUEFTUyBO dW1iZXIobmV3IERhdGUobmV3IERhdGUoMSwgMSwgMSwgMSwgMSwgSW5maW5pdHksIDEsIDEsIDEp KSkgaXMgTnVtYmVyLk5hTgotUEFTUyBOdW1iZXIobmV3IERhdGUobmV3IERhdGUoMSwgMSwgMSwg MSwgMSwgMSwgSW5maW5pdHksIDEsIDEpKSkgaXMgTnVtYmVyLk5hTgorUEFTUyBOdW1iZXIobmV3 IERhdGUobmV3IERhdGUoSW5maW5pdHksIDEsIDEsIDEsIDEsIDEsIDEsIDEsIDEpKS5nZXRUaW1l KCkgLSB0aW1lWm9uZU9mZnNldCkgaXMgTnVtYmVyLk5hTgorUEFTUyBOdW1iZXIobmV3IERhdGUo bmV3IERhdGUoMSwgSW5maW5pdHksIDEsIDEsIDEsIDEsIDEsIDEsIDEpKS5nZXRUaW1lKCkgLSB0 aW1lWm9uZU9mZnNldCkgaXMgTnVtYmVyLk5hTgorUEFTUyBOdW1iZXIobmV3IERhdGUobmV3IERh dGUoMSwgMSwgSW5maW5pdHksIDEsIDEsIDEsIDEsIDEsIDEpKS5nZXRUaW1lKCkgLSB0aW1lWm9u ZU9mZnNldCkgaXMgTnVtYmVyLk5hTgorUEFTUyBOdW1iZXIobmV3IERhdGUobmV3IERhdGUoMSwg MSwgMSwgSW5maW5pdHksIDEsIDEsIDEsIDEsIDEpKS5nZXRUaW1lKCkgLSB0aW1lWm9uZU9mZnNl dCkgaXMgTnVtYmVyLk5hTgorUEFTUyBOdW1iZXIobmV3IERhdGUobmV3IERhdGUoMSwgMSwgMSwg MSwgSW5maW5pdHksIDEsIDEsIDEsIDEpKS5nZXRUaW1lKCkgLSB0aW1lWm9uZU9mZnNldCkgaXMg TnVtYmVyLk5hTgorUEFTUyBOdW1iZXIobmV3IERhdGUobmV3IERhdGUoMSwgMSwgMSwgMSwgMSwg SW5maW5pdHksIDEsIDEsIDEpKS5nZXRUaW1lKCkgLSB0aW1lWm9uZU9mZnNldCkgaXMgTnVtYmVy Lk5hTgorUEFTUyBOdW1iZXIobmV3IERhdGUobmV3IERhdGUoMSwgMSwgMSwgMSwgMSwgMSwgSW5m aW5pdHksIDEsIDEpKS5nZXRUaW1lKCkgLSB0aW1lWm9uZU9mZnNldCkgaXMgTnVtYmVyLk5hTgor UEFTUyBOdW1iZXIobmV3IERhdGUobmV3IERhdGUoMSwgMSwgMSwgMSwgMSwgMSwgMSwgMSwgSW5m aW5pdHkpKS5nZXRUaW1lKCkgLSB0aW1lWm9uZU9mZnNldCkgaXMgLTIxNzQ3NzA3Mzg5OTkKIFBB U1MgdGVzdFN0ciBpcyAiMTIzNDU2NyIKIFBBU1MgdGVzdFN0ciBpcyAiMTIzNDU2NyIKIFBBU1Mg c3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv anMvc2NyaXB0LXRlc3RzL2RhdGUtY29uc3RydWN0b3IuanMgYi9MYXlvdXRUZXN0cy9mYXN0L2pz L3NjcmlwdC10ZXN0cy9kYXRlLWNvbnN0cnVjdG9yLmpzCmluZGV4IDNkZmM2MmEuLjZlODk1M2Mg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvanMvc2NyaXB0LXRlc3RzL2RhdGUtY29uc3Ry dWN0b3IuanMKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvZGF0ZS1jb25z dHJ1Y3Rvci5qcwpAQCAtMzUsMTMgKzM1LDE0IEBAIHNob3VsZEJlKCduZXcgRGF0ZShuZXcgRGF0 ZSgxMTExLCAxLCAxLCAxLCAxLCAxLCAxKSkuZ2V0VGltZSgpIC0gdGltZVpvbmVPZmZzZXQnCiBz aG91bGRCZSgnbmV3IERhdGUobmV3IERhdGUoMTExMSwgMSwgMSwgMSwgMSwgMSwgMSwgMSkpLmdl dFRpbWUoKSAtIHRpbWVab25lT2Zmc2V0JywgJy0yNzEwNDc5OTUzODk5OScpOwogc2hvdWxkQmUo J25ldyBEYXRlKG5ldyBEYXRlKDExMTEsIDEsIDEsIDEsIDEsIDEsIDEsIDEsIDEpKS5nZXRUaW1l KCkgLSB0aW1lWm9uZU9mZnNldCcsICctMjcxMDQ3OTk1Mzg5OTknKTsKIAotc2hvdWxkQmUoIk51 bWJlcihuZXcgRGF0ZShuZXcgRGF0ZShJbmZpbml0eSwgMSwgMSwgMSwgMSwgMSwgMSwgMSwgMSkp KSIsICdOdW1iZXIuTmFOJyk7Ci1zaG91bGRCZSgiTnVtYmVyKG5ldyBEYXRlKG5ldyBEYXRlKDEs IEluZmluaXR5LCAxLCAxLCAxLCAxLCAxLCAxLCAxKSkpIiwgJ051bWJlci5OYU4nKTsKLXNob3Vs ZEJlKCJOdW1iZXIobmV3IERhdGUobmV3IERhdGUoMSwgMSwgSW5maW5pdHksIDEsIDEsIDEsIDEs IDEsIDEpKSkiLCAnTnVtYmVyLk5hTicpOwotc2hvdWxkQmUoIk51bWJlcihuZXcgRGF0ZShuZXcg RGF0ZSgxLCAxLCAxLCBJbmZpbml0eSwgMSwgMSwgMSwgMSwgMSkpKSIsICdOdW1iZXIuTmFOJyk7 Ci1zaG91bGRCZSgiTnVtYmVyKG5ldyBEYXRlKG5ldyBEYXRlKDEsIDEsIDEsIDEsIEluZmluaXR5 LCAxLCAxLCAxLCAxKSkpIiwgJ051bWJlci5OYU4nKTsKLXNob3VsZEJlKCJOdW1iZXIobmV3IERh dGUobmV3IERhdGUoMSwgMSwgMSwgMSwgMSwgSW5maW5pdHksIDEsIDEsIDEpKSkiLCAnTnVtYmVy Lk5hTicpOwotc2hvdWxkQmUoIk51bWJlcihuZXcgRGF0ZShuZXcgRGF0ZSgxLCAxLCAxLCAxLCAx LCAxLCBJbmZpbml0eSwgMSwgMSkpKSIsICdOdW1iZXIuTmFOJyk7CitzaG91bGRCZSgiTnVtYmVy KG5ldyBEYXRlKG5ldyBEYXRlKEluZmluaXR5LCAxLCAxLCAxLCAxLCAxLCAxLCAxLCAxKSkuZ2V0 VGltZSgpIC0gdGltZVpvbmVPZmZzZXQpIiwgJ051bWJlci5OYU4nKTsKK3Nob3VsZEJlKCJOdW1i ZXIobmV3IERhdGUobmV3IERhdGUoMSwgSW5maW5pdHksIDEsIDEsIDEsIDEsIDEsIDEsIDEpKS5n ZXRUaW1lKCkgLSB0aW1lWm9uZU9mZnNldCkiLCAnTnVtYmVyLk5hTicpOworc2hvdWxkQmUoIk51 bWJlcihuZXcgRGF0ZShuZXcgRGF0ZSgxLCAxLCBJbmZpbml0eSwgMSwgMSwgMSwgMSwgMSwgMSkp LmdldFRpbWUoKSAtIHRpbWVab25lT2Zmc2V0KSIsICdOdW1iZXIuTmFOJyk7CitzaG91bGRCZSgi TnVtYmVyKG5ldyBEYXRlKG5ldyBEYXRlKDEsIDEsIDEsIEluZmluaXR5LCAxLCAxLCAxLCAxLCAx KSkuZ2V0VGltZSgpIC0gdGltZVpvbmVPZmZzZXQpIiwgJ051bWJlci5OYU4nKTsKK3Nob3VsZEJl KCJOdW1iZXIobmV3IERhdGUobmV3IERhdGUoMSwgMSwgMSwgMSwgSW5maW5pdHksIDEsIDEsIDEs IDEpKS5nZXRUaW1lKCkgLSB0aW1lWm9uZU9mZnNldCkiLCAnTnVtYmVyLk5hTicpOworc2hvdWxk QmUoIk51bWJlcihuZXcgRGF0ZShuZXcgRGF0ZSgxLCAxLCAxLCAxLCAxLCBJbmZpbml0eSwgMSwg MSwgMSkpLmdldFRpbWUoKSAtIHRpbWVab25lT2Zmc2V0KSIsICdOdW1iZXIuTmFOJyk7CitzaG91 bGRCZSgiTnVtYmVyKG5ldyBEYXRlKG5ldyBEYXRlKDEsIDEsIDEsIDEsIDEsIDEsIEluZmluaXR5 LCAxLCAxKSkuZ2V0VGltZSgpIC0gdGltZVpvbmVPZmZzZXQpIiwgJ051bWJlci5OYU4nKTsKK3No b3VsZEJlKCJOdW1iZXIobmV3IERhdGUobmV3IERhdGUoMSwgMSwgMSwgMSwgMSwgMSwgMSwgMSwg SW5maW5pdHkpKS5nZXRUaW1lKCkgLSB0aW1lWm9uZU9mZnNldCkiLCAnLTIxNzQ3NzA3Mzg5OTkn KTsKIAogLy8gSW4gRmlyZWZveCwgdGhlIHJlc3VsdHMgb2YgdGhlIGZvbGxvd2luZyB0ZXN0cyBh cmUgdGltZXpvbmUtZGVwZW5kZW50LCB3aGljaCBsaWtlbHkgaW1wbGllcyB0aGF0IHRoZSBpbXBs ZW1lbnRhdGlvbiBpcyBub3QgcXVpdGUgY29ycmVjdC4KIC8vIE91ciByZXN1bHRzIGFyZSBldmVu IHdvcnNlLCB0aG91Z2gsIGFzIHRoZSBkYXRlcyBhcmUgY2xpcHBlZDogKG5ldyBEYXRlKDExMTEs IDEyMDEpLmdldFRpbWUoKSkgPT0gKG5ldyBEYXRlKDExMTEsIDYwMSkuZ2V0VGltZSgpKQotLSAK MS43LjUuNAoK