75690 2012-01-06 01:35:45 -0800 FrameDestructionObserver should be more full-service 2012-01-06 02:28:33 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth eric webkit.review.bot oldest_to_newest 530984 0 abarth 2012-01-06 01:35:45 -0800 FrameDestructionObserver should be more full-service 530985 1 121410 abarth 2012-01-06 01:37:22 -0800 Created attachment 121410 Patch 530988 2 121410 eric 2012-01-06 01:59:57 -0800 Comment on attachment 121410 Patch LGTM. 531000 3 121410 abarth 2012-01-06 02:28:29 -0800 Comment on attachment 121410 Patch Clearing flags on attachment: 121410 Committed r104279: <http://trac.webkit.org/changeset/104279> 531001 4 abarth 2012-01-06 02:28:33 -0800 All reviewed patches have been landed. Closing bug. 121410 2012-01-06 01:37:22 -0800 2012-01-06 02:28:29 -0800 Patch bug-75690-20120106013721.patch text/plain 6747 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNDI3NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDEyLTAxLTA2ICBBZGFtIEJh cnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRnJhbWVEZXN0cnVjdGlvbk9ic2Vy dmVyIHNob3VsZCBiZSBtb3JlIGZ1bGwtc2VydmljZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU2OTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIG1vdmVzIGNvZGUgY29tbW9uIHRvIGJv dGggc3ViY2xhc3NlcyBvZgorICAgICAgICBGcmFtZURlc3RydWN0aW9uT2JzZXJ2ZXIgaW50byBG cmFtZURlc3RydWN0aW9uT2JzZXJ2ZXIgaXRzZWxmLiAgQXMgd2UKKyAgICAgICAgYWRkIG1vcmUg c3ViY2xhc3Nlcywgd2UgZG9uJ3Qgd2FudCB0byBrZWVwIGNvcHkvcGFzdGluZyB0aGlzIGNvZGUu CisKKyAgICAgICAgKiBwYWdlL0ZyYW1lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lRGVz dHJ1Y3Rpb25PYnNlcnZlcjo6RnJhbWVEZXN0cnVjdGlvbk9ic2VydmVyKToKKyAgICAgICAgKFdl YkNvcmU6OkZyYW1lRGVzdHJ1Y3Rpb25PYnNlcnZlcjo6fkZyYW1lRGVzdHJ1Y3Rpb25PYnNlcnZl cik6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZURlc3RydWN0aW9uT2JzZXJ2ZXI6OmZyYW1lRGVz dHJveWVkKToKKyAgICAgICAgKiBwYWdlL0ZyYW1lLmg6CisgICAgICAgIChXZWJDb3JlOjpGcmFt ZURlc3RydWN0aW9uT2JzZXJ2ZXI6OmZyYW1lKToKKyAgICAgICAgKiBwbHVnaW5zL0RPTU1pbWVU eXBlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRPTU1pbWVUeXBlOjpET01NaW1lVHlwZSk6Cisg ICAgICAgIChXZWJDb3JlOjpET01NaW1lVHlwZTo6fkRPTU1pbWVUeXBlKToKKyAgICAgICAgKiBw bHVnaW5zL0RPTU1pbWVUeXBlLmg6CisgICAgICAgICogcGx1Z2lucy9ET01QbHVnaW4uY3BwOgor ICAgICAgICAoV2ViQ29yZTo6RE9NUGx1Z2luOjpET01QbHVnaW4pOgorICAgICAgICAoV2ViQ29y ZTo6RE9NUGx1Z2luOjp+RE9NUGx1Z2luKToKKyAgICAgICAgKiBwbHVnaW5zL0RPTVBsdWdpbi5o OgorCiAyMDEyLTAxLTA2ICBBbGljZSBCb3hoYWxsICA8YWJveGhhbGxAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJlcG9ydCBjb3JyZWN0IGxpbmUgbnVtYmVyIGZvciBub24tbmF0aXZlIGVkaXRh YmxlIHRleHQgZWxlbWVudHMuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAkocmV2aXNpb24gMTA0 MjY4KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTIzNSw2ICsyMzUsMjQgQEAgRnJhbWU6On5GcmFtZSgpCiAgICAgfQogfQogCitGcmFtZURlc3Ry dWN0aW9uT2JzZXJ2ZXI6OkZyYW1lRGVzdHJ1Y3Rpb25PYnNlcnZlcihGcmFtZSogZnJhbWUpCisg ICAgOiBtX2ZyYW1lKGZyYW1lKQoreworICAgIGlmIChtX2ZyYW1lKQorICAgICAgICBtX2ZyYW1l LT5hZGREZXN0cnVjdGlvbk9ic2VydmVyKHRoaXMpOworfQorCitGcmFtZURlc3RydWN0aW9uT2Jz ZXJ2ZXI6On5GcmFtZURlc3RydWN0aW9uT2JzZXJ2ZXIoKQoreworICAgIGlmIChtX2ZyYW1lKQor ICAgICAgICBtX2ZyYW1lLT5yZW1vdmVEZXN0cnVjdGlvbk9ic2VydmVyKHRoaXMpOworfQorCit2 b2lkIEZyYW1lRGVzdHJ1Y3Rpb25PYnNlcnZlcjo6ZnJhbWVEZXN0cm95ZWQoKQoreworICAgIG1f ZnJhbWUgPSAwOworfQorCiB2b2lkIEZyYW1lOjphZGREZXN0cnVjdGlvbk9ic2VydmVyKEZyYW1l RGVzdHJ1Y3Rpb25PYnNlcnZlciogb2JzZXJ2ZXIpCiB7CiAgICAgbV9kZXN0cnVjdGlvbk9ic2Vy dmVycy5hZGQob2JzZXJ2ZXIpOwpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuaAkocmV2aXNpb24gMTA0MjY4 KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5oCSh3b3JraW5nIGNvcHkpCkBAIC02Myw2 ICs2Myw3IEBAIHR5cGVkZWYgc3RydWN0IEhCSVRNQVBfXyogSEJJVE1BUDsKIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAogICAgIGNsYXNzIERvY3VtZW50OworICAgIGNsYXNzIEZyYW1lOwogICAgIGNs YXNzIEZyYW1lVmlldzsKICAgICBjbGFzcyBIVE1MVGFibGVDZWxsRWxlbWVudDsKICAgICBjbGFz cyBSZWd1bGFyRXhwcmVzc2lvbjsKQEAgLTc1LDkgKzc2LDE0IEBAIG5hbWVzcGFjZSBXZWJDb3Jl IHsKIAogICAgIGNsYXNzIEZyYW1lRGVzdHJ1Y3Rpb25PYnNlcnZlciB7CiAgICAgcHVibGljOgot ICAgICAgICB2aXJ0dWFsIH5GcmFtZURlc3RydWN0aW9uT2JzZXJ2ZXIoKSB7IH0KKyAgICAgICAg ZXhwbGljaXQgRnJhbWVEZXN0cnVjdGlvbk9ic2VydmVyKEZyYW1lKik7CisgICAgICAgIHZpcnR1 YWwgdm9pZCBmcmFtZURlc3Ryb3llZCgpOworICAgICAgICBGcmFtZSogZnJhbWUoKSBjb25zdCB7 IHJldHVybiBtX2ZyYW1lOyB9CiAKLSAgICAgICAgdmlydHVhbCB2b2lkIGZyYW1lRGVzdHJveWVk KCkgPSAwOworICAgIHByb3RlY3RlZDoKKyAgICAgICAgdmlydHVhbCB+RnJhbWVEZXN0cnVjdGlv bk9ic2VydmVyKCk7CisKKyAgICAgICAgRnJhbWUqIG1fZnJhbWU7CiAgICAgfTsKIAogICAgIGNs YXNzIEZyYW1lIDogcHVibGljIFJlZkNvdW50ZWQ8RnJhbWU+LCBwdWJsaWMgVGlsZWRCYWNraW5n U3RvcmVDbGllbnQgewpJbmRleDogU291cmNlL1dlYkNvcmUvcGx1Z2lucy9ET01NaW1lVHlwZS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGx1Z2lucy9ET01NaW1lVHlwZS5jcHAJ KHJldmlzaW9uIDEwNDI2OCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsdWdpbnMvRE9NTWltZVR5cGUu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMCwxOCArMzAsMTQgQEAKIG5hbWVzcGFjZSBXZWJDb3Jl IHsKIAogRE9NTWltZVR5cGU6OkRPTU1pbWVUeXBlKFBhc3NSZWZQdHI8UGx1Z2luRGF0YT4gcGx1 Z2luRGF0YSwgRnJhbWUqIGZyYW1lLCB1bnNpZ25lZCBpbmRleCkKLSAgICA6IG1fcGx1Z2luRGF0 YShwbHVnaW5EYXRhKQotICAgICwgbV9mcmFtZShmcmFtZSkKKyAgICA6IEZyYW1lRGVzdHJ1Y3Rp b25PYnNlcnZlcihmcmFtZSkKKyAgICAsIG1fcGx1Z2luRGF0YShwbHVnaW5EYXRhKQogICAgICwg bV9pbmRleChpbmRleCkKIHsKLSAgICBpZiAobV9mcmFtZSkKLSAgICAgICAgbV9mcmFtZS0+YWRk RGVzdHJ1Y3Rpb25PYnNlcnZlcih0aGlzKTsKIH0KIAogRE9NTWltZVR5cGU6On5ET01NaW1lVHlw ZSgpCiB7Ci0gICAgaWYgKG1fZnJhbWUpCi0gICAgICAgIG1fZnJhbWUtPnJlbW92ZURlc3RydWN0 aW9uT2JzZXJ2ZXIodGhpcyk7CiB9CiAKIGNvbnN0IFN0cmluZyAmRE9NTWltZVR5cGU6OnR5cGUo KSBjb25zdApJbmRleDogU291cmNlL1dlYkNvcmUvcGx1Z2lucy9ET01NaW1lVHlwZS5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsdWdpbnMvRE9NTWltZVR5cGUuaAkocmV2aXNpb24g MTA0MjY4KQorKysgU291cmNlL1dlYkNvcmUvcGx1Z2lucy9ET01NaW1lVHlwZS5oCSh3b3JraW5n IGNvcHkpCkBAIC0zMiw3ICszMiw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgRE9N UGx1Z2luOwogCi1jbGFzcyBET01NaW1lVHlwZSA6IHB1YmxpYyBSZWZDb3VudGVkPERPTU1pbWVU eXBlPiwgcHJpdmF0ZSBGcmFtZURlc3RydWN0aW9uT2JzZXJ2ZXIgeworY2xhc3MgRE9NTWltZVR5 cGUgOiBwdWJsaWMgUmVmQ291bnRlZDxET01NaW1lVHlwZT4sIHB1YmxpYyBGcmFtZURlc3RydWN0 aW9uT2JzZXJ2ZXIgewogcHVibGljOgogICAgIHN0YXRpYyBQYXNzUmVmUHRyPERPTU1pbWVUeXBl PiBjcmVhdGUoUGFzc1JlZlB0cjxQbHVnaW5EYXRhPiBwbHVnaW5EYXRhLCBGcmFtZSogZnJhbWUs IHVuc2lnbmVkIGluZGV4KSB7IHJldHVybiBhZG9wdFJlZihuZXcgRE9NTWltZVR5cGUocGx1Z2lu RGF0YSwgZnJhbWUsIGluZGV4KSk7IH0KICAgICB+RE9NTWltZVR5cGUoKTsKQEAgLTQyLDE1ICs0 MiwxMSBAQCBwdWJsaWM6CiAgICAgY29uc3QgU3RyaW5nICZkZXNjcmlwdGlvbigpIGNvbnN0Owog ICAgIFBhc3NSZWZQdHI8RE9NUGx1Z2luPiBlbmFibGVkUGx1Z2luKCkgY29uc3Q7CiAKLSAgICAv LyBGcmFtZURlc3RydWN0aW9uT2JzZXJ2ZXIKLSAgICB2aXJ0dWFsIHZvaWQgZnJhbWVEZXN0cm95 ZWQoKSB7IG1fZnJhbWUgPSAwOyB9Ci0KIHByaXZhdGU6CiAgICAgY29uc3QgTWltZUNsYXNzSW5m byYgbWltZUNsYXNzSW5mbygpIGNvbnN0IHsgcmV0dXJuIG1fcGx1Z2luRGF0YS0+bWltZXMoKVtt X2luZGV4XTsgfQotICAgIAorCiAgICAgRE9NTWltZVR5cGUoUGFzc1JlZlB0cjxQbHVnaW5EYXRh PiwgRnJhbWUqLCB1bnNpZ25lZCBpbmRleCk7CiAgICAgUmVmUHRyPFBsdWdpbkRhdGE+IG1fcGx1 Z2luRGF0YTsKLSAgICBGcmFtZSogbV9mcmFtZTsKICAgICB1bnNpZ25lZCBtX2luZGV4OwogfTsK IApJbmRleDogU291cmNlL1dlYkNvcmUvcGx1Z2lucy9ET01QbHVnaW4uY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3BsdWdpbnMvRE9NUGx1Z2luLmNwcAkocmV2aXNpb24gMTA0MjY4 KQorKysgU291cmNlL1dlYkNvcmUvcGx1Z2lucy9ET01QbHVnaW4uY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yNiwxOCArMjYsMTQgQEAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogRE9NUGx1Z2luOjpE T01QbHVnaW4oUGx1Z2luRGF0YSogcGx1Z2luRGF0YSwgRnJhbWUqIGZyYW1lLCB1bnNpZ25lZCBp bmRleCkKLSAgICA6IG1fcGx1Z2luRGF0YShwbHVnaW5EYXRhKQotICAgICwgbV9mcmFtZShmcmFt ZSkKKyAgICA6IEZyYW1lRGVzdHJ1Y3Rpb25PYnNlcnZlcihmcmFtZSkKKyAgICAsIG1fcGx1Z2lu RGF0YShwbHVnaW5EYXRhKQogICAgICwgbV9pbmRleChpbmRleCkKIHsKLSAgICBpZiAobV9mcmFt ZSkKLSAgICAgICAgbV9mcmFtZS0+YWRkRGVzdHJ1Y3Rpb25PYnNlcnZlcih0aGlzKTsKIH0KIAog RE9NUGx1Z2luOjp+RE9NUGx1Z2luKCkKIHsKLSAgICBpZiAobV9mcmFtZSkKLSAgICAgICAgbV9m cmFtZS0+cmVtb3ZlRGVzdHJ1Y3Rpb25PYnNlcnZlcih0aGlzKTsKIH0KIAogU3RyaW5nIERPTVBs dWdpbjo6bmFtZSgpIGNvbnN0CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL0RPTVBsdWdp bi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsdWdpbnMvRE9NUGx1Z2luLmgJKHJl dmlzaW9uIDEwNDI2OCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsdWdpbnMvRE9NUGx1Z2luLmgJKHdv cmtpbmcgY29weSkKQEAgLTMwLDcgKzMwLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogY2xhc3Mg UGx1Z2luOwogY2xhc3MgUGx1Z2luRGF0YTsKIAotY2xhc3MgRE9NUGx1Z2luIDogcHVibGljIFJl ZkNvdW50ZWQ8RE9NUGx1Z2luPiwgcHJpdmF0ZSBGcmFtZURlc3RydWN0aW9uT2JzZXJ2ZXIgewor Y2xhc3MgRE9NUGx1Z2luIDogcHVibGljIFJlZkNvdW50ZWQ8RE9NUGx1Z2luPiwgcHVibGljIEZy YW1lRGVzdHJ1Y3Rpb25PYnNlcnZlciB7CiBwdWJsaWM6CiAgICAgc3RhdGljIFBhc3NSZWZQdHI8 RE9NUGx1Z2luPiBjcmVhdGUoUGx1Z2luRGF0YSogcGx1Z2luRGF0YSwgRnJhbWUqIGZyYW1lLCB1 bnNpZ25lZCBpbmRleCkgeyByZXR1cm4gYWRvcHRSZWYobmV3IERPTVBsdWdpbihwbHVnaW5EYXRh LCBmcmFtZSwgaW5kZXgpKTsgfQogICAgIH5ET01QbHVnaW4oKTsKQEAgLTQ1LDE1ICs0NSwxMSBA QCBwdWJsaWM6CiAgICAgYm9vbCBjYW5HZXRJdGVtc0Zvck5hbWUoY29uc3QgQXRvbWljU3RyaW5n JiBwcm9wZXJ0eU5hbWUpOwogICAgIFBhc3NSZWZQdHI8RE9NTWltZVR5cGU+IG5hbWVkSXRlbShj b25zdCBBdG9taWNTdHJpbmcmIHByb3BlcnR5TmFtZSk7CiAKLSAgICAvLyBGcmFtZURlc3RydWN0 aW9uT2JzZXJ2ZXIKLSAgICB2aXJ0dWFsIHZvaWQgZnJhbWVEZXN0cm95ZWQoKSB7IG1fZnJhbWUg PSAwOyB9Ci0KIHByaXZhdGU6CiAgICAgY29uc3QgUGx1Z2luSW5mbyYgcGx1Z2luSW5mbygpIGNv bnN0IHsgcmV0dXJuIG1fcGx1Z2luRGF0YS0+cGx1Z2lucygpW21faW5kZXhdOyB9CiAKICAgICBE T01QbHVnaW4oUGx1Z2luRGF0YSosIEZyYW1lKiwgdW5zaWduZWQgaW5kZXgpOwogICAgIFJlZlB0 cjxQbHVnaW5EYXRhPiBtX3BsdWdpbkRhdGE7Ci0gICAgRnJhbWUqIG1fZnJhbWU7CiAgICAgdW5z aWduZWQgbV9pbmRleDsKIH07CiAK