75681 2012-01-05 18:45:33 -0800 [EFL] Fixed displaying buffering progress in the media control. 2012-08-14 03:13:30 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 ky0.choi webkit-unassigned gyuyoung.kim gyuyoung.kim kenneth lucas.de.marchi rakuco sw0524.lee webkit.review.bot oldest_to_newest 530866 0 ky0.choi 2012-01-05 18:45:33 -0800 Fixed typo. It is required "rangeRect" instead of "rect". 530936 1 ky0.choi 2012-01-05 22:36:18 -0800 It is required "rangeRect" instead of "rect" to display buffering progress properly. 675406 2 153722 ky0.choi 2012-07-22 20:07:28 -0700 Created attachment 153722 patch 675426 3 153722 rakuco 2012-07-22 21:00:02 -0700 Comment on attachment 153722 patch Does it make any existing test pass? 675449 4 153722 cdumez 2012-07-22 22:26:41 -0700 Comment on attachment 153722 patch Change looks good but it is likely that some tests need rebasing with this fix. It would be good to do the rebasing in the same patch if it is really needed. 676615 5 ky0.choi 2012-07-24 03:39:15 -0700 I tested "LayoutTests/media/" with/without this patch. But, the test results are same. Each case has 356 failures. This patch does not affects the test results. It's about network load and displaying media control. The buffering progress can be read from JS properly, but display is wrong. I think this patch is required to display buffering progress on media control properly. 680427 6 ky0.choi 2012-07-27 04:19:19 -0700 Should I provide test for this patch? I think it's not easy. :( 680758 7 153722 gyuyoung.kim 2012-07-27 10:06:24 -0700 Comment on attachment 153722 patch Could you check if there is difference result on whole layout test. If there is no effect EFL layout test result, looks fine. 681249 8 rakuco 2012-07-27 17:08:09 -0700 Are you sure no test can be unskipped after this fix? 682771 9 ky0.choi 2012-07-31 00:11:44 -0700 My previous test result was wrong. I should use SHARED_CORE But I did't. So I tested it again. 1. LayoutTests/media/ Test after remove efl/Skipped and wk2/Skipped The results are same. 102 are diff and 1 is flaky. 2. Entire test The results are little bit different. But the different items are not related to media. The changes on this patch is just display rect on media control. So it does not affect to other part. 692422 10 ky0.choi 2012-08-10 03:32:26 -0700 There are no changes in LayoutTests. But it's too hard to make a test for this. If this patch is not applied, then above block to calculate rangeRect is not necessary. I think it need to be merged. 693381 11 153722 gyuyoung.kim 2012-08-12 22:34:54 -0700 Comment on attachment 153722 patch If this patch doesn't influence on existing layout test result and there is no unskipped tests, looks good to me. 694738 12 153722 webkit.review.bot 2012-08-14 03:13:25 -0700 Comment on attachment 153722 patch Clearing flags on attachment: 153722 Committed r125536: <http://trac.webkit.org/changeset/125536> 694739 13 webkit.review.bot 2012-08-14 03:13:30 -0700 All reviewed patches have been landed. Closing bug. 153722 2012-07-22 20:07:28 -0700 2012-08-14 03:13:24 -0700 patch patch text/plain 1401 ky0.choi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0YjAyZjJhLi45YTBhNDUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDctMjIgIEt3YW5nWW9uZyBDaG9pICA8a3kwLmNob2lAc2Ftc3VuZy5jb20+CisK KyAgICAgICAgW0VGTF0gRml4ZWQgZGlzcGxheWluZyBidWZmZXJpbmcgcHJvZ3Jlc3MgaW4gdGhl IG1lZGlhIGNvbnRyb2wuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03NTY4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEl0IGlzIHJlcXVpcmVkICJyYW5nZVJlY3QiIGluc3RlYWQgb2YgInJlY3QiIHRvIGRp c3BsYXkgYnVmZmVyaW5nCisgICAgICAgIHByb2dyZXNzIHByb3Blcmx5LgorCisgICAgICAgICog cGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl clRoZW1lRWZsOjpwYWludE1lZGlhU2xpZGVyVHJhY2spOgorCiAyMDEyLTA3LTIyICBHeXV5b3Vu ZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgTWlzc2luZyAqZXhw bGljaXQqIGtleXdvcmQgaW4gc3RvcmFnZSBhbmQgd29ya2Vycy4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwCmluZGV4IGU1Nzg0YWYuLmZlOTdkODIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcApA QCAtMTIxMiw3ICsxMjEyLDcgQEAgYm9vbCBSZW5kZXJUaGVtZUVmbDo6cGFpbnRNZWRpYVNsaWRl clRyYWNrKFJlbmRlck9iamVjdCogb2JqZWN0LCBjb25zdCBQYWludEluZm8KICAgICAgICAgSW50 UG9pbnQgc2xpZGVyVG9wUmlnaHQgPSBzbGlkZXJUb3BMZWZ0OwogICAgICAgICBzbGlkZXJUb3BS aWdodC5tb3ZlKDAsIHJhbmdlUmVjdC5oZWlnaHQoKSk7CiAKLSAgICAgICAgY29udGV4dC0+Zmls bFJlY3QoRmxvYXRSZWN0KHJlY3QpLCBtX21lZGlhUGFuZWxDb2xvciwgQ29sb3JTcGFjZURldmlj ZVJHQik7CisgICAgICAgIGNvbnRleHQtPmZpbGxSZWN0KEZsb2F0UmVjdChyYW5nZVJlY3QpLCBt X21lZGlhUGFuZWxDb2xvciwgQ29sb3JTcGFjZURldmljZVJHQik7CiAgICAgfQogICAgIGNvbnRl eHQtPnJlc3RvcmUoKTsKICAgICByZXR1cm4gdHJ1ZTsK