75656 2012-01-05 15:19:01 -0800 Assertion failure under SharedBuffer::append() when NETWORK_CFDATA_ARRAY_CALLBACK is enabled 2012-01-08 13:31:21 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 psolanki psolanki benjamin japhet psolanki webkit.review.bot oldest_to_newest 530684 0 psolanki 2012-01-05 15:19:01 -0800 I get the following assertion when I enable NETWORK_CFDATA_ARRAY_CALLBACK on Mac OSX. ASSERTION FAILED: i < size() /Volumes/Data/Builds/Xcode4-builds/Debug/JavaScriptCore.framework/PrivateHeaders/Vector.h(520) : char *&WTF::Vector<char *, 0>::at(size_t) 1 0x1033deb9a WTF::Vector<char*, 0ul>::at(unsigned long) 2 0x1033de0cb WTF::Vector<char*, 0ul>::last() 3 0x1033dd18b WebCore::SharedBuffer::append(char const*, unsigned int) 4 0x103327eeb WebCore::ResourceLoader::addData(char const*, int, bool) 5 0x103328499 WebCore::ResourceLoader::didReceiveData(char const*, int, long long, bool) 6 0x10344c811 WebCore::SubresourceLoader::didReceiveData(char const*, int, long long, bool) 7 0x10344d2b1 WebCore::SubresourceLoader::didReceiveDataArray(__CFArray const*) 8 0x103329d38 WebCore::ResourceLoader::didReceiveDataArray(WebCore::ResourceHandle*, __CFArray const*) 9 0x1033238b2 WebCore::ResourceHandle::handleDataArray(__CFArray const*) 10 0x1033212c0 _ZN7WebCoreL19didReceiveDataArrayEP16_CFURLConnectionPK9__CFArrayPKv 11 0x7fff8fa9f563 URLConnectionClient::_clientDidReceiveData(__CFArray const*, URLConnectionClient::ClientConnectionEventQueue*) 12 0x7fff8fb50ceb URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePayload(XConnectionEventInfo<XClientEvent, XClientEventParams>*, long) 13 0x7fff8fb50efa URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePayload(XConnectionEventInfo<XClientEvent, XClientEventParams>*, long) 14 0x7fff8fa7bdfd URLConnectionClient::processEvents() 15 0x7fff8fa7bca2 MultiplexerSource::perform() 16 0x7fff8e818b51 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 17 0x7fff8e81847c __CFRunLoopDoSources0 18 0x7fff8e83f1a9 __CFRunLoopRun 19 0x7fff8e83eae6 CFRunLoopRunSpecific 20 0x7fff923973d3 RunCurrentEventLoopInMode 21 0x7fff9239e63d ReceiveNextEventCommon 22 0x7fff9239e4ca BlockUntilNextEventMatchingListInMode 23 0x7fff949573f1 _DPSNextEvent 24 0x7fff94956cf5 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] 25 0x7fff8dfa80d3 -[BrowserApplication nextEventMatchingMask:untilDate:inMode:dequeue:] 26 0x7fff9495362d -[NSApplication run] 27 0x7fff94bd280c NSApplicationMain 28 0x7fff8e15bffb SafariMain 29 0x100000f24 530794 1 121370 psolanki 2012-01-05 17:04:29 -0800 Created attachment 121370 Patch 531804 2 121370 webkit.review.bot 2012-01-08 13:31:18 -0800 Comment on attachment 121370 Patch Clearing flags on attachment: 121370 Committed r104407: <http://trac.webkit.org/changeset/104407> 531805 3 webkit.review.bot 2012-01-08 13:31:21 -0800 All reviewed patches have been landed. Closing bug. 121370 2012-01-05 17:04:29 -0800 2012-01-08 13:31:17 -0800 Patch bug-75656-20120105170428.patch text/plain 4121 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0MTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTM5NGFhYjkzYzFmOTY1 MzhmMDJmYmYwODI2MTAzZWRkMWExODRjNC4uZmJkMjY3M2ZiNzdhNmU4ZTJmNDU5YTgzNWJkN2Vk ZTMwODZjMTA0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTAxLTA1ICBQcmF0 aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKworICAgICAgICBBc3NlcnRpb24gZmFp bHVyZSB1bmRlciBTaGFyZWRCdWZmZXI6OmFwcGVuZCgpIHdoZW4gTkVUV09SS19DRkRBVEFfQVJS QVlfQ0FMTEJBQ0sgaXMgZW5hYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NzU2NTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBVcGRhdGUgdGhlIGltcGxlbWVudGF0aW9uIG9mIFN1YnJlc291cmNlTG9h ZGVyOjpkaWRSZWNlaXZlRGF0YUFycmF5KCkgdG8gY29uZm9ybSB0byB0aGUKKyAgICAgICAgcmVm YWN0b3JpbmcgZG9uZSBhcyBwYXJ0IG9mIGJ1ZyA3MTE0OSBpbiByMTAwMzExLgorCisgICAgICAg ICogbG9hZGVyL1N1YnJlc291cmNlTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN1YnJl c291cmNlTG9hZGVyOjpkaWRSZWNlaXZlRGF0YSk6CisgICAgICAgIChXZWJDb3JlOjpTdWJyZXNv dXJjZUxvYWRlcjo6ZXJyb3JMb2FkaW5nUmVzb3VyY2UpOgorICAgICAgICAqIGxvYWRlci9TdWJy ZXNvdXJjZUxvYWRlci5oOgorICAgICAgICAqIGxvYWRlci9jZi9TdWJyZXNvdXJjZUxvYWRlckNG LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN1YnJlc291cmNlTG9hZGVyOjpkaWRSZWNlaXZlRGF0 YUFycmF5KToKKwogMjAxMi0wMS0wNSAgSmlhbiBMaSAgPGppYW5saUBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgRmlsZVJlYWRlciBuZWVkcyBhZGRFdmVudExpc3RlbmVyCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9sb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNv cmUvbG9hZGVyL1N1YnJlc291cmNlTG9hZGVyLmNwcAppbmRleCA3MDM1MTdiY2FhNDIxMjc3MThk OTVlNjExNmNiOTc5MGY0ZjgwNTNhLi5iOWExZDdlM2ViMjMzMGU3YzUxNDlmNzAyMzZmNjc5Mzhi NWYyZDg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvU3VicmVzb3VyY2VMb2Fk ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9TdWJyZXNvdXJjZUxvYWRlci5jcHAK QEAgLTIxMSwxNyArMjExLDI0IEBAIHZvaWQgU3VicmVzb3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVE YXRhKGNvbnN0IGNoYXIqIGRhdGEsIGludCBsZW5ndGgsIGxvbmcgbG9uZyBlCiAgICAgUmVmUHRy PFN1YnJlc291cmNlTG9hZGVyPiBwcm90ZWN0KHRoaXMpOwogICAgIFJlc291cmNlTG9hZGVyOjpk aWRSZWNlaXZlRGF0YShkYXRhLCBsZW5ndGgsIGVuY29kZWREYXRhTGVuZ3RoLCBhbGxBdE9uY2Up OwogCi0gICAgaWYgKG1fcmVzb3VyY2UtPnJlc3BvbnNlKCkuaHR0cFN0YXR1c0NvZGUoKSA+PSA0 MDAgJiYgIW1fcmVzb3VyY2UtPnNob3VsZElnbm9yZUhUVFBTdGF0dXNDb2RlRXJyb3JzKCkpIHsK LSAgICAgICAgbV9yZXNvdXJjZS0+ZXJyb3IoQ2FjaGVkUmVzb3VyY2U6OkxvYWRFcnJvcik7Ci0g ICAgICAgIG1fc3RhdGUgPSBGaW5pc2hpbmc7Ci0gICAgICAgIGNhbmNlbCgpOworICAgIGlmIChl cnJvckxvYWRpbmdSZXNvdXJjZSgpKQogICAgICAgICByZXR1cm47Ci0gICAgfQogCiAgICAgaWYg KCFtX2xvYWRpbmdNdWx0aXBhcnRDb250ZW50KQogICAgICAgICBzZW5kRGF0YVRvUmVzb3VyY2Uo ZGF0YSwgbGVuZ3RoKTsKIH0KIAorYm9vbCBTdWJyZXNvdXJjZUxvYWRlcjo6ZXJyb3JMb2FkaW5n UmVzb3VyY2UoKQoreworICAgIGlmIChtX3Jlc291cmNlLT5yZXNwb25zZSgpLmh0dHBTdGF0dXND b2RlKCkgPCA0MDAgfHwgbV9yZXNvdXJjZS0+c2hvdWxkSWdub3JlSFRUUFN0YXR1c0NvZGVFcnJv cnMoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgbV9yZXNvdXJjZS0+ZXJyb3IoQ2Fj aGVkUmVzb3VyY2U6OkxvYWRFcnJvcik7CisgICAgbV9zdGF0ZSA9IEZpbmlzaGluZzsKKyAgICBj YW5jZWwoKTsKKyAgICByZXR1cm4gdHJ1ZTsKK30KKwogdm9pZCBTdWJyZXNvdXJjZUxvYWRlcjo6 c2VuZERhdGFUb1Jlc291cmNlKGNvbnN0IGNoYXIqIGRhdGEsIGludCBsZW5ndGgpCiB7CiAgICAg Ly8gVGhlcmUgYXJlIHR3byBjYXNlcyB3aGVyZSB3ZSBtaWdodCBuZWVkIHRvIGNyZWF0ZSBvdXIg b3duIFNoYXJlZEJ1ZmZlciBpbnN0ZWFkIG9mIGNvcHlpbmcgdGhlIG9uZSBpbiBSZXNvdXJjZUxv YWRlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9TdWJyZXNvdXJjZUxvYWRl ci5oIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL1N1YnJlc291cmNlTG9hZGVyLmgKaW5kZXggMmRh MzAzOTE3M2NjNjlhN2ViNzZmMDdiZGFiZWI3N2IwMGU0YjcxNy4uM2NmMmYzNjYxM2U3YmU4Yjg3 MDkzZWMwZWU1MzkzYWNkNWIzNWRlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVy L1N1YnJlc291cmNlTG9hZGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL1N1YnJlc291 cmNlTG9hZGVyLmgKQEAgLTcxLDYgKzcxLDcgQEAgcHJpdmF0ZToKICNlbmRpZgogICAgIHZpcnR1 YWwgdm9pZCByZWxlYXNlUmVzb3VyY2VzKCk7CiAKKyAgICBib29sIGVycm9yTG9hZGluZ1Jlc291 cmNlKCk7CiAgICAgdm9pZCBzZW5kRGF0YVRvUmVzb3VyY2UoY29uc3QgY2hhciosIGludCk7CiAK ICAgICBlbnVtIFN1YnJlc291cmNlTG9hZGVyU3RhdGUgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvbG9hZGVyL2NmL1N1YnJlc291cmNlTG9hZGVyQ0YuY3BwIGIvU291cmNlL1dlYkNvcmUv bG9hZGVyL2NmL1N1YnJlc291cmNlTG9hZGVyQ0YuY3BwCmluZGV4IDE1YWI4ODdmODYwZTA2MGM0 ZjVmNzA1MzdlMDRiNDMzZGJiMDRhMTcuLjUwMDhhMTZiNGY2MDgzMWQ3NzExODM5Nzk5NzkyYTky MWVjY2YxNjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jZi9TdWJyZXNvdXJj ZUxvYWRlckNGLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2YvU3VicmVzb3VyY2VM b2FkZXJDRi5jcHAKQEAgLTM2LDEzICszNiwxNiBAQCB2b2lkIFN1YnJlc291cmNlTG9hZGVyOjpk aWRSZWNlaXZlRGF0YUFycmF5KENGQXJyYXlSZWYgZGF0YUFycmF5KQogCiAgICAgUmVzb3VyY2VM b2FkZXI6OmRpZFJlY2VpdmVEYXRhQXJyYXkoZGF0YUFycmF5KTsKIAorICAgIGlmIChlcnJvckxv YWRpbmdSZXNvdXJjZSgpKQorICAgICAgICByZXR1cm47CisKICAgICAvLyBBIHN1YnJlc291cmNl IGxvYWRlciBkb2VzIG5vdCBsb2FkIG11bHRpcGFydCBzZWN0aW9ucyBwcm9ncmVzc2l2ZWx5Lgog ICAgIC8vIFNvIGRvbid0IGRlbGl2ZXIgYW55IGRhdGEgdG8gdGhlIGxvYWRlciB5ZXQuCiAgICAg aWYgKCFtX2xvYWRpbmdNdWx0aXBhcnRDb250ZW50KSB7CiAgICAgICAgIENGSW5kZXggYXJyYXlD b3VudCA9IENGQXJyYXlHZXRDb3VudChkYXRhQXJyYXkpOwogICAgICAgICBmb3IgKENGSW5kZXgg aSA9IDA7IGkgPCBhcnJheUNvdW50OyArK2kpICB7CiAgICAgICAgICAgICBDRkRhdGFSZWYgZGF0 YSA9IHJlaW50ZXJwcmV0X2Nhc3Q8Q0ZEYXRhUmVmPihDRkFycmF5R2V0VmFsdWVBdEluZGV4KGRh dGFBcnJheSwgaSkpOwotICAgICAgICAgICAgZGlkUmVjZWl2ZURhdGEocmVpbnRlcnByZXRfY2Fz dDxjb25zdCBjaGFyICo+KENGRGF0YUdldEJ5dGVQdHIoZGF0YSkpLCBzdGF0aWNfY2FzdDxpbnQ+ KENGRGF0YUdldExlbmd0aChkYXRhKSksIC0xLCBmYWxzZSk7CisgICAgICAgICAgICBzZW5kRGF0 YVRvUmVzb3VyY2UocmVpbnRlcnByZXRfY2FzdDxjb25zdCBjaGFyICo+KENGRGF0YUdldEJ5dGVQ dHIoZGF0YSkpLCBzdGF0aWNfY2FzdDxpbnQ+KENGRGF0YUdldExlbmd0aChkYXRhKSkpOwogICAg ICAgICB9CiAgICAgfQogfQo=