75654 2012-01-05 15:16:42 -0800 Text fields should draw using NSTextFieldCell instead of WebKitSystemInterface 2012-05-14 15:31:20 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin rniwa oldest_to_newest 530680 0 bdakin 2012-01-05 15:16:42 -0800 Text fields should be converted to draw via NSCell like other form controls. 530686 1 121344 bdakin 2012-01-05 15:20:34 -0800 Created attachment 121344 Patch 530760 2 bdakin 2012-01-05 16:31:12 -0800 Thanks John! Committed change with revision 104240. 532806 3 rniwa 2012-01-09 21:35:03 -0800 fyi, chromium reverted this change: http://trac.webkit.org/changeset/104494 623385 4 ap 2012-05-14 15:31:20 -0700 This was <rdar://problem/10582064>. > fyi, chromium reverted this change: http://trac.webkit.org/changeset/104494 I think that a regression was fixed later as <http://trac.webkit.org/changeset/110480>. 121344 2012-01-05 15:20:34 -0800 2012-01-05 16:09:47 -0800 Patch for-review.txt text/plain 3593 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNDIzMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAxLTA1ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzU2NTQKKyAgICAgICAgVGV4dCBmaWVsZHMgc2hvdWxkIGRyYXcg dXNpbmcgTlNUZXh0RmllbGRDZWxsIGluc3RlYWQgb2YgV2ViS2l0U3lzdGVtSW50ZXJmYWNlCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBjaGFu Z2Ugc2hvdWxkIG5vdCBoYXZlIGFueSBhZmZlY3Qgb24gdGVzdHMgb3IgcmVhbCB3ZWIgc2l0ZXMu IEl0IGp1c3QgY2hhbmdlZCAKKyAgICAgICAgdGhlIGltcGxlbWVudGF0aW9uIHVuZGVyIHRoZSBo b29kIHRvIHRoZSBtb3JlIG1vZGVybiBOU0NlbGwgYXBwcm9hY2guCisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlclRoZW1lTWFjLmg6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFj Lm1tOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVNYWM6OnBhaW50VGV4dEZpZWxkKToK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lTWFjOjp0ZXh0RmllbGQpOgorCiAyMDEyLTAx LTA1ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgSW50cm9kdWNl IFBsYXRmb3JtIG5hbWVzcGFjZSBmb3IgV2ViQ29yZS9wbGF0Zm9ybQpJbmRleDogU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLmgJKHJldmlzaW9uIDEwMzk0OCkKKysrIFNv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZU1hYy5oCSh3b3JraW5nIGNvcHkpCkBA IC0yMTksNiArMjE5LDcgQEAgcHJpdmF0ZToKICAgICBOU01lbnUqIHNlYXJjaE1lbnVUZW1wbGF0 ZSgpIGNvbnN0OwogICAgIE5TU2xpZGVyQ2VsbCogc2xpZGVyVGh1bWJIb3Jpem9udGFsKCkgY29u c3Q7CiAgICAgTlNTbGlkZXJDZWxsKiBzbGlkZXJUaHVtYlZlcnRpY2FsKCkgY29uc3Q7CisgICAg TlNUZXh0RmllbGRDZWxsKiB0ZXh0RmllbGQoKSBjb25zdDsKIAogI2lmIEVOQUJMRShNRVRFUl9U QUcpCiAgICAgTlNMZXZlbEluZGljYXRvclN0eWxlIGxldmVsSW5kaWNhdG9yU3R5bGVGb3IoQ29u dHJvbFBhcnQpIGNvbnN0OwpAQCAtMjM4LDYgKzIzOSw3IEBAIHByaXZhdGU6CiAgICAgbXV0YWJs ZSBSZXRhaW5QdHI8TlNTbGlkZXJDZWxsPiBtX3NsaWRlclRodW1iSG9yaXpvbnRhbDsKICAgICBt dXRhYmxlIFJldGFpblB0cjxOU1NsaWRlckNlbGw+IG1fc2xpZGVyVGh1bWJWZXJ0aWNhbDsKICAg ICBtdXRhYmxlIFJldGFpblB0cjxOU0xldmVsSW5kaWNhdG9yQ2VsbD4gbV9sZXZlbEluZGljYXRv cjsKKyAgICBtdXRhYmxlIFJldGFpblB0cjxOU1RleHRGaWVsZENlbGw+IG1fdGV4dEZpZWxkOwog CiAgICAgYm9vbCBtX2lzU2xpZGVyVGh1bWJIb3Jpem9udGFsUHJlc3NlZDsKICAgICBib29sIG1f aXNTbGlkZXJUaHVtYlZlcnRpY2FsUHJlc3NlZDsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJUaGVtZU1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVGhlbWVNYWMubW0JKHJldmlzaW9uIDEwMzk0OCkKKysrIFNvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZU1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtNzEzLDcg KzcxMywxNSBAQCBOU0NvbnRyb2xTaXplIFJlbmRlclRoZW1lTWFjOjpjb250cm9sU2l6CiBib29s IFJlbmRlclRoZW1lTWFjOjpwYWludFRleHRGaWVsZChSZW5kZXJPYmplY3QqIG8sIGNvbnN0IFBh aW50SW5mbyYgcGFpbnRJbmZvLCBjb25zdCBJbnRSZWN0JiByKQogewogICAgIExvY2FsQ3VycmVu dEdyYXBoaWNzQ29udGV4dCBsb2NhbENvbnRleHQocGFpbnRJbmZvLmNvbnRleHQpOwotICAgIHdr RHJhd0JlemVsZWRUZXh0RmllbGRDZWxsKHIsIGlzRW5hYmxlZChvKSAmJiAhaXNSZWFkT25seUNv bnRyb2wobykpOworICAgIE5TVGV4dEZpZWxkQ2VsbCogdGV4dEZpZWxkID0gdGhpcy0+dGV4dEZp ZWxkKCk7CisKKyAgICBHcmFwaGljc0NvbnRleHRTdGF0ZVNhdmVyIHN0YXRlU2F2ZXIoKnBhaW50 SW5mby5jb250ZXh0KTsKKworICAgIFt0ZXh0RmllbGQgc2V0RW5hYmxlZDooaXNFbmFibGVkKG8p ICYmICFpc1JlYWRPbmx5Q29udHJvbChvKSldOworICAgIFt0ZXh0RmllbGQgZHJhd1dpdGhGcmFt ZTpOU1JlY3QocikgaW5WaWV3OmRvY3VtZW50Vmlld0ZvcihvKV07CisKKyAgICBbdGV4dEZpZWxk IHNldENvbnRyb2xWaWV3Om5pbF07CisKICAgICByZXR1cm4gZmFsc2U7CiB9CiAKQEAgLTIwODQs NiArMjA5MiwyMyBAQCBOU1NsaWRlckNlbGwqIFJlbmRlclRoZW1lTWFjOjpzbGlkZXJUaHVtCiAg ICAgcmV0dXJuIG1fc2xpZGVyVGh1bWJWZXJ0aWNhbC5nZXQoKTsKIH0KIAorTlNUZXh0RmllbGRD ZWxsKiBSZW5kZXJUaGVtZU1hYzo6dGV4dEZpZWxkKCkgY29uc3QKK3sKKyAgICBpZiAoIW1fdGV4 dEZpZWxkKSB7CisgICAgICAgIG1fdGV4dEZpZWxkLmFkb3B0TlMoW1tOU1RleHRGaWVsZENlbGwg YWxsb2NdIGluaXRUZXh0Q2VsbDpAIiJdKTsKKyAgICAgICAgW21fdGV4dEZpZWxkLmdldCgpIHNl dEJlemVsZWQ6WUVTXTsKKyAgICAgICAgW21fdGV4dEZpZWxkLmdldCgpIHNldEVkaXRhYmxlOllF U107CisgICAgICAgIFttX3RleHRGaWVsZC5nZXQoKSBzZXRGb2N1c1JpbmdUeXBlOk5TRm9jdXNS aW5nVHlwZUV4dGVyaW9yXTsKKworICAgICAgICAvLyBTZXR0aW5nIGEgY2xlYXIgYmFja2dyb3Vu ZCBvbiB0aGUgY2VsbCBpcyBuZWNlc3NhcnkgZm9yIENTUy1zdHlsZWQgYmFja2dyb3VuZHMKKyAg ICAgICAgLy8gdG8gc2hvdyB0aHJvdWdoLiBJZGVhbGx5LCB0aGVyZSB3b3VsZCBiZSBhIGJldHRl ciB3YXkgdG8gZG8gdGhpcy4KKyAgICAgICAgW21fdGV4dEZpZWxkLmdldCgpIHNldERyYXdzQmFj a2dyb3VuZDpZRVNdOworICAgICAgICBbbV90ZXh0RmllbGQuZ2V0KCkgc2V0QmFja2dyb3VuZENv bG9yOltOU0NvbG9yIGNsZWFyQ29sb3JdXTsKKyAgICB9CisKKyAgICByZXR1cm4gbV90ZXh0Rmll bGQuZ2V0KCk7Cit9CisKIFN0cmluZyBSZW5kZXJUaGVtZU1hYzo6ZmlsZUxpc3ROYW1lRm9yV2lk dGgoY29uc3QgVmVjdG9yPFN0cmluZz4mIGZpbGVuYW1lcywgY29uc3QgRm9udCYgZm9udCwgaW50 IHdpZHRoLCBib29sIG11bHRpcGxlRmlsZXNBbGxvd2VkKQogewogICAgIGlmICh3aWR0aCA8PSAw KQo=