75650 2012-01-05 14:34:41 -0800 Media Element: scrubbing in full-screen mode breaks playback. 2012-01-06 11:13:14 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble oldest_to_newest 530636 0 jer.noble 2012-01-05 14:34:41 -0800 Media Element: scrubbing in full-screen mode breaks playback. 530639 1 jer.noble 2012-01-05 14:36:14 -0800 The media panel and the timeline both attempt to handle the mouseDown event during a scrub event, which results in the timeline never receiving a mouseUp event. 530640 2 jer.noble 2012-01-05 14:36:29 -0800 <rdar://problem/10650963> 530740 3 121359 jer.noble 2012-01-05 16:00:33 -0800 Created attachment 121359 Patch 530796 4 121359 eric.carlson 2012-01-05 17:06:29 -0800 Comment on attachment 121359 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121359&action=review > Source/WebCore/html/shadow/MediaControlElements.cpp:243 > + } else if (event->type() == eventNames().mousemoveEvent && m_isBeingDragged) > continueDrag(location); Is there no need to call setDefaultHandled() on the move event? > LayoutTests/ChangeLog:9 > + * fullscreen/video-controls-timeline.html: Added. > + Did you forget to add the test results? 530860 5 jer.noble 2012-01-05 18:24:56 -0800 (In reply to comment #4) > (From update of attachment 121359 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=121359&action=review > > > Source/WebCore/html/shadow/MediaControlElements.cpp:243 > > + } else if (event->type() == eventNames().mousemoveEvent && m_isBeingDragged) > > continueDrag(location); > > Is there no need to call setDefaultHandled() on the move event? There is no need. The panel has already started capturing events at this point, so none of the other controls will get their default event handler called. > > LayoutTests/ChangeLog:9 > > + * fullscreen/video-controls-timeline.html: Added. > > + > > Did you forget to add the test results? I did; I'll add them before checking in. 531181 6 jer.noble 2012-01-06 11:13:14 -0800 Committed r104303: <http://trac.webkit.org/changeset/104303> 121359 2012-01-05 16:00:33 -0800 2012-01-05 17:06:29 -0800 Patch bug-75650-20120105160032.patch text/plain 4498 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzMjg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjgxZjFhOTg1YTRjY2Y5 ZjMwOGVlM2IwNDBjZWY0ZjdhZWNhODlkYy4uOWY5MWUzZmY3OThlOThmMmUzYTJiMTQxNWY4MjY1 Mzg2NWQ0ZTUwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTAxLTA1ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCisgICAgICAgIE1lZGlhIEVsZW1lbnQ6IHNj cnViYmluZyBpbiBmdWxsLXNjcmVlbiBtb2RlIGJyZWFrcyBwbGF5YmFjay4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1NjUwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogZnVsbHNjcmVlbi92aWRl by1jb250cm9scy10aW1lbGluZS5odG1sCisKKyAgICAgICAgT25seSBiZWdpbiBzY3J1YmJpbmcg aWYgdGhlIHBhbmVsIGl0c2VsZiBpcyB0aGUgbW91c2Vkb3duIGV2ZW50IHRhcmdldC4KKworICAg ICAgICAqIGh0bWwvc2hhZG93L01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6Ok1lZGlhQ29udHJvbFBhbmVsRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcik6CisK KzIwMTItMDEtMDUgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKICAgICAgICAg UkVHUkVTU0lPTiAocjkwNzk3KTogRnVsbCBzY3JlZW4gdmlkZW8gSFVEIGNhbm5vdCBiZSBkcmFn Z2VkIGhvcml6b250YWxseQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NzUyMDAKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cv TWVkaWFDb250cm9sRWxlbWVudHMuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVk aWFDb250cm9sRWxlbWVudHMuY3BwCmluZGV4IDQ1ZmYxNmRmMTMzODZlZDNhYWM3OWZlMWZjNGMw OTIyNGFmMDQ2NTAuLjg3ZDM3ZjNlNWFmMzFmYWFmMzM3NDdiOWEzM2ZhOWQwYTMwMjlkMWUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L01lZGlhQ29udHJvbEVsZW1lbnRz LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xFbGVtZW50 cy5jcHAKQEAgLTIzNiwxMiArMjM2LDEyIEBAIHZvaWQgTWVkaWFDb250cm9sUGFuZWxFbGVtZW50 OjpkZWZhdWx0RXZlbnRIYW5kbGVyKEV2ZW50KiBldmVudCkKIAogICAgIGlmIChldmVudC0+aXNN b3VzZUV2ZW50KCkpIHsKICAgICAgICAgTGF5b3V0UG9pbnQgbG9jYXRpb24gPSBzdGF0aWNfY2Fz dDxNb3VzZUV2ZW50Kj4oZXZlbnQpLT5hYnNvbHV0ZUxvY2F0aW9uKCk7Ci0gICAgICAgIGlmIChl dmVudC0+dHlwZSgpID09IGV2ZW50TmFtZXMoKS5tb3VzZWRvd25FdmVudCkgeworICAgICAgICBp ZiAoZXZlbnQtPnR5cGUoKSA9PSBldmVudE5hbWVzKCkubW91c2Vkb3duRXZlbnQgJiYgZXZlbnQt PnRhcmdldCgpID09IHRoaXMpIHsKICAgICAgICAgICAgIHN0YXJ0RHJhZyhsb2NhdGlvbik7CiAg ICAgICAgICAgICBldmVudC0+c2V0RGVmYXVsdEhhbmRsZWQoKTsKLSAgICAgICAgfSBlbHNlIGlm IChldmVudC0+dHlwZSgpID09IGV2ZW50TmFtZXMoKS5tb3VzZW1vdmVFdmVudCkKKyAgICAgICAg fSBlbHNlIGlmIChldmVudC0+dHlwZSgpID09IGV2ZW50TmFtZXMoKS5tb3VzZW1vdmVFdmVudCAm JiBtX2lzQmVpbmdEcmFnZ2VkKQogICAgICAgICAgICAgY29udGludWVEcmFnKGxvY2F0aW9uKTsK LSAgICAgICAgZWxzZSBpZiAoZXZlbnQtPnR5cGUoKSA9PSBldmVudE5hbWVzKCkubW91c2V1cEV2 ZW50KSB7CisgICAgICAgIGVsc2UgaWYgKGV2ZW50LT50eXBlKCkgPT0gZXZlbnROYW1lcygpLm1v dXNldXBFdmVudCAmJiBtX2lzQmVpbmdEcmFnZ2VkKSB7CiAgICAgICAgICAgICBjb250aW51ZURy YWcobG9jYXRpb24pOwogICAgICAgICAgICAgZW5kRHJhZygpOwogICAgICAgICAgICAgZXZlbnQt PnNldERlZmF1bHRIYW5kbGVkKCk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZWMwNGFlMTM3OWYzOGIzZDA2OTAzMGRlNTli N2U1MjAwZGRhYjIzYi4uMmE0MGIzNDQ1YzdlMDJkZDdkYWM0NWUyYzk5NWIzODY1ZmI5OGU2MSAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDEyLTAxLTA1ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVA YXBwbGUuY29tPgogCisgICAgICAgIE1lZGlhIEVsZW1lbnQ6IHNjcnViYmluZyBpbiBmdWxsLXNj cmVlbiBtb2RlIGJyZWFrcyBwbGF5YmFjay4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTc1NjUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBmdWxsc2NyZWVuL3ZpZGVvLWNvbnRyb2xzLXRpbWVsaW5lLmh0 bWw6IEFkZGVkLgorCisyMDEyLTAxLTA1ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29t PgorCiAgICAgICAgIFJFR1JFU1NJT04gKHI5MDc5Nyk6IEZ1bGwgc2NyZWVuIHZpZGVvIEhVRCBj YW5ub3QgYmUgZHJhZ2dlZCBob3Jpem9udGFsbHkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTc1MjAwCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Z1 bGxzY3JlZW4vdmlkZW8tY29udHJvbHMtdGltZWxpbmUuaHRtbCBiL0xheW91dFRlc3RzL2Z1bGxz Y3JlZW4vdmlkZW8tY29udHJvbHMtdGltZWxpbmUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43ZGQyMWY5OGM0 ZTRiYTVhZDMzOTY0Mzc5MDM3NjE2NDNkMzg3YTVkCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZnVsbHNjcmVlbi92aWRlby1jb250cm9scy10aW1lbGluZS5odG1sCkBAIC0wLDAgKzEs MzQgQEAKKzxib2R5PgorICAgIDxwPlRoaXMgdGVzdHMgdGhhdCB0aGUgdmlkZW8gZWxlbWVudCdz IHRpbWVsaW5lIGNvbnRyb2xzIGFyZSBkcmFnZ2FibGUgaW4gZnVsbCBzY3JlZW4uICBQcmVzcyBh bnkga2V5IHRvIGNvbnRpbnVlLjwvcD4KKyAgICA8dmlkZW8gaWQ9InZpZGVvIiB3aWR0aD0iMzAw IiBjb250cm9scz48L3ZpZGVvPgorICAgIDxzY3JpcHQgc3JjPSJmdWxsLXNjcmVlbi10ZXN0Lmpz Ij48L3NjcmlwdD4KKyAgICA8c2NyaXB0IHNyYz0iLi4vbWVkaWEvbWVkaWEtY29udHJvbHMuanMi Pjwvc2NyaXB0PgorICAgIDxzY3JpcHQgc3JjPSIuLi9tZWRpYS9tZWRpYS1maWxlLmpzIj48L3Nj cmlwdD4KKyAgICA8c2NyaXB0PgorICAgICAgICB2YXIgdmlkZW8gPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgndmlkZW8nKTsKKyAgICAgICAgdmFyIHRpbWVsaW5lOworCisgICAgICAgIHdhaXRG b3JFdmVudChkb2N1bWVudCwgJ3dlYmtpdGZ1bGxzY3JlZW5jaGFuZ2UnLCBmdW5jdGlvbigpIHsK KyAgICAgICAgICAgIGlmICh3aW5kb3cuaW50ZXJuYWxzKSB7CisgICAgICAgICAgICAgICAgdGlt ZWxpbmUgPSBtZWRpYUNvbnRyb2xzRWxlbWVudChpbnRlcm5hbHMuc2hhZG93Um9vdCh2aWRlbyku Zmlyc3RDaGlsZCwgJy13ZWJraXQtbWVkaWEtY29udHJvbHMtdGltZWxpbmUnKTsKKyAgICAgICAg ICAgICAgICB2YXIgYm94ID0gaW50ZXJuYWxzLmJvdW5kaW5nQm94KHRpbWVsaW5lKTsKKworICAg ICAgICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKGJveC5sZWZ0ICsgNSwgYm94LnRv cCArIDUpOworCisgICAgICAgICAgICAgICAgd2FpdEZvckV2ZW50KHRpbWVsaW5lLCAnbW91c2Vk b3duJyk7CisgICAgICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7CisKKyAgICAg ICAgICAgICAgICB3YWl0Rm9yRXZlbnRBbmRFbmQodGltZWxpbmUsICdtb3VzZXVwJyk7CisgICAg ICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VVcCgpOworICAgICAgICAgICAgfQorICAgICAg ICAgICAgZWxzZQorICAgICAgICAgICAgICAgIGxvZ1Jlc3VsdChmYWxzZSwgIndpbmRvdy5pbnRl cm5hbHMgPT0gdW5kZWZpbmVkIik7CisgICAgICAgIH0pOworCisgICAgICAgIHdhaXRGb3JFdmVu dCh2aWRlbywgJ2NhbnBsYXl0aHJvdWdoJywgZnVuY3Rpb24oKSB7CisgICAgICAgICAgICBydW5X aXRoS2V5RG93bihmdW5jdGlvbigpe3ZpZGVvLndlYmtpdFJlcXVlc3RGdWxsU2NyZWVuKCl9KTsK KyAgICAgICAgfSk7CisKKyAgICAgICAgdmlkZW8uc3JjID0gZmluZE1lZGlhRmlsZSgndmlkZW8n LCAnLi4vbWVkaWEvY29udGVudC90ZXN0Jyk7CisgICAgPC9zY3JpcHQ+Cis8L2JvZHk+Cg==