75627 2012-01-05 09:11:59 -0800 make canvas-lineWidth test pass even if pixel values vary a tiny bit 2012-01-06 07:43:17 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 epoger epoger bfulgham deanm oliver rniwa senorblanco tomhudson webkit.review.bot oldest_to_newest 530334 0 epoger 2012-01-05 09:11:59 -0800 In https://bugs.webkit.org/show_bug.cgi?id=75552 ('rebaselining some canvas images'), we noted that this test was reporting failure even though the results were "close enough". So I have modified the test to pass, as long as the results are indeed "close enough". 530337 1 121287 epoger 2012-01-05 09:15:00 -0800 Created attachment 121287 Patch 530343 2 epoger 2012-01-05 09:20:51 -0800 Tom and Ryosuke- please look at the test change and see if it looks reasonable to you. If so, Ryosuke, please r+. 530352 3 tomhudson 2012-01-05 09:29:22 -0800 LGTM. Allowable difference may grow in the future, but we don't have a quantified range, so let's start conservative. 530573 4 epoger 2012-01-05 13:11:09 -0800 rniwa has added a few more people in CC, since he isn't very familiar with canvas stuff... 530578 5 epoger 2012-01-05 13:13:54 -0800 Stephen- could you plese take a look, and r+ if appropriate? 530581 6 bfulgham 2012-01-05 13:19:50 -0800 LGTM. I am strongly in favor of this change, as the WinCairo port often has small differences against the Apple Windows port. This would greatly reduce the amount of custom testing needed to stay in sync. 530585 7 senorblanco 2012-01-05 13:22:04 -0800 I'm ok with this, as long as it's spec-compliant. r=me 531070 8 121287 webkit.review.bot 2012-01-06 07:43:13 -0800 Comment on attachment 121287 Patch Clearing flags on attachment: 121287 Committed r104293: <http://trac.webkit.org/changeset/104293> 531071 9 webkit.review.bot 2012-01-06 07:43:17 -0800 All reviewed patches have been landed. Closing bug. 121287 2012-01-05 09:15:00 -0800 2012-01-06 07:43:12 -0800 Patch bug-75627-20120105121458.patch text/plain 2035 epoger SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEwNDE2OCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAxLTA1ICBFbGxpb3QgUG9nZXIgIDxl cG9nZXJAZ29vZ2xlLmNvbT4KKworICAgICAgICBtYWtlIGNhbnZhcy1saW5lV2lkdGggdGVzdCBw YXNzIGV2ZW4gaWYgcGl4ZWwgdmFsdWVzIHZhcnkgYSB0aW55IGJpdAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU2MjcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvY2FudmFzL2NhbnZhcy1saW5l V2lkdGguanM6CisgICAgICAgIChjb21wYXJlUm93cyk6CisKIDIwMTItMDEtMDUgIFBoaWxpcHBl IE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIEdU SyB0ZXN0X2V4cGVjdGF0aW9ucyB1cGRhdGUuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2NhbnZh cy9jYW52YXMtbGluZVdpZHRoLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY2Fu dmFzL2NhbnZhcy1saW5lV2lkdGguanMJKHJldmlzaW9uIDEwNDE2MikKKysrIExheW91dFRlc3Rz L2Zhc3QvY2FudmFzL2NhbnZhcy1saW5lV2lkdGguanMJKHdvcmtpbmcgY29weSkKQEAgLTEsMTAg KzEsMTEgQEAKLS8vIENvbXBhcmUgc2VjdGlvbnMgb2YgYSA8Y2FudmFzPiB0byBhc3NlcnQgdGhl eSBhcmUgaWRlbnRpY2FsLgotZnVuY3Rpb24gY29tcGFyZVJvd3MoY3R4LCB5MCwgeTEsIHdpZHRo LCBoZWlnaHQpIHsKKy8vIENvbXBhcmUgc2VjdGlvbnMgb2YgYSA8Y2FudmFzPiB0byBhc3NlcnQg dGhleSBhcmUgaWRlbnRpY2FsLCBvciBuZWFybHkgc28uCitmdW5jdGlvbiBjb21wYXJlUm93cyhj dHgsIHkwLCB5MSwgd2lkdGgsIGhlaWdodCwgYWxsb3dhYmxlRGlmZmVyZW5jZSkgewogICAgIHZh ciBkYXRhMCA9IGN0eC5nZXRJbWFnZURhdGEoMCwgeTAsIHdpZHRoLCBoZWlnaHQpLmRhdGE7CiAg ICAgdmFyIGRhdGExID0gY3R4LmdldEltYWdlRGF0YSgwLCB5MSwgd2lkdGgsIGhlaWdodCkuZGF0 YTsKICAgICBmb3IgKHZhciBpID0gMCwgaWwgPSBkYXRhMC5sZW5ndGg7IGkgPCBpbDsgKytpKSB7 Ci0gICAgICAgIGlmIChkYXRhMFtpXSAhPSBkYXRhMVtpXSkgewotICAgICAgICAgICAgdGVzdEZh aWxlZCgiUGl4ZWwgYXQgIiArIGkgKyAiIHNob3VsZCBiZSAiICsgZGF0YTBbaV0gKyAiIGJ1dCB3 YXMgIiArIGRhdGExW2ldKTsKKyAgICAgICAgaWYgKE1hdGguYWJzKGRhdGEwW2ldIC0gZGF0YTFb aV0pID4gYWxsb3dhYmxlRGlmZmVyZW5jZSkgeworICAgICAgICAgICAgdGVzdEZhaWxlZCgiUGl4 ZWwgYXQgIiArIGkgKyAiIHNob3VsZCBiZSB3aXRoaW4gIiArIGFsbG93YWJsZURpZmZlcmVuY2Ug KworICAgICAgICAgICAgICAgICIgb2YgIiArIGRhdGEwW2ldICsgIiBidXQgd2FzICIgKyBkYXRh MVtpXSk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogICAgIH0KQEAgLTQwLDYgKzQx LDcgQEAgZm9yICh2YXIgaiA9IDA7IGogPCAzOyArK2opIHsKICAgICB9CiB9CiAKLS8vIE1ha2Ug c3VyZSB0aGF0IGFsbCByb3dzIGFyZSBpZGVudGljYWwuCi1jb21wYXJlUm93cyhjdHgsIDAsIDEw MCwgNjAwLCAxMDApOwotY29tcGFyZVJvd3MoY3R4LCAwLCAyMDAsIDYwMCwgMTAwKTsKKy8vIE1h a2Ugc3VyZSB0aGF0IGFsbCByb3dzIGFyZSBuZWFybHkgaWRlbnRpY2FsLgorLy8gKFRpbnkgdmFy aWF0aW9ucyBhcmUgT0suKQorY29tcGFyZVJvd3MoY3R4LCAwLCAxMDAsIDYwMCwgMTAwLCAxKTsK K2NvbXBhcmVSb3dzKGN0eCwgMCwgMjAwLCA2MDAsIDEwMCwgMSk7Cg==