75612 2012-01-05 02:35:59 -0800 WTF::String: Inline method shouldn't have WTF_EXPORT_PRIVATE 2012-01-06 00:04:48 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 morrita morrita ap kevino webkit.review.bot oldest_to_newest 530130 0 morrita 2012-01-05 02:35:59 -0800 Inline methods cannot have any visible linkages. Thus they shouldn't be marked as WTF_EXPORT_PRIVATE. This is a series of nit-picking for making Bug 72855 build-able. 530131 1 121247 morrita 2012-01-05 02:39:51 -0800 Created attachment 121247 Patch 530350 2 ap 2012-01-05 09:27:57 -0800 FWIW, this was added in bug 27551, which looks like an original of bug 72855. 530951 3 morrita 2012-01-05 23:43:03 -0800 (In reply to comment #2) > FWIW, this was added in bug 27551, which looks like an original of bug 72855. Alexey, thanks for checking this! Actually this is why we are switching from hand-crafted annotation to automated annotation. With a tool's help, the annotation can be more precise. This bug was also found during the investigation to see why generated annotations wasn't built. 530958 4 121247 webkit.review.bot 2012-01-06 00:04:43 -0800 Comment on attachment 121247 Patch Clearing flags on attachment: 121247 Committed r104270: <http://trac.webkit.org/changeset/104270> 530959 5 webkit.review.bot 2012-01-06 00:04:48 -0800 All reviewed patches have been landed. Closing bug. 121247 2012-01-05 02:39:51 -0800 2012-01-06 00:04:43 -0800 Patch bug-75612-20120105193948.patch text/plain 4367 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0MTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi M2EyZWYwNTRhYTI1MTQzNTJkOWM1ZTBhY2ZiMzEyNDE1MGJkN2QwLi40YzBlMWMwZTcxNDM2YjE5 MjZmYmFlZmQ2ZDQ4MzBlOGZiMzg0NDU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxMi0wMS0wNSAgSGFqaW1lIE1vcnJpdGEgIDxtb3JyaXRhQGNocm9taXVt Lm9yZz4KKworICAgICAgICBXVEY6OlN0cmluZzogSW5saW5lIG1ldGhvZCBzaG91bGRuJ3QgaGF2 ZSBXVEZfRVhQT1JUX1BSSVZBVEUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTc1NjEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiB3dGYvdGV4dC9XVEZTdHJpbmcuaDoKKyAgICAgICAgKFdURjo6U3RyaW5n OjpmaW5kSWdub3JpbmdDYXNlKToKKyAgICAgICAgKFdURjo6U3RyaW5nOjphcHBlbmQpOgorICAg ICAgICAoV1RGOjpTdHJpbmc6OmZyb21VVEY4KToKKyAgICAgICAgKFdURjo6U3RyaW5nOjpmcm9t VVRGOFdpdGhMYXRpbjFGYWxsYmFjayk6CisgICAgICAgIChXVEY6OlN0cmluZzo6aXNIYXNoVGFi bGVEZWxldGVkVmFsdWUpOgorCiAyMDEyLTAxLTA0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBs ZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgYWNjaWRlbnRhbGx5IHR1cm5lZCBvZmYgdGhl IEpJVCBpbiBwcmV2aW91cyBjb21taXQuIFR1cm5pbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS93dGYvdGV4dC9XVEZTdHJpbmcuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93 dGYvdGV4dC9XVEZTdHJpbmcuaAppbmRleCBlNjFiODBmYjUyOTZhYjNiYjQwNWRkNTBlZWRhMmYx NmJkN2I0ZDgyLi5iNzg5YTMyZTBiODE2MGZiNWI0MGIzNjk4NzgzYWFiY2VkMWRjMzkxIDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL3RleHQvV1RGU3RyaW5nLmgKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1dURlN0cmluZy5oCkBAIC0yMTQsOSArMjE0 LDkgQEAgcHVibGljOgogICAgICAgICB7IHJldHVybiBtX2ltcGwgPyBtX2ltcGwtPnJldmVyc2VG aW5kKHN0ci5pbXBsKCksIHN0YXJ0KSA6IG5vdEZvdW5kOyB9CiAKICAgICAvLyBDYXNlIGluc2Vu c2l0aXZlIHN0cmluZyBtYXRjaGluZy4KLSAgICBXVEZfRVhQT1JUX1BSSVZBVEUgc2l6ZV90IGZp bmRJZ25vcmluZ0Nhc2UoY29uc3QgTENoYXIqIHN0ciwgdW5zaWduZWQgc3RhcnQgPSAwKSBjb25z dAorICAgIHNpemVfdCBmaW5kSWdub3JpbmdDYXNlKGNvbnN0IExDaGFyKiBzdHIsIHVuc2lnbmVk IHN0YXJ0ID0gMCkgY29uc3QKICAgICAgICAgeyByZXR1cm4gbV9pbXBsID8gbV9pbXBsLT5maW5k SWdub3JpbmdDYXNlKHN0ciwgc3RhcnQpIDogbm90Rm91bmQ7IH0KLSAgICBXVEZfRVhQT1JUX1BS SVZBVEUgc2l6ZV90IGZpbmRJZ25vcmluZ0Nhc2UoY29uc3QgU3RyaW5nJiBzdHIsIHVuc2lnbmVk IHN0YXJ0ID0gMCkgY29uc3QKKyAgICBzaXplX3QgZmluZElnbm9yaW5nQ2FzZShjb25zdCBTdHJp bmcmIHN0ciwgdW5zaWduZWQgc3RhcnQgPSAwKSBjb25zdAogICAgICAgICB7IHJldHVybiBtX2lt cGwgPyBtX2ltcGwtPmZpbmRJZ25vcmluZ0Nhc2Uoc3RyLmltcGwoKSwgc3RhcnQpIDogbm90Rm91 bmQ7IH0KICAgICBzaXplX3QgcmV2ZXJzZUZpbmRJZ25vcmluZ0Nhc2UoY29uc3QgU3RyaW5nJiBz dHIsIHVuc2lnbmVkIHN0YXJ0ID0gVUlOVF9NQVgpIGNvbnN0CiAgICAgICAgIHsgcmV0dXJuIG1f aW1wbCA/IG1faW1wbC0+cmV2ZXJzZUZpbmRJZ25vcmluZ0Nhc2Uoc3RyLmltcGwoKSwgc3RhcnQp IDogbm90Rm91bmQ7IH0KQEAgLTI0NCw3ICsyNDQsNyBAQCBwdWJsaWM6CiAKICAgICBXVEZfRVhQ T1JUX1BSSVZBVEUgdm9pZCBhcHBlbmQoY29uc3QgU3RyaW5nJik7CiAgICAgV1RGX0VYUE9SVF9Q UklWQVRFIHZvaWQgYXBwZW5kKExDaGFyKTsKLSAgICBpbmxpbmUgV1RGX0VYUE9SVF9QUklWQVRF IHZvaWQgYXBwZW5kKGNoYXIgYykgeyBhcHBlbmQoc3RhdGljX2Nhc3Q8TENoYXI+KGMpKTsgfTsK KyAgICB2b2lkIGFwcGVuZChjaGFyIGMpIHsgYXBwZW5kKHN0YXRpY19jYXN0PExDaGFyPihjKSk7 IH07CiAgICAgV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgYXBwZW5kKFVDaGFyKTsKICAgICBXVEZf RVhQT1JUX1BSSVZBVEUgdm9pZCBhcHBlbmQoY29uc3QgVUNoYXIqLCB1bnNpZ25lZCBsZW5ndGgp OwogICAgIFdURl9FWFBPUlRfUFJJVkFURSB2b2lkIGluc2VydChjb25zdCBTdHJpbmcmLCB1bnNp Z25lZCBwb3MpOwpAQCAtMzU2LDEyICszNTYsMTIgQEAgcHVibGljOgogICAgIC8vIHRoZSBpbnB1 dCBkYXRhIGNvbnRhaW5zIGludmFsaWQgVVRGLTggc2VxdWVuY2VzLgogICAgIFdURl9FWFBPUlRf UFJJVkFURSBzdGF0aWMgU3RyaW5nIGZyb21VVEY4KGNvbnN0IExDaGFyKiwgc2l6ZV90KTsKICAg ICBXVEZfRVhQT1JUX1BSSVZBVEUgc3RhdGljIFN0cmluZyBmcm9tVVRGOChjb25zdCBMQ2hhciop OwotICAgIGlubGluZSBXVEZfRVhQT1JUX1BSSVZBVEUgc3RhdGljIFN0cmluZyBmcm9tVVRGOChj b25zdCBjaGFyKiBzLCBzaXplX3QgbGVuZ3RoKSB7IHJldHVybiBmcm9tVVRGOChyZWludGVycHJl dF9jYXN0PGNvbnN0IExDaGFyKj4ocyksIGxlbmd0aCk7IH07Ci0gICAgaW5saW5lIFdURl9FWFBP UlRfUFJJVkFURSBzdGF0aWMgU3RyaW5nIGZyb21VVEY4KGNvbnN0IGNoYXIqIHMpIHsgcmV0dXJu IGZyb21VVEY4KHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgTENoYXIqPihzKSk7IH07CisgICAgc3Rh dGljIFN0cmluZyBmcm9tVVRGOChjb25zdCBjaGFyKiBzLCBzaXplX3QgbGVuZ3RoKSB7IHJldHVy biBmcm9tVVRGOChyZWludGVycHJldF9jYXN0PGNvbnN0IExDaGFyKj4ocyksIGxlbmd0aCk7IH07 CisgICAgc3RhdGljIFN0cmluZyBmcm9tVVRGOChjb25zdCBjaGFyKiBzKSB7IHJldHVybiBmcm9t VVRGOChyZWludGVycHJldF9jYXN0PGNvbnN0IExDaGFyKj4ocykpOyB9OwogCiAgICAgLy8gVHJp ZXMgdG8gY29udmVydCB0aGUgcGFzc2VkIGluIHN0cmluZyB0byBVVEYtOCwgYnV0IHdpbGwgZmFs bCBiYWNrIHRvIExhdGluLTEgaWYgdGhlIHN0cmluZyBpcyBub3QgdmFsaWQgVVRGLTguCiAgICAg V1RGX0VYUE9SVF9QUklWQVRFIHN0YXRpYyBTdHJpbmcgZnJvbVVURjhXaXRoTGF0aW4xRmFsbGJh Y2soY29uc3QgTENoYXIqLCBzaXplX3QpOwotICAgIGlubGluZSBXVEZfRVhQT1JUX1BSSVZBVEUg c3RhdGljIFN0cmluZyBmcm9tVVRGOFdpdGhMYXRpbjFGYWxsYmFjayhjb25zdCBjaGFyKiBzLCBz aXplX3QgbGVuZ3RoKSB7IHJldHVybiBmcm9tVVRGOFdpdGhMYXRpbjFGYWxsYmFjayhyZWludGVy cHJldF9jYXN0PGNvbnN0IExDaGFyKj4ocyksIGxlbmd0aCk7IH07CisgICAgc3RhdGljIFN0cmlu ZyBmcm9tVVRGOFdpdGhMYXRpbjFGYWxsYmFjayhjb25zdCBjaGFyKiBzLCBzaXplX3QgbGVuZ3Ro KSB7IHJldHVybiBmcm9tVVRGOFdpdGhMYXRpbjFGYWxsYmFjayhyZWludGVycHJldF9jYXN0PGNv bnN0IExDaGFyKj4ocyksIGxlbmd0aCk7IH07CiAgICAgCiAgICAgLy8gRGV0ZXJtaW5lcyB0aGUg d3JpdGluZyBkaXJlY3Rpb24gdXNpbmcgdGhlIFVuaWNvZGUgQmlkaSBBbGdvcml0aG0gcnVsZXMg UDIgYW5kIFAzLgogICAgIFdURjo6VW5pY29kZTo6RGlyZWN0aW9uIGRlZmF1bHRXcml0aW5nRGly ZWN0aW9uKGJvb2wqIGhhc1N0cm9uZ0RpcmVjdGlvbmFsaXR5ID0gMCkgY29uc3QKQEAgLTM3OSw3 ICszNzksNyBAQCBwdWJsaWM6CiAKICAgICAvLyBIYXNoIHRhYmxlIGRlbGV0ZWQgdmFsdWVzLCB3 aGljaCBhcmUgb25seSBjb25zdHJ1Y3RlZCBhbmQgbmV2ZXIgY29waWVkIG9yIGRlc3Ryb3llZC4K ICAgICBTdHJpbmcoV1RGOjpIYXNoVGFibGVEZWxldGVkVmFsdWVUeXBlKSA6IG1faW1wbChXVEY6 Okhhc2hUYWJsZURlbGV0ZWRWYWx1ZSkgeyB9Ci0gICAgV1RGX0VYUE9SVF9QUklWQVRFIGJvb2wg aXNIYXNoVGFibGVEZWxldGVkVmFsdWUoKSBjb25zdCB7IHJldHVybiBtX2ltcGwuaXNIYXNoVGFi bGVEZWxldGVkVmFsdWUoKTsgfQorICAgIGJvb2wgaXNIYXNoVGFibGVEZWxldGVkVmFsdWUoKSBj b25zdCB7IHJldHVybiBtX2ltcGwuaXNIYXNoVGFibGVEZWxldGVkVmFsdWUoKTsgfQogCiAjaWZu ZGVmIE5ERUJVRwogICAgIHZvaWQgc2hvdygpIGNvbnN0Owo=