75611 2012-01-05 01:22:55 -0800 [BlackBerry] Use the concrete FrameNetworkingContextBlackBerry to access Frame 2012-01-08 18:51:03 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 leo.yang leo.yang charles.wei rwlbuis staikos zimmermann oldest_to_newest 530090 0 leo.yang 2012-01-05 01:22:55 -0800 In platform/network/blackberry/ResourceHandleBlackBerry.cpp, We were using NetworkingContext::wrappedFrame() to access frame associated with the networking context. NetworkingContext::wrappedFrame() was added by the BlackBerry porting internally. We don't want to upstream this specific change, so use the concrete FrameNetworkingContextBlackBerry to avoid modifying platform/network/NetworkingContext.h. 530093 1 121240 leo.yang 2012-01-05 01:28:45 -0800 Created attachment 121240 Patch 531342 2 121240 tonikitoo 2012-01-06 13:36:48 -0800 Comment on attachment 121240 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121240&action=review > Source/WebCore/ChangeLog:11 > + networking context. NetworkingContext::wrappedFrame() was added by the BlackBerry > + porting internally. We don't want to upstream this specific change, so use You could mention why it was added and why it is not needed or it is fine to use the "concrete" one? 531908 3 leo.yang 2012-01-08 18:35:18 -0800 (In reply to comment #2) > (From update of attachment 121240 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=121240&action=review > > > Source/WebCore/ChangeLog:11 > > + networking context. NetworkingContext::wrappedFrame() was added by the BlackBerry > > + porting internally. We don't want to upstream this specific change, so use > > You could mention why it was added and why it is not needed or it is fine to use the "concrete" one? Thanks. Will add before landing. 531912 4 leo.yang 2012-01-08 18:51:03 -0800 Committed r104427: <http://trac.webkit.org/changeset/104427> 121240 2012-01-05 01:28:45 -0800 2012-01-06 13:36:48 -0800 Patch 0001-BlackBerry-Use-the-concrete-FrameNetworkingContextBl.patch text/plain 4055 leo.yang RnJvbSA2N2JmY2Q4NzA5ZjE4Zjk0N2I1NmVjZTg0ZGVlNDA5OWNiZjM5NDcxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu PgpEYXRlOiBUaHUsIDUgSmFuIDIwMTIgMTc6Mjg6MDIgKzA4MDAKU3ViamVjdDogW1BBVENIXSBb QmxhY2tCZXJyeV0gVXNlIHRoZSBjb25jcmV0ZQogRnJhbWVOZXR3b3JraW5nQ29udGV4dEJsYWNr QmVycnkgdG8gYWNjZXNzIEZyYW1lCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzU2MTEKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKSW4gcGxhdGZvcm0vbmV0 d29yay9ibGFja2JlcnJ5L1Jlc291cmNlSGFuZGxlQmxhY2tCZXJyeS5jcHAsIHdlIHdlcmUgdXNp bmcKTmV0d29ya2luZ0NvbnRleHQ6OndyYXBwZWRGcmFtZSgpIHRvIGFjY2VzcyB0aGUgZnJhbWUg YXNzb2NpYXRlZCB3aXRoIHRoZQpuZXR3b3JraW5nIGNvbnRleHQuIE5ldHdvcmtpbmdDb250ZXh0 Ojp3cmFwcGVkRnJhbWUoKSB3YXMgYWRkZWQgYnkgdGhlIEJsYWNrQmVycnkKcG9ydGluZyBpbnRl cm5hbGx5LiBXZSBkb24ndCB3YW50IHRvIHVwc3RyZWFtIHRoaXMgc3BlY2lmaWMgY2hhbmdlLCBz byB1c2UKdGhlIGNvbmNyZXRlIEZyYW1lTmV0d29ya2luZ0NvbnRleHRCbGFja0JlcnJ5IHRvIGFj Y2VzcyBmcmFtZSB0byBhdm9pZCBtb2RpZnlpbmcKcGxhdGZvcm0vbmV0d29yay9OZXR3b3JraW5n Q29udGV4dC5oLgoKTm8gZnVuY3Rpb25hbGl0aWVzIGNoYW5nZWQsIG5vIG5ldyB0ZXN0cy4KCiog cGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L1Jlc291cmNlSGFuZGxlQmxhY2tCZXJyeS5jcHA6 CihXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6c3RhcnQpOgooV2ViQ29yZTo6UmVzb3VyY2VIYW5k bGU6OmxvYWRSZXNvdXJjZVN5bmNocm9ub3VzbHkpOgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAyMCArKysrKysrKysrKysrKysrKysr KwogLi4uL2JsYWNrYmVycnkvUmVzb3VyY2VIYW5kbGVCbGFja0JlcnJ5LmNwcCAgICAgICAgfCAg ICA1ICsrKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCmluZGV4IDYzZGZiZGIuLmU5Yjg3NDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwyMyBAQAorMjAxMi0wMS0wNSAgTGVvIFlhbmcgIDxsZW8ueWFuZ0B0b3JjaG1vYmlsZS5jb20u Y24+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFVzZSB0aGUgY29uY3JldGUgRnJhbWVOZXR3b3Jr aW5nQ29udGV4dEJsYWNrQmVycnkgdG8gYWNjZXNzIEZyYW1lCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTYxMQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHBsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJy eS9SZXNvdXJjZUhhbmRsZUJsYWNrQmVycnkuY3BwLCB3ZSB3ZXJlIHVzaW5nCisgICAgICAgIE5l dHdvcmtpbmdDb250ZXh0Ojp3cmFwcGVkRnJhbWUoKSB0byBhY2Nlc3MgdGhlIGZyYW1lIGFzc29j aWF0ZWQgd2l0aCB0aGUKKyAgICAgICAgbmV0d29ya2luZyBjb250ZXh0LiBOZXR3b3JraW5nQ29u dGV4dDo6d3JhcHBlZEZyYW1lKCkgd2FzIGFkZGVkIGJ5IHRoZSBCbGFja0JlcnJ5CisgICAgICAg IHBvcnRpbmcgaW50ZXJuYWxseS4gV2UgZG9uJ3Qgd2FudCB0byB1cHN0cmVhbSB0aGlzIHNwZWNp ZmljIGNoYW5nZSwgc28gdXNlCisgICAgICAgIHRoZSBjb25jcmV0ZSBGcmFtZU5ldHdvcmtpbmdD b250ZXh0QmxhY2tCZXJyeSB0byBhY2Nlc3MgZnJhbWUgdG8gYXZvaWQgbW9kaWZ5aW5nCisgICAg ICAgIHBsYXRmb3JtL25ldHdvcmsvTmV0d29ya2luZ0NvbnRleHQuaC4KKworICAgICAgICBObyBm dW5jdGlvbmFsaXRpZXMgY2hhbmdlZCwgbm8gbmV3IHRlc3RzLgorCisgICAgICAgICogcGxhdGZv cm0vbmV0d29yay9ibGFja2JlcnJ5L1Jlc291cmNlSGFuZGxlQmxhY2tCZXJyeS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6c3RhcnQpOgorICAgICAgICAoV2ViQ29yZTo6 UmVzb3VyY2VIYW5kbGU6OmxvYWRSZXNvdXJjZVN5bmNocm9ub3VzbHkpOgorCiAyMDEyLTAxLTA0 ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9t aXVtXSBSZW1vdmUgY2hyb21pdW0gY29tcG9zaXRvciBzdXBwb3J0IGZvciB1bnVzZWQgem9vbUFu aW1hdG9yVHJhbnNmb3JtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL2JsYWNrYmVycnkvUmVzb3VyY2VIYW5kbGVCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9SZXNvdXJjZUhhbmRsZUJsYWNrQmVycnku Y3BwCmluZGV4IDA4MjAzNDguLmZlMGRmNGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9SZXNvdXJjZUhhbmRsZUJsYWNrQmVycnkuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9SZXNvdXJjZUhh bmRsZUJsYWNrQmVycnkuY3BwCkBAIC0yMiw2ICsyMiw3IEBACiAjaW5jbHVkZSAiRXZlbnRMb29w LmgiCiAjaW5jbHVkZSAiRnJhbWUuaCIKICNpbmNsdWRlICJGcmFtZUxvYWRlckNsaWVudEJsYWNr QmVycnkuaCIKKyNpbmNsdWRlICJGcmFtZU5ldHdvcmtpbmdDb250ZXh0QmxhY2tCZXJyeS5oIgog I2luY2x1ZGUgIk5ldHdvcmtNYW5hZ2VyLmgiCiAjaW5jbHVkZSAiTm90SW1wbGVtZW50ZWQuaCIK ICNpbmNsdWRlICJQYWdlLmgiCkBAIC0xMTIsNyArMTEzLDcgQEAgYm9vbCBSZXNvdXJjZUhhbmRs ZTo6c3RhcnQoTmV0d29ya2luZ0NvbnRleHQqIGNvbnRleHQpCiAgICAgICAgIHJldHVybiBmYWxz ZTsKIAogICAgIC8vIEZJWE1FOiBjbGVhbiB1cCB1c2Ugb2YgRnJhbWUgbm93IHRoYXQgd2UgaGF2 ZSBOZXR3b3JraW5nQ29udGV4dCAoc2VlIFJJTSBCdWcgIzE1MTUpCi0gICAgRnJhbWUqIGZyYW1l ID0gY29udGV4dC0+d3JhcHBlZEZyYW1lKCk7CisgICAgRnJhbWUqIGZyYW1lID0gc3RhdGljX2Nh c3Q8RnJhbWVOZXR3b3JraW5nQ29udGV4dEJsYWNrQmVycnkqPihjb250ZXh0KS0+ZnJhbWUoKTsK ICAgICBpZiAoIWZyYW1lIHx8ICFmcmFtZS0+bG9hZGVyKCkgfHwgIWZyYW1lLT5sb2FkZXIoKS0+ Y2xpZW50KCkgfHwgIWNsaWVudCgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgaW50IHBs YXllcklkID0gc3RhdGljX2Nhc3Q8RnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5Kj4oZnJhbWUt PmxvYWRlcigpLT5jbGllbnQoKSktPnBsYXllcklkKCk7CkBAIC0xNDQsNyArMTQ1LDcgQEAgdm9p ZCBSZXNvdXJjZUhhbmRsZTo6bG9hZFJlc291cmNlU3luY2hyb25vdXNseShOZXR3b3JraW5nQ29u dGV4dCogY29udGV4dCwgY29uc3QKICAgICB9CiAKICAgICAvLyBGSVhNRTogY2xlYW4gdXAgdXNl IG9mIEZyYW1lIG5vdyB0aGF0IHdlIGhhdmUgTmV0d29ya2luZ0NvbnRleHQgKHNlZSBSSU0gQnVn ICMxNTE1KQotICAgIEZyYW1lKiBmcmFtZSA9IGNvbnRleHQtPndyYXBwZWRGcmFtZSgpOworICAg IEZyYW1lKiBmcmFtZSA9IHN0YXRpY19jYXN0PEZyYW1lTmV0d29ya2luZ0NvbnRleHRCbGFja0Jl cnJ5Kj4oY29udGV4dCktPmZyYW1lKCk7CiAgICAgaWYgKCFmcmFtZSB8fCAhZnJhbWUtPmxvYWRl cigpIHx8ICFmcmFtZS0+bG9hZGVyKCktPmNsaWVudCgpIHx8ICFmcmFtZS0+cGFnZSgpKSB7CiAg ICAgICAgIEFTU0VSVChmYWxzZSAmJiAibG9hZFJlc291cmNlU3luY2hyb25vdXNseSBjYWxsZWQg d2l0aG91dCBhIGZyYW1lIG9yIGZyYW1lIGNsaWVudCIpOwogICAgICAgICByZXR1cm47Ci0tIAox LjcuNS40Cgo=