75524 2012-01-03 21:56:42 -0800 prepare-ChangeLog cannot parse python code that nests classes and defs 2012-01-05 02:56:26 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 73531 1 haraken haraken darin ddkilzer rniwa webkit.review.bot oldest_to_newest 529329 0 haraken 2012-01-03 21:56:42 -0800 The python parser of prepare-ChangeLog cannot correctly parse python code that nests classes and defs, like this: class C: pass def f(): pass pass 529343 1 121066 haraken 2012-01-03 22:15:50 -0800 Created attachment 121066 Patch 529379 2 121066 haraken 2012-01-03 23:10:56 -0800 Comment on attachment 121066 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121066&action=review > Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:4 > + '23', This should be 21, but 23 is also acceptable because including extra empty lines into @ranges does not at all affect the prepare-ChangeLog output. (Even if fixing this issue were necessary, I'd like to fix it in another patch as it requires non-trivial code change.) 21 def func1(): 22 23 24 def func2(): 25 .... 529592 3 121066 rniwa 2012-01-04 10:19:48 -0800 Comment on attachment 121066 Patch looks sane to me 530138 4 121066 webkit.review.bot 2012-01-05 02:56:21 -0800 Comment on attachment 121066 Patch Clearing flags on attachment: 121066 Committed r104132: <http://trac.webkit.org/changeset/104132> 530139 5 webkit.review.bot 2012-01-05 02:56:26 -0800 All reviewed patches have been landed. Closing bug. 121066 2012-01-03 22:15:50 -0800 2012-01-05 02:56:21 -0800 Patch bug-75524-20120104151549.patch text/plain 5726 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzOTM3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2Y3ZjYzNjc1MWUyNmU0MjkwOWE3OGY0ZDNhMTU1MTQ5 YjNiMjc1ZC4uOGViZDM0NmFiMzY0MThmZDg0NDExZDE3YjQ0NmM1OGY4NDUzZGE4YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM4 IEBACisyMDEyLTAxLTAzICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBwcmVwYXJlLUNoYW5nZUxvZyBjYW5ub3QgcGFyc2UgcHl0aG9uIGNvZGUgdGhhdCBu ZXN0cyBjbGFzc2VzIGFuZCBkZWZzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD03NTUyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgcGF0Y2ggZml4ZXMgdGhlIHB5dGhvbiBwYXJzZXIgb2YgcHJlcGFy ZS1DaGFuZ2VMb2cgc28gdGhhdCBpdCBjYW4gcGFyc2UKKyAgICAgICAgcHl0aG9uIGNvZGUgdGhh dCBuZXN0cyBjbGFzc2VzIGFuZCBkZWZzLCBsaWtlIHRoaXM6CisKKyAgICAgICAgY2xhc3MgQzoK KyAgICAgICAgICAgIHBhc3MKKyAgICAgICAgICAgIGRlZiBmKCk6CisgICAgICAgICAgICAgICAg cGFzcworICAgICAgICAgICAgcGFzcworCisgICAgICAgIEFsc28sIHRoaXMgcGF0Y2ggZml4ZXMg dGhlIHB5dGhvbiBwYXJzZXIgc28gdGhhdCBpdCBpbnNlcnRzIGEgZHVtbXkgbGluZQorICAgICAg ICBhdCB0aGUgZW5kIG9mIHRoZSBmaWxlIHRvIHBvcCBvdXQgYWxsIHBvcHBlZCBzY29wZXMuCisK KyAgICAgICAgKiBTY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nOgorICAgICAgICAoZ2V0X2Z1bmN0 aW9uX2xpbmVfcmFuZ2VzX2Zvcl9weXRob24pOgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw ZXJsL3ByZXBhcmUtQ2hhbmdlTG9nX3VuaXR0ZXN0L3Jlc291cmNlcy9weXRob25fdW5pdHRlc3Rz LnB5OgorICAgICAgICBBZGRlZCB0ZXN0IGNhc2VzIHRoYXQgbmVzdCBjbGFzc2VzIGFuZCBkZWZz LgorICAgICAgICAoZnVuYzcpOgorICAgICAgICAoZnVuYzcuZnVuYzgpOgorICAgICAgICAoZnVu YzcuZnVuYzguZnVuYzkpOgorICAgICAgICAoQ2xhc3MyKToKKyAgICAgICAgKENsYXNzMi5DbGFz czMpOgorICAgICAgICAoQ2xhc3MyLkNsYXNzMy5DbGFzczQpOgorICAgICAgICAoQ2xhc3M1KToK KyAgICAgICAgKENsYXNzNS5mdW5jMTApOgorICAgICAgICAoQ2xhc3M1LmZ1bmMxMSk6CisgICAg ICAgICogU2NyaXB0cy93ZWJraXRwZXJsL3ByZXBhcmUtQ2hhbmdlTG9nX3VuaXR0ZXN0L3Jlc291 cmNlcy9weXRob25fdW5pdHRlc3RzLWV4cGVjdGVkLnR4dDoKKwogMjAxMi0wMS0wMyAgVG9yIEFy bmUgVmVzdGLDuCAgPHRvci5hcm5lLnZlc3Rib0Bub2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBD bGVhbiB1cCBkZXRlY3Rpb24gb2YgZm9udGNvbmZpZwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy9wcmVwYXJlLUNoYW5nZUxvZyBiL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKaW5k ZXggNzEzNmZkZmQ0NDRmODdjMzdjNTRmNDBjNzE4NzkzNmZkZWMzODllNi4uZWY0ZDI3MTJlYjkz NjJmM2Q3YzAwNjYzMmJjZTI3NGI1ZDM5ZjJhNiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9w cmVwYXJlLUNoYW5nZUxvZworKysgYi9Ub29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCkBA IC0xMzI0LDExICsxMzI0LDIxIEBAIHN1YiBnZXRfZnVuY3Rpb25fbGluZV9yYW5nZXNfZm9yX3B5 dGhvbigkJCkKICAgICBteSBAcmFuZ2VzOwogCiAgICAgbXkgQHNjb3BlU3RhY2sgPSAoeyBsaW5l ID0+IDAsIGluZGVudCA9PiAtMSwgbmFtZSA9PiB1bmRlZiB9KTsKLSAgICB3aGlsZSAoPCRmaWxl SGFuZGxlPikgeworICAgIG15ICRsYXN0TGluZSA9IDA7CisgICAgdW50aWwgKCRsYXN0TGluZSkg eworICAgICAgICAkXyA9IDwkZmlsZUhhbmRsZT47CisgICAgICAgIHVubGVzcyAoJF8pIHsKKyAg ICAgICAgICAgICMgVG8gcG9wIG91dCBhbGwgcG9wcGVkIHNjb3BlcywgcnVuIHRoZSBsb29wIG9u Y2UgbW9yZSBhZnRlcgorICAgICAgICAgICAgIyB3ZSBlbmNvdW50ZXJlZCB0aGUgZW5kIG9mIHRo ZSBmaWxlLgorICAgICAgICAgICAgJF8gPSAicGFzc1xuIjsKKyAgICAgICAgICAgICQuKys7Cisg ICAgICAgICAgICAkbGFzdExpbmUgPSAxOworICAgICAgICB9CisgICAgICAgIGNob21wOwogICAg ICAgICBuZXh0IHVubGVzcyAvXihccyopKFteI10uKikkLzsKKwogICAgICAgICBteSAkaW5kZW50 ID0gbGVuZ3RoICQxOwogICAgICAgICBteSAkcmVzdCA9ICQyOwotCiAgICAgICAgIG15ICRzY29w ZSA9ICRzY29wZVN0YWNrWy0xXTsKIAogICAgICAgICBpZiAoJGluZGVudCA8PSAkc2NvcGUtPntp bmRlbnR9KSB7CkBAIC0xMzU2LDkgKzEzNjYsMTIgQEAgc3ViIGdldF9mdW5jdGlvbl9saW5lX3Jh bmdlc19mb3JfcHl0aG9uKCQkKQogCiAgICAgICAgIG5leHQgdW5sZXNzICRyZXN0ID1+IC8oPzpj bGFzc3xkZWYpXHMrKFx3KykvOwogICAgICAgICBteSAkbmFtZSA9ICQxOwotCiAgICAgICAgIG15 ICRmdWxsTmFtZSA9ICRzY29wZS0+e25hbWV9ID8gam9pbignLicsICRzY29wZS0+e25hbWV9LCAk bmFtZSkgOiAkbmFtZTsKICAgICAgICAgcHVzaCBAc2NvcGVTdGFjaywgeyBsaW5lID0+ICQuLCBp bmRlbnQgPT4gJGluZGVudCwgbmFtZSA9PiAkZnVsbE5hbWUgfTsKKworICAgICAgICBpZiAoJHNj b3BlLT57aW5kZW50fSA+PSAwKSB7CisgICAgICAgICAgICBwdXNoIEByYW5nZXMsIFskc2NvcGUt PntsaW5lfSwgJC4gLSAxLCAkc2NvcGUtPntuYW1lfV07CisgICAgICAgIH0KICAgICB9CiAKICAg ICByZXR1cm4gQHJhbmdlczsKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9w cmVwYXJlLUNoYW5nZUxvZ191bml0dGVzdC9yZXNvdXJjZXMvcHl0aG9uX3VuaXR0ZXN0cy1leHBl Y3RlZC50eHQgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvcHJlcGFyZS1DaGFuZ2VMb2dfdW5p dHRlc3QvcmVzb3VyY2VzL3B5dGhvbl91bml0dGVzdHMtZXhwZWN0ZWQudHh0CmluZGV4IGQ5MmVm NTc5YmM2YmI4NjI2ZGZhYjFhMmYyYzM4YjYwMzNhZTM3ZDguLjJiZjEwNTM4MWQ5NmRhZDVjOTJj NGNlZjAzNTAzMjk2MDBiZGU5NDkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVy bC9wcmVwYXJlLUNoYW5nZUxvZ191bml0dGVzdC9yZXNvdXJjZXMvcHl0aG9uX3VuaXR0ZXN0cy1l eHBlY3RlZC50eHQKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL3ByZXBhcmUtQ2hhbmdl TG9nX3VuaXR0ZXN0L3Jlc291cmNlcy9weXRob25fdW5pdHRlc3RzLWV4cGVjdGVkLnR4dApAQCAt MSw1MiArMSwxMjcgQEAKIFsKICAgWwogICAgICcyMScsCi0gICAgJzIxJywKKyAgICAnMjMnLAog ICAgICdmdW5jMScKICAgXSwKICAgWwogICAgICcyNCcsCi0gICAgJzI1JywKKyAgICAnMjcnLAog ICAgICdmdW5jMicKICAgXSwKICAgWwogICAgICcyOCcsCi0gICAgJzMwJywKKyAgICAnMzQnLAog ICAgICdmdW5jMycKICAgXSwKICAgWwogICAgICczNScsCi0gICAgJzM2JywKKyAgICAnMzgnLAog ICAgICdmdW5jNCcKICAgXSwKICAgWwogICAgICczOScsCi0gICAgJzQwJywKKyAgICAnNDInLAog ICAgICdmdW5jNScKICAgXSwKICAgWwogICAgICc0MycsCi0gICAgJzQ1JywKKyAgICAnNDcnLAog ICAgICdmdW5jNicKICAgXSwKICAgWwogICAgICc0OCcsCi0gICAgJzQ5JywKKyAgICAnNTEnLAog ICAgICdmdW5jT3ZlcmxvYWRlZCcKICAgXSwKICAgWwogICAgICc1MicsCi0gICAgJzUzJywKKyAg ICAnNTUnLAogICAgICdmdW5jT3ZlcmxvYWRlZCcKICAgXSwKICAgWwogICAgICc1NicsCi0gICAg JzU3JywKKyAgICAnNTknLAogICAgICdmdW5jT3ZlcmxvYWRlZCcKICAgXSwKICAgWwogICAgICc2 MCcsCi0gICAgJzYxJywKKyAgICAnNjInLAorICAgICdmdW5jNycKKyAgXSwKKyAgWworICAgICc2 MycsCisgICAgJzY1JywKKyAgICAnZnVuYzcuZnVuYzgnCisgIF0sCisgIFsKKyAgICAnNjYnLAor ICAgICc2NycsCisgICAgJ2Z1bmM3LmZ1bmM4LmZ1bmM5JworICBdLAorICBbCisgICAgJzY4JywK KyAgICAnNjgnLAorICAgICdmdW5jNy5mdW5jOCcKKyAgXSwKKyAgWworICAgICc2OScsCisgICAg JzcxJywKKyAgICAnZnVuYzcnCisgIF0sCisgIFsKKyAgICAnNzInLAorICAgICc3NScsCiAgICAg J0NsYXNzMScKKyAgXSwKKyAgWworICAgICc3NicsCisgICAgJzc4JywKKyAgICAnQ2xhc3MyJwor ICBdLAorICBbCisgICAgJzc5JywKKyAgICAnODEnLAorICAgICdDbGFzczIuQ2xhc3MzJworICBd LAorICBbCisgICAgJzgyJywKKyAgICAnODMnLAorICAgICdDbGFzczIuQ2xhc3MzLkNsYXNzNCcK KyAgXSwKKyAgWworICAgICc4NCcsCisgICAgJzg0JywKKyAgICAnQ2xhc3MyLkNsYXNzMycKKyAg XSwKKyAgWworICAgICc4NScsCisgICAgJzg3JywKKyAgICAnQ2xhc3MyJworICBdLAorICBbCisg ICAgJzg4JywKKyAgICAnOTAnLAorICAgICdDbGFzczUnCisgIF0sCisgIFsKKyAgICAnOTEnLAor ICAgICc5MicsCisgICAgJ0NsYXNzNS5mdW5jMTAnCisgIF0sCisgIFsKKyAgICAnOTMnLAorICAg ICc5NCcsCisgICAgJ0NsYXNzNScKKyAgXSwKKyAgWworICAgICc5NScsCisgICAgJzk2JywKKyAg ICAnQ2xhc3M1LmZ1bmMxMScKKyAgXSwKKyAgWworICAgICc5NycsCisgICAgJzk3JywKKyAgICAn Q2xhc3M1JwogICBdCiBdCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvcHJl cGFyZS1DaGFuZ2VMb2dfdW5pdHRlc3QvcmVzb3VyY2VzL3B5dGhvbl91bml0dGVzdHMucHkgYi9U b29scy9TY3JpcHRzL3dlYmtpdHBlcmwvcHJlcGFyZS1DaGFuZ2VMb2dfdW5pdHRlc3QvcmVzb3Vy Y2VzL3B5dGhvbl91bml0dGVzdHMucHkKaW5kZXggZjY4ODcxY2FkZTVkODUxZGIxMGYyYzI3NDY4 MzRmYzI4MDJmYzdhOS4uMWExOWNjMjljODAzNTA1ZDM3MmFkMTlhM2M5MDgyZWI0ZTI3MWVhNSAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL3ByZXBhcmUtQ2hhbmdlTG9nX3Vu aXR0ZXN0L3Jlc291cmNlcy9weXRob25fdW5pdHRlc3RzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cGVybC9wcmVwYXJlLUNoYW5nZUxvZ191bml0dGVzdC9yZXNvdXJjZXMvcHl0aG9uX3Vu aXR0ZXN0cy5weQpAQCAtNTcsNiArNTcsNDEgQEAgZGVmIGZ1bmNPdmVybG9hZGVkKGEsIGIsIGM9 MTAwKToKICAgICByZXR1cm4KIAogCitkZWYgZnVuYzcoKToKKyAgICBwYXNzCisKKyAgICBkZWYg ZnVuYzgoKToKKyAgICAgICAgcGFzcworCisgICAgICAgIGRlZiBmdW5jOSgpOgorICAgICAgICAg ICAgcGFzcworICAgICAgICBwYXNzCisgICAgcGFzcworCisKIGNsYXNzIENsYXNzMToKICAgICBw YXNzCiAKKworY2xhc3MgQ2xhc3MyOgorICAgIHBhc3MKKworICAgIGNsYXNzIENsYXNzMzoKKyAg ICAgICAgcGFzcworCisgICAgICAgIGNsYXNzIENsYXNzNDoKKyAgICAgICAgICAgIHBhc3MKKyAg ICAgICAgcGFzcworICAgIHBhc3MKKworCitjbGFzcyBDbGFzczU6CisgICAgcGFzcworCisgICAg ZGVmIGZ1bmMxMCgpOgorICAgICAgICBwYXNzCisgICAgcGFzcworCisgICAgZGVmIGZ1bmMxMSgp OgorICAgICAgICBwYXNzCisgICAgcGFzcwo=