75491 2012-01-03 14:00:50 -0800 Plumbs WebLayerTreeViewImpl::didCompleteSwapBuffers 2013-09-01 10:31:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 0 pkotwicz webkit-unassigned andersca fishd jamesr piman pkotwicz webkit.review.bot oldest_to_newest 529027 0 pkotwicz 2012-01-03 14:00:50 -0800 Plubs WebLayerTreeViewImpl::didCompleteSwapBuffers 529037 1 120991 pkotwicz 2012-01-03 14:06:57 -0800 Created attachment 120991 Patch 529038 2 pkotwicz 2012-01-03 14:09:02 -0800 Did not plumb ::didCommitAndDrawFrame as it is not needed yet 529048 3 pkotwicz 2012-01-03 14:14:25 -0800 This is the missing piece for the multithreaded compositor to work with accelerated content. Once webgraphicscontext3d_command_buffer_impl is used in the browser compositor, accelerated content should work with the multithreaded compositor 529059 4 piman 2012-01-03 14:19:42 -0800 LGTM, but you'll need the chrome-side change to land first before this can go in. 529066 5 120991 jamesr 2012-01-03 14:26:34 -0800 Comment on attachment 120991 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120991&action=review > Source/WebKit/chromium/public/platform/WebLayerTreeViewClient.h:52 > + // Signals that a swap buffers has been completed. > + virtual void didCompleteSwapBuffers() = 0; > + where's the chromium-side implementation of this? 529114 6 webkit.review.bot 2012-01-03 15:42:39 -0800 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 535663 7 pkotwicz 2012-01-13 07:18:56 -0800 Ping. The chromium side has landed. Chromium side: http://codereview.chromium.org/9014030 536189 8 jamesr 2012-01-14 10:13:21 -0800 The comment is phrased oddly and could be improved (I don't think a "swap buffers" is a phrase) 536220 9 pkotwicz 2012-01-14 15:05:56 -0800 James, do you have suggestions for the comment? I am pulling a blank. I am thinking: "Signals that a new color buffer has been posted to the native window."(In reply to comment #8) > The comment is phrased oddly and could be improved (I don't think a "swap buffers" is a phrase) 923504 10 andersca 2013-09-01 10:31:08 -0700 Chromium is gone. 120991 2012-01-03 14:06:57 -0800 2012-01-14 10:12:52 -0800 Patch bug-75491-20120103170656.patch text/plain 2999 pkotwicz U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzNzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDFhNTIwMWQxODBlODZiMWE4OTZlYmQxNjc4YTBhZDg1M2UwZGI3MWYuLmUwZGQ0MGUxOTgxNDJm ZGY4MzZlODdkMDhkNzViODcwNTc3YmExOTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMDEtMDMgIFBldGVyIEtvdHdpY3ogIDxwa290d2ljekBnb29n bGUuY29tPgorCisgICAgICAgIFBsdW1icyBXZWJMYXllclRyZWVWaWV3SW1wbDo6ZGlkQ29tcGxl dGVTd2FwQnVmZmVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzU0OTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHB1YmxpYy9wbGF0Zm9ybS9XZWJMYXllclRyZWVWaWV3Q2xpZW50Lmg6CisgICAgICAg ICogc3JjL1dlYkxheWVyVHJlZVZpZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViTGF5 ZXJUcmVlVmlld0ltcGw6OmRpZENvbXBsZXRlU3dhcEJ1ZmZlcnMpOgorICAgICAgICAqIHRlc3Rz L1dlYkxheWVyVGVzdC5jcHA6CisKIDIwMTEtMTItMjggIFNoZXJpZmYgQm90ICA8d2Via2l0LnJl dmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIx MDM2MjAuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9wbGF0Zm9y bS9XZWJMYXllclRyZWVWaWV3Q2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9wbGF0Zm9ybS9XZWJMYXllclRyZWVWaWV3Q2xpZW50LmgKaW5kZXggNmY1MDA5NjA3NmNkZjY2 MmI3MjRhMDE4MzQ1Mzc0YzRiMGQ2YWQ3OC4uN2MwNjQ1NTQ4NTNmYjFiZTc4YzlkYzllNWU3NWU0 ZmMzOGQwODIwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvcGxh dGZvcm0vV2ViTGF5ZXJUcmVlVmlld0NsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL3BsYXRmb3JtL1dlYkxheWVyVHJlZVZpZXdDbGllbnQuaApAQCAtNDcsNiArNDcs OSBAQCBwdWJsaWM6CiAgICAgLy8gbW9yZSB0aGFuIG9uY2UgaWYgdGhlIGNvbnRleHQgZ2V0cyBs b3N0LgogICAgIHZpcnR1YWwgV2ViR3JhcGhpY3NDb250ZXh0M0QqIGNyZWF0ZUNvbnRleHQzRCgp ID0gMDsKIAorICAgIC8vIFNpZ25hbHMgdGhhdCBhIHN3YXAgYnVmZmVycyBoYXMgYmVlbiBjb21w bGV0ZWQuCisgICAgdmlydHVhbCB2b2lkIGRpZENvbXBsZXRlU3dhcEJ1ZmZlcnMoKSA9IDA7CisK ICAgICAvLyBTaWduYWxzIGEgc3VjY2Vzc2Z1bCByZWJpbmRpbmcgb2YgdGhlIDNEIGNvbnRleHQg KGUuZy4gYWZ0ZXIgYSBsb3N0CiAgICAgLy8gY29udGV4dCBldmVudCkuCiAgICAgdmlydHVhbCB2 b2lkIGRpZFJlYmluZEdyYXBoaWNzQ29udGV4dChib29sIHN1Y2Nlc3MpID0gMDsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkxheWVyVHJlZVZpZXdJbXBsLmNwcCBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkxheWVyVHJlZVZpZXdJbXBsLmNwcAppbmRl eCBlZGMxNmVjN2IyNzIzZmIwOGVmM2MyZGI2MWE5ZjkzMTgzNTBjNDI2Li45YTQ3M2NmYzFiMTMx M2VkZWFkMzY0MTljOTEyOWRlNTlkMDFlZTUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJMYXllclRyZWVWaWV3SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViTGF5ZXJUcmVlVmlld0ltcGwuY3BwCkBAIC0xMDQsNyArMTA0LDggQEAg dm9pZCBXZWJMYXllclRyZWVWaWV3SW1wbDo6ZGlkQ29tbWl0QW5kRHJhd0ZyYW1lKCkKIAogdm9p ZCBXZWJMYXllclRyZWVWaWV3SW1wbDo6ZGlkQ29tcGxldGVTd2FwQnVmZmVycygpCiB7Ci0gICAg Ly8gRklYTUU6IHJvdXRlIHRoaXMgdXAgdG8gdGhlIFdlYkxheWVyVHJlZVZpZXcgY2xpZW50Cisg ICAgaWYgKG1fY2xpZW50KQorICAgICAgICBtX2NsaWVudC0+ZGlkQ29tcGxldGVTd2FwQnVmZmVy cygpOyAgCiB9CiAKIHZvaWQgV2ViTGF5ZXJUcmVlVmlld0ltcGw6OmRpZFJlY3JlYXRlR3JhcGhp Y3NDb250ZXh0KGJvb2wgc3VjY2VzcykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vdGVzdHMvV2ViTGF5ZXJUZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMv V2ViTGF5ZXJUZXN0LmNwcAppbmRleCBhN2M5MDJiNDg5NWQ1NDdjOTVhNTg2YzFkZjBjNmM2YTM0 ZjU0ODcyLi4wNTE4YzBlNGEwMTlmZDUxMzhkOTdmOTlhODU1Y2ZmYWZlMWY4MWMwIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dlYkxheWVyVGVzdC5jcHAKKysrIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9XZWJMYXllclRlc3QuY3BwCkBAIC01NSw2ICs1 NSw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgYW5pbWF0ZUFuZExheW91dChkb3VibGUg ZnJhbWVCZWdpblRpbWUpIHsgfQogICAgIHZpcnR1YWwgdm9pZCBhcHBseVNjcm9sbEFuZFNjYWxl KGNvbnN0IFdlYlNpemUmIHNjcm9sbERlbHRhLCBmbG9hdCBzY2FsZUZhY3RvcikgeyB9CiAgICAg dmlydHVhbCBXZWJHcmFwaGljc0NvbnRleHQzRCogY3JlYXRlQ29udGV4dDNEKCkgeyByZXR1cm4g Q29tcG9zaXRvckZha2VXZWJHcmFwaGljc0NvbnRleHQzRDo6Y3JlYXRlKFdlYkdyYXBoaWNzQ29u dGV4dDNEOjpBdHRyaWJ1dGVzKCkpLmxlYWtQdHIoKTsgfQorICAgIHZpcnR1YWwgdm9pZCBkaWRD b21wbGV0ZVN3YXBCdWZmZXJzKCkgeyB9CiAgICAgdmlydHVhbCB2b2lkIGRpZFJlYmluZEdyYXBo aWNzQ29udGV4dChib29sIHN1Y2Nlc3MpIHsgfQogfTsKIAo=