75488 2012-01-03 13:25:21 -0800 [Qt] Add UI for JavaScript Prompt dialog in the Qt MiniBrowser 2012-01-04 06:05:12 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ahf ahf vestbo webkit.review.bot oldest_to_newest 529000 0 ahf 2012-01-03 13:25:21 -0800 SSIA. 529004 1 120986 ahf 2012-01-03 13:34:09 -0800 Created attachment 120986 Patch 529006 2 ahf 2012-01-03 13:35:01 -0800 Adding Tor Arne. 529458 3 120986 vestbo 2012-01-04 04:22:08 -0800 Comment on attachment 120986 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120986&action=review > Tools/MiniBrowser/qt/qml/PromptDialog.qml:40 > + width: dialog.width - 30 For the furture, this is better done with an anchor and a margin. 529468 4 120986 ahf 2012-01-04 04:48:50 -0800 Comment on attachment 120986 Patch Requesting CQ :) 529487 5 120986 webkit.review.bot 2012-01-04 06:05:08 -0800 Comment on attachment 120986 Patch Clearing flags on attachment: 120986 Committed r104032: <http://trac.webkit.org/changeset/104032> 529488 6 webkit.review.bot 2012-01-04 06:05:12 -0800 All reviewed patches have been landed. Closing bug. 120986 2012-01-03 13:34:09 -0800 2012-01-04 06:05:08 -0800 Patch bug-75488-20120103223406.patch text/plain 7349 ahf U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzOTQzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGRmNGY3YjlmMmI4NDUzODE1MmRkMTU4MjhiZjc5OTQ1 ZGQ2MTdiMS4uMGNjOTYwNWZmMjQyMjZkOGUyYzM5ZWRjZDE0NTBhNzk5ZTYzZjRmMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTAxLTAzICBBbGV4YW5kZXIgRsOmcsO4eSAgPGFoZkAweDkwLmRrPgorCisgICAg ICAgIFtRdF0gQWRkIFVJIGZvciBKYXZhU2NyaXB0IFByb21wdCBkaWFsb2cgaW4gdGhlIFF0IE1p bmlCcm93c2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03NTQ4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogTWluaUJyb3dzZXIvcXQvTWluaUJyb3dzZXIucXJjOgorICAgICAgICAqIE1pbmlCcm93c2Vy L3F0L3FtbC9Ccm93c2VyV2luZG93LnFtbDoKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9xdC9xbWwv RGlhbG9nLnFtbDoKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9xdC9xbWwvRGlhbG9nTGluZUlucHV0 LnFtbDogQ29waWVkIGZyb20gVG9vbHMvTWluaUJyb3dzZXIvcXQvcW1sL0RpYWxvZy5xbWwuCisg ICAgICAgICogTWluaUJyb3dzZXIvcXQvcW1sL1Byb21wdERpYWxvZy5xbWw6IENvcGllZCBmcm9t IFRvb2xzL01pbmlCcm93c2VyL3F0L3FtbC9EaWFsb2cucW1sLgorCiAyMDEyLTAxLTAzICBNYXJp byBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBy dW4tZ3RrLXRlc3Qgc2hvdWxkIGlnbm9yZSBmaWxlcyB3aXRoIG5hbWVzIHdpdGhvdXQgYSAidGVz dCIgb3IgIlRlc3QiIHByZWZpeApkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvcXQvTWlu aUJyb3dzZXIucXJjIGIvVG9vbHMvTWluaUJyb3dzZXIvcXQvTWluaUJyb3dzZXIucXJjCmluZGV4 IGFhMzM5NGM2YzBiNzE0MDg5ZmQwNTE2NWY2YzllOTZmNjA0NmU1NDguLmI1MDYwOTM5ODc3N2Vi YTBhNTg2NjI1MDRlNjlmZDcyMDYwMGUwMzggMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2Vy L3F0L01pbmlCcm93c2VyLnFyYworKysgYi9Ub29scy9NaW5pQnJvd3Nlci9xdC9NaW5pQnJvd3Nl ci5xcmMKQEAgLTExLDggKzExLDEwIEBACiAgICAgICAgIDxmaWxlPnFtbC9Db25maXJtRGlhbG9n LnFtbDwvZmlsZT4KICAgICAgICAgPGZpbGU+cW1sL0RpYWxvZy5xbWw8L2ZpbGU+CiAgICAgICAg IDxmaWxlPnFtbC9EaWFsb2dCdXR0b24ucW1sPC9maWxlPgorICAgICAgICA8ZmlsZT5xbWwvRGlh bG9nTGluZUlucHV0LnFtbDwvZmlsZT4KICAgICAgICAgPGZpbGU+cW1sL0l0ZW1TZWxlY3Rvci5x bWw8L2ZpbGU+CiAgICAgICAgIDxmaWxlPnFtbC9Nb2NrVG91Y2hQb2ludC5xbWw8L2ZpbGU+Cisg ICAgICAgIDxmaWxlPnFtbC9Qcm9tcHREaWFsb2cucW1sPC9maWxlPgogICAgICAgICA8ZmlsZT5x bWwvVmlld3BvcnRJbmZvSXRlbS5xbWw8L2ZpbGU+CiAgICAgICAgIDxmaWxlPnVzZXJhZ2VudGxp c3QudHh0PC9maWxlPgogICAgICAgICA8ZmlsZT5pY29ucy9mYXZpY29uLnBuZzwvZmlsZT4KZGlm ZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL3F0L3FtbC9Ccm93c2VyV2luZG93LnFtbCBiL1Rv b2xzL01pbmlCcm93c2VyL3F0L3FtbC9Ccm93c2VyV2luZG93LnFtbAppbmRleCBkMTY4OGFmNDM0 MjFiMWRjNDQyZGZjN2E0NGFmZDEyNjVmNDNkMjJlLi4wZDczZGNlY2ExMWVmY2YyNTkwNDYyY2Q0 YzQwZmYwZjU0NmJmZjlhIDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9xdC9xbWwvQnJv d3NlcldpbmRvdy5xbWwKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvcXQvcW1sL0Jyb3dzZXJXaW5k b3cucW1sCkBAIC0yNjUsNiArMjY1LDcgQEAgUmVjdGFuZ2xlIHsKICAgICAgICAgZXhwZXJpbWVu dGFsLml0ZW1TZWxlY3RvcjogSXRlbVNlbGVjdG9yIHsgfQogICAgICAgICBleHBlcmltZW50YWwu YWxlcnREaWFsb2c6IEFsZXJ0RGlhbG9nIHsgfQogICAgICAgICBleHBlcmltZW50YWwuY29uZmly bURpYWxvZzogQ29uZmlybURpYWxvZyB7IH0KKyAgICAgICAgZXhwZXJpbWVudGFsLnByb21wdERp YWxvZzogUHJvbXB0RGlhbG9nIHsgfQogICAgIH0KIAogICAgIFZpZXdwb3J0SW5mb0l0ZW0gewpk aWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvcXQvcW1sL0RpYWxvZy5xbWwgYi9Ub29scy9N aW5pQnJvd3Nlci9xdC9xbWwvRGlhbG9nLnFtbAppbmRleCAwMzg5ZTY0OThmMGU4NzYzOWYxNWMx NDM4Mjg4YjVjNWExYmU5M2QxLi41Y2E2ZWUwMDg4MDZmMzBiZTc2NGYyZDFiYjI2ZTUxMDU2YjVl YjM5IDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9xdC9xbWwvRGlhbG9nLnFtbAorKysg Yi9Ub29scy9NaW5pQnJvd3Nlci9xdC9xbWwvRGlhbG9nLnFtbApAQCAtNTIsNyArNTIsNyBAQCBS ZWN0YW5nbGUgewogCiAgICAgSXRlbSB7CiAgICAgICAgIGlkOiBzdGF0aWNDb250ZW50Ci0KKyAg ICAgICAgYW5jaG9ycy5jZW50ZXJJbjogcGFyZW50CiAgICAgICAgIGFuY2hvcnMuZmlsbDogcGFy ZW50CiAgICAgICAgIGFuY2hvcnMubWFyZ2luczogMTAKIApAQCAtNzQsNiArNzQsNyBAQCBSZWN0 YW5nbGUgewogCiAgICAgICAgIENvbHVtbiB7CiAgICAgICAgICAgICBpZDogZHluYW1pY0NvbHVt bgorICAgICAgICAgICAgc3BhY2luZzogNQogICAgICAgICAgICAgYW5jaG9ycyB7CiAgICAgICAg ICAgICAgICAgbWFyZ2luczogMTAKICAgICAgICAgICAgICAgICBib3R0b206IHN0YXRpY0NvbnRl bnQuYm90dG9tCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9xdC9xbWwvRGlhbG9nTGlu ZUlucHV0LnFtbCBiL1Rvb2xzL01pbmlCcm93c2VyL3F0L3FtbC9EaWFsb2dMaW5lSW5wdXQucW1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjFjODVmZjk2MmUyN2M4ODJhYjM2ZDI2ODlkOTM0NDgzMmYxN2ZjMjEKLS0t IC9kZXYvbnVsbAorKysgYi9Ub29scy9NaW5pQnJvd3Nlci9xdC9xbWwvRGlhbG9nTGluZUlucHV0 LnFtbApAQCAtMCwwICsxLDU1IEBACisvKgorICogQ29weXJpZ2h0IChDKSAyMDEyIE5va2lhIENv cnBvcmF0aW9uIGFuZC9vciBpdHMgc3Vic2lkaWFyeSgtaWVzKQorICoKKyAqIEFsbCByaWdodHMg cmVzZXJ2ZWQuCisgKgorICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJp bmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0 ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyAqIGFyZSBtZXQ6Cisg KiAxLiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3Zl IGNvcHlyaWdodAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhl IGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogMi4gUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBm b3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhp cyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUK KyAqICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRo IHRoZSBkaXN0cmlidXRpb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBB UFBMRSBDT01QVVRFUiwgSU5DLiBgYEFTIElTJycgQU5EIEFOWQorICogRVhQUkVTUyBPUiBJTVBM SUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBUSEUKKyAqIElN UExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFS VElDVUxBUgorICogUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gIElOIE5PIEVWRU5UIFNIQUxMIEFQ UExFIENPTVBVVEVSLCBJTkMuIE9SCisgKiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkg RElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwKKyAqIEVYRU1QTEFSWSwgT1Ig Q09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywKKyAq IFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNF LCBEQVRBLCBPUgorICogUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVS IENBVVNFRCBBTkQgT04gQU5ZIFRIRU9SWQorICogT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENP TlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisgKiAoSU5DTFVESU5HIE5FR0xJR0VO Q0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyAqIE9G IFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VD SCBEQU1BR0UuCisgKi8KKworaW1wb3J0IFF0UXVpY2sgMi4wCisKK1JlY3RhbmdsZSB7CisgICAg aWQ6IGRpYWxvZ0xpbmVJbnB1dAorCisgICAgcHJvcGVydHkgYWxpYXMgdGV4dDogaW5wdXQudGV4 dAorICAgIHNpZ25hbCBhY2NlcHRlZCgpCisKKyAgICBoZWlnaHQ6IDIwCisgICAgY29sb3I6ICIj ZmVmZWZlIgorCisgICAgYm9yZGVyIHsKKyAgICAgICAgd2lkdGg6IDEKKyAgICAgICAgY29sb3I6 ICIjYWVhZWFlIgorICAgIH0KKworICAgIHNtb290aDogdHJ1ZQorICAgIHJhZGl1czogMworICAg IGNsaXA6IHRydWUKKworICAgIFRleHRJbnB1dCB7CisgICAgICAgIGlkOiBpbnB1dAorICAgICAg ICBmb2N1czogdHJ1ZQorICAgICAgICBhbmNob3JzLmZpbGw6IHBhcmVudAorCisgICAgICAgIG9u QWNjZXB0ZWQ6IGRpYWxvZ0xpbmVJbnB1dC5hY2NlcHRlZCgpCisgICAgfQorfQpkaWZmIC0tZ2l0 IGEvVG9vbHMvTWluaUJyb3dzZXIvcXQvcW1sL1Byb21wdERpYWxvZy5xbWwgYi9Ub29scy9NaW5p QnJvd3Nlci9xdC9xbWwvUHJvbXB0RGlhbG9nLnFtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5hY2M1OTQ2MjJiZTBj NGI3YjY2NTVkMmEzOGQxMWEzYzBhYWM3Njg5Ci0tLSAvZGV2L251bGwKKysrIGIvVG9vbHMvTWlu aUJyb3dzZXIvcXQvcW1sL1Byb21wdERpYWxvZy5xbWwKQEAgLTAsMCArMSw2MSBAQAorLyoKKyAq IENvcHlyaWdodCAoQykgMjAxMiBOb2tpYSBDb3Jwb3JhdGlvbiBhbmQvb3IgaXRzIHN1YnNpZGlh cnkoLWllcykKKyAqCisgKiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICoKKyAqIFJlZGlzdHJpYnV0 aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAor ICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2lu ZyBjb25kaXRpb25zCisgKiBhcmUgbWV0OgorICogMS4gUmVkaXN0cmlidXRpb25zIG9mIHNvdXJj ZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhp cyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyAqIDIu IFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUg Y29weXJpZ2h0CisgKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUg Zm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCisgKiAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBv dGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorICoKKyAqIFRI SVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUgQ09NUFVURVIsIElOQy4gYGBBUyBJUycn IEFORCBBTlkKKyAqIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJV VCBOT1QgTElNSVRFRCBUTywgVEhFCisgKiBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRB QklMSVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIKKyAqIFBVUlBPU0UgQVJFIERJU0NM QUlNRUQuICBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBDT01QVVRFUiwgSU5DLiBPUgorICogQ09O VFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUws IFNQRUNJQUwsCisgKiBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVE SU5HLCBCVVQgTk9UIExJTUlURUQgVE8sCisgKiBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdP T0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwgREFUQSwgT1IKKyAqIFBST0ZJVFM7IE9SIEJV U0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkKKyAq IE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1Ig VE9SVAorICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBB TlkgV0FZIE9VVCBPRiBUSEUgVVNFCisgKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklT RUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorICovCisKK2ltcG9ydCBRdFF1 aWNrIDIuMAorCitEaWFsb2cgeworICAgIGlkOiBkaWFsb2cKKworICAgIHRpdGxlOiAiSmF2YVNj cmlwdCBQcm9tcHQiCisgICAgbWVzc2FnZTogbW9kZWwubWVzc2FnZQorCisgICAgaGVpZ2h0OiAx ODAKKworICAgIERpYWxvZ0xpbmVJbnB1dCB7CisgICAgICAgIGlkOiBpbnB1dAorICAgICAgICB3 aWR0aDogZGlhbG9nLndpZHRoIC0gMzAKKyAgICAgICAgdGV4dDogbW9kZWwuZGVmYXVsdFZhbHVl CisKKyAgICAgICAgb25BY2NlcHRlZDogbW9kZWwuYWNjZXB0KGlucHV0LnRleHQpCisgICAgfQor CisgICAgUm93IHsKKyAgICAgICAgaWQ6IGJ1dHRvblJvdworICAgICAgICBzcGFjaW5nOiA1Cisg ICAgICAgIGFuY2hvcnMuaG9yaXpvbnRhbENlbnRlcjogcGFyZW50Lmhvcml6b250YWxDZW50ZXIK KworICAgICAgICBEaWFsb2dCdXR0b24geworICAgICAgICAgICAgdGV4dDogIk9LIgorICAgICAg ICAgICAgb25DbGlja2VkOiBtb2RlbC5hY2NlcHQoaW5wdXQudGV4dCkKKyAgICAgICAgfQorCisg ICAgICAgIERpYWxvZ0J1dHRvbiB7CisgICAgICAgICAgICB0ZXh0OiAiQ2FuY2VsIgorICAgICAg ICAgICAgb25DbGlja2VkOiBtb2RlbC5yZWplY3QoKQorICAgICAgICB9CisgICAgfQorfQo=