75474 2012-01-03 08:19:05 -0800 [GTK] run-gtk-test should ignore files with names without a "test" or "Test" prefix 2012-01-03 09:00:26 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 72589 1 mario webkit-unassigned cgarcia gustavo mrobinson oldest_to_newest 528784 0 mario 2012-01-03 08:19:05 -0800 Currently, any executable file placed under the WK2GTK's API tests directory will be executed, no matter it has or not the "test" or "Test" prefix, which is a problem at least for the patch about bug 72589, since we need to place there a helper program that is not a test, but an "accessibility test server" to be inspected from TestWebKitAccessibility (the actual test). Initial solution in bug 72589 to this was to include the WebKit2APITests/AccessibilityTestServer file in the SKIPPED list in run-gtk-tests, but it seems that a better solution would be just to make run-gtk-tests to ignore files without the "test" (used for WK1's API tests) and the "Test" (used in WK2) prefix. So, this bug is about that. 528792 1 120949 mario 2012-01-03 08:26:33 -0800 Created attachment 120949 Patch proposal 528799 2 120949 cgarcia 2012-01-03 08:37:20 -0800 Comment on attachment 120949 Patch proposal Looks good to me, I would probably use if not test_file.lower().startswith("test") but I guess it's a matter of taste. 528801 3 120953 mario 2012-01-03 08:37:58 -0800 Created attachment 120953 Patch proposal A better approach 528811 4 mario 2012-01-03 09:00:26 -0800 Committed r103943: <http://trac.webkit.org/changeset/103943> 120949 2012-01-03 08:26:33 -0800 2012-01-03 08:37:58 -0800 Patch proposal 0001-2012-01-03-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 2047 mario RnJvbSA5ODNhNDFjNTVmOWE2NDkyOGU0NzdkZWZmYzc2Y2QwMGNmNjUzMTcyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBUdWUsIDMgSmFuIDIwMTIgMTc6MjI6NTMgKzAxMDAKU3ViamVjdDogW1BBVENI XSAyMDEyLTAxLTAzICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4K CiAgICAgICAgW0dUS10gcnVuLWd0ay10ZXN0IHNob3VsZCBpZ25vcmUgZmlsZXMgd2l0aCBuYW1l cyB3aXRob3V0IGEgInRlc3QiIG9yICJUZXN0IiBwcmVmaXgKICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU0NzQKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCgogICAgICAgICogU2NyaXB0cy9ydW4tZ3RrLXRlc3RzOiBJZ25vcmUgZmls ZXMgd2hvc2UgbmFtZSBkb2VzIG5vdCBzdGFydAogICAgICAgIHdpdGggYSAidGVzdCIgKGZvciBX SzEncyBBUEkgdGVzdHMpIG9yIGEgIlRlc3QiIHByZWZpeCAoZm9yIFdLMikuCi0tLQogVG9vbHMv Q2hhbmdlTG9nICAgICAgICAgICAgIHwgICAxMCArKysrKysrKysrCiBUb29scy9TY3JpcHRzL3J1 bi1ndGstdGVzdHMgfCAgICAyICsrCiAyIGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyks IDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hh bmdlTG9nCmluZGV4IGJiMGQ2NjguLmM1NzY2MTkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxv ZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wMS0wMyAgTWFy aW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10g cnVuLWd0ay10ZXN0IHNob3VsZCBpZ25vcmUgZmlsZXMgd2l0aCBuYW1lcyB3aXRob3V0IGEgInRl c3QiIG9yICJUZXN0IiBwcmVmaXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTc1NDc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1ndGstdGVzdHM6IElnbm9yZSBmaWxlcyB3aG9zZSBu YW1lIGRvZXMgbm90IHN0YXJ0CisgICAgICAgIHdpdGggYSAidGVzdCIgKGZvciBXSzEncyBBUEkg dGVzdHMpIG9yIGEgIlRlc3QiIHByZWZpeCAoZm9yIFdLMikuCisKIDIwMTItMDEtMDMgIENhcmxv cyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFVz ZSBnZGtfc2NyZWVuX2dldF9tb25pdG9yX3dvcmthcmVhKCkgd2hlbiBhdmFpbGFibGUgZm9yIHNj cmVlbkF2YWlsYWJsZVJlY3QoKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRl c3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzCmluZGV4IGRmM2Q2NmMuLjA4OWUzYTAg MTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cworKysgYi9Ub29scy9TY3Jp cHRzL3J1bi1ndGstdGVzdHMKQEAgLTUyLDYgKzUyLDggQEAgY2xhc3MgVGVzdFJ1bm5lcjoKICAg ICAgICAgICAgIGlmIG5vdCBvcy5wYXRoLmlzZGlyKGFic29sdXRlX3Rlc3RfZGlyKToKICAgICAg ICAgICAgICAgICBjb250aW51ZQogICAgICAgICAgICAgZm9yIHRlc3RfZmlsZSBpbiBvcy5saXN0 ZGlyKGFic29sdXRlX3Rlc3RfZGlyKToKKyAgICAgICAgICAgICAgICBpZiBub3QgdGVzdF9maWxl Wzo0XSBpbiBbInRlc3QiLCAiVGVzdCJdOgorICAgICAgICAgICAgICAgICAgICBjb250aW51ZQog ICAgICAgICAgICAgICAgIHRlc3RfcmVsYXRpdmVfcGF0aCA9IG9zLnBhdGguam9pbih0ZXN0X2Rp ciwgdGVzdF9maWxlKQogICAgICAgICAgICAgICAgIGlmIHRlc3RfcmVsYXRpdmVfcGF0aCBpbiBz ZWxmLlNLSVBQRUQ6CiAgICAgICAgICAgICAgICAgICAgIHN5cy5zdGRvdXQud3JpdGUoIlNraXBw aW5nIHRlc3QgJXNcbiIgJSAodGVzdF9yZWxhdGl2ZV9wYXRoKSkKLS0gCjEuNy43LjQKCg== 120953 2012-01-03 08:37:58 -0800 2012-01-03 08:39:04 -0800 Patch proposal 0001-2012-01-03-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 2050 mario RnJvbSA0NDk0ZjUyZjQ3ODIyMjM4MjFiYmVhZWM0MGViYjQyZjlkYTYyYTVmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBUdWUsIDMgSmFuIDIwMTIgMTc6MjI6NTMgKzAxMDAKU3ViamVjdDogW1BBVENI XSAyMDEyLTAxLTAzICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4K CiAgICAgICAgW0dUS10gcnVuLWd0ay10ZXN0IHNob3VsZCBpZ25vcmUgZmlsZXMgd2l0aCBuYW1l cyB3aXRob3V0IGEgInRlc3QiIG9yICJUZXN0IiBwcmVmaXgKICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU0NzQKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCgogICAgICAgICogU2NyaXB0cy9ydW4tZ3RrLXRlc3RzOiBJZ25vcmUgZmls ZXMgd2hvc2UgbmFtZSBkb2VzIG5vdCBzdGFydAogICAgICAgIHdpdGggYSAidGVzdCIgKGZvciBX SzEncyBBUEkgdGVzdHMpIG9yIGEgIlRlc3QiIHByZWZpeCAoZm9yIFdLMikuCi0tLQogVG9vbHMv Q2hhbmdlTG9nICAgICAgICAgICAgIHwgICAxMCArKysrKysrKysrCiBUb29scy9TY3JpcHRzL3J1 bi1ndGstdGVzdHMgfCAgICAyICsrCiAyIGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyks IDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hh bmdlTG9nCmluZGV4IGJiMGQ2NjguLmM1NzY2MTkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxv ZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wMS0wMyAgTWFy aW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10g cnVuLWd0ay10ZXN0IHNob3VsZCBpZ25vcmUgZmlsZXMgd2l0aCBuYW1lcyB3aXRob3V0IGEgInRl c3QiIG9yICJUZXN0IiBwcmVmaXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTc1NDc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1ndGstdGVzdHM6IElnbm9yZSBmaWxlcyB3aG9zZSBu YW1lIGRvZXMgbm90IHN0YXJ0CisgICAgICAgIHdpdGggYSAidGVzdCIgKGZvciBXSzEncyBBUEkg dGVzdHMpIG9yIGEgIlRlc3QiIHByZWZpeCAoZm9yIFdLMikuCisKIDIwMTItMDEtMDMgIENhcmxv cyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFVz ZSBnZGtfc2NyZWVuX2dldF9tb25pdG9yX3dvcmthcmVhKCkgd2hlbiBhdmFpbGFibGUgZm9yIHNj cmVlbkF2YWlsYWJsZVJlY3QoKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRl c3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzCmluZGV4IGRmM2Q2NmMuLjcwY2YyNzQg MTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cworKysgYi9Ub29scy9TY3Jp cHRzL3J1bi1ndGstdGVzdHMKQEAgLTUyLDYgKzUyLDggQEAgY2xhc3MgVGVzdFJ1bm5lcjoKICAg ICAgICAgICAgIGlmIG5vdCBvcy5wYXRoLmlzZGlyKGFic29sdXRlX3Rlc3RfZGlyKToKICAgICAg ICAgICAgICAgICBjb250aW51ZQogICAgICAgICAgICAgZm9yIHRlc3RfZmlsZSBpbiBvcy5saXN0 ZGlyKGFic29sdXRlX3Rlc3RfZGlyKToKKyAgICAgICAgICAgICAgICBpZiBub3QgdGVzdF9maWxl Lmxvd2VyKCkuc3RhcnRzd2l0aCgidGVzdCIpOgorICAgICAgICAgICAgICAgICAgICBjb250aW51 ZQogICAgICAgICAgICAgICAgIHRlc3RfcmVsYXRpdmVfcGF0aCA9IG9zLnBhdGguam9pbih0ZXN0 X2RpciwgdGVzdF9maWxlKQogICAgICAgICAgICAgICAgIGlmIHRlc3RfcmVsYXRpdmVfcGF0aCBp biBzZWxmLlNLSVBQRUQ6CiAgICAgICAgICAgICAgICAgICAgIHN5cy5zdGRvdXQud3JpdGUoIlNr aXBwaW5nIHRlc3QgJXNcbiIgJSAodGVzdF9yZWxhdGl2ZV9wYXRoKSkKLS0gCjEuNy43LjQKCg==