<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>75472</bug_id>
          
          <creation_ts>2012-01-03 07:55:10 -0800</creation_ts>
          <short_desc>[Qt] Add UI for JavaScript Confirmation dialog in the Qt MiniBrowser</short_desc>
          <delta_ts>2012-01-03 08:52:50 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alexander Færøy">ahf</reporter>
          <assigned_to name="Alexander Færøy">ahf</assigned_to>
          <cc>vestbo</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>528769</commentid>
    <comment_count>0</comment_count>
    <who name="Alexander Færøy">ahf</who>
    <bug_when>2012-01-03 07:55:10 -0800</bug_when>
    <thetext>SSIA.

Patch coming up.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>528772</commentid>
    <comment_count>1</comment_count>
      <attachid>120946</attachid>
    <who name="Alexander Færøy">ahf</who>
    <bug_when>2012-01-03 07:59:41 -0800</bug_when>
    <thetext>Created attachment 120946
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>528773</commentid>
    <comment_count>2</comment_count>
      <attachid>120946</attachid>
    <who name="Tor Arne Vestbø">vestbo</who>
    <bug_when>2012-01-03 08:00:48 -0800</bug_when>
    <thetext>Comment on attachment 120946
Patch

nice</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>528780</commentid>
    <comment_count>3</comment_count>
      <attachid>120946</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-01-03 08:10:01 -0800</bug_when>
    <thetext>Comment on attachment 120946
Patch

Rejecting attachment 120946 from commit-queue.

Failed to run &quot;[&apos;/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;-...&quot; exit_code: 2

Last 500 characters of output:
owser/qt/MiniBrowser.qrc
Hunk #1 FAILED at 8.
1 out of 1 hunk FAILED -- saving rejects to file Tools/MiniBrowser/qt/MiniBrowser.qrc.rej
patching file Tools/MiniBrowser/qt/qml/BrowserWindow.qml
Hunk #1 FAILED at 265.
1 out of 1 hunk FAILED -- saving rejects to file Tools/MiniBrowser/qt/qml/BrowserWindow.qml.rej
patching file Tools/MiniBrowser/qt/qml/ConfirmDialog.qml

Failed to run &quot;[u&apos;/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply&apos;, u&apos;--reviewer&apos;, u&apos;Tor Arne Vestb\xf8&apos;, u...&quot; exit_code: 1

Full output: http://queues.webkit.org/results/10954487</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>528787</commentid>
    <comment_count>4</comment_count>
      <attachid>120946</attachid>
    <who name="Alexander Færøy">ahf</who>
    <bug_when>2012-01-03 08:22:10 -0800</bug_when>
    <thetext>Comment on attachment 120946
Patch

Requesting CQ again since the patch of which this patch depends upon has just landed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>528806</commentid>
    <comment_count>5</comment_count>
      <attachid>120946</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-01-03 08:52:45 -0800</bug_when>
    <thetext>Comment on attachment 120946
Patch

Clearing flags on attachment: 120946

Committed r103942: &lt;http://trac.webkit.org/changeset/103942&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>528807</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-01-03 08:52:50 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>120946</attachid>
            <date>2012-01-03 07:59:41 -0800</date>
            <delta_ts>2012-01-03 08:52:45 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-75472-20120103165938.patch</filename>
            <type>text/plain</type>
            <size>4557</size>
            <attacher name="Alexander Færøy">ahf</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzOTM2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzgzZmFmZjYxZDkxOThkNGFkNTA2Njg5ZWI4MjQyOWEz
ZDdmNWE3NS4uYzRjMmUyOTEzNTZiZWY3NTVlYzczNDE3MDM1MjkyYzc3MjVlYjJkNSAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3
IEBACiAyMDEyLTAxLTAzICBBbGV4YW5kZXIgRsOmcsO4eSAgPGFsZXhhbmRlci5mYWVyb3lAbm9r
aWEuY29tPgogCisgICAgICAgIFtRdF0gQWRkIFVJIGZvciBKYXZhU2NyaXB0IENvbmZpcm1hdGlv
biBkaWFsb2cgaW4gdGhlIFF0IE1pbmlCcm93c2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTQ3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgICogTWluaUJyb3dzZXIvcXQvTWluaUJyb3dzZXIucHJvOgor
ICAgICAgICAqIE1pbmlCcm93c2VyL3F0L01pbmlCcm93c2VyLnFyYzoKKyAgICAgICAgKiBNaW5p
QnJvd3Nlci9xdC9xbWwvQnJvd3NlcldpbmRvdy5xbWw6CisgICAgICAgICogTWluaUJyb3dzZXIv
cXQvcW1sL0NvbmZpcm1EaWFsb2cucW1sOiBBZGRlZC4KKworMjAxMi0wMS0wMyAgQWxleGFuZGVy
IEbDpnLDuHkgIDxhbGV4YW5kZXIuZmFlcm95QG5va2lhLmNvbT4KKwogICAgICAgICBbUXRdIEFk
ZCBVSSBmb3IgSmF2YVNjcmlwdCBBbGVydCBkaWFsb2cgaW4gdGhlIFF0IE1pbmlCcm93c2VyCiAg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTQ3MQogCmRp
ZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9xdC9NaW5pQnJvd3Nlci5wcm8gYi9Ub29scy9N
aW5pQnJvd3Nlci9xdC9NaW5pQnJvd3Nlci5wcm8KaW5kZXggNTZlMzM4OTc4NjlmNmQyNjY5ZTE0
NmZhZjcyZTYyN2FjYTA5NDdkNi4uNWFhYWE2ODVkYmQ1MWUzMjczYzZlYzAzZTQ3YTMyYTFjNDU3
NDk5ZCAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvcXQvTWluaUJyb3dzZXIucHJvCisr
KyBiL1Rvb2xzL01pbmlCcm93c2VyL3F0L01pbmlCcm93c2VyLnBybwpAQCAtMjksMTAgKzI5LDQg
QEAgbWFjeDogUVQgKz0geG1sCiAKIFJFU09VUkNFUyArPSBNaW5pQnJvd3Nlci5xcmMKIAotT1RI
RVJfRklMRVMgKz0gXAotICAgIHFtbC9BbGVydERpYWxvZy5xbWwgXAotICAgIHFtbC9Ccm93c2Vy
V2luZG93LnFtbCBcCi0gICAgcW1sL0RpYWxvZy5xbWwgXAotICAgIHFtbC9EaWFsb2dCdXR0b24u
cW1sIFwKLSAgICBxbWwvSXRlbVNlbGVjdG9yLnFtbCBcCi0gICAgcW1sL1ZpZXdwb3J0SW5mb0l0
ZW0ucW1sCitPVEhFUl9GSUxFUyArPSBxbWwvKgpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dz
ZXIvcXQvTWluaUJyb3dzZXIucXJjIGIvVG9vbHMvTWluaUJyb3dzZXIvcXQvTWluaUJyb3dzZXIu
cXJjCmluZGV4IGUzN2E1NTBmZTU3MTE3Njg3NmI3NmEyM2U4OTQ1ZjQxZGI4NmMzZGMuLmFhMzM5
NGM2YzBiNzE0MDg5ZmQwNTE2NWY2YzllOTZmNjA0NmU1NDggMTAwNjQ0Ci0tLSBhL1Rvb2xzL01p
bmlCcm93c2VyL3F0L01pbmlCcm93c2VyLnFyYworKysgYi9Ub29scy9NaW5pQnJvd3Nlci9xdC9N
aW5pQnJvd3Nlci5xcmMKQEAgLTgsNiArOCw3IEBACiAgICAgICAgIDxmaWxlPmljb25zL3RvdWNo
cG9pbnQucG5nPC9maWxlPgogICAgICAgICA8ZmlsZT5xbWwvQWxlcnREaWFsb2cucW1sPC9maWxl
PgogICAgICAgICA8ZmlsZT5xbWwvQnJvd3NlcldpbmRvdy5xbWw8L2ZpbGU+CisgICAgICAgIDxm
aWxlPnFtbC9Db25maXJtRGlhbG9nLnFtbDwvZmlsZT4KICAgICAgICAgPGZpbGU+cW1sL0RpYWxv
Zy5xbWw8L2ZpbGU+CiAgICAgICAgIDxmaWxlPnFtbC9EaWFsb2dCdXR0b24ucW1sPC9maWxlPgog
ICAgICAgICA8ZmlsZT5xbWwvSXRlbVNlbGVjdG9yLnFtbDwvZmlsZT4KZGlmZiAtLWdpdCBhL1Rv
b2xzL01pbmlCcm93c2VyL3F0L3FtbC9Ccm93c2VyV2luZG93LnFtbCBiL1Rvb2xzL01pbmlCcm93
c2VyL3F0L3FtbC9Ccm93c2VyV2luZG93LnFtbAppbmRleCAzMTk5MTNhYzg2NThlZmFkMDQ2MjZl
ZGVkZWU3NDNhMmMwNWEzYWJlLi44NjNhZTliY2U5N2JkNzI5ZDRjYTI1MDNjMzdmZDlmYWJiZDFj
YjU2IDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9xdC9xbWwvQnJvd3NlcldpbmRvdy5x
bWwKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvcXQvcW1sL0Jyb3dzZXJXaW5kb3cucW1sCkBAIC0y
NjUsNiArMjY1LDcgQEAgUmVjdGFuZ2xlIHsKIAogICAgICAgICBleHBlcmltZW50YWwuaXRlbVNl
bGVjdG9yOiBJdGVtU2VsZWN0b3IgeyB9CiAgICAgICAgIGV4cGVyaW1lbnRhbC5hbGVydERpYWxv
ZzogQWxlcnREaWFsb2cgeyB9CisgICAgICAgIGV4cGVyaW1lbnRhbC5jb25maXJtRGlhbG9nOiBD
b25maXJtRGlhbG9nIHsgfQogICAgIH0KIAogICAgIFZpZXdwb3J0SW5mb0l0ZW0gewpkaWZmIC0t
Z2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvcXQvcW1sL0NvbmZpcm1EaWFsb2cucW1sIGIvVG9vbHMv
TWluaUJyb3dzZXIvcXQvcW1sL0NvbmZpcm1EaWFsb2cucW1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0
CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjk3NGQwNjVi
NzhkZmQ0ZTFkMDNlNjAyZjlkOWNmOGMwNjNiY2I3Y2MKLS0tIC9kZXYvbnVsbAorKysgYi9Ub29s
cy9NaW5pQnJvd3Nlci9xdC9xbWwvQ29uZmlybURpYWxvZy5xbWwKQEAgLTAsMCArMSw0NyBAQAor
LyoKKyAqIENvcHlyaWdodCAoQykgMjAxMiBOb2tpYSBDb3Jwb3JhdGlvbiBhbmQvb3IgaXRzIHN1
YnNpZGlhcnkoLWllcykKKyAqCisgKiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICoKKyAqIFJlZGlz
dHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0
aG91dAorICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZv
bGxvd2luZyBjb25kaXRpb25zCisgKiBhcmUgbWV0OgorICogMS4gUmVkaXN0cmlidXRpb25zIG9m
IHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGlj
ZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4K
KyAqIDIuIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUg
YWJvdmUgY29weXJpZ2h0CisgKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFu
ZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCisgKiAgICBkb2N1bWVudGF0aW9uIGFu
ZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorICoK
KyAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUgQ09NUFVURVIsIElOQy4gYGBB
UyBJUycnIEFORCBBTlkKKyAqIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJ
TkcsIEJVVCBOT1QgTElNSVRFRCBUTywgVEhFCisgKiBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVS
Q0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIKKyAqIFBVUlBPU0UgQVJF
IERJU0NMQUlNRUQuICBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBDT01QVVRFUiwgSU5DLiBPUgor
ICogQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lE
RU5UQUwsIFNQRUNJQUwsCisgKiBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUyAo
SU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sCisgKiBQUk9DVVJFTUVOVCBPRiBTVUJTVElU
VVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwgREFUQSwgT1IKKyAqIFBST0ZJVFM7
IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVP
UlkKKyAqIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElU
WSwgT1IgVE9SVAorICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lO
RyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCisgKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElG
IEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorICovCisKK2ltcG9y
dCBRdFF1aWNrIDIuMAorCitEaWFsb2cgeworICAgIHRpdGxlOiAiSmF2YVNjcmlwdCBDb25maXJt
YXRpb24iCisgICAgbWVzc2FnZTogbW9kZWwubWVzc2FnZQorCisgICAgUm93IHsKKyAgICAgICAg
c3BhY2luZzogNQorCisgICAgICAgIERpYWxvZ0J1dHRvbiB7CisgICAgICAgICAgICB0ZXh0OiAi
T0siCisgICAgICAgICAgICBvbkNsaWNrZWQ6IG1vZGVsLmFjY2VwdCgpCisgICAgICAgIH0KKwor
ICAgICAgICBEaWFsb2dCdXR0b24geworICAgICAgICAgICAgdGV4dDogIkNhbmNlbCIKKyAgICAg
ICAgICAgIG9uQ2xpY2tlZDogbW9kZWwucmVqZWN0KCkKKyAgICAgICAgfQorICAgIH0KK30K
</data>

          </attachment>
      

    </bug>

</bugzilla>