75467 2012-01-03 03:03:31 -0800 [GTK] Fix scrollbars size with GTK+ 3.x 2012-02-20 13:16:04 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned xan.lopez oldest_to_newest 528708 0 cgarcia 2012-01-03 03:03:31 -0800 The problem is that GTK+ code that queries the style properties ignores the GtkStyleContext, and uses GtkWidgetPath. This should work in GTK+ but the style properties will be deprecated soon, so we could just add the style classes to the GtkWidgetPatch when creating GtkStyleContext objects as a workaround for now. 528709 1 120925 cgarcia 2012-01-03 03:08:23 -0800 Created attachment 120925 Patch I don't like the ifs, but we can't use a switch because GTK_TYPE macros expand to _get_type() functions and can't be used in switchs, and a static table mapping style classes to widget stypes would call _get_type() for every widget type. 528711 2 120925 xan.lopez 2012-01-03 03:16:48 -0800 Comment on attachment 120925 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120925&action=review I think I would just have one call to gtk_widget_path_iter_add_class and set the right style class to a variable in the ifs, but other than that it looks OK to me. There are no tests that need updating because of this? > Source/WebCore/platform/gtk/RenderThemeGtk3.cpp:92 > + gtk_widget_path_iter_add_class(path, 0, "arrow"); I suppose this does not use GTK_STYLE_CLASS_ARROW because it was added later? 528713 3 cgarcia 2012-01-03 03:36:57 -0800 (In reply to comment #2) > (From update of attachment 120925 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=120925&action=review > > I think I would just have one call to gtk_widget_path_iter_add_class and set the right style class to a variable in the ifs, but other than that it looks OK to me. Ok, I'll change that. > There are no tests that need updating because of this? hmm, I guess this might break tests using scrolbars for example. > > Source/WebCore/platform/gtk/RenderThemeGtk3.cpp:92 > > + gtk_widget_path_iter_add_class(path, 0, "arrow"); > > I suppose this does not use GTK_STYLE_CLASS_ARROW because it was added later? Yes, it didn't exist, I'm not sure if it exists now or when it was added. 528748 4 cgarcia 2012-01-03 06:15:00 -0800 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 120925 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=120925&action=review > > > > I think I would just have one call to gtk_widget_path_iter_add_class and set the right style class to a variable in the ifs, but other than that it looks OK to me. > > Ok, I'll change that. We don't want to call gtk_widget_path_iter_add_class() at all in case widget types is unknown so we would need another if to check whether the variables has been set or not. 528749 5 cgarcia 2012-01-03 06:16:01 -0800 Committed r103936: <http://trac.webkit.org/changeset/103936> 560332 6 mrobinson 2012-02-20 13:16:04 -0800 *** Bug 63307 has been marked as a duplicate of this bug. *** 120925 2012-01-03 03:08:23 -0800 2012-01-03 03:16:48 -0800 Patch wk-scrollbars-size.diff text/plain 2716 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjOTgwMTdmLi41YjA0ZjZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg QEAKIDIwMTItMDEtMDMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtHVEtdIEZpeCBzY3JvbGxiYXJzIHNpemUgd2l0aCBHVEsrIDMueAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU0NjcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2d0 ay9SZW5kZXJUaGVtZUd0azMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Z2V0U3R5bGVDb250ZXh0 KTogQWRkIHRoZSBzdHlsZSBjbGFzcyBmb3IgdGhlIGdpdmVuCisgICAgICAgIHdpZGdldCB0eXBl IHRvIHRoZSBHdGtXaWRnZXRQYXRoIHdoZW4gY3JlYXRpbmcgR3RrU3R5bGVDb250ZXh0CisgICAg ICAgIG9iamVjdHMuCisKKzIwMTItMDEtMDMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNp YUBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtHVEtdIFVzZSBnZGtfc2NyZWVuX2dldF9tb25pdG9y X3dvcmthcmVhKCkgd2hlbiBhdmFpbGFibGUgZm9yIHNjcmVlbkF2YWlsYWJsZVJlY3QoKQogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU0MzUKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrMy5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGszLmNwcAppbmRleCAz NTA5MDUyLi5kMjMzOWIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv UmVuZGVyVGhlbWVHdGszLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVu ZGVyVGhlbWVHdGszLmNwcApAQCAtODQsNiArODQsMjkgQEAgc3RhdGljIEd0a1N0eWxlQ29udGV4 dCogZ2V0U3R5bGVDb250ZXh0KEdUeXBlIHdpZGdldFR5cGUpCiAgICAgR3RrV2lkZ2V0UGF0aCog cGF0aCA9IGd0a193aWRnZXRfcGF0aF9uZXcoKTsKICAgICBndGtfd2lkZ2V0X3BhdGhfYXBwZW5k X3R5cGUocGF0aCwgd2lkZ2V0VHlwZSk7CiAKKyAgICBpZiAod2lkZ2V0VHlwZSA9PSBHVEtfVFlQ RV9TQ1JPTExCQVIpCisgICAgICAgIGd0a193aWRnZXRfcGF0aF9pdGVyX2FkZF9jbGFzcyhwYXRo LCAwLCBHVEtfU1RZTEVfQ0xBU1NfU0NST0xMQkFSKTsKKyAgICBlbHNlIGlmICh3aWRnZXRUeXBl ID09IEdUS19UWVBFX0VOVFJZKQorICAgICAgICBndGtfd2lkZ2V0X3BhdGhfaXRlcl9hZGRfY2xh c3MocGF0aCwgMCwgR1RLX1NUWUxFX0NMQVNTX0VOVFJZKTsKKyAgICBlbHNlIGlmICh3aWRnZXRU eXBlID09IEdUS19UWVBFX0FSUk9XKQorICAgICAgICBndGtfd2lkZ2V0X3BhdGhfaXRlcl9hZGRf Y2xhc3MocGF0aCwgMCwgImFycm93Iik7CisgICAgZWxzZSBpZiAod2lkZ2V0VHlwZSA9PSBHVEtf VFlQRV9CVVRUT04pCisgICAgICAgIGd0a193aWRnZXRfcGF0aF9pdGVyX2FkZF9jbGFzcyhwYXRo LCAwLCBHVEtfU1RZTEVfQ0xBU1NfQlVUVE9OKTsKKyAgICBlbHNlIGlmICh3aWRnZXRUeXBlID09 IEdUS19UWVBFX1NDQUxFKQorICAgICAgICBndGtfd2lkZ2V0X3BhdGhfaXRlcl9hZGRfY2xhc3Mo cGF0aCwgMCwgR1RLX1NUWUxFX0NMQVNTX1NDQUxFKTsKKyAgICBlbHNlIGlmICh3aWRnZXRUeXBl ID09IEdUS19UWVBFX1NFUEFSQVRPUikKKyAgICAgICAgZ3RrX3dpZGdldF9wYXRoX2l0ZXJfYWRk X2NsYXNzKHBhdGgsIDAsIEdUS19TVFlMRV9DTEFTU19TRVBBUkFUT1IpOworICAgIGVsc2UgaWYg KHdpZGdldFR5cGUgPT0gR1RLX1RZUEVfUFJPR1JFU1NfQkFSKQorICAgICAgICBndGtfd2lkZ2V0 X3BhdGhfaXRlcl9hZGRfY2xhc3MocGF0aCwgMCwgR1RLX1NUWUxFX0NMQVNTX1BST0dSRVNTQkFS KTsKKyAgICBlbHNlIGlmICh3aWRnZXRUeXBlID09IEdUS19UWVBFX1NQSU5fQlVUVE9OKQorICAg ICAgICBndGtfd2lkZ2V0X3BhdGhfaXRlcl9hZGRfY2xhc3MocGF0aCwgMCwgR1RLX1NUWUxFX0NM QVNTX1NQSU5CVVRUT04pOworICAgIGVsc2UgaWYgKHdpZGdldFR5cGUgPT0gR1RLX1RZUEVfVFJF RV9WSUVXKQorICAgICAgICBndGtfd2lkZ2V0X3BhdGhfaXRlcl9hZGRfY2xhc3MocGF0aCwgMCwg R1RLX1NUWUxFX0NMQVNTX1ZJRVcpOworICAgIGVsc2UgaWYgKHdpZGdldFR5cGUgPT0gR1RLX1RZ UEVfQ0hFQ0tfQlVUVE9OKQorICAgICAgICBndGtfd2lkZ2V0X3BhdGhfaXRlcl9hZGRfY2xhc3Mo cGF0aCwgMCwgR1RLX1NUWUxFX0NMQVNTX0NIRUNLKTsKKyAgICBlbHNlIGlmICh3aWRnZXRUeXBl ID09IEdUS19UWVBFX1JBRElPX0JVVFRPTikKKyAgICAgICAgZ3RrX3dpZGdldF9wYXRoX2l0ZXJf YWRkX2NsYXNzKHBhdGgsIDAsIEdUS19TVFlMRV9DTEFTU19SQURJTyk7CisKICAgICBHUmVmUHRy PEd0a1N0eWxlQ29udGV4dD4gY29udGV4dCA9IGFkb3B0R1JlZihndGtfc3R5bGVfY29udGV4dF9u ZXcoKSk7CiAgICAgZ3RrX3N0eWxlX2NvbnRleHRfc2V0X3BhdGgoY29udGV4dC5nZXQoKSwgcGF0 aCk7CiAgICAgZ3RrX3dpZGdldF9wYXRoX2ZyZWUocGF0aCk7Cg==