75465 2012-01-03 01:26:03 -0800 [WK2] WebPageProxy::activeURL should return unreachableURL() when it's not empty 2012-03-15 02:09:17 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 75433 1 cgarcia webkit-unassigned andersca ap dglazkov gustavo mitz plaes sam sullivan webkit.review.bot oldest_to_newest 528693 0 cgarcia 2012-01-03 01:26:03 -0800 Assuming unreachableURL is what the user should show in the location entry, the active URL of the page should be the unreachableURL when loadAlternateHTML has been used to load current page contents. 528694 1 120918 cgarcia 2012-01-03 01:28:50 -0800 Created attachment 120918 Patch 530162 2 plaes 2012-01-05 03:44:29 -0800 (In reply to comment #1) > Created an attachment (id=120918) [details] > Patch Could you also remove the FIXME from WebViewTest::replaceContent in Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp ? 530164 3 cgarcia 2012-01-05 03:49:41 -0800 (In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=120918) [details] [details] > > Patch > > Could you also remove the FIXME from WebViewTest::replaceContent in Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp ? Sure 530169 4 121255 cgarcia 2012-01-05 04:00:18 -0800 Created attachment 121255 Updated patch It removes the workaround used to fix unit tests in r104129 530170 5 webkit.review.bot 2012-01-05 04:01:53 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 530583 6 121255 webkit.review.bot 2012-01-05 13:20:25 -0800 Comment on attachment 121255 Updated patch Attachment 121255 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11143062 New failing tests: http/tests/inspector/network/download.html 570641 7 cgarcia 2012-03-05 06:46:17 -0800 ping, could someone review this patch please? 579205 8 121255 pnormand 2012-03-15 01:52:30 -0700 Comment on attachment 121255 Updated patch LGTM 579216 9 cgarcia 2012-03-15 02:09:17 -0700 Committed r110834: <http://trac.webkit.org/changeset/110834> 120918 2012-01-03 01:28:50 -0800 2012-01-05 04:00:18 -0800 Patch wk2-unreachable-active-url.diff text/plain 1279 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3YjlkZTNhMC4uNDQ0NzhjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTAxLTAzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNv bT4KKworICAgICAgICBbV0syXSBXZWJQYWdlUHJveHk6OmFjdGl2ZVVSTCBzaG91bGQgcmV0dXJu IHVucmVhY2hhYmxlVVJMKCkgd2hlbiBpdCdzIG5vdCBlbXB0eQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU0NjUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmFjdGl2ZVVSTCk6IFJldHVybiB0aGUg bWFpbiBmcmFtZQorICAgICAgICB1bnJlYWNoYWJsZVVSTCBpZiBpdCdzIG5vdCBlbXB0eS4KKwog MjAxMi0wMS0wMiAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIEZp eGVkIGEgdHlwbyBJIG1hZGUgaW4gcjEwMzg3MS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dl YlBhZ2VQcm94eS5jcHAKaW5kZXggNmFmMmNmNC4uN2UyOTY2NSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKQEAgLTYxNyw3ICs2MTcsOCBAQCBTdHJpbmcgV2Vi UGFnZVByb3h5OjphY3RpdmVVUkwoKSBjb25zdAogICAgIGlmICghbV9wZW5kaW5nQVBJUmVxdWVz dFVSTC5pc051bGwoKSkKICAgICAgICAgcmV0dXJuIG1fcGVuZGluZ0FQSVJlcXVlc3RVUkw7CiAK LSAgICAvLyBGSVhNRTogV2hhdCBkbyB3ZSBkbyBpbiB0aGUgY2FzZSBvZiB0aGUgdW5yZWFjaGFi bGUgVVJMPworICAgIGlmICghbV9tYWluRnJhbWUtPnVucmVhY2hhYmxlVVJMKCkuaXNFbXB0eSgp KQorICAgICAgICByZXR1cm4gbV9tYWluRnJhbWUtPnVucmVhY2hhYmxlVVJMKCk7CiAKICAgICBz d2l0Y2ggKG1fbWFpbkZyYW1lLT5sb2FkU3RhdGUoKSkgewogICAgIGNhc2UgV2ViRnJhbWVQcm94 eTo6TG9hZFN0YXRlUHJvdmlzaW9uYWw6Cg== 121255 2012-01-05 04:00:18 -0800 2012-03-15 01:52:30 -0700 Updated patch wk2-active-url-unreachable2.diff text/plain 2362 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA0ZmYxNjc2Li43NmYwMDhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTgg QEAKIDIwMTItMDEtMDUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtXSzJdIFdlYlBhZ2VQcm94eTo6YWN0aXZlVVJMIHNob3VsZCByZXR1cm4g dW5yZWFjaGFibGVVUkwoKSB3aGVuIGl0J3Mgbm90IGVtcHR5CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTQ2NQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvV2Vi Vmlld1Rlc3QuY3BwOgorICAgICAgICAoV2ViVmlld1Rlc3Q6OnJlcGxhY2VDb250ZW50KTogUmV0 dXJuIHRoZSBtYWluIGZyYW1lCisgICAgICAgIHVucmVhY2hhYmxlVVJMIGlmIGl0J3Mgbm90IGVt cHR5LgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2Vi S2l0OjpXZWJQYWdlUHJveHk6OmFjdGl2ZVVSTCk6CisKKzIwMTItMDEtMDUgIENhcmxvcyBHYXJj aWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtHVEtdIFJlbmFtZSB3 ZWJraXRfd2ViX3ZpZXdfbG9hZF9hbHRlcm5hdGVfaHRtbCBhcyB3ZWJraXRfd2ViX3ZpZXdfcmVw bGFjZV9jb250ZW50IGluIFdlYktpdDIgR1RLKwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU0MzMKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvV2ViVmlld1Rlc3QuY3BwIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvV2ViVmlld1Rlc3QuY3BwCmluZGV4IGRmZDlkYTQuLjkz MjNiMTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3Rz L1dlYlZpZXdUZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90 ZXN0cy9XZWJWaWV3VGVzdC5jcHAKQEAgLTY2LDE1ICs2Niw3IEBAIHZvaWQgV2ViVmlld1Rlc3Q6 OmxvYWRSZXF1ZXN0KFdlYktpdFVSSVJlcXVlc3QqIHJlcXVlc3QpCiAKIHZvaWQgV2ViVmlld1Rl c3Q6OnJlcGxhY2VDb250ZW50KGNvbnN0IGNoYXIqIGh0bWwsIGNvbnN0IGNoYXIqIGNvbnRlbnRV UkksIGNvbnN0IGNoYXIqIGJhc2VVUkkpCiB7Ci0gICAgLy8gRklYTUU6IFRoZSBhY3RpdmUgdXJp IHNob3VsZCBiZSB0aGUgY29udGVudFVSSSwKLSAgICAvLyBidXQgV2ViUGFnZVByb3h5IGRvZXNu J3QgcmV0dXJuIHRoZSB1bnJlYWNoYWJsZVVSTAotICAgIC8vIHdoZW4gdGhlIHBhZ2UgaGFzIGJl ZW4gbG9hZGVkIHdpdGggQWx0ZXJuYXRlSFRNTCgpCi0gICAgLy8gU2VlIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTQ2NS4KLSNpZiAwCiAgICAgbV9hY3RpdmVVUkkg PSBjb250ZW50VVJJOwotI2Vsc2UKLSAgICBtX2FjdGl2ZVVSSSA9ICJhYm91dDpibGFuayI7Ci0j ZW5kaWYKICAgICB3ZWJraXRfd2ViX3ZpZXdfcmVwbGFjZV9jb250ZW50KG1fd2ViVmlldywgaHRt bCwgY29udGVudFVSSSwgYmFzZVVSSSk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dl YlBhZ2VQcm94eS5jcHAKaW5kZXggMTVhYmY5Yy4uNmI2YjUwMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKQEAgLTYxNyw3ICs2MTcsOCBAQCBTdHJpbmcgV2Vi UGFnZVByb3h5OjphY3RpdmVVUkwoKSBjb25zdAogICAgIGlmICghbV9wZW5kaW5nQVBJUmVxdWVz dFVSTC5pc051bGwoKSkKICAgICAgICAgcmV0dXJuIG1fcGVuZGluZ0FQSVJlcXVlc3RVUkw7CiAK LSAgICAvLyBGSVhNRTogV2hhdCBkbyB3ZSBkbyBpbiB0aGUgY2FzZSBvZiB0aGUgdW5yZWFjaGFi bGUgVVJMPworICAgIGlmICghbV9tYWluRnJhbWUtPnVucmVhY2hhYmxlVVJMKCkuaXNFbXB0eSgp KQorICAgICAgICByZXR1cm4gbV9tYWluRnJhbWUtPnVucmVhY2hhYmxlVVJMKCk7CiAKICAgICBz d2l0Y2ggKG1fbWFpbkZyYW1lLT5sb2FkU3RhdGUoKSkgewogICAgIGNhc2UgV2ViRnJhbWVQcm94 eTo6TG9hZFN0YXRlUHJvdmlzaW9uYWw6Cg==